Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Jingoo, On 11/04/2018 20:37, Jingoo Han wrote: > On Wednesday, April 11, 2018 3:40 AM, Gustavo Pimentel wrote: >> >> Hi Jingoo, >> >> On 11/04/2018 01:01, Jingoo Han wrote: >>> On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: Replaces a simple division by 2 to a right shift

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Jingoo, On 11/04/2018 20:37, Jingoo Han wrote: > On Wednesday, April 11, 2018 3:40 AM, Gustavo Pimentel wrote: >> >> Hi Jingoo, >> >> On 11/04/2018 01:01, Jingoo Han wrote: >>> On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: Replaces a simple division by 2 to a right shift

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Fabio, On 15/04/2018 14:09, Fabio Estevam wrote: > Hi Gustavo, > > On Wed, Apr 11, 2018 at 4:40 AM, Gustavo Pimentel > wrote: > >> Can be this one? >> >> Probably any recent and decent compiler does this kind of substitution >> in order to improve code

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Fabio, On 15/04/2018 14:09, Fabio Estevam wrote: > Hi Gustavo, > > On Wed, Apr 11, 2018 at 4:40 AM, Gustavo Pimentel > wrote: > >> Can be this one? >> >> Probably any recent and decent compiler does this kind of substitution >> in order to improve code performance. Nevertheless it's a

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Gustavo, On Wed, Apr 11, 2018 at 4:40 AM, Gustavo Pimentel wrote: > Can be this one? > > Probably any recent and decent compiler does this kind of substitution > in order to improve code performance. Nevertheless it's a coding good > practice whenever there is

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Gustavo, On Wed, Apr 11, 2018 at 4:40 AM, Gustavo Pimentel wrote: > Can be this one? > > Probably any recent and decent compiler does this kind of substitution > in order to improve code performance. Nevertheless it's a coding good > practice whenever there is a division / multiplication by

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

On Wednesday, April 11, 2018 3:40 AM, Gustavo Pimentel wrote: > > Hi Jingoo, > > On 11/04/2018 01:01, Jingoo Han wrote: > > On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > >> > >> Replaces a simple division by 2 to a right shift rotation of 1 bit. > > > > It looks good. However,

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

On Wednesday, April 11, 2018 3:40 AM, Gustavo Pimentel wrote: > > Hi Jingoo, > > On 11/04/2018 01:01, Jingoo Han wrote: > > On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > >> > >> Replaces a simple division by 2 to a right shift rotation of 1 bit. > > > > It looks good. However,

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Jingoo, On 11/04/2018 01:01, Jingoo Han wrote: > On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: >> >> Replaces a simple division by 2 to a right shift rotation of 1 bit. > > It looks good. However, would you add a simple reason to the commit > message? Sure. Can be this one?

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

Hi Jingoo, On 11/04/2018 01:01, Jingoo Han wrote: > On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: >> >> Replaces a simple division by 2 to a right shift rotation of 1 bit. > > It looks good. However, would you add a simple reason to the commit > message? Sure. Can be this one?

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > > Replaces a simple division by 2 to a right shift rotation of 1 bit. It looks good. However, would you add a simple reason to the commit message? Best regards, Jingoo Han > > Signed-off-by: Gustavo Pimentel

Re: [PATCH v2 8/9] PCI: dwc: Small computation improvement

On Monday, April 9, 2018 5:41 AM, Gustavo Pimentel wrote: > > Replaces a simple division by 2 to a right shift rotation of 1 bit. It looks good. However, would you add a simple reason to the commit message? Best regards, Jingoo Han > > Signed-off-by: Gustavo Pimentel > --- > Change v1->v2: >