Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-08-20 Thread Mike Lothian
I've updated the bug some more with more info I can't replicate this on RHEL7 with GCC 4.8.5 or GCC 7.3.1 My GCC is as follows: Using built-in specs. COLLECT_GCC=gcc COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/9.2.0/lto-wrapper Target: x86_64-pc-linux-gnu Configured with: /var/tmp/p

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-08-19 Thread Thomas Gleixner
On Mon, 19 Aug 2019, Mike Lothian wrote: > > I'm using GCC 9.2, binutils 2.32. I used to use the gold linker but > I've just switched back to using ld.bfd based on this discussion > > My .config can be found at: > https://raw.githubusercontent.com/FireBurn/KernelStuff/master/dot_config_tip Does t

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-08-19 Thread Mike Lothian
On Mon, 19 Aug 2019 at 14:08, Thomas Gleixner wrote: > > On Mon, 19 Aug 2019, Mike Lothian wrote: > > On Wed, 14 Aug 2019 at 12:09, Mike Lothian wrote: > > > > > > As it's related. I've raised > > > https://bugzilla.kernel.org/show_bug.cgi?id=204495 about the > > > relocatition I'm seeing since s

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-08-19 Thread Thomas Gleixner
On Mon, 19 Aug 2019, Mike Lothian wrote: > On Wed, 14 Aug 2019 at 12:09, Mike Lothian wrote: > > > > As it's related. I've raised > > https://bugzilla.kernel.org/show_bug.cgi?id=204495 about the > > relocatition I'm seeing since switching back to ld.bfd - is this safe > > to ignore? I'm guessing t

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-08-19 Thread Mike Lothian
On Wed, 14 Aug 2019 at 12:09, Mike Lothian wrote: > > As it's related. I've raised > https://bugzilla.kernel.org/show_bug.cgi?id=204495 about the > relocatition I'm seeing since switching back to ld.bfd - is this safe > to ignore? I'm guessing this is why gold isn't working as it can't do > them >

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-08-14 Thread Mike Lothian
On Thu, 25 Jul 2019 at 07:59, Greg KH wrote: > > On Wed, Jul 24, 2019 at 10:20:34PM +0200, Thomas Gleixner wrote: > > On Wed, 24 Jul 2019, Thomas Gleixner wrote: > > > > > On Wed, 24 Jul 2019, Greg KH wrote: > > > > On Wed, Jul 24, 2019 at 06:03:41PM +0200, Thomas Gleixner wrote: > > > > > > Gotta

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Greg KH
On Wed, Jul 24, 2019 at 10:20:34PM +0200, Thomas Gleixner wrote: > On Wed, 24 Jul 2019, Thomas Gleixner wrote: > > > On Wed, 24 Jul 2019, Greg KH wrote: > > > On Wed, Jul 24, 2019 at 06:03:41PM +0200, Thomas Gleixner wrote: > > > > > Gotta love old tool-chains :( > > > > > > > > Oh yes. /me does

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Thomas Gleixner
On Wed, 24 Jul 2019, Thomas Gleixner wrote: > On Wed, 24 Jul 2019, Greg KH wrote: > > On Wed, Jul 24, 2019 at 06:03:41PM +0200, Thomas Gleixner wrote: > > > > Gotta love old tool-chains :( > > > > > > Oh yes. /me does archaeology to find a VM with old stuff > > > > I can provide a binary if you

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Thomas Gleixner
On Wed, 24 Jul 2019, Greg KH wrote: > On Wed, Jul 24, 2019 at 06:03:41PM +0200, Thomas Gleixner wrote: > > > Gotta love old tool-chains :( > > > > Oh yes. /me does archaeology to find a VM with old stuff > > I can provide a binary if you can't find anything. Found GNU ld (GNU Binutils for Debian

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Peter Zijlstra
On Wed, Jul 24, 2019 at 05:57:35PM +0200, Greg KH wrote: > Wait, does clang link things itself and not need ld? There's ld.lld; which might be used by your clang.

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Greg KH
On Wed, Jul 24, 2019 at 06:03:41PM +0200, Thomas Gleixner wrote: > On Wed, 24 Jul 2019, Greg KH wrote: > > On Wed, Jul 24, 2019 at 05:49:45PM +0200, Thomas Gleixner wrote: > > > > Ok, I dug around and the gold linker is not being used here, only clang > > > > to build the source and GNU ld to link,

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Thomas Gleixner
On Wed, 24 Jul 2019, Greg KH wrote: > On Wed, Jul 24, 2019 at 05:49:45PM +0200, Thomas Gleixner wrote: > > > Ok, I dug around and the gold linker is not being used here, only clang > > > to build the source and GNU ld to link, and I am still seeing this > > > error. > > > > Odd combo. > > I'm not

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Thomas Gleixner
On Wed, 24 Jul 2019, Thomas Gleixner wrote: > On Wed, 24 Jul 2019, Greg KH wrote: > > On Tue, Jul 23, 2019 at 03:44:54PM +0200, Greg KH wrote: > > > Sorry, I saw that after writing that. You are right, if the others > > > don't object, that's fine with me. I'll go poke the various build > > > sys

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Greg KH
On Wed, Jul 24, 2019 at 05:49:45PM +0200, Thomas Gleixner wrote: > On Wed, 24 Jul 2019, Greg KH wrote: > > On Tue, Jul 23, 2019 at 03:44:54PM +0200, Greg KH wrote: > > > Sorry, I saw that after writing that. You are right, if the others > > > don't object, that's fine with me. I'll go poke the va

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Thomas Gleixner
On Wed, 24 Jul 2019, Greg KH wrote: > On Tue, Jul 23, 2019 at 03:44:54PM +0200, Greg KH wrote: > > Sorry, I saw that after writing that. You are right, if the others > > don't object, that's fine with me. I'll go poke the various build > > systems that are failing right now on 5.3-rc1 and try to

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-24 Thread Greg KH
On Tue, Jul 23, 2019 at 03:44:54PM +0200, Greg KH wrote: > On Tue, Jul 23, 2019 at 03:31:32PM +0200, Thomas Gleixner wrote: > > On Tue, 23 Jul 2019, Greg KH wrote: > > > On Mon, Jul 15, 2019 at 01:16:48PM -0700, H.J. Lu wrote: > > > > > > > > > > > > > Since building a workable kernel for differen

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-23 Thread Greg KH
On Tue, Jul 23, 2019 at 03:31:32PM +0200, Thomas Gleixner wrote: > On Tue, 23 Jul 2019, Greg KH wrote: > > On Mon, Jul 15, 2019 at 01:16:48PM -0700, H.J. Lu wrote: > > > > > > > > > > Since building a workable kernel for different kernel configurations > > > isn't a > > > requirement for gold, I

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-23 Thread Greg KH
On Tue, Jul 23, 2019 at 03:05:14PM +0200, Greg KH wrote: > On Mon, Jul 15, 2019 at 01:16:48PM -0700, H.J. Lu wrote: > > On Mon, Jul 15, 2019 at 3:35 AM Thomas Gleixner wrote: > > > > > > On Mon, 15 Jul 2019, Thomas Gleixner wrote: > > > > On Mon, 15 Jul 2019, Mike Lothian wrote: > > > > > That bui

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-23 Thread Thomas Gleixner
On Tue, 23 Jul 2019, Greg KH wrote: > On Mon, Jul 15, 2019 at 01:16:48PM -0700, H.J. Lu wrote: > > > > > > > Since building a workable kernel for different kernel configurations isn't a > > requirement for gold, I don't recommend gold for kernel. > > Um, it worked before this commit, and now it d

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-23 Thread Greg KH
On Mon, Jul 15, 2019 at 01:16:48PM -0700, H.J. Lu wrote: > On Mon, Jul 15, 2019 at 3:35 AM Thomas Gleixner wrote: > > > > On Mon, 15 Jul 2019, Thomas Gleixner wrote: > > > On Mon, 15 Jul 2019, Mike Lothian wrote: > > > > That build failure is from the current tip of Linus's tree > > > > If the fix

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-15 Thread H.J. Lu
On Mon, Jul 15, 2019 at 3:35 AM Thomas Gleixner wrote: > > On Mon, 15 Jul 2019, Thomas Gleixner wrote: > > On Mon, 15 Jul 2019, Mike Lothian wrote: > > > That build failure is from the current tip of Linus's tree > > > If the fix is in, then it hasn't fixed the issue > > > > The reverted commit ca

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-15 Thread Thomas Gleixner
On Mon, 15 Jul 2019, Thomas Gleixner wrote: > On Mon, 15 Jul 2019, Mike Lothian wrote: > > That build failure is from the current tip of Linus's tree > > If the fix is in, then it hasn't fixed the issue > > The reverted commit caused a build fail with gold as well. Let me stare at > your issue. S

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-15 Thread Thomas Gleixner
On Mon, 15 Jul 2019, Mike Lothian wrote: A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? > That build failure is from

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-15 Thread Thomas Gleixner
On Sun, 14 Jul 2019, Mike Lothian wrote: > Will the fix be in the next RC? As I said, it's upstream already, so yes.

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-14 Thread Mike Lothian
Will the fix be in the next RC? On Sun, 14 Jul 2019 at 11:16, Thomas Gleixner wrote: > > On Sat, 13 Jul 2019, Mike Lothian wrote: > > > This appears to be causing issues with gold again: > > > > axion /usr/src/linux # make > > CALLscripts/checksyscalls.sh > > CALLscripts/atomic/check-

Re: [PATCH v3 1/2] x86/mm: Identify the end of the kernel area to be reserved

2019-07-14 Thread Thomas Gleixner
On Sat, 13 Jul 2019, Mike Lothian wrote: > This appears to be causing issues with gold again: > > axion /usr/src/linux # make > CALLscripts/checksyscalls.sh > CALLscripts/atomic/check-atomics.sh > DESCEND objtool > CHK include/generated/compile.h > VDSOCHK arch/x86/entry/vd