Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-26 Thread Tomasz Nowicki
Hi John, On 19.10.2017 12:25, John Garry wrote: On 19/10/2017 06:18, Tomasz Nowicki wrote: Summary: I'm not at all happy with this specification's attempt to leave out pieces of information which make parsing things more deterministic. In this case I'm happy to demote the message level, but

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-26 Thread Tomasz Nowicki
Hi John, On 19.10.2017 12:25, John Garry wrote: On 19/10/2017 06:18, Tomasz Nowicki wrote: Summary: I'm not at all happy with this specification's attempt to leave out pieces of information which make parsing things more deterministic. In this case I'm happy to demote the message level, but

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-23 Thread Jeremy Linton
Hi, On 10/20/2017 02:53 PM, Christ, Austin wrote: Hey Jeremy, Quick comment below. On 10/12/2017 1:48 PM, Jeremy Linton wrote: +static int topology_setup_acpi_cpu(struct acpi_table_header *table, +    unsigned int cpu, int level) +{ +    struct acpi_pptt_processor *cpu_node;

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-23 Thread Jeremy Linton
Hi, On 10/20/2017 02:53 PM, Christ, Austin wrote: Hey Jeremy, Quick comment below. On 10/12/2017 1:48 PM, Jeremy Linton wrote: +static int topology_setup_acpi_cpu(struct acpi_table_header *table, +    unsigned int cpu, int level) +{ +    struct acpi_pptt_processor *cpu_node;

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-20 Thread Christ, Austin
Hey Jeremy, Quick comment below. On 10/12/2017 1:48 PM, Jeremy Linton wrote: +static int topology_setup_acpi_cpu(struct acpi_table_header *table, + unsigned int cpu, int level) +{ + struct acpi_pptt_processor *cpu_node; + u32 acpi_cpu_id =

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-20 Thread Christ, Austin
Hey Jeremy, Quick comment below. On 10/12/2017 1:48 PM, Jeremy Linton wrote: +static int topology_setup_acpi_cpu(struct acpi_table_header *table, + unsigned int cpu, int level) +{ + struct acpi_pptt_processor *cpu_node; + u32 acpi_cpu_id =

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-20 Thread Lorenzo Pieralisi
On Thu, Oct 19, 2017 at 10:43:46AM -0500, Jeremy Linton wrote: > On 10/19/2017 05:22 AM, Lorenzo Pieralisi wrote: > >On Thu, Oct 12, 2017 at 02:48:50PM -0500, Jeremy Linton wrote: > >>ACPI 6.2 adds a new table, which describes how processing units > >>are related to each other in tree like

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-20 Thread Lorenzo Pieralisi
On Thu, Oct 19, 2017 at 10:43:46AM -0500, Jeremy Linton wrote: > On 10/19/2017 05:22 AM, Lorenzo Pieralisi wrote: > >On Thu, Oct 12, 2017 at 02:48:50PM -0500, Jeremy Linton wrote: > >>ACPI 6.2 adds a new table, which describes how processing units > >>are related to each other in tree like

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread Jeremy Linton
On 10/19/2017 05:22 AM, Lorenzo Pieralisi wrote: On Thu, Oct 12, 2017 at 02:48:50PM -0500, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread Jeremy Linton
On 10/19/2017 05:22 AM, Lorenzo Pieralisi wrote: On Thu, Oct 12, 2017 at 02:48:50PM -0500, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread Jeremy Linton
Hi, On 10/19/2017 12:18 AM, Tomasz Nowicki wrote: On 18.10.2017 19:30, Jeremy Linton wrote: On 10/18/2017 05:24 AM, Tomasz Nowicki wrote: On 18.10.2017 07:39, Tomasz Nowicki wrote: On 17.10.2017 17:22, Jeremy Linton wrote: On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: On 12.10.2017 21:48,

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread Jeremy Linton
Hi, On 10/19/2017 12:18 AM, Tomasz Nowicki wrote: On 18.10.2017 19:30, Jeremy Linton wrote: On 10/18/2017 05:24 AM, Tomasz Nowicki wrote: On 18.10.2017 07:39, Tomasz Nowicki wrote: On 17.10.2017 17:22, Jeremy Linton wrote: On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: On 12.10.2017 21:48,

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread John Garry
On 19/10/2017 06:18, Tomasz Nowicki wrote: Summary: I'm not at all happy with this specification's attempt to leave out pieces of information which make parsing things more deterministic. In this case I'm happy to demote the message level, but not remove it entirely but I do think the obvious

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread John Garry
On 19/10/2017 06:18, Tomasz Nowicki wrote: Summary: I'm not at all happy with this specification's attempt to leave out pieces of information which make parsing things more deterministic. In this case I'm happy to demote the message level, but not remove it entirely but I do think the obvious

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread Lorenzo Pieralisi
On Thu, Oct 12, 2017 at 02:48:50PM -0500, Jeremy Linton wrote: > ACPI 6.2 adds a new table, which describes how processing units > are related to each other in tree like fashion. Caches are > also sprinkled throughout the tree and describe the properties > of the caches in relation to other caches

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-19 Thread Lorenzo Pieralisi
On Thu, Oct 12, 2017 at 02:48:50PM -0500, Jeremy Linton wrote: > ACPI 6.2 adds a new table, which describes how processing units > are related to each other in tree like fashion. Caches are > also sprinkled throughout the tree and describe the properties > of the caches in relation to other caches

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-18 Thread Tomasz Nowicki
On 18.10.2017 19:30, Jeremy Linton wrote: On 10/18/2017 05:24 AM, Tomasz Nowicki wrote: On 18.10.2017 07:39, Tomasz Nowicki wrote: Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-18 Thread Tomasz Nowicki
On 18.10.2017 19:30, Jeremy Linton wrote: On 10/18/2017 05:24 AM, Tomasz Nowicki wrote: On 18.10.2017 07:39, Tomasz Nowicki wrote: Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-18 Thread Jeremy Linton
On 10/18/2017 05:24 AM, Tomasz Nowicki wrote: On 18.10.2017 07:39, Tomasz Nowicki wrote: Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-18 Thread Jeremy Linton
On 10/18/2017 05:24 AM, Tomasz Nowicki wrote: On 18.10.2017 07:39, Tomasz Nowicki wrote: Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-18 Thread Tomasz Nowicki
On 18.10.2017 07:39, Tomasz Nowicki wrote: Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-18 Thread Tomasz Nowicki
On 18.10.2017 07:39, Tomasz Nowicki wrote: Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Tomasz Nowicki
Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Tomasz Nowicki
Hi, On 17.10.2017 17:22, Jeremy Linton wrote: Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Xiongfeng Wang
Hi Jeremy, On 2017/10/17 23:22, Jeremy Linton wrote: > Hi, > > On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: >> Hi Jeremy, >> >> I did second round of review and have some more comments, please see below: >> >> On 12.10.2017 21:48, Jeremy Linton wrote: > I disagree, that routine is shared by the

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Xiongfeng Wang
Hi Jeremy, On 2017/10/17 23:22, Jeremy Linton wrote: > Hi, > > On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: >> Hi Jeremy, >> >> I did second round of review and have some more comments, please see below: >> >> On 12.10.2017 21:48, Jeremy Linton wrote: > I disagree, that routine is shared by the

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Jeremy Linton
Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion.

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Jeremy Linton
Hi, On 10/17/2017 08:25 AM, Tomasz Nowicki wrote: Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion.

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Tomasz Nowicki
Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-17 Thread Tomasz Nowicki
Hi Jeremy, I did second round of review and have some more comments, please see below: On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-16 Thread John Garry
On 12/10/2017 20:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in relation to other caches and processing units. Add

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-16 Thread John Garry
On 12/10/2017 20:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in relation to other caches and processing units. Add

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread Jeremy Linton
Hi, Thanks for spending the time to take a look at this. On 10/13/2017 04:56 AM, Julien Thierry wrote: Hi Jeremy, Please see below some suggestions. On 12/10/17 20:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread Jeremy Linton
Hi, Thanks for spending the time to take a look at this. On 10/13/2017 04:56 AM, Julien Thierry wrote: Hi Jeremy, Please see below some suggestions. On 12/10/17 20:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread Jeremy Linton
Hi, On 10/13/2017 09:23 AM, tn wrote: Hi Jeremy, On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread Jeremy Linton
Hi, On 10/13/2017 09:23 AM, tn wrote: Hi Jeremy, On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread tn
Hi Jeremy, On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in relation to other caches and processing

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread tn
Hi Jeremy, On 12.10.2017 21:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in relation to other caches and processing

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread Julien Thierry
Hi Jeremy, Please see below some suggestions. On 12/10/17 20:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in

Re: [PATCH v3 1/7] ACPI/PPTT: Add Processor Properties Topology Table parsing

2017-10-13 Thread Julien Thierry
Hi Jeremy, Please see below some suggestions. On 12/10/17 20:48, Jeremy Linton wrote: ACPI 6.2 adds a new table, which describes how processing units are related to each other in tree like fashion. Caches are also sprinkled throughout the tree and describe the properties of the caches in