Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

2016-09-16 Thread Jens Axboe
On 09/16/2016 09:13 AM, Andy Lutomirski wrote: On Sep 16, 2016 1:41 AM, "Christoph Hellwig" wrote: On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote: Any user I can imagine that needs a buffer at all will want to pass a pointer directly. There are no currently

Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

2016-09-16 Thread Jens Axboe
On 09/16/2016 09:13 AM, Andy Lutomirski wrote: On Sep 16, 2016 1:41 AM, "Christoph Hellwig" wrote: On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote: Any user I can imagine that needs a buffer at all will want to pass a pointer directly. There are no currently callers that use

Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

2016-09-16 Thread Andy Lutomirski
On Sep 16, 2016 1:41 AM, "Christoph Hellwig" wrote: > > On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote: > > Any user I can imagine that needs a buffer at all will want to pass > > a pointer directly. There are no currently callers that use > > buffers, so this

Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

2016-09-16 Thread Andy Lutomirski
On Sep 16, 2016 1:41 AM, "Christoph Hellwig" wrote: > > On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote: > > Any user I can imagine that needs a buffer at all will want to pass > > a pointer directly. There are no currently callers that use > > buffers, so this change is

Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

2016-09-16 Thread Christoph Hellwig
On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote: > Any user I can imagine that needs a buffer at all will want to pass > a pointer directly. There are no currently callers that use > buffers, so this change is painless, and it will make it much easier > to start using features

Re: [PATCH v3 2/3] nvme: Pass pointers, not dma addresses, to nvme_get/set_features()

2016-09-16 Thread Christoph Hellwig
On Thu, Sep 15, 2016 at 10:24:20PM -0700, Andy Lutomirski wrote: > Any user I can imagine that needs a buffer at all will want to pass > a pointer directly. There are no currently callers that use > buffers, so this change is painless, and it will make it much easier > to start using features