Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-17 Thread Rob Herring
On Thu, Aug 10, 2017 at 06:57:40PM +0800, David.Wu wrote: > Hi Andrew, Florian > > 在 2017/8/10 8:20, Andrew Lunn 写道: > > Hi Florian, David. > > > > I'm happy with the property name. But i think the text needs more > > description. We deal with Ethernet switches with integrated PHYs. Yet > > for u

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-10 Thread David.Wu
Hi Andrew, Florian 在 2017/8/10 8:20, Andrew Lunn 写道: Hi Florian, David. I'm happy with the property name. But i think the text needs more description. We deal with Ethernet switches with integrated PHYs. Yet for us, this property is unneeded. Seeing this property means some bit of software nee

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Chen-Yu Tsai
On Thu, Aug 10, 2017 at 8:20 AM, Andrew Lunn wrote: > On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: >> On August 9, 2017 5:10:30 AM PDT, David Wu wrote: >> >Add the documentation for internal phy. A boolean property >> >indicates that a internal phy will be used. >> > >> >Sign

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Andrew Lunn
On Wed, Aug 09, 2017 at 03:47:34PM -0700, Florian Fainelli wrote: > On August 9, 2017 5:10:30 AM PDT, David Wu wrote: > >Add the documentation for internal phy. A boolean property > >indicates that a internal phy will be used. > > > >Signed-off-by: David Wu > >--- > > Documentation/devicetree/bin

Re: [PATCH v4 05/12] Documentation: net: phy: Add phy-is-internal binding

2017-08-09 Thread Florian Fainelli
On August 9, 2017 5:10:30 AM PDT, David Wu wrote: >Add the documentation for internal phy. A boolean property >indicates that a internal phy will be used. > >Signed-off-by: David Wu >--- > Documentation/devicetree/bindings/net/phy.txt | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/Docu