Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs
On Fri, Apr 06, 2018 at 04:16:42PM -0700, Stephen Boyd wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian
> > Signed-off-by: Lina Iyer
> > Reviewed-by: Bjorn Andersson
> > ---
> >
>
> Reviewed-by: Stephen Boyd
>
> > + reserved-memory {
> > + [...]
> > + qcom,cmd-db@85fe {
>
> Nitpick: This may want to be called 'memory@85fe' because we prefer
> generic node names.
Well, "memory" is for nodes of memory that aren't reserved. So
"reserved-memory@..." would be better.
Otherwise,
Reviewed-by: Rob Herring
Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs
On Fri, Apr 6, 2018 at 4:16 PM Stephen Boyd wrote:
> Quoting Lina Iyer (2018-04-06 08:13:56)
> > From: Mahesh Sivasubramanian
> >
> > Command DB provides information on shared resources like clocks,
> > regulators etc., probed at boot by the remote subsytem and made
> > available in shared memory.
> >
> > Cc: devicet...@vger.kernel.org
> > Signed-off-by: Mahesh Sivasubramanian
> > Signed-off-by: Lina Iyer
> > Reviewed-by: Bjorn Andersson
> > ---
> >
> Reviewed-by: Stephen Boyd
> > + reserved-memory {
> > + [...]
> > + qcom,cmd-db@85fe {
> Nitpick: This may want to be called 'memory@85fe' because we prefer
> generic node names.
Another nit: the cmd-db region seems to need "no-map" to make the example
actually work.
Reviewed-by: Evan Green
-Evan
Re: [PATCH v7 [RESEND] 2/2] dt-bindings: introduce Command DB for QCOM SoCs
Quoting Lina Iyer (2018-04-06 08:13:56)
> From: Mahesh Sivasubramanian
>
> Command DB provides information on shared resources like clocks,
> regulators etc., probed at boot by the remote subsytem and made
> available in shared memory.
>
> Cc: devicet...@vger.kernel.org
> Signed-off-by: Mahesh Sivasubramanian
> Signed-off-by: Lina Iyer
> Reviewed-by: Bjorn Andersson
> ---
>
Reviewed-by: Stephen Boyd
> + reserved-memory {
> + [...]
> + qcom,cmd-db@85fe {
Nitpick: This may want to be called 'memory@85fe' because we prefer
generic node names.
