Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-05 Thread Lorenzo Pieralisi
On Fri, Jan 02, 2015 at 09:09:33PM +, Arnd Bergmann wrote: > On Friday 02 January 2015 12:18:06 Suravee Suthikulanit wrote: > > On 1/2/2015 5:55 AM, Lorenzo Pieralisi wrote: > > > Hi Suravee, > > > > > > On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: > > >> >Hi, > > >>

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-05 Thread Lorenzo Pieralisi
On Fri, Jan 02, 2015 at 09:09:33PM +, Arnd Bergmann wrote: On Friday 02 January 2015 12:18:06 Suravee Suthikulanit wrote: On 1/2/2015 5:55 AM, Lorenzo Pieralisi wrote: Hi Suravee, On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: Hi, I am not sure if

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-02 Thread Arnd Bergmann
On Friday 02 January 2015 12:18:06 Suravee Suthikulanit wrote: > On 1/2/2015 5:55 AM, Lorenzo Pieralisi wrote: > > Hi Suravee, > > > > On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: > >> >Hi, > >> > > >> >I am not sure if this thread is still alive. I'm trying to see what I

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-02 Thread Suravee Suthikulanit
On 1/2/2015 5:55 AM, Lorenzo Pieralisi wrote: Hi Suravee, On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: >Hi, > >I am not sure if this thread is still alive. I'm trying to see what I >can do to help clean up/convert to make the PCI GHC also works for arm64 >w/ zero or

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-02 Thread Lorenzo Pieralisi
Hi Suravee, On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: > Hi, > > I am not sure if this thread is still alive. I'm trying to see what I > can do to help clean up/convert to make the PCI GHC also works for arm64 > w/ zero or minimal ifdefs. > > Please let me know if

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-02 Thread Lorenzo Pieralisi
Hi Suravee, On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: Hi, I am not sure if this thread is still alive. I'm trying to see what I can do to help clean up/convert to make the PCI GHC also works for arm64 w/ zero or minimal ifdefs. Please let me know if someone

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-02 Thread Suravee Suthikulanit
On 1/2/2015 5:55 AM, Lorenzo Pieralisi wrote: Hi Suravee, On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: Hi, I am not sure if this thread is still alive. I'm trying to see what I can do to help clean up/convert to make the PCI GHC also works for arm64 w/ zero or

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2015-01-02 Thread Arnd Bergmann
On Friday 02 January 2015 12:18:06 Suravee Suthikulanit wrote: On 1/2/2015 5:55 AM, Lorenzo Pieralisi wrote: Hi Suravee, On Mon, Dec 29, 2014 at 07:32:44PM +, Suravee Suthikulpanit wrote: Hi, I am not sure if this thread is still alive. I'm trying to see what I can do to help

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-12-29 Thread Suravee Suthikulpanit
Hi, I am not sure if this thread is still alive. I'm trying to see what I can do to help clean up/convert to make the PCI GHC also works for arm64 w/ zero or minimal ifdefs. Please let me know if someone is already working on this. I noticed that Lorenzo's patches has already been in

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-12-29 Thread Suravee Suthikulpanit
Hi, I am not sure if this thread is still alive. I'm trying to see what I can do to help clean up/convert to make the PCI GHC also works for arm64 w/ zero or minimal ifdefs. Please let me know if someone is already working on this. I noticed that Lorenzo's patches has already been in

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-06 Thread Lorenzo Pieralisi
On Thu, Nov 06, 2014 at 12:05:48AM +, Arnd Bergmann wrote: > On Wednesday 05 November 2014 16:39:21 Bjorn Helgaas wrote: > > On Wed, Oct 22, 2014 at 10:52:19PM +0200, Arnd Bergmann wrote: > > > On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: > > > > On Wed, Oct 01, 2014 at

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-06 Thread Lorenzo Pieralisi
On Thu, Nov 06, 2014 at 12:05:48AM +, Arnd Bergmann wrote: On Wednesday 05 November 2014 16:39:21 Bjorn Helgaas wrote: On Wed, Oct 22, 2014 at 10:52:19PM +0200, Arnd Bergmann wrote: On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Arnd Bergmann
On Wednesday 05 November 2014 16:40:58 Bjorn Helgaas wrote: > > > > See below for a sample patch I just did. It duplicates the code from > > pci_common_init_dev/pci_common_init because we know that all users > > of pci_common_init_dev are modern and only pass a single host bridge. > > The new

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Arnd Bergmann
On Wednesday 05 November 2014 16:39:21 Bjorn Helgaas wrote: > On Wed, Oct 22, 2014 at 10:52:19PM +0200, Arnd Bergmann wrote: > > On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: > > > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > > > > > [...] > > > > > > > The

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Bjorn Helgaas
On Thu, Oct 23, 2014 at 03:33:16PM +0200, Arnd Bergmann wrote: > On Thursday 23 October 2014 10:13:09 Liviu Dudau wrote: > > > @@ -335,7 +329,9 @@ void __init cns3xxx_pcie_init_late(void) > > > cns3xxx_pwr_soft_rst(0x1 << PM_SOFT_RST_REG_OFFST_PCIE(i)); > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Bjorn Helgaas
On Wed, Oct 22, 2014 at 10:52:19PM +0200, Arnd Bergmann wrote: > On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: > > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > > > [...] > > > > > The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Bjorn Helgaas
On Wed, Oct 22, 2014 at 10:52:19PM +0200, Arnd Bergmann wrote: On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be removed if

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Bjorn Helgaas
On Thu, Oct 23, 2014 at 03:33:16PM +0200, Arnd Bergmann wrote: On Thursday 23 October 2014 10:13:09 Liviu Dudau wrote: @@ -335,7 +329,9 @@ void __init cns3xxx_pcie_init_late(void) cns3xxx_pwr_soft_rst(0x1 PM_SOFT_RST_REG_OFFST_PCIE(i));

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Arnd Bergmann
On Wednesday 05 November 2014 16:39:21 Bjorn Helgaas wrote: On Wed, Oct 22, 2014 at 10:52:19PM +0200, Arnd Bergmann wrote: On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] The arm32

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-11-05 Thread Arnd Bergmann
On Wednesday 05 November 2014 16:40:58 Bjorn Helgaas wrote: See below for a sample patch I just did. It duplicates the code from pci_common_init_dev/pci_common_init because we know that all users of pci_common_init_dev are modern and only pass a single host bridge. The new

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-27 Thread Lorenzo Pieralisi
On Thu, Oct 23, 2014 at 05:52:06PM +0100, Jason Gunthorpe wrote: > On Thu, Oct 23, 2014 at 12:27:31PM +0100, Lorenzo Pieralisi wrote: > > > I think that by removing that, we could switch to CONFIG_PCI_DOMAINS_GENERIC > > on ARM32. I will remove the dependency in drivers/pci/host/pci-mvebu.c > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-27 Thread Lorenzo Pieralisi
On Thu, Oct 23, 2014 at 05:52:06PM +0100, Jason Gunthorpe wrote: On Thu, Oct 23, 2014 at 12:27:31PM +0100, Lorenzo Pieralisi wrote: I think that by removing that, we could switch to CONFIG_PCI_DOMAINS_GENERIC on ARM32. I will remove the dependency in drivers/pci/host/pci-mvebu.c

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-24 Thread Liviu Dudau
On Thu, Oct 23, 2014 at 02:33:16PM +0100, Arnd Bergmann wrote: > On Thursday 23 October 2014 10:13:09 Liviu Dudau wrote: > > > @@ -335,7 +329,9 @@ void __init cns3xxx_pcie_init_late(void) > > > cns3xxx_pwr_soft_rst(0x1 << PM_SOFT_RST_REG_OFFST_PCIE(i)); > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-24 Thread Liviu Dudau
On Thu, Oct 23, 2014 at 02:33:16PM +0100, Arnd Bergmann wrote: On Thursday 23 October 2014 10:13:09 Liviu Dudau wrote: @@ -335,7 +329,9 @@ void __init cns3xxx_pcie_init_late(void) cns3xxx_pwr_soft_rst(0x1 PM_SOFT_RST_REG_OFFST_PCIE(i));

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Jason Gunthorpe
On Thu, Oct 23, 2014 at 12:27:31PM +0100, Lorenzo Pieralisi wrote: > I think that by removing that, we could switch to CONFIG_PCI_DOMAINS_GENERIC > on ARM32. I will remove the dependency in drivers/pci/host/pci-mvebu.c > introduced by commit 2613ba48. pci_sys_data.domain is always 0 in that >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Arnd Bergmann
On Thursday 23 October 2014 10:13:09 Liviu Dudau wrote: > > @@ -335,7 +329,9 @@ void __init cns3xxx_pcie_init_late(void) > > cns3xxx_pwr_soft_rst(0x1 << PM_SOFT_RST_REG_OFFST_PCIE(i)); > > cns3xxx_pcie_check_link(_pcie[i]); > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Lorenzo Pieralisi
On Thu, Oct 23, 2014 at 10:13:09AM +0100, Liviu Dudau wrote: > On Wed, Oct 22, 2014 at 09:52:19PM +0100, Arnd Bergmann wrote: > > On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: > > > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > > > > > [...] > > > > > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Liviu Dudau
On Wed, Oct 22, 2014 at 09:52:19PM +0100, Arnd Bergmann wrote: > On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: > > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > > > [...] > > > > > The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Liviu Dudau
On Wed, Oct 22, 2014 at 09:52:19PM +0100, Arnd Bergmann wrote: On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be removed if

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Lorenzo Pieralisi
On Thu, Oct 23, 2014 at 10:13:09AM +0100, Liviu Dudau wrote: On Wed, Oct 22, 2014 at 09:52:19PM +0100, Arnd Bergmann wrote: On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] The arm32

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Arnd Bergmann
On Thursday 23 October 2014 10:13:09 Liviu Dudau wrote: @@ -335,7 +329,9 @@ void __init cns3xxx_pcie_init_late(void) cns3xxx_pwr_soft_rst(0x1 PM_SOFT_RST_REG_OFFST_PCIE(i)); cns3xxx_pcie_check_link(cns3xxx_pcie[i]);

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-23 Thread Jason Gunthorpe
On Thu, Oct 23, 2014 at 12:27:31PM +0100, Lorenzo Pieralisi wrote: I think that by removing that, we could switch to CONFIG_PCI_DOMAINS_GENERIC on ARM32. I will remove the dependency in drivers/pci/host/pci-mvebu.c introduced by commit 2613ba48. pci_sys_data.domain is always 0 in that driver

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-22 Thread Arnd Bergmann
On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > [...] > > > The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be > > removed if we change the arm32 pcibios_init_hw function to call the new >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-22 Thread Bjorn Helgaas
On Wed, Oct 22, 2014 at 9:59 AM, Lorenzo Pieralisi wrote: > ... I wonder what's the > best course of action. Putting together all the bits and pieces required > to remove PCI bios dependency from this patch can take a while, I wonder > whether we should aim for merging this driver (rebased on

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-22 Thread Lorenzo Pieralisi
On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] > The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be > removed if we change the arm32 pcibios_init_hw function to call the new > interfaces that set the domain number. I wished, but it is a bit more

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-22 Thread Lorenzo Pieralisi
On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be removed if we change the arm32 pcibios_init_hw function to call the new interfaces that set the domain number. I wished, but it is a bit more

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-22 Thread Bjorn Helgaas
On Wed, Oct 22, 2014 at 9:59 AM, Lorenzo Pieralisi lorenzo.pieral...@arm.com wrote: ... I wonder what's the best course of action. Putting together all the bits and pieces required to remove PCI bios dependency from this patch can take a while, I wonder whether we should aim for merging this

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-22 Thread Arnd Bergmann
On Wednesday 22 October 2014 16:59:14 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] The arm32 implementations of pci_domain_nr/pci_proc_domain can probably be removed if we change the arm32 pcibios_init_hw function to call the new

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-13 Thread Lorenzo Pieralisi
On Fri, Oct 10, 2014 at 07:31:26PM +0100, Arnd Bergmann wrote: > On Friday 10 October 2014 14:58:04 Lorenzo Pieralisi wrote: > > On Thu, Oct 09, 2014 at 11:51:43AM +0100, Arnd Bergmann wrote: > > > > > > Last changes where introduced by commit 8c05cd08a, whose commit log adds > > > > to my

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-13 Thread Lorenzo Pieralisi
On Fri, Oct 10, 2014 at 07:31:26PM +0100, Arnd Bergmann wrote: On Friday 10 October 2014 14:58:04 Lorenzo Pieralisi wrote: On Thu, Oct 09, 2014 at 11:51:43AM +0100, Arnd Bergmann wrote: Last changes where introduced by commit 8c05cd08a, whose commit log adds to my confusion:

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-10 Thread Arnd Bergmann
On Friday 10 October 2014 14:58:04 Lorenzo Pieralisi wrote: > On Thu, Oct 09, 2014 at 11:51:43AM +0100, Arnd Bergmann wrote: > > > > Last changes where introduced by commit 8c05cd08a, whose commit log adds > > > to my confusion: > > > > > > "[...] I think what we want here is for pci_start to be

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-10 Thread Lorenzo Pieralisi
On Thu, Oct 09, 2014 at 11:51:43AM +0100, Arnd Bergmann wrote: [...] > > Last changes where introduced by commit 8c05cd08a, whose commit log adds > > to my confusion: > > > > "[...] I think what we want here is for pci_start to be 0 when mmap_api == > > PCI_MMAP_PROCFS.[...]" > > > > But

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-10 Thread Lorenzo Pieralisi
On Thu, Oct 09, 2014 at 11:51:43AM +0100, Arnd Bergmann wrote: [...] Last changes where introduced by commit 8c05cd08a, whose commit log adds to my confusion: [...] I think what we want here is for pci_start to be 0 when mmap_api == PCI_MMAP_PROCFS.[...] But that's not what the

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-10 Thread Arnd Bergmann
On Friday 10 October 2014 14:58:04 Lorenzo Pieralisi wrote: On Thu, Oct 09, 2014 at 11:51:43AM +0100, Arnd Bergmann wrote: Last changes where introduced by commit 8c05cd08a, whose commit log adds to my confusion: [...] I think what we want here is for pci_start to be 0 when

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-09 Thread Arnd Bergmann
On Thursday 09 October 2014 10:04:20 Lorenzo Pieralisi wrote: > On Wed, Oct 08, 2014 at 03:47:43PM +0100, Arnd Bergmann wrote: > > On Wednesday 08 October 2014 11:19:43 Lorenzo Pieralisi wrote: > > Please look at the procfs interface again. That one can be defined > > in two ways (either like

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-09 Thread Lorenzo Pieralisi
On Wed, Oct 08, 2014 at 03:47:43PM +0100, Arnd Bergmann wrote: > On Wednesday 08 October 2014 11:19:43 Lorenzo Pieralisi wrote: > > > > Ok. So, unless I am missing something, on platform with mem_offset != 0 > > /proc and /sys interfaces for remapping PCI resources can't work (IIUC > > the proc

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-09 Thread Lorenzo Pieralisi
On Wed, Oct 08, 2014 at 03:47:43PM +0100, Arnd Bergmann wrote: On Wednesday 08 October 2014 11:19:43 Lorenzo Pieralisi wrote: Ok. So, unless I am missing something, on platform with mem_offset != 0 /proc and /sys interfaces for remapping PCI resources can't work (IIUC the proc interface

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-09 Thread Arnd Bergmann
On Thursday 09 October 2014 10:04:20 Lorenzo Pieralisi wrote: On Wed, Oct 08, 2014 at 03:47:43PM +0100, Arnd Bergmann wrote: On Wednesday 08 October 2014 11:19:43 Lorenzo Pieralisi wrote: Please look at the procfs interface again. That one can be defined in two ways (either like sparc and

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 11:19:43 Lorenzo Pieralisi wrote: > > Ok. So, unless I am missing something, on platform with mem_offset != 0 > /proc and /sys interfaces for remapping PCI resources can't work (IIUC > the proc interface expects the user to pass in the resource address as > seen from

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-08 Thread Lorenzo Pieralisi
On Tue, Oct 07, 2014 at 10:39:47PM +0100, Arnd Bergmann wrote: > On Tuesday 07 October 2014 15:47:50 Lorenzo Pieralisi wrote: > > On Tue, Oct 07, 2014 at 02:52:27PM +0100, Arnd Bergmann wrote: > > > On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: > > > > On Wed, Oct 01, 2014 at

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-08 Thread Lorenzo Pieralisi
On Tue, Oct 07, 2014 at 10:39:47PM +0100, Arnd Bergmann wrote: On Tuesday 07 October 2014 15:47:50 Lorenzo Pieralisi wrote: On Tue, Oct 07, 2014 at 02:52:27PM +0100, Arnd Bergmann wrote: On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-08 Thread Arnd Bergmann
On Wednesday 08 October 2014 11:19:43 Lorenzo Pieralisi wrote: Ok. So, unless I am missing something, on platform with mem_offset != 0 /proc and /sys interfaces for remapping PCI resources can't work (IIUC the proc interface expects the user to pass in the resource address as seen from

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Arnd Bergmann
On Tuesday 07 October 2014 15:47:50 Lorenzo Pieralisi wrote: > On Tue, Oct 07, 2014 at 02:52:27PM +0100, Arnd Bergmann wrote: > > On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: > > > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > > > > > [...] > > > > > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Lorenzo Pieralisi
On Tue, Oct 07, 2014 at 02:52:27PM +0100, Arnd Bergmann wrote: > On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: > > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > > > [...] > > > > > pci_mmap_page_range could either get generalized some more in an attempt > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Arnd Bergmann
On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: > On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: > > [...] > > > pci_mmap_page_range could either get generalized some more in an attempt > > to have a __weak default implementation that works on ARM, or it could > > be

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Lorenzo Pieralisi
On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] > pci_mmap_page_range could either get generalized some more in an attempt > to have a __weak default implementation that works on ARM, or it could > be changed to lose the dependency on pci_sys_data instead. In either > case,

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Lorenzo Pieralisi
On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] pci_mmap_page_range could either get generalized some more in an attempt to have a __weak default implementation that works on ARM, or it could be changed to lose the dependency on pci_sys_data instead. In either case, the

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Arnd Bergmann
On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] pci_mmap_page_range could either get generalized some more in an attempt to have a __weak default implementation that works on ARM, or it could be changed

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Lorenzo Pieralisi
On Tue, Oct 07, 2014 at 02:52:27PM +0100, Arnd Bergmann wrote: On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] pci_mmap_page_range could either get generalized some more in an attempt to have a

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-07 Thread Arnd Bergmann
On Tuesday 07 October 2014 15:47:50 Lorenzo Pieralisi wrote: On Tue, Oct 07, 2014 at 02:52:27PM +0100, Arnd Bergmann wrote: On Tuesday 07 October 2014 13:06:59 Lorenzo Pieralisi wrote: On Wed, Oct 01, 2014 at 10:38:45AM +0100, Arnd Bergmann wrote: [...] pci_mmap_page_range

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-01 Thread Arnd Bergmann
On Wednesday 01 October 2014 09:46:26 Liviu Dudau wrote: > On Tue, Sep 30, 2014 at 09:01:14PM +0100, Arnd Bergmann wrote: > > On Tuesday 30 September 2014 20:54:41 Arnd Bergmann wrote: > > > On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: > > > > > > > > These are the functions I found

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-01 Thread Liviu Dudau
On Tue, Sep 30, 2014 at 09:01:14PM +0100, Arnd Bergmann wrote: > On Tuesday 30 September 2014 20:54:41 Arnd Bergmann wrote: > > On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: > > > > > > > These are the functions I found that refer to pci_sys_data on > > > > > > > arm32: > > > > > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-01 Thread Liviu Dudau
On Tue, Sep 30, 2014 at 09:01:14PM +0100, Arnd Bergmann wrote: On Tuesday 30 September 2014 20:54:41 Arnd Bergmann wrote: On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: These are the functions I found that refer to pci_sys_data on arm32: pcibios_add_bus

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-10-01 Thread Arnd Bergmann
On Wednesday 01 October 2014 09:46:26 Liviu Dudau wrote: On Tue, Sep 30, 2014 at 09:01:14PM +0100, Arnd Bergmann wrote: On Tuesday 30 September 2014 20:54:41 Arnd Bergmann wrote: On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: These are the functions I found that refer to

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Arnd Bergmann
On Tuesday 30 September 2014 20:54:41 Arnd Bergmann wrote: > On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: > > > > > > These are the functions I found that refer to pci_sys_data on arm32: > > > > > > > > > > > > pcibios_add_bus > > > > > > pcibios_remove_bus > > > > These are only

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Arnd Bergmann
On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: > > > > > These are the functions I found that refer to pci_sys_data on arm32: > > > > > > > > > > pcibios_add_bus > > > > > pcibios_remove_bus > > These are only needed if you want to do per HB processing of the bus > > > > > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Liviu Dudau
On Tue, Sep 30, 2014 at 06:35:40PM +0100, Lorenzo Pieralisi wrote: > On Tue, Sep 30, 2014 at 05:42:56PM +0100, Liviu Dudau wrote: > > On Tue, Sep 30, 2014 at 05:12:41PM +0100, Lorenzo Pieralisi wrote: > > > On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: > > > > On Tuesday 30

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Lorenzo Pieralisi
On Tue, Sep 30, 2014 at 05:42:56PM +0100, Liviu Dudau wrote: > On Tue, Sep 30, 2014 at 05:12:41PM +0100, Lorenzo Pieralisi wrote: > > On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: > > > On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: > > > > > > static int

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Liviu Dudau
On Tue, Sep 30, 2014 at 05:12:41PM +0100, Lorenzo Pieralisi wrote: > On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: > > On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: > > > > > static int gen_pci_probe(struct platform_device *pdev) > > > > > { > > > > > @@ -326,6

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Lorenzo Pieralisi
On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: > On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: > > > > static int gen_pci_probe(struct platform_device *pdev) > > > > { > > > > @@ -326,6 +385,7 @@ static int gen_pci_probe(struct platform_device > > > > *pdev) > >

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Arnd Bergmann
On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: > > > static int gen_pci_probe(struct platform_device *pdev) > > > { > > > @@ -326,6 +385,7 @@ static int gen_pci_probe(struct platform_device *pdev) > > > struct device *dev = >dev; > > > struct device_node *np =

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Lorenzo Pieralisi
On Mon, Sep 29, 2014 at 03:36:30PM +0100, Arnd Bergmann wrote: > On Sunday 28 September 2014 15:53:28 suravee.suthikulpa...@amd.com wrote: > > + > > +#ifdef CONFIG_ARM64 > > +struct pci_bus *gen_scan_root_bus(struct device *parent, int bus, > > + struct pci_ops

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Lorenzo Pieralisi
On Mon, Sep 29, 2014 at 03:36:30PM +0100, Arnd Bergmann wrote: On Sunday 28 September 2014 15:53:28 suravee.suthikulpa...@amd.com wrote: + +#ifdef CONFIG_ARM64 +struct pci_bus *gen_scan_root_bus(struct device *parent, int bus, + struct pci_ops *ops,

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Arnd Bergmann
On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: static int gen_pci_probe(struct platform_device *pdev) { @@ -326,6 +385,7 @@ static int gen_pci_probe(struct platform_device *pdev) struct device *dev = pdev-dev; struct device_node *np = dev-of_node;

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Lorenzo Pieralisi
On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: static int gen_pci_probe(struct platform_device *pdev) { @@ -326,6 +385,7 @@ static int gen_pci_probe(struct platform_device *pdev) struct

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Liviu Dudau
On Tue, Sep 30, 2014 at 05:12:41PM +0100, Lorenzo Pieralisi wrote: On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: static int gen_pci_probe(struct platform_device *pdev) { @@ -326,6 +385,7 @@ static

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Lorenzo Pieralisi
On Tue, Sep 30, 2014 at 05:42:56PM +0100, Liviu Dudau wrote: On Tue, Sep 30, 2014 at 05:12:41PM +0100, Lorenzo Pieralisi wrote: On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: On Tuesday 30 September 2014 13:03:44 Lorenzo Pieralisi wrote: static int gen_pci_probe(struct

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Liviu Dudau
On Tue, Sep 30, 2014 at 06:35:40PM +0100, Lorenzo Pieralisi wrote: On Tue, Sep 30, 2014 at 05:42:56PM +0100, Liviu Dudau wrote: On Tue, Sep 30, 2014 at 05:12:41PM +0100, Lorenzo Pieralisi wrote: On Tue, Sep 30, 2014 at 01:31:44PM +0100, Arnd Bergmann wrote: On Tuesday 30 September 2014

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Arnd Bergmann
On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: These are the functions I found that refer to pci_sys_data on arm32: pcibios_add_bus pcibios_remove_bus These are only needed if you want to do per HB processing of the bus pcibios_align_resource mvebu is

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-30 Thread Arnd Bergmann
On Tuesday 30 September 2014 20:54:41 Arnd Bergmann wrote: On Tuesday 30 September 2014 18:48:21 Liviu Dudau wrote: These are the functions I found that refer to pci_sys_data on arm32: pcibios_add_bus pcibios_remove_bus These are only needed if you want to do per HB

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-29 Thread Sunil Kovvuri
How does the res->parent for devices of non-"PCI_PROBE_ONLY" controller gets set with this patch ? On Mon, Sep 29, 2014 at 2:23 AM, wrote: > From: Suravee Suthikulpanit > > This patch adds ARM64 support to the generic PCI host driver. > > For MSI support, it adds new device tree binding

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-29 Thread Arnd Bergmann
On Sunday 28 September 2014 15:53:28 suravee.suthikulpa...@amd.com wrote: > + > +#ifdef CONFIG_ARM64 > +struct pci_bus *gen_scan_root_bus(struct device *parent, int bus, > + struct pci_ops *ops, void *sysdata, > + struct

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-29 Thread Arnd Bergmann
On Sunday 28 September 2014 15:53:28 suravee.suthikulpa...@amd.com wrote: + +#ifdef CONFIG_ARM64 +struct pci_bus *gen_scan_root_bus(struct device *parent, int bus, + struct pci_ops *ops, void *sysdata, + struct

Re: [RFC 2/4] PCI: generic: Add support for ARM64 and MSI(x)

2014-09-29 Thread Sunil Kovvuri
How does the res-parent for devices of non-PCI_PROBE_ONLY controller gets set with this patch ? On Mon, Sep 29, 2014 at 2:23 AM, suravee.suthikulpa...@amd.com wrote: From: Suravee Suthikulpanit suravee.suthikulpa...@amd.com This patch adds ARM64 support to the generic PCI host driver. For