applied as the attached two patches to jgarzik/libata-dev.git#alpm
open issues:
1) need to check ata_dev_set_feature() return value in
ata_dev_set_dipm() and do something useful with it
2) as the name implies, this probably better belongs in ata_link.
3) however, the feature is tightly
applied as the attached two patches to jgarzik/libata-dev.git#alpm
open issues:
1) need to check ata_dev_set_feature() return value in
ata_dev_set_dipm() and do something useful with it
2) as the name implies, this probably better belongs in ata_link.
3) however, the feature is tightly
Alan Cox wrote:
It converts several macros to inline functions (encouraged), and also
illustrates a nice, clean way of testing an ID word's validity.
[obviously the final implementation varies, depending on that ID word's
history]
Its in -mm and I thought you put a copy in your tree after I
> It converts several macros to inline functions (encouraged), and also
> illustrates a nice, clean way of testing an ID word's validity.
> [obviously the final implementation varies, depending on that ID word's
> history]
Its in -mm and I thought you put a copy in your tree after I said it
It converts several macros to inline functions (encouraged), and also
illustrates a nice, clean way of testing an ID word's validity.
[obviously the final implementation varies, depending on that ID word's
history]
Its in -mm and I thought you put a copy in your tree after I said it
hadn't
Alan Cox wrote:
It converts several macros to inline functions (encouraged), and also
illustrates a nice, clean way of testing an ID word's validity.
[obviously the final implementation varies, depending on that ID word's
history]
Its in -mm and I thought you put a copy in your tree after I
Davide Libenzi wrote:
> On Tue, 25 Sep 2007, roel wrote:
>
>>> + if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
>> if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) {
>
> int foo(int i, int j) {
>
> return !(i & 8) || !j;
> }
>
> int moo(int i, int
Kristen Carlson Accardi wrote:
On Tue, 25 Sep 2007 01:12:32 +0200
roel <[EMAIL PROTECTED]> wrote:
#define ata_id_cdb_intr(id)(((id)[0] & 0x60) == 0x20)
+#define ata_id_has_hipm(id)\
+ ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \
+ ((id)[76] & (1 << 9)) )
On Tue, 25 Sep 2007 01:12:32 +0200
roel <[EMAIL PROTECTED]> wrote:
> > #define ata_id_cdb_intr(id)(((id)[0] & 0x60) == 0x20)
> > +#define ata_id_has_hipm(id)\
> > + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \
> > + ((id)[76] & (1 << 9)) )
> ^
>
On Tue, 25 Sep 2007, roel wrote:
> > + if (!(ap->flags & ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
>
> if (!((ap->flags & ATA_FLAG_IPM) && ata_dev_enabled(dev))) {
int foo(int i, int j) {
return !(i & 8) || !j;
}
int moo(int i, int j) {
return !((i &
Kristen Carlson Accardi wrote:
> Device Initiated Power Management, which is defined
> in SATA 2.5 can be enabled for disks which support it.
> This patch enables DIPM when the user sets the link
> power management policy to "min_power".
>
> Additionally, libata drivers can define a function
>
Kristen Carlson Accardi wrote:
Device Initiated Power Management, which is defined
in SATA 2.5 can be enabled for disks which support it.
This patch enables DIPM when the user sets the link
power management policy to min_power.
Additionally, libata drivers can define a function
On Tue, 25 Sep 2007, roel wrote:
+ if (!(ap-flags ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
if (!((ap-flags ATA_FLAG_IPM) ata_dev_enabled(dev))) {
int foo(int i, int j) {
return !(i 8) || !j;
}
int moo(int i, int j) {
return !((i 8) j);
}
On Tue, 25 Sep 2007 01:12:32 +0200
roel [EMAIL PROTECTED] wrote:
#define ata_id_cdb_intr(id)(((id)[0] 0x60) == 0x20)
+#define ata_id_has_hipm(id)\
+ ( (((id)[76] != 0x) ((id)[76] != 0x)) \
+ ((id)[76] (1 9)) )
^
|
are you
Kristen Carlson Accardi wrote:
On Tue, 25 Sep 2007 01:12:32 +0200
roel [EMAIL PROTECTED] wrote:
#define ata_id_cdb_intr(id)(((id)[0] 0x60) == 0x20)
+#define ata_id_has_hipm(id)\
+ ( (((id)[76] != 0x) ((id)[76] != 0x)) \
+ ((id)[76] (1 9)) )
Davide Libenzi wrote:
On Tue, 25 Sep 2007, roel wrote:
+ if (!(ap-flags ATA_FLAG_IPM) || !ata_dev_enabled(dev)) {
if (!((ap-flags ATA_FLAG_IPM) ata_dev_enabled(dev))) {
int foo(int i, int j) {
return !(i 8) || !j;
}
int moo(int i, int j) {
16 matches
Mail list logo
