Re: linux-next: build warning after merge of the tip tree

2020-12-13 Thread Ard Biesheuvel
On Mon, 14 Dec 2020 at 06:48, Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > In file included from include/linux/kernel.h:14, > from include/linux/list.h:9, > from

Re: linux-next: build warning after merge of the tip tree

2020-11-22 Thread Stephen Rothwell
Hi Balbir, On Tue, 17 Nov 2020 16:21:31 +1100 Balbir Singh wrote: > > I am testing a fix by pointing the ref to a label, will send it out > (hopefully soon), seems to work at my end. Fixes the warning here as well, thanks. -- Cheers, Stephen Rothwell pgpDlpETEsg3r.pgp Description: OpenPGP d

Re: linux-next: build warning after merge of the tip tree

2020-11-16 Thread Balbir Singh
On 11/16/20 9:23 AM, Balbir Singh wrote: > > > On 10/28/20 2:23 PM, Stephen Rothwell wrote: >> Hi all, >> >> After merging the tip tree, today's linux-next build (htmldocs) produced >> this warning: >> >> Documentation/admin-guide/hw-vuln/l1d_flush.rst:25: WARNING: undefined >> label: documen

Re: linux-next: build warning after merge of the tip tree

2020-11-15 Thread Balbir Singh
On 10/28/20 2:23 PM, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (htmldocs) produced > this warning: > > Documentation/admin-guide/hw-vuln/l1d_flush.rst:25: WARNING: undefined label: > documentation/userspace-api/spec_ctrl.rst (if the link has no

Re: linux-next: build warning after merge of the tip tree

2020-11-15 Thread Stephen Rothwell
Hi all, On Wed, 28 Oct 2020 14:23:00 +1100 Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (htmldocs) produced > this warning: > > Documentation/admin-guide/hw-vuln/l1d_flush.rst:25: WARNING: undefined label: > documentation/userspace-api/spec_ctrl

Re: linux-next: build warning after merge of the tip tree

2020-11-05 Thread Stephen Rothwell
Hi all, On Thu, 5 Nov 2020 18:06:00 +1100 Stephen Rothwell wrote: > > After merging the tip tree, today's linux-next build (htmldocs) produced > this warning: > > Documentation/admin-guide/hw-vuln/l1d_flush.rst:25: WARNING: undefined label: > documentation/userspace-api/spec_ctrl.rst (if the

Re: linux-next: build warning after merge of the tip tree

2020-10-14 Thread Kees Cook
On Thu, Oct 15, 2020 at 09:25:26AM +1100, Stephen Rothwell wrote: > Hi Kees, > > On Sun, 4 Oct 2020 19:44:52 -0700 Kees Cook wrote: > > > > On Sun, Oct 04, 2020 at 09:00:18PM +1100, Stephen Rothwell wrote: > > > Hi Kees, > > > > > > On Sun, 4 Oct 2020 01:27:01 -0700 Kees Cook > > > wrote: >

Re: linux-next: build warning after merge of the tip tree

2020-10-14 Thread Stephen Rothwell
Hi Kees, On Wed, 14 Oct 2020 16:10:05 -0700 Kees Cook wrote: > > I've pinged the thread of the patch (from Oct 4th) that fixes this. > Hopefully that or this email will float to the top for an x86 > maintainer. :) If it doesn't get picked up soon, I can try sending this > direct to Linus, though

Re: linux-next: build warning after merge of the tip tree

2020-10-14 Thread Stephen Rothwell
Hi Kees, On Sun, 4 Oct 2020 19:44:52 -0700 Kees Cook wrote: > > On Sun, Oct 04, 2020 at 09:00:18PM +1100, Stephen Rothwell wrote: > > Hi Kees, > > > > On Sun, 4 Oct 2020 01:27:01 -0700 Kees Cook wrote: > > > > > > I assume CONFIG_CONSTRUCTORS is enabled for your build (it should be for > >

Re: linux-next: build warning after merge of the tip tree

2020-10-08 Thread Borislav Petkov
On Thu, Oct 08, 2020 at 03:28:32PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > WARNING: modpost: EXPORT symbol "copy_mc_fragile" [vmlinux] version > generation failed, symbol will not be vers

Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Kees Cook
On Sun, Oct 04, 2020 at 09:00:18PM +1100, Stephen Rothwell wrote: > Hi Kees, > > On Sun, 4 Oct 2020 01:27:01 -0700 Kees Cook wrote: > > > > I assume CONFIG_CONSTRUCTORS is enabled for your build (it should be for > > yes, indeed. > > > allmodconfig). Does this patch fix it? (I'm kind of blindly

Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Stephen Rothwell
Hi Kees, On Sun, 4 Oct 2020 01:27:01 -0700 Kees Cook wrote: > > I assume CONFIG_CONSTRUCTORS is enabled for your build (it should be for yes, indeed. > allmodconfig). Does this patch fix it? (I'm kind of blindly guessing > based on my understanding of where this could be coming from...) > > >

Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Kees Cook
On Sun, Oct 04, 2020 at 10:24:37AM +1100, Stephen Rothwell wrote: > Hi Kees, > > On Sat, 3 Oct 2020 14:54:46 -0700 Kees Cook wrote: > > > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the tip tree, today's linux-next build (x86_64 all

Re: linux-next: build warning after merge of the tip tree

2020-10-04 Thread Kees Cook
On Sun, Oct 04, 2020 at 10:24:37AM +1100, Stephen Rothwell wrote: > On Sat, 3 Oct 2020 14:54:46 -0700 Kees Cook wrote: > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > > produced this w

Re: linux-next: build warning after merge of the tip tree

2020-10-03 Thread Stephen Rothwell
Hi Kees, On Sat, 3 Oct 2020 14:54:46 -0700 Kees Cook wrote: > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > x86_64-linux-gnu-ld: warning: orpha

Re: linux-next: build warning after merge of the tip tree

2020-10-03 Thread Kees Cook
On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > x86_64-linux-gnu-ld: warning: orphan section `.ctors.65435' from > `kernel/trace/trace_selftest_dynamic.o' being

Re: linux-next: build warning after merge of the tip tree

2020-10-02 Thread Kees Cook
On Thu, Oct 01, 2020 at 09:02:57PM +1000, Stephen Rothwell wrote: > Hi all, > > On Tue, 15 Sep 2020 08:35:53 +1000 Stephen Rothwell > wrote: > > > > Hi Kees, > > > > On Mon, 14 Sep 2020 13:11:37 -0700 Kees Cook wrote: > > > > > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote

Re: linux-next: build warning after merge of the tip tree

2020-10-01 Thread Stephen Rothwell
Hi all, On Tue, 15 Sep 2020 08:35:53 +1000 Stephen Rothwell wrote: > > Hi Kees, > > On Mon, 14 Sep 2020 13:11:37 -0700 Kees Cook wrote: > > > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) >

Re: linux-next: build warning after merge of the tip tree

2020-09-14 Thread Stephen Rothwell
Hi Kees, On Mon, 14 Sep 2020 13:11:37 -0700 Kees Cook wrote: > > On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > x86_64-linux-gnu-ld: warning: orphan section `.ctor

Re: linux-next: build warning after merge of the tip tree

2020-09-14 Thread Kees Cook
On Mon, Sep 14, 2020 at 01:22:49PM +1000, Stephen Rothwell wrote: > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > x86_64-linux-gnu-ld: warning: orphan section `.ctors.65435' from > `kernel/trace/trace_selftest_dynamic.o' being placed in se

Re: linux-next: build warning after merge of the tip tree

2020-05-19 Thread Steve French
Ronnie mentioned that he will take a look ... On Tue, May 19, 2020 at 1:57 AM Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > fs/cifs/smb2inode.c: In function 'smb2_compound_op': > fs/cifs/smb2inode.c:

Re: linux-next: build warning after merge of the tip tree

2019-07-25 Thread Stephen Rothwell
Hi Josh, On Thu, 25 Jul 2019 23:49:09 -0500 Josh Poimboeuf wrote: > > This will be fixed by: > > > https://lkml.kernel.org/r/51a4155c5bc2ca847a9cbe85c1c11918bb193141.1564086017.git.jpoim...@redhat.com Thanks -- Cheers, Stephen Rothwell pgpIcuqnFnGu_.pgp Description: OpenPGP digital signa

Re: linux-next: build warning after merge of the tip tree

2019-07-25 Thread Josh Poimboeuf
On Fri, Jul 26, 2019 at 01:05:49PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > .altinstr_replacement+0x1c: redundant UACCES

Re: linux-next: build warning after merge of the tip tree

2018-12-18 Thread Stephen Rothwell
Hi all, On Tue, 6 Nov 2018 11:46:12 +1100 Stephen Rothwell wrote: > > After merging the tip tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > warning: include/asm-generic/atomic-instrumented.h is out-of-date. > warning: include/asm-generic/atomic-long.h is out

Re: linux-next: build warning after merge of the tip tree

2018-09-12 Thread Thomas Gleixner
On Tue, 11 Sep 2018, Stephen Rothwell wrote: > After merging the tip tree, today's linux-next build (x86_64 allnoconfig) > produced this warning: > > arch/x86/kernel/cpu/common.c: In function 'syscall_init': > arch/x86/kernel/cpu/common.c:1534:6: warning: unused variable 'cpu' > [-Wunused-variabl

Re: linux-next: build warning after merge of the tip tree

2018-03-23 Thread Stephen Rothwell
Hi Christoph, On Fri, 23 Mar 2018 09:31:34 +0100 Christoph Hellwig wrote: > > True. I'll send a fixup. Thanks. -- Cheers, Stephen Rothwell pgpatT5TbuEkF.pgp Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the tip tree

2018-03-23 Thread Christoph Hellwig
On Fri, Mar 23, 2018 at 01:28:53PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > lib/swiotlb.c:748:13: warning: 'swiotlb_free_buffer' defined but not used > [-Wunused-function] > static boo

Re: linux-next: build warning after merge of the tip tree

2018-03-16 Thread Thomas Gleixner
On Fri, 16 Mar 2018, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, yesterday's linux-next build (x86_64 allnoconfig) > produced this warning: > > kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used > [-Wunused-function] > static bool cpuhp_is_ap_state(enu

Re: linux-next: build warning after merge of the tip tree

2018-03-15 Thread Dou Liyang
Hi Stephen, At 03/16/2018 01:52 PM, Dou Liyang wrote: Hi Stephen, At 03/16/2018 01:37 PM, Stephen Rothwell wrote: Hi all, After merging the tip tree, yesterday's linux-next build (x86_64 allnoconfig) produced this warning: kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not u

Re: linux-next: build warning after merge of the tip tree

2018-03-15 Thread Dou Liyang
Hi Stephen, At 03/16/2018 01:37 PM, Stephen Rothwell wrote: Hi all, After merging the tip tree, yesterday's linux-next build (x86_64 allnoconfig) produced this warning: kernel/cpu.c:129:13: warning: 'cpuhp_is_ap_state' defined but not used [-Wunused-function] static bool cpuhp_is_ap_state(e

Re: linux-next: build warning after merge of the tip tree

2017-09-27 Thread Prarit Bhargava
On 09/26/2017 11:42 PM, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allnoconfig) > produced this warning: > > kernel/printk/printk.c:1983:12: warning: 'printk_time' defined but not used > [-Wunused-variable] > static int printk_time; >

Re: linux-next: build warning after merge of the tip tree

2017-06-22 Thread Stephen Rothwell
Hi Michael, On Fri, 23 Jun 2017 14:10:25 +1000 Michael Ellerman wrote: > > Fixed in my next today by: > > d4cfb11387ee ("powerpc: Convert VDSO update function to use new > update_vsyscall interface") > > But you must have pulled before I pushed that, so the warning will go > away tomorrow.

Re: linux-next: build warning after merge of the tip tree

2017-06-22 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > [Forgot to cc John] > > On Fri, 23 Jun 2017 13:58:34 +1000 Stephen Rothwell > wrote: >> >> Hi all, >> >> After merging the tip tree, today's linux-next build (powerpc >> ppc64_defconfig) produced this warning: >> >> kernel/time/timekeeping.c:519:2: warni

Re: linux-next: build warning after merge of the tip tree

2017-06-22 Thread Stephen Rothwell
Hi all, [Forgot to cc John] On Fri, 23 Jun 2017 13:58:34 +1000 Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > kernel/time/timekeeping.c:519:2: warning: #warning Please contact your > maintain

Re: linux-next: build warning after merge of the tip tree

2016-12-14 Thread Ingo Molnar
* Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > fs/ubifs/dir.c: In function 'ubifs_readdir': > fs/ubifs/dir.c:629:13: warning: 'fstr_real_len' may be used uninitialized in > this function [-Wmaybe-

Re: linux-next: build warning after merge of the tip tree

2016-12-14 Thread Stephen Rothwell
Hi Richard, On Wed, 14 Dec 2016 09:05:10 +0100 Richard Weinberger wrote: > > The commit comes via my UBIFS tree. But I never saw this warning, I'm testing > with both gcc-4.8 and gcc-6.1. > Let me investigate into that. > > Does today's tip change some compiler flags? Linus' tree commit a76

Re: linux-next: build warning after merge of the tip tree

2016-12-14 Thread Richard Weinberger
Stephen, Ingo, CC'ing David. On 14.12.2016 08:24, Ingo Molnar wrote: > > * Stephen Rothwell wrote: > >> Hi all, >> >> After merging the tip tree, today's linux-next build (x86_64 allmodconfig) >> produced this warning: >> >> fs/ubifs/dir.c: In function 'ubifs_readdir': >> fs/ubifs/dir.c:629:13

Re: linux-next: build warning after merge of the tip tree

2016-12-14 Thread Stephen Rothwell
Hi Ingo, On Wed, 14 Dec 2016 08:24:11 +0100 Ingo Molnar wrote: > > FYI, f4f61d2cc6d8 is not in the -tip tree, so it cannot possibly have > introduced > this warning. Yeah, I know, but the warning only seemed to happen after merging the tip tree. I would have expected it to appear much earlier

Re: linux-next: build warning after merge of the tip tree

2016-07-25 Thread Rich Felker
On Mon, Jul 25, 2016 at 05:42:09PM +0100, Mark Brown wrote: > On Mon, Jul 25, 2016 at 10:53:37AM -0400, Rich Felker wrote: > > On Mon, Jul 25, 2016 at 03:11:48PM +0200, Daniel Lezcano wrote: > > > > I don't know the goal of adding those patches in linux-next via your > > > tree, may be you misunde

Re: linux-next: build warning after merge of the tip tree

2016-07-25 Thread Mark Brown
On Mon, Jul 25, 2016 at 10:53:37AM -0400, Rich Felker wrote: > On Mon, Jul 25, 2016 at 03:11:48PM +0200, Daniel Lezcano wrote: > > I don't know the goal of adding those patches in linux-next via your > > tree, may be you misunderstood how linux-next works and you should > > remove them. But if the

Re: linux-next: build warning after merge of the tip tree

2016-07-25 Thread Rich Felker
On Mon, Jul 25, 2016 at 03:11:48PM +0200, Daniel Lezcano wrote: > On 07/25/2016 09:16 AM, Thomas Gleixner wrote: > > On Sun, 24 Jul 2016, Stephen Rothwell wrote: > >> Hi all, > >> > >> After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > >> produced this warning: > >> > >> I

Re: linux-next: build warning after merge of the tip tree

2016-07-25 Thread Rich Felker
On Mon, Jul 25, 2016 at 09:16:48AM +0200, Thomas Gleixner wrote: > On Sun, 24 Jul 2016, Stephen Rothwell wrote: > > Hi all, > > > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > > produced this warning: > > > > In file included from include/linux/clocksource.h:18:0,

Re: linux-next: build warning after merge of the tip tree

2016-07-25 Thread Daniel Lezcano
On 07/25/2016 09:16 AM, Thomas Gleixner wrote: > On Sun, 24 Jul 2016, Stephen Rothwell wrote: >> Hi all, >> >> After merging the tip tree, today's linux-next build (x86_64 allmodconfig) >> produced this warning: >> >> In file included from include/linux/clocksource.h:18:0, >> from

Re: linux-next: build warning after merge of the tip tree

2016-07-25 Thread Thomas Gleixner
On Sun, 24 Jul 2016, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > In file included from include/linux/clocksource.h:18:0, > from include/linux/clockchips.h:13, > from

Re: linux-next: build warning after merge of the tip tree

2016-04-07 Thread Stephen Rothwell
Hi Ingo, On Thu, 7 Apr 2016 10:48:33 +0200 Ingo Molnar wrote: > > Indeed - and this only triggers on HAVE_GENERIC_RCU_GUP. > > I've amended the commit. Thanks. -- Cheers, Stephen Rothwell

Re: linux-next: build warning after merge of the tip tree

2016-04-07 Thread Ingo Molnar
* Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (powerpc > ppc44x_defconfig) > produced this warning: > > mm/gup.c: In function 'get_user_pages_fast': > mm/gup.c:1510:20: warning: unused variable 'mm' [-Wunused-variable] > struct mm_struct *mm =

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread H. Peter Anvin
On 07/18/2014 01:20 PM, Andy Lutomirski wrote: >> >> The reason this is a concern is that: (x > x + n) and its variants is >> often used to mean (x > INT_MAX - n) without the type knowledge, but >> that is actually invalid standard C because signed types are not >> guaranteed to wrap. > > Right, b

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread Andy Lutomirski
On Fri, Jul 18, 2014 at 1:15 PM, H. Peter Anvin wrote: > On 07/18/2014 01:08 PM, Andy Lutomirski wrote: >> >> i isn't an index in to the syms array at all. This code is completely >> wrong. See the patch I sent in reply to Stephen's original email. >> >> But, to your earlier point, presumably th

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread H. Peter Anvin
On 07/18/2014 01:08 PM, Andy Lutomirski wrote: > > i isn't an index in to the syms array at all. This code is completely > wrong. See the patch I sent in reply to Stephen's original email. > > But, to your earlier point, presumably this could warn: > > for (int i = 0; i < 10; i++) > if (arra

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread Andy Lutomirski
On Fri, Jul 18, 2014 at 1:05 PM, H. Peter Anvin wrote: > On 07/18/2014 12:57 PM, Andy Lutomirski wrote: >> >> This particular warning is IMO in a particularly dumb category: GCC >> optimizes some code and then warns about a construct that wasn't there >> in the original code. In this case, I thin

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread H. Peter Anvin
On 07/18/2014 12:57 PM, Andy Lutomirski wrote: > > This particular warning is IMO in a particularly dumb category: GCC > optimizes some code and then warns about a construct that wasn't there > in the original code. In this case, I think it unrolled a loop and > discovered that one iteration cont

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread Andy Lutomirski
On Fri, Jul 18, 2014 at 12:16 PM, H. Peter Anvin wrote: > On 07/17/2014 10:00 PM, Stephen Rothwell wrote: >> Hi all, >> >> After merging the tip tree, today's linux-next build (x86_64 >> allmodconfig) produced these warnings: >> >> In file included from arch/x86/vdso/vdso2c.c:161:0: >> arch/x86/vd

Re: linux-next: build warning after merge of the tip tree

2014-07-18 Thread H. Peter Anvin
On 07/17/2014 10:00 PM, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 > allmodconfig) produced these warnings: > > In file included from arch/x86/vdso/vdso2c.c:161:0: > arch/x86/vdso/vdso2c.c: In function 'main': > arch/x86/vdso/vdso2c.h:118:

Re: linux-next: build warning after merge of the tip tree

2014-06-19 Thread Stephen Rothwell
Hi Peter, On Thu, 19 Jun 2014 21:30:49 -0700 "H. Peter Anvin" wrote: > > On 06/19/2014 09:24 PM, Stephen Rothwell wrote: > > > > On Mon, 16 Jun 2014 11:57:09 +1000 Stephen Rothwell > > wrote: > >> > >> After merging the tip tree, today's linux-next build (x86_64 > >> allmodconfig) produced t

Re: linux-next: build warning after merge of the tip tree

2014-06-19 Thread H. Peter Anvin
On 06/19/2014 09:24 PM, Stephen Rothwell wrote: > Hi all, > > On Mon, 16 Jun 2014 11:57:09 +1000 Stephen Rothwell > wrote: >> >> After merging the tip tree, today's linux-next build (x86_64 >> allmodconfig) produced this warning: >> >> In file included from >> arch/x86/crypto/camellia_aesni_

Re: linux-next: build warning after merge of the tip tree

2014-06-19 Thread Stephen Rothwell
Hi all, On Mon, 16 Jun 2014 11:57:09 +1000 Stephen Rothwell wrote: > > After merging the tip tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > In file included from arch/x86/crypto/camellia_aesni_avx_glue.c:23:0: > arch/x86/include/asm/xsave.h:73:12: warning: 'xs

Re: linux-next: build warning after merge of the tip tree

2014-03-31 Thread H. Peter Anvin
On 03/31/2014 05:26 PM, Stephen Rothwell wrote: > > And today from Linus' tree I get these: > > x86_64_allmodconfig: > > arch/x86/crypto/sha1_ssse3_glue.c:43:1: warning: > 'externally_visible' attribute have effect only on public objects > [-Wattributes] static asmlinkage void (*sha1_transform_a

Re: linux-next: build warning after merge of the tip tree

2014-03-31 Thread Stephen Rothwell
Hi Thomas, On Mon, 31 Mar 2014 21:57:43 +1100 Stephen Rothwell wrote: > > On Mon, 31 Mar 2014 11:45:24 +0200 (CEST) Thomas Gleixner > wrote: > > > > commit 8783dd3a37a5853689e1a8fa728827a50905b912 > > Author: Stephen Boyd > > Date: Tue Mar 4 16:40:30 2014 -0800 > > > > irqchip: Remove

Re: linux-next: build warning after merge of the tip tree

2014-03-31 Thread Stephen Rothwell
Hi Thomas, On Mon, 31 Mar 2014 11:45:24 +0200 (CEST) Thomas Gleixner wrote: > > commit 8783dd3a37a5853689e1a8fa728827a50905b912 > Author: Stephen Boyd > Date: Tue Mar 4 16:40:30 2014 -0800 > > irqchip: Remove asmlinkage from static functions > > which is in the tip tree since March 12t

Re: linux-next: build warning after merge of the tip tree

2014-03-31 Thread Thomas Gleixner
On Fri, 28 Mar 2014, Stephen Rothwell wrote: > > > I guess that there may be more places where "asmlinkage" is used with > > > "static" - I assume that they are all incorrect? > > > > > > $ git grep -l 'static.*asmlinkage' > > > arch/x86/crypto/sha1_ssse3_glue.c > > > arch/x86/crypto/sha256_ssse3_

Re: linux-next: build warning after merge of the tip tree

2014-03-27 Thread Stephen Rothwell
Hi all, On Thu, 6 Mar 2014 15:00:10 +1100 Stephen Rothwell wrote: > > On Mon, 24 Feb 2014 15:17:32 +1100 Stephen Rothwell > wrote: > > > > After merging the tip tree, today's linux-next build (arm > > multi_v7_defconfig) produced this warning: > > > > drivers/irqchip/irq-armada-370-xp.c:415:1

Re: linux-next: build warning after merge of the tip tree

2014-03-05 Thread Stephen Rothwell
On Mon, 24 Feb 2014 15:17:32 +1100 Stephen Rothwell wrote: > > Hi all, > > After merging the tip tree, today's linux-next build (arm > multi_v7_defconfig) produced this warning: > > drivers/irqchip/irq-armada-370-xp.c:415:1: warning: 'externally_visible' > attribute have effect only on public

Re: linux-next: build warning after merge of the tip tree

2014-02-24 Thread H. Peter Anvin
static asmlinkage can make sense if a pointer to the function is taken somewhere in the same translation unit. On February 24, 2014 7:48:41 AM PST, Andi Kleen wrote: >> I guess that there may be more places where "asmlinkage" is used with >> "static" - I assume that they are all incorrect? > >Li

Re: linux-next: build warning after merge of the tip tree

2014-02-24 Thread Andi Kleen
> I guess that there may be more places where "asmlinkage" is used with > "static" - I assume that they are all incorrect? Likely they are bogus yes. One issue is still the changed ABI on i386, so one has to double check before removing if they have arguments. -Andi -- To unsubscribe from this l

Re: linux-next: build warning after merge of the tip tree

2014-02-23 Thread Stephen Rothwell
Hi Andrew, On Sun, 23 Feb 2014 22:12:17 -0800 Andrew Morton wrote: > > Doh, I missed that. I don't know if it's "allowed" or not, but it's > clearly the wrong thing to do - the whole point of asmlinkage is to > export the thing to other compilation units. > > So I suppose this: > > mm/process

Re: linux-next: build warning after merge of the tip tree

2014-02-23 Thread Andrew Morton
On Mon, 24 Feb 2014 16:56:21 +1100 Stephen Rothwell wrote: > Hi all, > > On Mon, 24 Feb 2014 15:17:32 +1100 Stephen Rothwell > wrote: > > > > I guess that there may be more places where "asmlinkage" is used with > > "static" - I assume that they are all incorrect? > > > > $ git grep -l 'stat

Re: linux-next: build warning after merge of the tip tree

2014-02-23 Thread Stephen Rothwell
Hi all, On Mon, 24 Feb 2014 15:17:32 +1100 Stephen Rothwell wrote: > > I guess that there may be more places where "asmlinkage" is used with > "static" - I assume that they are all incorrect? > > $ git grep -l 'static.*asmlinkage' > arch/x86/crypto/sha1_ssse3_glue.c > arch/x86/crypto/sha256_sss

Re: linux-next: build warning after merge of the tip tree

2013-08-30 Thread Ingo Molnar
* Andi Kleen wrote: > > > I've seen this pattern of deficient changelogs a dozen > > > times in your patches this year alone ... > > > > Ping? > > I've re-sent the patch already last week. hpa was on vacation, if he doesn't pick it up I'll apply it. > Some perf patches are also pending, the

Re: linux-next: build warning after merge of the tip tree

2013-08-30 Thread Andi Kleen
> > I've seen this pattern of deficient changelogs a dozen > > times in your patches this year alone ... > > Ping? I've re-sent the patch already last week. Some perf patches are also pending, there just seems to be a long backlog. http://permalink.gmane.org/gmane.linux.kernel/1548787 http://

Re: linux-next: build warning after merge of the tip tree

2013-08-30 Thread Stephen Rothwell
Hi all, On Tue, 20 Aug 2013 08:42:09 +0200 Ingo Molnar wrote: > > * Andi Kleen wrote: > > > > > Introduced by commit 9a55fdbe941e ("x86, asmlinkage, paravirt: Add > > > > __visible/asmlinkage to xen paravirt ops"). The 2 definitions used to > > > > be > > > > identical ... maybe there should

Re: linux-next: build warning after merge of the tip tree

2013-08-19 Thread Ingo Molnar
* Andi Kleen wrote: > > > Introduced by commit 9a55fdbe941e ("x86, asmlinkage, paravirt: Add > > > __visible/asmlinkage to xen paravirt ops"). The 2 definitions used to be > > > identical ... maybe there should be only one. > > > > Andi, please send a fix for this build warning, against > > t

Re: linux-next: build warning after merge of the tip tree

2013-08-19 Thread Andi Kleen
> > Introduced by commit 9a55fdbe941e ("x86, asmlinkage, paravirt: Add > > __visible/asmlinkage to xen paravirt ops"). The 2 definitions used to be > > identical ... maybe there should be only one. > > Andi, please send a fix for this build warning, against > tip:x86/asmlinkage. I resent the pa

Re: linux-next: build warning after merge of the tip tree

2013-08-18 Thread Ingo Molnar
* Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > arch/x86/kernel/paravirt.c:66:0: warning: "DEF_NATIVE" redefined [enabled by > default] > #define DEF_NATIVE(ops, name, code) \ > ^ > In file i

Re: linux-next: build warning after merge of the tip tree

2012-10-01 Thread Josh Triplett
On Tue, Oct 02, 2012 at 12:54:23AM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (sparc64 defconfig) > produced this warning: > > include/linux/efi.h:503:13: warning: 'efi_enter_virtual_mode' defined but not > used [-Wunused-function] > include