Re: spi: OF module autoloading is still broken

2015-11-19 Thread Javier Martinez Canillas
Hello, On 11/18/2015 05:07 PM, Javier Martinez Canillas wrote: > Hello Brian and Mark, > > On 11/16/2015 06:32 PM, Javier Martinez Canillas wrote: >> On 11/16/2015 05:47 PM, Brian Norris wrote: >>> On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: On 11/16/2015 04:24

Re: spi: OF module autoloading is still broken

2015-11-19 Thread Javier Martinez Canillas
Hello, On 11/18/2015 05:07 PM, Javier Martinez Canillas wrote: > Hello Brian and Mark, > > On 11/16/2015 06:32 PM, Javier Martinez Canillas wrote: >> On 11/16/2015 05:47 PM, Brian Norris wrote: >>> On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: On 11/16/2015 04:24

Re: spi: OF module autoloading is still broken

2015-11-18 Thread Javier Martinez Canillas
Hello Brian and Mark, On 11/16/2015 06:32 PM, Javier Martinez Canillas wrote: > On 11/16/2015 05:47 PM, Brian Norris wrote: >> On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: >>> On 11/16/2015 04:24 PM, Brian Norris wrote: [snip] I don't think you have problems

Re: spi: OF module autoloading is still broken

2015-11-18 Thread Javier Martinez Canillas
Hello Brian and Mark, On 11/16/2015 06:32 PM, Javier Martinez Canillas wrote: > On 11/16/2015 05:47 PM, Brian Norris wrote: >> On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: >>> On 11/16/2015 04:24 PM, Brian Norris wrote: [snip] I don't think you have problems

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Javier Martinez Canillas
Hello Mark, On 11/17/2015 10:34 AM, Mark Brown wrote: > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > >> Now that I think about it, there is another issue and is that today spi:foo >> defines a namespace while changing to of: will make the namespace flat so >> a

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Javier Martinez Canillas
Hello Mark, On 11/17/2015 10:19 AM, Mark Brown wrote: > On Tue, Nov 17, 2015 at 10:14:27AM -0300, Javier Martinez Canillas wrote: >> On 11/16/2015 06:51 PM, Brian Norris wrote: > >>> Lest someone else wonder whether this is theoretical or not, I'll save >>> them the work in pointing at an

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Mark Brown
On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > Now that I think about it, there is another issue and is that today spi:foo > defines a namespace while changing to of: will make the namespace flat so > a platform driver that has the same vendor and model will have the

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Mark Brown
On Tue, Nov 17, 2015 at 10:14:27AM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 06:51 PM, Brian Norris wrote: > > Lest someone else wonder whether this is theoretical or not, I'll save > > them the work in pointing at an example: "st,st33zp24". See: > >

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Javier Martinez Canillas
Hello Brian, On 11/16/2015 06:51 PM, Brian Norris wrote: > On Mon, Nov 16, 2015 at 06:32:22PM -0300, Javier Martinez Canillas wrote: [snip] >> >> Let's suppose you have 3 different IP's blocks (i.e: pmics) from the same >> vendor. The IP's are quite similar but only differ in that use a

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Javier Martinez Canillas
Hello Mark, On 11/17/2015 10:19 AM, Mark Brown wrote: > On Tue, Nov 17, 2015 at 10:14:27AM -0300, Javier Martinez Canillas wrote: >> On 11/16/2015 06:51 PM, Brian Norris wrote: > >>> Lest someone else wonder whether this is theoretical or not, I'll save >>> them the work in pointing at an

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Javier Martinez Canillas
Hello Mark, On 11/17/2015 10:34 AM, Mark Brown wrote: > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > >> Now that I think about it, there is another issue and is that today spi:foo >> defines a namespace while changing to of: will make the namespace flat so >> a

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Javier Martinez Canillas
Hello Brian, On 11/16/2015 06:51 PM, Brian Norris wrote: > On Mon, Nov 16, 2015 at 06:32:22PM -0300, Javier Martinez Canillas wrote: [snip] >> >> Let's suppose you have 3 different IP's blocks (i.e: pmics) from the same >> vendor. The IP's are quite similar but only differ in that use a

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Mark Brown
On Tue, Nov 17, 2015 at 10:14:27AM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 06:51 PM, Brian Norris wrote: > > Lest someone else wonder whether this is theoretical or not, I'll save > > them the work in pointing at an example: "st,st33zp24". See: > >

Re: spi: OF module autoloading is still broken

2015-11-17 Thread Mark Brown
On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > Now that I think about it, there is another issue and is that today spi:foo > defines a namespace while changing to of: will make the namespace flat so > a platform driver that has the same vendor and model will have the

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Brian Norris
Hi Javier, On Mon, Nov 16, 2015 at 06:32:22PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 05:47 PM, Brian Norris wrote: > > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > >> Now that I think about it, there is another issue and is that today spi:foo > >>

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Brian, On 11/16/2015 05:47 PM, Brian Norris wrote: > Hi, > > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: >> On 11/16/2015 04:24 PM, Brian Norris wrote: > >> I also didn't think about wilcards... I wonder why there are trailing >> wildcards for a compatible

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Brian Norris
Hi, On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 04:24 PM, Brian Norris wrote: > I also didn't think about wilcards... I wonder why there are trailing > wildcards for a compatible string. After all a compatible string should > define a particular IP

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Brian, On 11/16/2015 04:24 PM, Brian Norris wrote: > Hi Javier, > > On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: >> On 11/13/2015 08:48 PM, Brian Norris wrote: >>> On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: On Fri, Nov 13, 2015 at

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Brian Norris
Hi Javier, On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: > On 11/13/2015 08:48 PM, Brian Norris wrote: > > On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: > >> On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: >

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Mark, On 11/16/2015 02:51 PM, Mark Brown wrote: > On Mon, Nov 16, 2015 at 02:26:49PM -0300, Javier Martinez Canillas wrote: >> On 11/16/2015 10:53 AM, Mark Brown wrote: > >>> What I don't really understand here is why we've decided to push all >>> this stuff into the subsystems, it seems

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Mark, On 11/16/2015 02:49 PM, Mark Brown wrote: > On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: >> On 11/13/2015 08:48 PM, Brian Norris wrote: > >>> (I believe I avoided this in the first place for mostly-aesthetic >>> reasons; technically this allows people to

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 02:26:49PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 10:53 AM, Mark Brown wrote: > > What I don't really understand here is why we've decided to push all > > this stuff into the subsystems, it seems like if we're managing to do > > the matching based on the

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: > On 11/13/2015 08:48 PM, Brian Norris wrote: > > (I believe I avoided this in the first place for mostly-aesthetic > > reasons; technically this allows people to put garbage in their DT, like > > "garbage,spi-nor". It's

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Mark, On 11/16/2015 10:53 AM, Mark Brown wrote: > On Fri, Nov 13, 2015 at 03:48:57PM -0800, Brian Norris wrote: > >> I suspect we'll have to fully support both spi_device_id tables (fully >> supported already; if nothing else, to keep wildcard matching) and >> of_match_tables (not fully

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Brian and Mark, Sorry for the delay, I was quite busy at the end of last week and didn't have time to look at my email closely. On 11/13/2015 08:48 PM, Brian Norris wrote: > Hi, > > On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: >> On Fri, Nov 13, 2015 at 02:51:13PM -0800,

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-16 Thread Mark Brown
On Fri, Nov 13, 2015 at 03:48:57PM -0800, Brian Norris wrote: > I suspect we'll have to fully support both spi_device_id tables (fully > supported already; if nothing else, to keep wildcard matching) and > of_match_tables (not fully supported for module loading), and in some > cases, the two will

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-16 Thread Mark Brown
On Fri, Nov 13, 2015 at 03:48:57PM -0800, Brian Norris wrote: > I suspect we'll have to fully support both spi_device_id tables (fully > supported already; if nothing else, to keep wildcard matching) and > of_match_tables (not fully supported for module loading), and in some > cases, the two will

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: > On 11/13/2015 08:48 PM, Brian Norris wrote: > > (I believe I avoided this in the first place for mostly-aesthetic > > reasons; technically this allows people to put garbage in their DT, like > > "garbage,spi-nor". It's

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Mark, On 11/16/2015 02:49 PM, Mark Brown wrote: > On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: >> On 11/13/2015 08:48 PM, Brian Norris wrote: > >>> (I believe I avoided this in the first place for mostly-aesthetic >>> reasons; technically this allows people to

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Mark, On 11/16/2015 10:53 AM, Mark Brown wrote: > On Fri, Nov 13, 2015 at 03:48:57PM -0800, Brian Norris wrote: > >> I suspect we'll have to fully support both spi_device_id tables (fully >> supported already; if nothing else, to keep wildcard matching) and >> of_match_tables (not fully

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Mark Brown
On Mon, Nov 16, 2015 at 02:26:49PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 10:53 AM, Mark Brown wrote: > > What I don't really understand here is why we've decided to push all > > this stuff into the subsystems, it seems like if we're managing to do > > the matching based on the

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Mark, On 11/16/2015 02:51 PM, Mark Brown wrote: > On Mon, Nov 16, 2015 at 02:26:49PM -0300, Javier Martinez Canillas wrote: >> On 11/16/2015 10:53 AM, Mark Brown wrote: > >>> What I don't really understand here is why we've decided to push all >>> this stuff into the subsystems, it seems

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Brian and Mark, Sorry for the delay, I was quite busy at the end of last week and didn't have time to look at my email closely. On 11/13/2015 08:48 PM, Brian Norris wrote: > Hi, > > On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: >> On Fri, Nov 13, 2015 at 02:51:13PM -0800,

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Brian, On 11/16/2015 05:47 PM, Brian Norris wrote: > Hi, > > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: >> On 11/16/2015 04:24 PM, Brian Norris wrote: > >> I also didn't think about wilcards... I wonder why there are trailing >> wildcards for a compatible

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Brian Norris
Hi Javier, On Mon, Nov 16, 2015 at 06:32:22PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 05:47 PM, Brian Norris wrote: > > On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > >> Now that I think about it, there is another issue and is that today spi:foo > >>

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Brian Norris
Hi Javier, On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: > On 11/13/2015 08:48 PM, Brian Norris wrote: > > On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: > >> On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: >

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Brian Norris
Hi, On Mon, Nov 16, 2015 at 05:00:43PM -0300, Javier Martinez Canillas wrote: > On 11/16/2015 04:24 PM, Brian Norris wrote: > I also didn't think about wilcards... I wonder why there are trailing > wildcards for a compatible string. After all a compatible string should > define a particular IP

Re: spi: OF module autoloading is still broken

2015-11-16 Thread Javier Martinez Canillas
Hello Brian, On 11/16/2015 04:24 PM, Brian Norris wrote: > Hi Javier, > > On Mon, Nov 16, 2015 at 02:19:27PM -0300, Javier Martinez Canillas wrote: >> On 11/13/2015 08:48 PM, Brian Norris wrote: >>> On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: On Fri, Nov 13, 2015 at

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Brian Norris
Hi, On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: > On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: > > > General problem: > > > > > The SPI core doesn't use the OF compatible property for generating > > uevent/modalias, and therefore can't autoload

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Mark Brown
On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: > On Fri, Nov 13, 2015 at 10:12:28PM +, Mark Brown wrote: > > On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > > > (Changing subject line, because apparently some people ignore mail if it > > > doesn't have 'SPI' in

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Brian Norris
Hi Mark, On Fri, Nov 13, 2015 at 10:12:28PM +, Mark Brown wrote: > On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > > > (Changing subject line, because apparently some people ignore mail if it > > doesn't have 'SPI' in the subject line) > > Well, if you mean me I'm getting

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Mark Brown
On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > (Changing subject line, because apparently some people ignore mail if it > doesn't have 'SPI' in the subject line) Well, if you mean me I'm getting CCed on such a large number of large threads about MTD patches that only have

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Mark Brown
On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > (Changing subject line, because apparently some people ignore mail if it > doesn't have 'SPI' in the subject line) Well, if you mean me I'm getting CCed on such a large number of large threads about MTD patches that only have

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Mark Brown
On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: > On Fri, Nov 13, 2015 at 10:12:28PM +, Mark Brown wrote: > > On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > > > (Changing subject line, because apparently some people ignore mail if it > > > doesn't have 'SPI' in

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Brian Norris
Hi Mark, On Fri, Nov 13, 2015 at 10:12:28PM +, Mark Brown wrote: > On Fri, Nov 13, 2015 at 11:40:31AM -0800, Brian Norris wrote: > > > (Changing subject line, because apparently some people ignore mail if it > > doesn't have 'SPI' in the subject line) > > Well, if you mean me I'm getting

Re: spi: OF module autoloading is still broken (was: Re: m25p80: Commit "allow arbitrary OF matching for "jedec,spi-nor"" breaks module autoloading)

2015-11-13 Thread Brian Norris
Hi, On Fri, Nov 13, 2015 at 11:14:10PM +, Mark Brown wrote: > On Fri, Nov 13, 2015 at 02:51:13PM -0800, Brian Norris wrote: > > > General problem: > > > > > The SPI core doesn't use the OF compatible property for generating > > uevent/modalias, and therefore can't autoload