Re: [RFC] Fix BUG splat during nubus_driver_register()

2018-05-03 Thread Michael Schmitz
Hi Finn, Am 03.05.18 um 12:52 schrieb Finn Thain: >> No need for a Mac test in nubus_proc_init() as it appears to work just >> fine. >> > Yes. I suggested a MACH_IS_MAC() test because zorro_proc_init() has a > similar test. The postcore_initcall() approach retains the MACH_IS_MAC() > test, so

Re: [RFC] Fix BUG splat during nubus_driver_register()

2018-05-02 Thread Finn Thain
On Thu, 3 May 2018, Michael Schmitz wrote: > Hi Finn, > > with your patch, 4.17rc2 boots again to user space. > OK. > # ls -lrt /sys/bus/nubus/devices/ > total 0 > # cat /proc/bus/nubus/devices > [no output] > > No need for a Mac test in nubus_proc_init() as it appears to work just > fine.

Re: [RFC] Fix BUG splat during nubus_driver_register()

2018-05-02 Thread Michael Schmitz
Hi Finn, with your patch, 4.17rc2 boots again to user space. # ls -lrt /sys/bus/nubus/devices/ total 0 # cat /proc/bus/nubus/devices [no output] No need for a Mac test in nubus_proc_init() as it appears to work just fine. Are we confusing any legacy user space tools that might check for

Re: [RFC] Fix BUG splat during nubus_driver_register()

2018-05-01 Thread Michael Schmitz
Hi Finn, I'll try that one - will require a new kernel though, and I can't currently reach elgar by ssh... Quite confident this is the right way to fix the issue. Regarding zorro bus drivers - bus_register is called unconditionally from a core initcall for the Zorro bus code. I suppose it's