Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver
Tejun, On Mon, Mar 19, 2018 at 7:41 AM, Tejun Heo wrote: > Hello, > > On Sat, Mar 17, 2018 at 10:24:18PM -0700, Philippe Ombredanne wrote: >> > v2: >> > - clarify license version (it should be GPL 2.0) >> > - use SPDX header >> >> For the use of SPDX ids, you have my ack: (I am not qualified for the rest) >> >> Acked-by: Philippe Ombredanne > > I don't think it's a good idea to add this acked-by when it's purely > based on a single liner license tag. I understand that you want to > encourage use of the new tags but this can be misleading and it'd be > great if you reconsider sending out acks like this. > > Thanks. You have a good point. I find it confusing myself. Please, remove this ack! -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3] ata: add Amiga Gayle PATA controller driver
On Fri, Mar 16, 2018 at 9:15 AM, Bartlomiej Zolnierkiewicz wrote: > Add Amiga Gayle PATA controller driver. It enables libata support > for the on-board IDE interfaces on some Amiga models (A600, A1200, > A4000 and A4000T) and also for IDE interfaces on the Zorro expansion > bus (M-Tech E-Matrix 530 expansion card). > > Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help > with testing the driver. > > Tested-by: John Paul Adrian Glaubitz > Cc: Michael Schmitz > Cc: Geert Uytterhoeven > Cc: Philippe Ombredanne > Cc: Andy Shevchenko > Signed-off-by: Bartlomiej Zolnierkiewicz > --- > v3: > - fix minor issues reported by Andy > > v2: > - clarify license version (it should be GPL 2.0) > - use SPDX header For the use of SPDX ids, you have my ack: (I am not qualified for the rest) Acked-by: Philippe Ombredanne -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] ata: add Amiga Gayle PATA controller driver
On Mon, Feb 12, 2018 at 2:49 PM, Bartlomiej Zolnierkiewicz
wrote:
> Add Amiga Gayle PATA controller driver. It enables libata support
> for the on-board IDE interfaces on some Amiga models (A600, A1200,
> A4000 and A4000T) and also for IDE interfaces on the Zorro expansion
> bus (M-Tech E-Matrix 530 expansion card).
>
> Thanks to John Paul Adrian Glaubitz and Michael Schmitz for help
> with testing the driver.
>
> Tested-by: John Paul Adrian Glaubitz
> Cc: Michael Schmitz
> Cc: Geert Uytterhoeven
> Signed-off-by: Bartlomiej Zolnierkiewicz
> + *
> + * This file is subject to the terms and conditions of the GNU General Public
> + * License. See the file "COPYING" in the main directory of this archive
> + * for more details.
> + */
Do you mind using the new SDPX ids? (well not so new anymore). [1]
> +
> +MODULE_AUTHOR("Bartlomiej Zolnierkiewicz");
> +MODULE_DESCRIPTION("low-level driver for Amiga Gayle PATA");
> +MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:amiga-gayle-ide");
> +MODULE_VERSION(DRV_VERSION);
>
and while doing it please make sure your MODULE_LICENSE matches
the license.
Here for instance it is not clear to me if this a GPL-2.0 or a GPL-2.0+
Thanks!
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst
--
Cordially
Philippe Ombredanne
+1 650 799 0949 | pombreda...@nexb.com
DejaCode - What's in your code?! - http://www.dejacode.com
AboutCode - Open source for open source - https://www.aboutcode.org
nexB Inc. - http://www.nexb.com
CONFIDENTIALITY NOTICE: This e-mail (including attachments) may
contain information that is proprietary or confidential. If you are
not the intended recipient or a person responsible for its delivery to
the intended recipient, do not copy or distribute it. Please
permanently delete the e-mail and any attachments, and notify us
immediately at (650) 799 0949.
--
To unsubscribe from this list: send the line "unsubscribe linux-m68k" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 14/14] nubus: Add support for the driver model
Finn, On Sun, Dec 10, 2017 at 11:03 AM, Finn Thain wrote: > On Thu, 7 Dec 2017, Philippe Ombredanne wrote: > >> > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c >> > new file mode 100644 >> > index ..b5045e639b4d >> > --- /dev/null >> > +++ b/drivers/nubus/bus.c >> > @@ -0,0 +1,119 @@ >> > +/* >> > + * Bus implementation for the NuBus subsystem. >> > + * >> > + * Copyright (C) 2017 Finn Thain >> > + * >> > + * SPDX-License-Identifier: GPL-2.0 >> > + */ >> >> I think the SPDX id should be on the first line using C++-style // comments. > > Sure, why not. > > Since Linus has explicitly allowed conversion of the entire block comment > to C++ style, I think I may prefer that as being less ugly than the > mixture of styles (though fwiw this will always read like top posting to > me). > >> See tglx's doc patches > > I didn't find any mention of SPDX under Documentation... > >> and Linus posts explaining why he wants it this way! >> > > I suspect that you are referring to his posts in this thread (?) > https://lkml.org/lkml/2017/11/2/728 Actually this is patch series: https://lkml.org/lkml/2017/12/4/934 And possibly some minor fixes pending, based on Heiko eagle eye review and some of my nits. -- Cordially Philippe Ombredanne +1 650 799 0949 | pombreda...@nexb.com DejaCode - What's in your code?! - http://www.dejacode.com AboutCode - Open source for open source - https://www.aboutcode.org nexB Inc. - http://www.nexb.com -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 14/14] nubus: Add support for the driver model
Finn, On Tue, Dec 5, 2017 at 7:20 AM, Finn Thain wrote: > This patch brings basic support for the Linux Driver Model to the > NuBus subsystem. > > For flexibility, the matching of boards with drivers is left up to the > drivers. This is also the approach taken by NetBSD. A board may have > many functions, and drivers may have to consider many functional > resources and board resources in order to match a device. > > This implementation does not bind drivers to resources (nor does it bind > many drivers to the same board). Apple's NuBus declaration ROM design > is flexible enough to allow that, but I don't see a need to support it > as we don't use the "slot zero" resources (in the main logic board ROM). > > Eliminate the global nubus_boards linked list by rewriting the procfs > board iterator around bus_for_each_dev(). Hence the nubus device refcount > can be used to determine the lifespan of board objects. > > Cc: Greg Kroah-Hartman > Tested-by: Stan Johnson > Signed-off-by: Finn Thain > > --- > The conversion of Mac network drivers from the Space.c convention to > the Driver Model takes place in a separate patch series, archived at > https://lkml.org/lkml/2017/11/11/25 > That series motivates parts of this design, such as the definition of > 'for_each_board_func_rsrc'. [] > diff --git a/drivers/nubus/bus.c b/drivers/nubus/bus.c > new file mode 100644 > index ..b5045e639b4d > --- /dev/null > +++ b/drivers/nubus/bus.c > @@ -0,0 +1,119 @@ > +/* > + * Bus implementation for the NuBus subsystem. > + * > + * Copyright (C) 2017 Finn Thain > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ I think the SPDX id should be on the first line using C++-style // comments. See tglx's doc patches and Linus posts explaining why he wants it this way! -- Cordially Philippe Ombredanne -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
