Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-06 Thread Michael Schmitz
Hi Geert, thanks. will add the necessary DMA mask fixup to the ESP driver now. Cheers, Michael Am 06.03.2018 um 20:56 schrieb Geert Uytterhoeven: > Hi Michael, > > On Tue, Mar 6, 2018 at 2:06 AM, Michael Schmitz wrote: >> thanks for explaining - I had forgotten that the SCSI adapter

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-05 Thread Geert Uytterhoeven
Hi Michael, On Tue, Mar 6, 2018 at 2:06 AM, Michael Schmitz wrote: > thanks for explaining - I had forgotten that the SCSI adapter in elgar > is probably on the CPU accelerator card. > > 00: Phase 5 Digital Products CyberSCSI/Blizzard 1220 > Type: Zorro II > Address: 00e9 (000

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-05 Thread Michael Schmitz
Hi Geert, thanks for explaining - I had forgotten that the SCSI adapter in elgar is probably on the CPU accelerator card. 00: Phase 5 Digital Products CyberSCSI/Blizzard 1220 Type: Zorro II Address: 00e9 (0001 bytes) Serial number: Slot address: 00

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-05 Thread Geert Uytterhoeven
Hi Michael, On Sun, Mar 4, 2018 at 1:21 AM, Michael Schmitz wrote: > that's odd - the DMA setup code in the old ESP drivers does program the > full 32 bit addresses on DMA set-up. No masking off to 24 bit. > > All boards except for the Fastlane are ZorroII. Writes to the DMA > registers are done

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-03 Thread Michael Schmitz
Hi Geert, that's odd - the DMA setup code in the old ESP drivers does program the full 32 bit addresses on DMA set-up. No masking off to 24 bit. All boards except for the Fastlane are ZorroII. Writes to the DMA registers are done byte-wise there (only on the Fastlane, the target address is writte

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-03 Thread Geert Uytterhoeven
On Sat, Mar 3, 2018 at 12:08 AM, Christoph Hellwig wrote: > Assuming all zorro devices can deal fine with a 32-bit dma mask: No they don't. Zorro II has a 24-bit bus, Zorro III has a 32-bit bus. So it should be something like: switch (z->rom.er_Type & ERT_TYPEMASK) { case ERT_ZORROIII:

Re: [PATCH v2] m68k/amiga - zorro.c: set up z->dev.dma_mask for the DMA API

2018-03-02 Thread Christoph Hellwig
Assuming all zorro devices can deal fine with a 32-bit dma mask: Acked-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-m68k" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html