Re: [PATCH] pwc: add support for webcam snapshot button

2009-01-08 Thread Mauro Carvalho Chehab
On Thu, 8 Jan 2009 12:31:48 +0700 Nam Phạm Thành phamthanhnam@gmail.com wrote: OK, resent. Hope it's OK now. Unfortunately, it is not 100% ok. See the comments bellow. You shouldn't add any comment before the patch (like the above). Otherwise, it will be committed by the scripts also, or

Re: Fw: [PATCH] v4l/dvb: remove err macro from few usb devices

2009-01-08 Thread Mike Isely
Why is this change needed? (Please point me at a discussion thread, if you'd like...) -Mike On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: Alexey, You should get the driver maintainer's ack or at least let them know that you're touching on their drivers. Mike, Thierry an Dean,

Re: Fw: [PATCH] v4l/dvb: remove err macro from few usb devices

2009-01-08 Thread Thierry Merle
Mike Isely wrote: Why is this change needed? (Please point me at a discussion thread, if you'd like...) -Mike I remember this list of patches: https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3708324 and https://kerneltrap.org/mailarchive/linux-usb/2008/10/17/3709124 I think this

USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mauro Carvalho Chehab
Hi Mike, There were an upstream change usb_lock_device_for_reset() that touched on pvrusb2 driver. I didn't backport it yet, since I'm not sure if the change is ok. Could you please check? Thanks, Mauro. commit 011b15df465745474e3ec85482633685933ed5a7 Author: Alan Stern

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: Hi Mike, There were an upstream change usb_lock_device_for_reset() that touched on pvrusb2 driver. I didn't backport it yet, since I'm not sure if the change is ok. Could you please check? Thanks, Mauro. Yes, the pvrusb2 part of this

Re: Any rules in making ioctl or cids?

2009-01-08 Thread DongSoo Kim
Thank you Mauro. I finally got it what to do. I'll figure it out how to make it easier to control strobe lights through CIDs. Try to avoid creating newer ioctls is the same I think. Cheers, Nate On Fri, Jan 9, 2009 at 1:18 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Fri, 9 Jan

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mauro Carvalho Chehab
On Thu, 8 Jan 2009 22:28:18 -0600 (CST) Mike Isely is...@isely.net wrote: On Thu, 8 Jan 2009, Mike Isely wrote: On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: Hi Mike, There were an upstream change usb_lock_device_for_reset() that touched on pvrusb2 driver. I didn't

Re: USB: change interface to usb_lock_device_for_reset()

2009-01-08 Thread Mike Isely
On Fri, 9 Jan 2009, Mauro Carvalho Chehab wrote: On Thu, 8 Jan 2009 22:28:18 -0600 (CST) Mike Isely is...@isely.net wrote: On Thu, 8 Jan 2009, Mike Isely wrote: On Thu, 8 Jan 2009, Mauro Carvalho Chehab wrote: Hi Mike, There were an upstream change

Re: [v4l-dvb-maintainer] zr36067 no longer loadsautomatically (regression)

2009-01-08 Thread Trent Piepho
On Thu, 8 Jan 2009, Jean Delvare wrote: +#if (defined(CONFIG_USB_ZR364XX_MODULE) defined(MODULE)) Huh? I guess you really mean: CONFIG_VIDEO_ZORAN_MODULE? I don't get the point of checking for both CONFIG_VIDEO_ZORAN_MODULE and MODULE, checking for just one of them should be enough, right?