On Sun, 21 Mar 2010 22:31:06 +0100 (CET) Julia Lawall ju...@diku.dk wrote:
From: Julia Lawall ju...@diku.dk
If ov is NULL, it will not be possible to take the lock in the first place,
so move the test up earlier.
...
--- a/drivers/media/video/ov511.c
+++ b/drivers/media/video/ov511.c
From: Julia Lawall ju...@diku.dk
It seems impossible for ov to be NULL at this point.
The semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)
// smpl
@r exists@
expression E, E1;
identifier f;
statement S1,S3;
iterator iter;
@@
if ((E == NULL ...) || ...)
{
...
I think we can pretty safely assume that we never get here with ov==NULL.
Oh well, I'll leave the test there for others to ponder.
OK. I didn't read far enough in this email and sent another patch, in
case it's useful.
julia
--
To unsubscribe from this list: send the line unsubscribe
From: Sakari Ailus [sakari.ai...@maxwell.research.nokia.com]
Sent: Monday, March 22, 2010 11:50 PM
To: Viral Mehta
Cc: Aguirre, Sergio; linux-media@vger.kernel.org
Subject: Re: omap2 camera
Viral Mehta wrote:
Hi Sakari,
Hi Viral,
Ok, here's take two of the PULL request issued yesterday. It's
basically the same as yesterday, but except instead of moving the
unused code to separate files where it might actually be useful to
someone else in the future, I delete it entirely because Mauro's
scripts mangle the patches when
From: Aguirre, Sergio [saagui...@ti.com]
Sent: Tuesday, March 23, 2010 11:54 AM
To: Sakari Ailus; Viral Mehta
Cc: linux-media@vger.kernel.org
Subject: RE: omap2 camera
From: Sakari Ailus
At Mon, 22 Mar 2010 18:39:09 +0300,
Dan Carpenter wrote:
card-driver is 15 characters and a NULL, the original code could
cause a buffer overflow.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
In version 2, I used a better name that Takashi Iwai suggested.
Acked-by: Takashi Iwai
On Tuesday 23 March 2010 06:50:17 Sakari Ailus wrote:
Viral Mehta wrote:
Hi Sakari,
Hi Viral,
From: Sakari Ailus [sakari.ai...@maxwell.research.nokia.com]
Sent: Monday, March 22, 2010 10:51 PM
To: Aguirre, Sergio
Cc: Viral Mehta;
On Thu, Mar 18, 2010 at 11:28:28AM +0100, Guennadi Liakhovetski wrote:
diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig
index 64682bf..be6d016 100644
--- a/drivers/media/video/Kconfig
+++ b/drivers/media/video/Kconfig
@@ -511,6 +511,13 @@ config
Marco Lohse wrote:
Devin Heitmueller wrote:
[..]
Hi Marco,
Ok, great. Like I said, I will see if I can reproduce it here, as
that will help narrow down whether it's really an issue with the ngene
bridge, or whether it's got something to do with that particular
bridge/demod/tuner
Hi,
On 03/22/2010 11:55 AM, Hans Verkuil wrote:
On Monday 22 March 2010 10:29:09 Hans de Goede wrote:
Hi,
On 03/22/2010 01:17 AM, Hans Verkuil wrote:
On Sunday 21 March 2010 23:45:04 Hans Verkuil wrote:
On Saturday 20 March 2010 09:58:49 Hans Verkuil wrote:
These drivers have no hardware
On Mon, Mar 22, 2010 at 10:10:30PM +0200, Olimpiu Pascariu wrote:
From 32591165a537a03f472c68289798044d6eeea2e0 Mon Sep 17 00:00:00 2001
From: Olimpiu Pascariu olimpiu.pasca...@gmail.com
Date: Mon, 22 Mar 2010 22:07:20 +0200
Subject: [PATCH 5/5] Staging: cx25821: fix coding style issues in
On Tue, Mar 23, 2010 at 02:03:00PM +0300, Dan Carpenter wrote:
On Mon, Mar 22, 2010 at 10:10:30PM +0200, Olimpiu Pascariu wrote:
From 32591165a537a03f472c68289798044d6eeea2e0 Mon Sep 17 00:00:00 2001
From: Olimpiu Pascariu olimpiu.pasca...@gmail.com
Date: Mon, 22 Mar 2010 22:07:20 +0200
On Friday 19 March 2010 10:35:50 hvaib...@ti.com wrote:
From: Vaibhav Hiremath hvaib...@ti.com
Looking towards the number of files which are cluttering in media/video/
directory, it is required to introduce seperate working
directory for TI devices.
You should then move the omap24xxcam
card-driver is 15 characters and a NULL. The original code
goes past the end of the array.
Signed-off-by: Dan Carpenter erro...@gmail.com
---
V2: Takashi Iwai asked me to change the space to a hyphen since this is
used as an identifier in alsa-lib.
diff --git
Devin Heitmueller wrote:
Ok, here's take two of the PULL request issued yesterday. It's
basically the same as yesterday, but except instead of moving the
unused code to separate files where it might actually be useful to
someone else in the future, I delete it entirely because Mauro's
Devin Heitmueller wrote:
Ok, here's take two of the PULL request issued yesterday. It's
basically the same as yesterday, but except instead of moving the
unused code to separate files where it might actually be useful to
someone else in the future, I delete it entirely because Mauro's
As discussed many times, e.g. in http://lkml.org/lkml/2007/7/26/401
mixing IRQF_DISABLED with IRQF_SHARED may cause unpredictable and
unexpected results.
Add a module parameter to allow fine tuning the request_irq
flags based on local system requirements. Some may need to turn
off IRQF_DISABLED
On Tue, Mar 23, 2010 at 9:45 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Devin Heitmueller wrote:
Ok, here's take two of the PULL request issued yesterday. It's
basically the same as yesterday, but except instead of moving the
unused code to separate files where it might actually be
Dmitri Belimov wrote:
Hi
Add support SPI bus to v4l2. Useful for control some device with SPI bus like
hardware MPEG2 encoders and etc.
Hi Dmitri,
Aplied, thanks.
Next time, please don't use [RESEND] for a new version of the patch. Instead,
you may
name it as [PATCH v2]. The word resend
Current version of sh_mobile_ceu_camera.c interprets the V4L2 API specification
of the VIDIOC_S_CROP ioctl as change input (for capture devices) area,
preserve scaling factors, therefore change output window, whereas a more
intuitive interpretation of the API is change input area, preserve output
Thanks, Sergio!
Thanks for your response. Thanks Sergio.
I've only aware of the tcm825x sensor driver that works with the OMAP
2420 camera controller (omap24xxcam) driver.
Does this also mean that omap24xxcam.ko will *only* work with OMAP2420?
Or the same driver can be used for OMAP2430
-Original Message-
From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
Sent: Tuesday, March 23, 2010 5:11 PM
To: davinci-linux-open-sou...@linux.davincidsp.com
Cc: Hiremath, Vaibhav; linux-media@vger.kernel.org
Subject: Re: [Resubmit: PATCH-V2] Introducing ti-media
Devin Heitmueller wrote:
On Tue, Mar 23, 2010 at 9:45 AM, Mauro Carvalho Chehab
And as I explained to you, there were *extraordinarily* good reasons -
because the code will be enabled in the future, the code definitely
didn't belong in ngene-core.c, and because I didn't want the code to
get
soc-camera no longer requires .set_crop() implementations to update their
argument. Update the commentary.
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
drivers/media/video/soc_camera.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
This patch and the one, actually implementing this change, do not depend
on each other, but are logically related, so, this one can be considered
a follow-up.
Documentation/video4linux/sh_mobile_ceu_camera.txt | 80
Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de
---
drivers/media/video/videobuf-dma-contig.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/video/videobuf-dma-contig.c
b/drivers/media/video/videobuf-dma-contig.c
index 22c0109..8e45a49
On Tue, Mar 23, 2010 at 10:48 AM, Mauro Carvalho Chehab
mche...@redhat.com wrote:
Devin Heitmueller wrote:
On Tue, Mar 23, 2010 at 9:45 AM, Mauro Carvalho Chehab
And as I explained to you, there were *extraordinarily* good reasons -
because the code will be enabled in the future, the code
That said, if getting even trivial changes like moving a few functions
around are going to be met with such resistance and come at an
enormous cost, it's *very* tempting to just host it locally and not
submit it upstream at all.
Mauro,
It makes no sense to have Kernel Labs work out of tree.
Hello,
I have recently swapped my TeVii S470 card for a new one, the old one
was broken. I now have a revision 1.1 card and this card no longer
works. It gets recognized and the modules are loaded, but the firmware
never loads. Maybe as a result of this I get errors and timeouts after
mythtv
On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote:
At Mon, 22 Mar 2010 08:43:47 -0700,
Joe Perches wrote:
On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote:
card-driver is 15 characters and a NULL, the original code could
cause a buffer overflow.
In version 2, I
Steven Toth wrote:
That said, if getting even trivial changes like moving a few functions
around are going to be met with such resistance and come at an
enormous cost, it's *very* tempting to just host it locally and not
submit it upstream at all.
Mauro,
It makes no sense to have Kernel
Laurent,
I'm not too sure to like the ti-media name. It will soon get quite
crowded,
and name collisions might occur (look at the linux-omap-camera tree and
the
ISP driver in there for instance). Isn't there an internal name to refer
to
both the DM6446 and AM3517 that could be used ?
On Mon, 22 Mar 2010 13:54:16 -0400
Devin Heitmueller dheitmuel...@kernellabs.com wrote:
Hi Devin,
In the meantime, you can add card=53 as a modprobe option to em28xx, and it
should start working for you.
thanks that worked.
I was abled to tune to one DVB-T channel, back in the days
using
This message is generated daily by a cron job that builds v4l-dvb for
the kernels and architectures in the list below.
Results of the daily build of v4l-dvb:
date:Tue Mar 23 19:00:28 CET 2010
path:http://www.linuxtv.org/hg/v4l-dvb
changeset: 14502:a79dd2ae4d0e
git master:
Ricardo Maraschini wrote:
--- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300
+++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300
@@ -1401,7 +1401,8 @@
case CX88_BOARD_SAMSUNG_SMT_7020:
dev-ts_gen_cntrl = 0x08;
-
Hi Randy,
On Tue, Mar 23, 2010 at 4:45 PM, Randy Dunlap randy.dun...@oracle.com wrote:
Did you test this patch (by building this driver)?
I think not.
I tried to compile with the patch, but in a wrong way. Sorry.
I'm going to adjust the patch and send again.
Also, the Signed-off-by: line
On Tue, Mar 23, 2010 at 5:48 PM, Devin Heitmueller
dheitmuel...@kernellabs.com wrote:
How do you think this actually addresses the warning in question? You
still have the declaration of the variable in the middle of the switch
statement.
My mistake, sorry. I'm working on it.
Thanks for your
Mauro Carvalho Chehab wrote:
Steven Toth wrote:
That said, if getting even trivial changes like moving a few functions
around are going to be met with such resistance and come at an
enormous cost, it's *very* tempting to just host it locally and not
submit it upstream at all.
Mauro,
It
39 matches
Mail list logo
