Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Sachin Kamat
Hi Arun, On 18 June 2013 11:25, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Sachin, On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 18 June 2013 10:21, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Kamil, Thank you for the review. #define

Re: [REVIEWv2 PATCH 02/12] soc_camera: replace vdev-parent by vdev-v4l2_dev.

2013-06-18 Thread Hans Verkuil
Guennadi, Can you review/ack this? This patch series really should be merged for 3.11 to prevent problems with the debug ioctls being unable to discover and access subdevices in the v4l2-core code. I've tested this on my renesas board. If you prefer, you can also take care of this patch

Re: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Arun Kumar K
Hi Sachin, On Tue, Jun 18, 2013 at 11:42 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Arun, On 18 June 2013 11:25, Arun Kumar K arunkk.sams...@gmail.com wrote: Hi Sachin, On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat sachin.ka...@linaro.org wrote: On 18 June 2013 10:21, Arun

Re: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Daniel Vetter
On Mon, Jun 17, 2013 at 04:42:37PM +0100, Russell King - ARM Linux wrote: On Tue, Jun 18, 2013 at 12:03:31AM +0900, Inki Dae wrote: 2013/6/17 Russell King - ARM Linux li...@arm.linux.org.uk Exactly right. But that is not definitely my point. Could you please see the below simple example?:

Re: [REVIEWv2 PATCH 02/12] soc_camera: replace vdev-parent by vdev-v4l2_dev.

2013-06-18 Thread Guennadi Liakhovetski
Hi Hans Thanks for the patch. On Wed, 12 Jun 2013, Hans Verkuil wrote: From: Hans Verkuil hans.verk...@cisco.com The parent field will eventually disappear to be replaced by v4l2_dev. soc_camera does provide a v4l2_device struct but did not point to it in struct video_device. This is now

RE: [PATCH 3/6] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Kamil Debski
Hi Arun, Sachin, -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Tuesday, June 18, 2013 7:27 AM To: Arun Kumar K Cc: Kamil Debski; Arun Kumar K; LMML; jtp.p...@samsung.com; Sylwester Nawrocki; avnd.ki...@samsung.com Subject: Re: [PATCH 3/6] [media]

Re: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 02:27:40PM +0900, Inki Dae wrote: So I'd like to ask for other DRM maintainers. How do you think about it? it seems like that Intel DRM (maintained by Daniel), OMAP DRM (maintained by Rob) and GEM CMA helper also have same issue Russell pointed out. I think not only the

RE: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Inki Dae
-Original Message- From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent: Tuesday, June 18, 2013 5:43 PM To: Inki Dae Cc: 'Maarten Lankhorst'; 'linux-fbdev'; 'Kyungmin Park'; 'DRI mailing list'; 'Rob Clark'; 'myungjoo.ham'; 'YoungJun Cho'; 'Daniel Vetter';

RE: [PATCH v2 32/38] [media] exynos4-is: Remove check for SOC_EXYNOS4412

2013-06-18 Thread Kukjin Kim
Tomasz Figa wrote: Since SOC_EXYNOS4412 Kconfig symbol has been removed, it is enough to check for SOC_EXYNOS4212 for both SoCs from Exynos4x12 series. Cc: linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: Sylwester Nawrocki s.nawro...@samsung.com

Re: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 06:04:44PM +0900, Inki Dae wrote: -Original Message- From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] Sent: Tuesday, June 18, 2013 5:43 PM To: Inki Dae Cc: 'Maarten Lankhorst'; 'linux-fbdev'; 'Kyungmin Park'; 'DRI mailing list'; 'Rob

Re: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Lucas Stach
Am Dienstag, den 18.06.2013, 18:04 +0900 schrieb Inki Dae: [...] a display device driver. It shouldn't be used within a single driver as a means of passing buffers between userspace and kernel space. What I try to do is not really such ugly thing. What I try to do is to notify that,

Re: [PATCH 8/8] [media] coda: add CODA7541 decoding support

2013-06-18 Thread Philipp Zabel
Am Montag, den 17.06.2013, 16:59 +0200 schrieb Philipp Zabel: This patch enables decoding of h.264 and mpeg4 streams on CODA7541. Queued output buffers are immediately copied into the bitstream ringbuffer. A device_run can be scheduled whenever there is either enough compressed bitstream data,

Re: [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()

2013-06-18 Thread Philipp Zabel
Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function coda_stop_streaming() in the error handling case. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn ---

Re: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Russell King - ARM Linux
On Tue, Jun 18, 2013 at 09:00:16AM +0200, Daniel Vetter wrote: On Mon, Jun 17, 2013 at 04:42:37PM +0100, Russell King - ARM Linux wrote: What we need is something along the lines of: (a) dma_buf_map_attachment() _not_ to map the scatterlist for DMA. or (b) drm_gem_prime_import() not to

Re: [PATCH -next] [media] coda: fix missing unlock on error in coda_stop_streaming()

2013-06-18 Thread Wei Yongjun
On 06/18/2013 06:03 PM, Philipp Zabel wrote: Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun: From: Wei Yongjun yongjun_...@trendmicro.com.cn Add the missing unlock before return from function coda_stop_streaming() in the error handling case. Signed-off-by: Wei Yongjun

[PATCH v2 1/8] [media] s5p-mfc: Update v6 encoder buffer sizes

2013-06-18 Thread Arun Kumar K
The patch updates few encoder buffer sizes for MFC v6.5 as per the udpdated user manual. The same buffer sizes holds good for v7 firmware also. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h |4

[PATCH v2 2/8] [media] s5p-mfc: Rename IS_MFCV6 macro

2013-06-18 Thread Arun Kumar K
The MFC v6 specific code holds good for MFC v7 also as the v7 version is a superset of v6 and the HW interface remains more or less similar. This patch renames the macro IS_MFCV6() to IS_MFCV6_PLUS() so that it can be used for v7 also. Signed-off-by: Arun Kumar K arun...@samsung.com ---

[PATCH v2 0/8] Add support for MFC v7 firmware

2013-06-18 Thread Arun Kumar K
This patch series adds MFC v7 firmware support to the Exynos MFC driver. MFC v7 is present in 5420 SoC which has support for VP8 encoding and many other features. Changes from v1: - Addressed review comments from Hans and Sylwester

[PATCH v2 3/8] [media] s5p-mfc: Add register definition file for MFC v7

2013-06-18 Thread Arun Kumar K
The patch adds the register definition file for new firmware version v7 for MFC. New firmware supports VP8 encoding along with many other features. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v7.h | 58 ++ 1 file changed,

[PATCH v2 5/8] [media] s5p-mfc: Update driver for v7 firmware

2013-06-18 Thread Arun Kumar K
Firmware version v7 is mostly similar to v6 in terms of hardware specific controls and commands. So the hardware specific opr_v6 and cmd_v6 are re-used for v7 also. This patch updates the v6 files to handle v7 version also. Signed-off-by: Arun Kumar K arun...@samsung.com ---

[PATCH v2 4/8] [media] s5p-mfc: Core support for MFC v7

2013-06-18 Thread Arun Kumar K
Adds variant data and core support for the MFC v7 firmware Signed-off-by: Arun Kumar K arun...@samsung.com --- .../devicetree/bindings/media/s5p-mfc.txt |1 + drivers/media/platform/s5p-mfc/s5p_mfc.c | 32

[PATCH v2 6/8] [media] V4L: Add support for integer menu controls with standard menu items

2013-06-18 Thread Arun Kumar K
From: Sylwester Nawrocki s.nawro...@samsung.com The patch modifies the helper function v4l2_ctrl_new_std_menu to accept integer menu controls with standard menu items. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com ---

[PATCH v2 8/8] [media] s5p-mfc: Add support for VP8 encoder

2013-06-18 Thread Arun Kumar K
MFC v7 supports VP8 encoding and this patch adds support for it in the driver. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v6.c |3 + drivers/media/platform/s5p-mfc/s5p_mfc_common.h | 19 - drivers/media/platform/s5p-mfc/s5p_mfc_enc.c

[PATCH v2 7/8] [media] V4L: Add VP8 encoder controls

2013-06-18 Thread Arun Kumar K
This patch adds new V4L controls for VP8 encoding. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml | 151 ++ drivers/media/v4l2-core/v4l2-ctrls.c | 36 ++

[PATCH v2 1/6] libdvbv5: Remove buggy parsing of extra DTV_foo parameters

2013-06-18 Thread Guy Martin
The parsing of those extra parameters is buggy and completely useless since they are parsed individually later on in the code. Signed-off-by: Guy Martin gms...@tuxicoman.be --- lib/libdvbv5/dvb-file.c | 25 - 1 file changed, 25 deletions(-) diff --git

[PATCH 3/6] libdvbv5: Export dvb_fe_is_satellite()

2013-06-18 Thread Guy Martin
This patch makes the function dvb_fe_is_satellite() availble from libdvbv5. This function is simple but yet very handful to have around. Signed-off-by: Guy Martin gms...@tuxicoman.be --- lib/include/dvb-fe.h | 1 + lib/libdvbv5/dvb-fe.c | 14 +++--- 2 files changed, 8 insertions(+), 7

[PATCH 4/6] libdvbv5: Fix satellite handling and apply polarization parameter to the frontend

2013-06-18 Thread Guy Martin
Apply polarization parameters even if a satellite number is not provided. This allow proper setup of the tone and voltage. Signed-off-by: Guy Martin gms...@tuxicoman.be --- lib/include/dvb-fe.h | 1 - lib/libdvbv5/dvb-sat.c| 57 ---

[PATCH 6/6] dvbv5-zap: Parse the LNB from the channel file

2013-06-18 Thread Guy Martin
Parsing the LNB needs to be done for proper tuning. Signed-off-by: Guy Martin gms...@tuxicoman.be --- utils/dvb/dvbv5-zap.c | 9 + 1 file changed, 9 insertions(+) diff --git a/utils/dvb/dvbv5-zap.c b/utils/dvb/dvbv5-zap.c index c84cf70..d6c1152 100644 --- a/utils/dvb/dvbv5-zap.c +++

[PATCH 2/6] libdvbv5: Add parsing of POLARIZATION

2013-06-18 Thread Guy Martin
This patch add parsing support for the POLARIZATION parameter for the DVBv5 file format. Signed-off-by: Guy Martin gms...@tuxicoman.be --- lib/include/dvb-file.h | 1 - lib/libdvbv5/dvb-file.c | 65 ++--- 2 files changed, 29 insertions(+), 37

[PATCH 5/6] libdvbv5: Use a temporary copy of the dvb parameters when tuning

2013-06-18 Thread Guy Martin
This patch copies the parms provided into a temporary buffer. This buffer will then be used for any modification that needs to be performed. It makes the function dvb_fe_set_parms() thread-safe. Also, since the DTV_FREQUENCY is not modified, it fixes a bug where dvbv5-scan retrieves the

[PATCH v2 0/6] v4l-utils: v4l-utils: Fix satellite support in dvbv5-{scan,zap} tools

2013-06-18 Thread Guy Martin
Hi all, This set of patch fix sat support for dvbv5 libs and utils. In this set, a different approach is used. The polarization parameter is stored in the DTV_POLARIZATION property. Guy Guy Martin (6): libdvbv5: Remove buggy parsing of extra DTV_foo parameters libdvbv5: Add parsing of

Re: double-buffering with the omap3 parallel interface

2013-06-18 Thread Laurent Pinchart
Hi Michael, On Monday 17 June 2013 02:44:50 Sakari Ailus wrote: On Wed, Jun 12, 2013 at 06:16:26PM +0200, Michael Jones wrote: Hi Laurent co., I'd like to look at what the maximum possible frame rates are for a sensor connected to the OMAP3 ISP CCDC via the parallel interface, writing

Re: [RFC] Add query/get/set matrix ioctls

2013-06-18 Thread Laurent Pinchart
Hello, I'll jump in, sorry for the late review. On Wednesday 12 June 2013 15:26:27 Sakari Ailus wrote: On Wed, Jun 12, 2013 at 10:35:07AM +0200, Hans Verkuil wrote: On Tue 11 June 2013 23:33:42 Sylwester Nawrocki wrote: On 06/03/2013 02:14 PM, Hans Verkuil wrote: Hi all, When

Re: [RFC] Add query/get/set matrix ioctls

2013-06-18 Thread Laurent Pinchart
Hi Hans, On Wednesday 12 June 2013 14:57:21 Hans Verkuil wrote: On Wed 12 June 2013 14:26:27 Sakari Ailus wrote: On Wed, Jun 12, 2013 at 10:35:07AM +0200, Hans Verkuil wrote: On Tue 11 June 2013 23:33:42 Sylwester Nawrocki wrote: On 06/03/2013 02:14 PM, Hans Verkuil wrote: Hi all,

Re: [RFC] Add query/get/set matrix ioctls

2013-06-18 Thread Laurent Pinchart
Hi Hans, On Monday 17 June 2013 13:57:04 Hans Verkuil wrote: On Mon 17 June 2013 00:09:59 Sakari Ailus wrote: On Wed, Jun 12, 2013 at 02:57:21PM +0200, Hans Verkuil wrote: On Wed 12 June 2013 14:26:27 Sakari Ailus wrote: On Wed, Jun 12, 2013 at 10:35:07AM +0200, Hans Verkuil wrote:

cron job: media_tree daily build: WARNINGS

2013-06-18 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Jun 18 19:00:19 CEST 2013 git branch: test git hash: e049ca5e854263c821a15c0e25fe2ae202c365e1 gcc

Re: mt9p031 shows purple coloured capture

2013-06-18 Thread Laurent Pinchart
Hi Florian, On Tuesday 11 June 2013 10:01:31 Florian Neuhaus wrote: Hi Andrei, Your post helped me a lot! My environment: beagleboard-xm mt9p031 @96Mhz (adapted power-supply) linux-omap 3.7.10 omap3isp-live I have two similiar issues with the mt9p031, that has probably the same

Re: [PATCH v2 1/1] v4l: Document timestamp behaviour to correspond to reality

2013-06-18 Thread Laurent Pinchart
Hi Hans, On Monday 10 June 2013 13:29:53 Hans Verkuil wrote: On Mon June 10 2013 00:35:44 Sakari Ailus wrote: [snip] Note that the 'timestamp' field documentation still says that it is the timestamp of the first data byte for capture as well, that's also wrong. I know we've

RE: HD Capture Card (HDMI and Component) output raw pixels

2013-06-18 Thread Steve Cookson
Hi Jim, The Balckmagic Card does not seem to have any hardware compression, for me that's a drawback, but if that's what you want it may be the right thing. I want to avoid RAID 0 disks if I can. It appears to be supported by Linux in the GStreamer bad pluggins, it's called decklinksrc. There

Re: [GIT PULL FOR 3.11] Media entity link handling fixes

2013-06-18 Thread Sylwester Nawrocki
On 06/17/2013 10:27 PM, Laurent Pinchart wrote: Hi Sylwester, A bit late, but for the whole series, Acked-by: Laurent Pinchartlaurent.pinch...@ideasonboard.com As discussed privately earlier today, sorry for not having handled the patches myself. I will gather media controller related patches

Re: Mistake on the colorspace page in the API doc

2013-06-18 Thread Laurent Pinchart
Hi Wouter, On Sunday 26 May 2013 15:34:26 Wouter Thielen wrote: Hi all, I have been trying to get the colors right in the images grabbed from my webcam, and I tried the color conversion code on http://linuxtv.org/downloads/v4l-dvb-apis/colorspaces.html. It turned out to be very white, so

Re: [RFC] Support for events with a large payload

2013-06-18 Thread Laurent Pinchart
Hi Hans and Sakari, On Friday 07 June 2013 00:38:04 Sakari Ailus wrote: Hi Hans, Thanks for the RFC! :-) On Mon, May 13, 2013 at 02:14:43PM +0200, Hans Verkuil wrote: Currently the event API allows for a payload of up to 64 bytes. Sometimes we would like to pass larger payloads to

RE: HD Capture Card (HDMI and Component) output raw pixels

2013-06-18 Thread Steve Cookson
Hi Jim, I don't want to configure a RAID either, but if I purchase one SSD with 400 MB/sec write speeds, that might be good. Hmm... nice idea. Did you have any particular model in mind? If you had a link, I might be interested. I wouldn't know about sizing. I don't know how much space HD raw

Re: [PATCH] MAINTAINERS: Update S5P/Exynos FIMC driver entry

2013-06-18 Thread Sylwester Nawrocki
Hi Sachin, Thanks for your review. On 06/18/2013 05:39 AM, Sachin Kamat wrote: Hi Sylwester, Just a couple of nits inline. On 17 June 2013 22:12, Sylwester Nawrockis.nawro...@samsung.com wrote: This change is mainly to update the driver's path changed from drivers/media/platform/s5p-fimc

Re: [PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

2013-06-18 Thread Sylwester Nawrocki
Hi Sachin, On 06/18/2013 05:45 AM, Sachin Kamat wrote: Hi Sylwester, -The machine code (plat-s5p and arch/arm/mach-*) must select following options +The machine code (arch/arm/plat-samsung and arch/arm/mach-*) must select +following options: After the recent platform code cleanup the below

Re: [PATCH RFC v3 3/3] media: added managed v4l2/i2c subdevice initialization

2013-06-18 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Thursday 16 May 2013 10:14:34 Andrzej Hajda wrote: This patch adds managed version of initialization function for v4l2/i2c subdevices. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com

Re: [PATCH RFC v3 2/3] media: added managed v4l2 control initialization

2013-06-18 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Thursday 16 May 2013 10:14:33 Andrzej Hajda wrote: This patch adds managed version of initialization function for v4l2 control handler. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com

Re: [PATCH RFC v3 1/3] media: added managed media entity initialization

2013-06-18 Thread Laurent Pinchart
Hi Andrzej, Thank you for the patch. On Thursday 16 May 2013 10:14:32 Andrzej Hajda wrote: This patch adds managed versions of initialization function for media entity. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by:

Re: HD Capture Card (HDMI and Component) output raw pixels

2013-06-18 Thread Daniel Glöckner
On Tue, Jun 18, 2013 at 05:55:15PM -0300, Steve Cookson wrote: I don't want to configure a RAID either, but if I purchase one SSD with 400 MB/sec write speeds, that might be good. Hmm... nice idea. Did you have any particular model in mind? If you had a link, I might be interested. I

RE: HD Capture Card (HDMI and Component) output raw pixels

2013-06-18 Thread Charlie X. Liu
Right -- not practical, since you need 1920*1080*3*50 = 311.04MB/s bandwidth to transfer from PCIe and save the raw date onto a SSD, at which the PCIe 1.x link x1 (max 250MB/s) can not really meet such requirement. Well, PCIe 2.x link x1 can meet since its max is 500MB/s. Or, using YUYV, a more

Re: [PATCH] Documentation: Update driver's directory in video4linux/fimc.txt

2013-06-18 Thread Sachin Kamat
Hi Sylwester, On 19 June 2013 03:27, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Hi Sachin, On 06/18/2013 05:45 AM, Sachin Kamat wrote: Hi Sylwester, -The machine code (plat-s5p and arch/arm/mach-*) must select following options +The machine code (arch/arm/plat-samsung and

Re: [PATCH 2/2] Print parser position on error

2013-06-18 Thread Sascha Hauer
Hi Laurent, On Wed, Jun 19, 2013 at 02:39:48AM +0200, Laurent Pinchart wrote: Hi Sascha, On Monday 10 June 2013 15:56:01 Laurent Pinchart wrote: Hi Sascha, I'm sorry for the late reply. Great patch set, thank you. It's very helpful. Should I got ahead and apply the patch with

RE: [RFC PATCH v2] dmabuf-sync: Introduce buffer synchronization framework

2013-06-18 Thread Inki Dae
-Original Message- From: Lucas Stach [mailto:l.st...@pengutronix.de] Sent: Tuesday, June 18, 2013 6:47 PM To: Inki Dae Cc: 'Russell King - ARM Linux'; 'linux-fbdev'; 'Kyungmin Park'; 'DRI mailing list'; 'myungjoo.ham'; 'YoungJun Cho'; linux-arm- ker...@lists.infradead.org;

Re: [PATCH v2 1/1] v4l: Document timestamp behaviour to correspond to reality

2013-06-18 Thread Hans Verkuil
On Tue June 18 2013 21:55:26 Laurent Pinchart wrote: Hi Hans, On Monday 10 June 2013 13:29:53 Hans Verkuil wrote: On Mon June 10 2013 00:35:44 Sakari Ailus wrote: [snip] Note that the 'timestamp' field documentation still says that it is the timestamp of the first data byte for