Re: [PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon

2015-08-04 Thread Sudip Mukherjee
On Wed, Aug 05, 2015 at 12:14:55AM -0500, Pradheep Shrinivasan wrote: > From: pradheep Dan had previously told you that it is wrong. Here From: line is only required if you are not able to configure the email From: header while using some corporate server. But your email From: header is ok. regar

[PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon

2015-08-04 Thread Pradheep Shrinivasan
From: pradheep This patche removes the extra braces found in drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by checkpatch.pl Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_imon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 1/2] Remove the extra braces in if statement of lirc_imon

2015-08-04 Thread Pradheep Shrinivasan
From: pradheep This patche removes the extra braces found in drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by checkpatch.pl Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_imon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 1/2] staging: media: lirc Remove the extra braces in if statement of lirc_imon

2015-08-04 Thread Pradheep Shrinivasan
From: pradheep This patche removes the extra braces found in drivers/staging/media/lirc/lirc_imon.c to fix the warning thrown by checkpatch.pl Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_imon.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --gi

[PATCH 2/2] staging: media: lirc This fix changes the spaces to tab in lirc_sasem.c

2015-08-04 Thread Pradheep Shrinivasan
This fix changes the space in the code to tab to fix the ERROR "ERROR: code indent should use tabs where possible" Signed-off-by: Pradheep Shrinivasan --- drivers/staging/media/lirc/lirc_sasem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_s

Re: [PATCH 0/4] atmel-isi: Remove platform data support

2015-08-04 Thread Josh Wu
Hi, Laurent On 8/5/2015 6:08 AM, Laurent Pinchart wrote: Hi Josh, On Monday 03 August 2015 10:56:29 Josh Wu wrote: On 8/1/2015 5:22 PM, Laurent Pinchart wrote: Hello, While reviewing patches for the atmel-isi I noticed a couple of small issues with the driver. Here's a patch series to fix th

$0.92/pc monopod selfie stick,on promotion

2015-08-04 Thread Raymond
Dear Good day $0.92/pc monopod selfie stick with cable take pole,only from us,the arcpeaks factory Please feel free to contact me for more details Thanks Best Regards Ray arcpeaks.en.alibaba.com Skype:sixiwenzhi MOBIL:+86 18924649532 We will attend Hong kong Electronics Fair(Autumn Edition) On

[PATCH v2 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-04 Thread Josh Wu
In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register and just set part of it. So just set up this register directly makes things simpler. Currently only support YUV format from camera sensor.

[PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-04 Thread Josh Wu
After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu --- Changes in v2: - new added patch drivers/media/platform/soc_camera/atmel-isi.c | 39 +-- 1 file chan

[PATCH v2 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-04 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu Reviewed-by: L

cron job: media_tree daily build: OK

2015-08-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Aug 5 04:00:18 CEST 2015 git branch: test git hash: 4dc102b2f53d63207fa12a6ad49c7b6448bc3301 gcc versi

Re: [PATCH 0/4] atmel-isi: Remove platform data support

2015-08-04 Thread Laurent Pinchart
Hi Josh, On Monday 03 August 2015 10:56:29 Josh Wu wrote: > On 8/1/2015 5:22 PM, Laurent Pinchart wrote: > > Hello, > > > > While reviewing patches for the atmel-isi I noticed a couple of small > > issues with the driver. Here's a patch series to fix them, the main > > change being the removal of

Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function

2015-08-04 Thread Andrew Morton
On Tue, 04 Aug 2015 19:04:36 +0200 Robert Jarzmik wrote: > Andrew Morton writes: > > >> include/linux/scatterlist.h | 5 ++ > >> lib/scatterlist.c | 189 > >> > >> 2 files changed, 194 insertions(+) > > > > It's quite a bit of code for

Re: [PATCH] [media] vmc: Virtual Media Controller core, capture and sensor

2015-08-04 Thread Laurent Pinchart
Hi Hans, On Friday 24 July 2015 15:35:24 Hans Verkuil wrote: > Hi Helen, > > Thank you for creating this driver! Much appreciated! > > I do have some comments, see my notes below... > > On 07/18/2015 04:42 PM, Helen Fornazier wrote: > > First version of the Virtual Media Controller. > > Add a s

Re: [RFC PATCH v2] lib: scatterlist: add sg splitting function

2015-08-04 Thread Robert Jarzmik
Andrew Morton writes: >> include/linux/scatterlist.h | 5 ++ >> lib/scatterlist.c | 189 >> >> 2 files changed, 194 insertions(+) > > It's quite a bit of code for a fairly specialised thing. How ugly > would it be to put this in a new .c

Re: drivers/media/platform/am437x/am437x-vpfe.c:1698: bad test ?

2015-08-04 Thread Lad, Prabhakar
Hi David, On Mon, Aug 3, 2015 at 3:02 PM, David Binderman wrote: > Hello there, > > drivers/media/platform/am437x/am437x-vpfe.c:1698:27: warning: self-comparison > always evaluates to true [-Wtautological-compare] > > if (client->addr == curr_client->addr && > client->adapter->n

Re: [PATCH_RFC_v1 2/4] media: Add a common embeed struct for all media graph objects

2015-08-04 Thread Mauro Carvalho Chehab
Em Tue, 04 Aug 2015 14:26:04 +0200 Hans Verkuil escreveu: > > > On 08/04/2015 01:41 PM, Mauro Carvalho Chehab wrote: > > Due to the MC API proposed changes, we'll need to: > > - have an unique object ID for all graph objects; > > - be able to dynamically create/remove objects; > > -

Re: [PATCH_RFC_v1 2/4] media: Add a common embeed struct for all media graph objects

2015-08-04 Thread Hans Verkuil
On 08/04/2015 01:41 PM, Mauro Carvalho Chehab wrote: > Due to the MC API proposed changes, we'll need to: > - have an unique object ID for all graph objects; > - be able to dynamically create/remove objects; > - be able to group objects; > - keep the object in memory until

Re: [PATCH 2/2] ARM: shmobile: lager dts: specify default-input for ADV7612

2015-08-04 Thread Laurent Pinchart
Hi William, Thank you for the patch. On Tuesday 28 July 2015 17:17:44 William Towle wrote: > Set 'default-input' property for ADV7612. Enables image/video capture > without the need to have userspace specifying routing. > > Signed-off-by: Ian Molton > Tested-by: William Towle > --- > arch/arm

Re: [PATCH 1/2] ARM: shmobile: lager dts: Add entries for VIN HDMI input support

2015-08-04 Thread Laurent Pinchart
Hi William, Thank you for the patch. On Tuesday 28 July 2015 17:17:43 William Towle wrote: > Add DT entries for vin0, vin0_pins, and adv7612 > > Signed-off-by: William Towle > Signed-off-by: Rob Taylor > --- > arch/arm/boot/dts/r8a7790-lager.dts | 41 +++- > 1 fi

[PATCH_RFC_v1 3/4] media: add functions to create/remove entities

2015-08-04 Thread Mauro Carvalho Chehab
In order to be able to safely create/remove entities dynamically, we need to use krefs in a way that the entity memory will only be freed when nobody is using it anymore. So, instead of just using kmalloc/kfree, we need to map those into two functions that will use krefs to protect memory. Of cou

[PATCH_RFC_v1 2/4] media: Add a common embeed struct for all media graph objects

2015-08-04 Thread Mauro Carvalho Chehab
Due to the MC API proposed changes, we'll need to: - have an unique object ID for all graph objects; - be able to dynamically create/remove objects; - be able to group objects; - keep the object in memory until we stop use it. Due to that, create a struct media_grap

[PATCH_RFC_v1 1/4] media: Add some fields to store graph objects

2015-08-04 Thread Mauro Carvalho Chehab
We'll need unique IDs for graph objects and a way to associate them with the media interface. So, add an atomic var to be used to create unique IDs and a list to store such objects. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c ind

[PATCH_RFC_v1 4/4] dvbdev: Use functions to create/remove media_entity struct

2015-08-04 Thread Mauro Carvalho Chehab
Instead of using kalloc()/kfree(), use the new functions media_entity_create()/media_entity_remove(), in order to have the proper kref counts for the usage of the entity objects at the media graph. Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/

[PATCH_RFC_v1 0/4] MC initial changes due to MC workshop

2015-08-04 Thread Mauro Carvalho Chehab
This is an initial set of patches showing the approach I'm taking in order to fulfill all the MC needs that was discussed on the 3 day MC summit in Helsinki. As suggested, I'll be sending incremental patches and avoiding to do a large set of changes into one changeset series. So, this is the firs

Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-08-04 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Tuesday 04 August 2015 17:37:49 Josh Wu wrote: > This patch will get the DT parameters of vsync/hsync/pixclock polarity, and > pass to driver. > > Also add a debug information for test purpose. > > Signed-off-by: Josh Wu Reviewed-by: Laurent Pinchart > -

[PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-08-04 Thread Josh Wu
Since in soc_of_bind() it may use the of node's full name as the clk_name, and this full name may be longer than 32 characters, take at91 i2c sensor as an example, length is 34 bytes: /ahb/apb/i2c@f8028000/camera@0x30 So this patch increase the clk_name[] array size to 64. It seems big enough s

[PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-08-04 Thread Josh Wu
This patch will get the DT parameters of vsync/hsync/pixclock polarity, and pass to driver. Also add a debug information for test purpose. Signed-off-by: Josh Wu --- Changes in v3: - add embedded sync dt property support. Changes in v2: - rewrite the debug message and add pix clock polarity se

Re: [PATCH v2] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-08-04 Thread Josh Wu
Hi, Laurent On 8/4/2015 4:33 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Tuesday 04 August 2015 14:47:07 Josh Wu wrote: This patch will get the DT parameters of vsync/hsync/pixclock polarity, and pass to driver. Also add a debug information for test purpose. Signed-off-

Re: [PATCH v2] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity

2015-08-04 Thread Laurent Pinchart
Hi Josh, Thank you for the patch. On Tuesday 04 August 2015 14:47:07 Josh Wu wrote: > This patch will get the DT parameters of vsync/hsync/pixclock polarity, and > pass to driver. > > Also add a debug information for test purpose. > > Signed-off-by: Josh Wu > --- > > Changes in v2: > - rewrit