mediatek decoder: compiler/sparse warnings

2016-09-05 Thread Hans Verkuil
Hi Tiffany, I get a bunch of warnings when I compile the decoder driver in my daily build setup: /home/hans/work/build/media-git/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_if.c: In function 'put_fb_to_free': /home/hans/work/build/media-git/drivers/media/platform/mtk-vcodec/vdec/vdec_h264_

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Niklas Söderlund
Hi Laurent, Thanks for your review. On 2016-09-05 18:43:58 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday 02 Sep 2016 15:47:14 Niklas Söderlund wrote: > > The HGT is a Histogram Generator Two-Dimensions. It computes a weighted > > frequency histograms for

[PATCH] vcodec: mediatek: add Maintainers entry for Mediatek MT8173 vcodec drivers

2016-09-05 Thread Tiffany Lin
Add Tiffany Lin and Andrew-CT Chen as maintainers for Mediatek MT8173 vcodec drivers Signed-off-by: Tiffany Lin Signed-off-by: Andrew-CT Chen --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 0a16a82..ed830c7 100644 --- a/MAINTAINERS

[PATCH] vcodec: mediatek: Add V4L2_CAP_TIMEPERFRAME capability setting

2016-09-05 Thread Tiffany Lin
This patch setting V4L2_CAP_TIMEPERFRAME capability in vidioc_venc_s/g_parm functions Signed-off-by: Tiffany Lin --- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/pl

cron job: media_tree daily build: ERRORS

2016-09-05 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 6 04:00:18 CEST 2016 git branch: test git hash: e62c30e76829d46bf11d170fd81b735f13a014ac gcc versi

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

2016-09-05 Thread Oliver Collyer
> On 5 Sep 2016, at 23:19, Andrey Utkin wrote: > > On Mon, Sep 05, 2016 at 10:43:49PM +0300, Oliver Collyer wrote: >> I do not have any knowledge of uvcvideo and the associated classes apart >> from the studying I’ve done the past day or two, but it seems likely that >> error -71 and the later

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

2016-09-05 Thread Andrey Utkin
On Mon, Sep 05, 2016 at 10:43:49PM +0300, Oliver Collyer wrote: > I do not have any knowledge of uvcvideo and the associated classes apart from > the studying I’ve done the past day or two, but it seems likely that error > -71 and the later setting of V4L2_BUF_FLAG_ERROR are linked. Also, the fac

Re: uvcvideo error on second capture from USB device, leading to V4L2_BUF_FLAG_ERROR

2016-09-05 Thread Oliver Collyer
Hi So I built 4.8-rc5 from source, added in a line to videobuf2-v4l2.c to output to the kernel debug when it sets the error flag and repeated my tests. I get exactly the same result. I also enabled the uvc_trace output in case it helps. Attached are the following files: dmesg_reload_uvcvideo_

Re: [PATCH 2/2] v4l-utils: fixed dvbv5 vdr format

2016-09-05 Thread Chris Mayo
On 05/09/16 14:25, Mauro Carvalho Chehab wrote: > Em Mon, 5 Sep 2016 15:13:04 +0200 > Markus Heiser escreveu: > >> Hi Mauro, (Hi Chris) >> >> sorry for my late reply. I test the v4-utils on my HTPC, >> where I'am not often have time for experimentation ;-) >> >> Am 24.08.2016 um 16:52 schrieb Mau

v4l2-ctl does not show all parameters for HVR-1900

2016-09-05 Thread de_witte_koen
In short: Is it normal that I can use the v4l2-ctl command to adjust brightness, saturation, hue, etc but not to adjust more interesting parameters like bitrate, aspect ration, etc? Working: pi@raspberrypi:~ $ cat /sys/class/pvrusb2/sn-4034395926/ctl_hue/cur_val 0 pi@raspberrypi:~ $ v4l2-ctl -c

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Laurent Pinchart
On Monday 05 Sep 2016 17:57:11 Geert Uytterhoeven wrote: > On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote: > >> + for (n = 0; n < 6; n++) > > > > Nitpicking, the driver uses pre-increment in for loops (++n), not post- > > increment. This used to be a best-practice rule in C++, where >

Re: [PATCH] [media] cx24120: do not allow an invalid delivery system types

2016-09-05 Thread Jemma Denson
On 03/09/16 18:04, Colin King wrote: From: Colin Ian King cx24120_set_frontend currently allows invalid delivery system types other than SYS_DVBS2 and SYS_DVBS. Fix this by returning -EINVAL for invalid values. Signed-off-by: Colin Ian King --- drivers/media/dvb-frontends/cx24120.c | 3 +--

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Sep 5, 2016 at 5:43 PM, Laurent Pinchart wrote: >> + for (n = 0; n < 6; n++) > > Nitpicking, the driver uses pre-increment in for loops (++n), not post- > increment. This used to be a best-practice rule in C++, where pre-increment > can be faster for non-native types (see

[GIT PULL FOR v4.9] Add ST HVA driver

2016-09-05 Thread Hans Verkuil
The following changes since commit fb6609280db902bd5d34445fba1c926e95e63914: [media] dvb_frontend: Use memdup_user() rather than duplicating its implementation (2016-08-24 17:20:45 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git hva for you to fetch

Re: [PATCH 2/2] v4l: vsp1: Add HGT support

2016-09-05 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday 02 Sep 2016 15:47:14 Niklas Söderlund wrote: > The HGT is a Histogram Generator Two-Dimensions. It computes a weighted > frequency histograms for hue and saturation areas over a configurable > region of the image with optional subsampling. > > Signed

Re: [PATCH v6 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-09-05 Thread Jean Christophe TROTIN
On 09/05/2016 04:40 PM, Hans Verkuil wrote: > I ran checkpatch and it complains (correctly) that the MAINTAINERS file > wasn't updated. > Can you add an entry for this driver to the MAINTAINERS file and post it as a > separate > patch? I promise, that's the last thing I need :-) > > Regards, >

[PATCH v1] st-hva: update MAINTAINERS

2016-09-05 Thread Jean-Christophe Trotin
Add entry for the HVA driver to the MAINTAINERS file. Signed-off-by: Jean-Christophe Trotin --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 20bb1d0..5939be5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5634,6 +5634,14 @@ M: Nadi

[PATCH] v4l: vsp1: Move subdev operations from HGO to common histogram code

2016-09-05 Thread Laurent Pinchart
The code will be shared with the HGT entity, move it to the generic histogram implementation. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_drv.c | 7 +- drivers/media/platform/vsp1/vsp1_hgo.c | 308 ++-- drivers/media/platform/vsp1/vsp1_hgo.h

Re: [PATCH 0/8] Qualcomm video decoder/encoder driver

2016-09-05 Thread Hans Verkuil
On 08/22/2016 03:13 PM, Stanimir Varbanov wrote: > This patchset introduces a basic support for Qualcomm video > acceleration hardware used for video stream decoding/encoding. > The video IP can found on various qcom SoCs like apq8084, msm8916 > and msm8996, hence it is widly distributed but the dr

Re: [PATCH v6 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-09-05 Thread Hans Verkuil
I ran checkpatch and it complains (correctly) that the MAINTAINERS file wasn't updated. Can you add an entry for this driver to the MAINTAINERS file and post it as a separate patch? I promise, that's the last thing I need :-) Regards, Hans On 09/05/2016 04:06 PM, Jean-Christophe Trotin

[GIT PULL FOR v4.9] Various fixes

2016-09-05 Thread Hans Verkuil
The following changes since commit fb6609280db902bd5d34445fba1c926e95e63914: [media] dvb_frontend: Use memdup_user() rather than duplicating its implementation (2016-08-24 17:20:45 -0300) are available in the git repository at: git://linuxtv.org/hverkuil/media_tree.git for-v4.9c for you to

[PATCHv3] cobalt: update EDID

2016-09-05 Thread Hans Verkuil
Update the cobalt EDID, fixing various incorrect values (wrong name, product code, various video capabilities). Signed-off-by: Hans Verkuil --- Changes since v2: fix Display Type setting --- drivers/media/pci/cobalt/cobalt-driver.c | 47 1 file changed, 24 insert

[PATCHv2] vivid: update EDID

2016-09-05 Thread Hans Verkuil
Update the vivid EDID, fixing various incorrect values (wrong name, product code, various video capabilities). Signed-off-by: Hans Verkuil --- Change since v1: fix Display Type setting --- drivers/media/platform/vivid/vivid-core.c | 58 +++ 1 file changed, 29 insertio

[PATCH v6 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-09-05 Thread Jean-Christophe Trotin
version 6: - "depends on HAS_DMA" added in Kconfig - g/s parm only supported for output - V4L2_CAP_TIMEPERFRAME capability set in g/s parm - V4L2 compliance successfully passed with this version (see report below) version 5: - Compilation problem with 4.8-rc1 corrected: unsigned long used for dma_

[PATCH v6 2/3] st-hva: multi-format video encoder V4L2 driver

2016-09-05 Thread Jean-Christophe Trotin
This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework. This patch only contains the core parts of the driver: - the V4L2 interface with the userland (hva-v4l2.c) - the hardware services (hva-hw.c) - the memory mana

[PATCH v6 3/3] st-hva: add H.264 video encoding support

2016-09-05 Thread Jean-Christophe Trotin
This patch adds the H.264 video encoding capability in the V4L2 HVA video encoder driver for STMicroelectronics SoC (hva-h264.c). The main supported features are: - profile: baseline, main, high, stereo high - level: up to 4.2 - bitrate mode: CBR, VBR - entropy mode: CABAC, CAVLC - video aspect: 1

[PATCH v6 1/3] Documentation: DT: add bindings for ST HVA

2016-09-05 Thread Jean-Christophe Trotin
This patch adds DT binding documentation for STMicroelectronics hva driver. Signed-off-by: Yannick Fertre Signed-off-by: Jean-Christophe Trotin Acked-by: Peter Griffin --- .../devicetree/bindings/media/st,st-hva.txt| 24 ++ 1 file changed, 24 insertions(+) create m

Re: [PATCH 1/2] [media] tw5864-core: remove double irq lock code

2016-09-05 Thread Andrey Utkin
Just received a notification from patchwork that my alternative patch on this was rejected as not applicable. Thanks to Hans Verkuil - he has applied a reversion of Mauro's wrong patch and also applied my patch in his repo, git://linuxtv.org/hverkuil/media_tree.git (branch for-v4.9c). As I see th

Re: [PATCH 1/2] v4l: Define a pixel format for the R-Car VSP1 2-D histogram engine

2016-09-05 Thread Niklas Söderlund
Hi Laurent, Thanks for your review. On 2016-09-05 16:05:10 +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Friday 02 Sep 2016 15:47:13 Niklas Söderlund wrote: > > The format is used on the R-Car VSP1 video queues that carry > > 2-D histogram statistics data. > >

Re: [PATCH 2/2] v4l-utils: fixed dvbv5 vdr format

2016-09-05 Thread Mauro Carvalho Chehab
Em Mon, 5 Sep 2016 15:13:04 +0200 Markus Heiser escreveu: > Hi Mauro, (Hi Chris) > > sorry for my late reply. I test the v4-utils on my HTPC, > where I'am not often have time for experimentation ;-) > > Am 24.08.2016 um 16:52 schrieb Mauro Carvalho Chehab > : > > > Em Wed, 24 Aug 2016 11:49:2

Re: [PATCH 2/2] v4l-utils: fixed dvbv5 vdr format

2016-09-05 Thread Markus Heiser
Hi Mauro, (Hi Chris) sorry for my late reply. I test the v4-utils on my HTPC, where I'am not often have time for experimentation ;-) Am 24.08.2016 um 16:52 schrieb Mauro Carvalho Chehab : > Em Wed, 24 Aug 2016 11:49:27 -0300 > Mauro Carvalho Chehab escreveu: > >> Hi Markus, >> >> Em Wed, 10 A

Re: [PATCH v2] [media] v4l2-async: Always unregister the subdev on failure

2016-09-05 Thread Hans Verkuil
Hi Alban, On 08/24/2016 03:49 PM, Alban Bedel wrote: > In v4l2_async_test_notify() if the registered_async callback or the > complete notifier returns an error the subdev is not unregistered. > This leave paths where v4l2_async_register_subdev() can fail but > leave the subdev still registered. >

Re: [PATCH 1/2] v4l: Define a pixel format for the R-Car VSP1 2-D histogram engine

2016-09-05 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Friday 02 Sep 2016 15:47:13 Niklas Söderlund wrote: > The format is used on the R-Car VSP1 video queues that carry > 2-D histogram statistics data. > > Signed-off-by: Niklas Söderlund > --- > Documentation/media/uapi/v4l/meta-formats.rst | 1 + > .

Re: [PATCH 2/2] pulse8-cec: store logical address mask

2016-09-05 Thread Hans Verkuil
On 08/30/2016 02:31 PM, Johan Fjeldtvedt wrote: > In addition to setting the ACK mask, also set the logical address mask > setting in the dongle. This is (and not the ACK mask) is persisted for > use in autonomous mode. > > The logical address mask to use is deduced from the primary device type >

Re: [PATCH v5 00/13] pxa_camera transition to v4l2 standalone device

2016-09-05 Thread Hans Verkuil
On 08/29/2016 07:55 PM, Robert Jarzmik wrote: > There is no change between v4 and v5, ie. the global diff is empty, only one > line was shifted to prevent breaking bisectablility. Against which tree do you develop? Unfortunately this patch series doesn't apply to the media_tree master branch anymo

Re: [PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver

2016-09-05 Thread Hans Verkuil
On 09/05/2016 01:47 PM, Jean Christophe TROTIN wrote: > > > On 09/05/2016 10:24 AM, Hans Verkuil wrote: >> On 08/29/2016 03:21 PM, Jean-Christophe Trotin wrote: >>> This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder >>> driver for STMicroelectronics SoC. It uses the V4L2 mem2mem

[GIT PULL FOR v4.9] VSP1 changes

2016-09-05 Thread Laurent Pinchart
Hi Mauro, The following changes since commit fb6609280db902bd5d34445fba1c926e95e63914: [media] dvb_frontend: Use memdup_user() rather than duplicating its implementation (2016-08-24 17:20:45 -0300) are available in the git repository at: git://linuxtv.org/pinchartl/media.git vsp1/next for

[PATCH] cec-compliance: improve man page

2016-09-05 Thread Hans Verkuil
Clarify the 'OK (Not Supported)' explanation. Mention that most CEC adapters will detect the physical address automatically and that the --phys-addr option can be dropped. Signed-off-by: Hans Verkuil --- diff --git a/utils/cec-compliance/cec-compliance.1.in b/utils/cec-compliance/cec-complianc

Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-05 Thread Arnd Bergmann
On Sunday, September 4, 2016 2:41:41 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype for > 'omap4iss_flush' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which i

Re: [PATCH] staging: media: omap4iss: mark omap4iss_flush() static

2016-09-05 Thread Laurent Pinchart
Hi Baoyou, Thank you for the patch. On Sunday 04 Sep 2016 14:41:41 Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/media/omap4iss/iss.c:64:6: warning: no previous prototype > for 'omap4iss_flush' [-Wmissing-prototypes] > > In fact, this function is only used

Re: [PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver

2016-09-05 Thread Jean Christophe TROTIN
On 09/05/2016 10:24 AM, Hans Verkuil wrote: > On 08/29/2016 03:21 PM, Jean-Christophe Trotin wrote: >> This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder >> driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework. >> >> This patch only contains the core parts of the

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Hans Verkuil
On 09/05/2016 01:30 PM, Tiffany Lin wrote: > Hi Hans, > > On Mon, 2016-09-05 at 13:26 +0200, Hans Verkuil wrote: >> On 09/05/2016 12:52 PM, Tiffany Lin wrote: >>> Hi Hans, >>> >>> On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: On 09/05/2016 11:53 AM, Hans Verkuil wrote: > On 09/05

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Tiffany Lin
Hi Hans, On Mon, 2016-09-05 at 13:26 +0200, Hans Verkuil wrote: > On 09/05/2016 12:52 PM, Tiffany Lin wrote: > > Hi Hans, > > > > On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > >> On 09/05/2016 11:53 AM, Hans Verkuil wrote: > >>> On 09/05/2016 11:50 AM, Tiffany Lin wrote: > Hi Hans

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Hans Verkuil
On 09/05/2016 12:52 PM, Tiffany Lin wrote: > Hi Hans, > > On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: >> On 09/05/2016 11:53 AM, Hans Verkuil wrote: >>> On 09/05/2016 11:50 AM, Tiffany Lin wrote: Hi Hans, On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > On 09/

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Tiffany Lin
Hi Hans, On Mon, 2016-09-05 at 12:09 +0200, Hans Verkuil wrote: > On 09/05/2016 11:53 AM, Hans Verkuil wrote: > > On 09/05/2016 11:50 AM, Tiffany Lin wrote: > >> Hi Hans, > >> > >> On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > >>> On 09/02/2016 02:19 PM, Tiffany Lin wrote: > ==

[PATCH v2 06/12] [media] mb86a20s: fix demod settings

2016-09-05 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab With the current settings, only one channel locks properly. That's likely because, when this driver was written, Brazil were still using experimental transmissions. Change it to reproduce the settings used by the newer drivers. That makes it lock on other channels. S

[PATCH v2 05/12] [media] cx231xx: fix PV SBTVD Hybrid AGC GPIO pin

2016-09-05 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab The AGC GPIO pin for this board is wrong. it should be GPIO 28 (0x1c). Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-cards.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v2 01/12] [media] cx231xx: don't return error on success

2016-09-05 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab The cx231xx_set_agc_analog_digital_mux_select() callers expect it to return 0 or an error. That makes the first attempt to switch between analog/digital to fail. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx

[PATCH v2 03/12] [media] cx231xx: prints error code if can't switch TV mode

2016-09-05 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab If something bad happens when switching between digital and analog mode, prints an error and outputs the returned code. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-core.c | 9 - 1 file chan

[PATCH v2 10/12] [media] cx231xx-cards: unregister IR earlier

2016-09-05 Thread Mauro Carvalho Chehab
[ 1417.425863] cx231xx 1-3.1.4:1.1: Cx231xx dvb Extension removed [ 1417.571923] BUG: unable to handle kernel paging request at c081a024 [ 1417.571962] IP: [] string+0x24/0x80 [ 1417.571987] PGD 1c09067 PUD 1c0b067 PMD 88e653067 PTE 0 [ 1417.572013] Oops: [#1] SMP [ 1417.572026] Module

[PATCH v2 11/12] [media] tda18271: use prefix on all printk messages

2016-09-05 Thread Mauro Carvalho Chehab
Some messages have a hardcoded prefix; others not. Use the pr_fmt() to ensure that all messages will use the same prefix. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/tda18271-fe.c | 11 ++- drivers/media/tuners/tda18271-priv.h | 2 ++ 2 files changed, 8 insertions(+)

[PATCH v2 02/12] [media] cx231xx: fix GPIOs for Pixelview SBTVD hybrid

2016-09-05 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab This device uses GPIOs: 28 to switch between analog and digital modes: on digital mode, it should be set to 1. The code that sets it on analog mode is OK, but it misses the logic that sets it on digital mode. Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Mauro

[PATCH v2 08/12] [media] cx231xx-i2c: handle errors with cx231xx_get_i2c_adap()

2016-09-05 Thread Mauro Carvalho Chehab
The cx231xx_get_i2c_adap() function should return the I2C adapter that will be used to talk with a device. It should never be NULL, as otherwise the driver will try to dereference a null pointer. We might instead fix the callers, but if this condition ever happens, it is really a driver bug, becau

[PATCH v2 07/12] [media] cx231xx-core: fix GPIO comments

2016-09-05 Thread Mauro Carvalho Chehab
The number of the cx231xx REQ for GPIO register set/get are wrong. They should follow what's there at cx231xx-pcb-cfg.h. Noticed while checking the cx231xx parser at the v4l-utils. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-core.c | 8 1 file changed, 4

[PATCH v2 09/12] [media] cx231xx: can't proceed if I2C bus register fails

2016-09-05 Thread Mauro Carvalho Chehab
The driver should not ignore errors while registering the I2C bus, as this device can't even minimally work without the buses, as it uses those buses internally to talk with the several IP blocks inside the chip. Signed-off-by: Mauro Carvalho Chehab --- drivers/media/usb/cx231xx/cx231xx-core.c |

[PATCH v2 00/12] Fix ISDB-T tuning on PV SBTVD Hybrid

2016-09-05 Thread Mauro Carvalho Chehab
This patch series fix a series of bugs and issues related to PV SBTVD device while tuning to ISDB-T channels found in Brazil. Mauro Carvalho Chehab (12): [media] cx231xx: don't return error on success [media] cx231xx: fix GPIOs for Pixelview SBTVD hybrid [media] cx231xx: prints error code if

[PATCH v2 12/12] [media] tea5767: use module prefix on printed messages

2016-09-05 Thread Mauro Carvalho Chehab
use pr_fmt() & friends for error messages to output like: [9.651721] tea5767: Chip ID is not zero. It is not a TEA5767 Signed-off-by: Mauro Carvalho Chehab --- drivers/media/tuners/tea5767.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/media/tuners/te

[PATCH v2 04/12] [media] mb86a20s: fix the locking logic

2016-09-05 Thread Mauro Carvalho Chehab
From: Mauro Carvalho Chehab On this frontend, it takes a while to start output normal TS data. That only happens on state S9. On S8, the TS output is enabled, but it is not reliable enough. However, the zigzag loop is too fast to let it sync. As, on practical tests, the zigzag software loop doe

Re: [PATCH v5 3/5] media: Add Mediatek MDP Driver

2016-09-05 Thread Hans Verkuil
On 08/30/2016 02:25 PM, Minghsiu Tsai wrote: > Add MDP driver for MT8173 > > Signed-off-by: Minghsiu Tsai > --- > drivers/media/platform/Kconfig| 17 + > drivers/media/platform/Makefile |2 + > drivers/media/platform/mtk-mdp/Makefile |9 + > drivers/

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Hans Verkuil
On 09/05/2016 11:53 AM, Hans Verkuil wrote: > On 09/05/2016 11:50 AM, Tiffany Lin wrote: >> Hi Hans, >> >> On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: >>> On 09/02/2016 02:19 PM, Tiffany Lin wrote: == Introduction == The purpose of this s

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Hans Verkuil
On 09/05/2016 11:50 AM, Tiffany Lin wrote: > Hi Hans, > > On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: >> On 09/02/2016 02:19 PM, Tiffany Lin wrote: >>> == >>> Introduction >>> == >>> >>> The purpose of this series is to add the driver for video codec hw embedded

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Tiffany Lin
Hi Hans, On Mon, 2016-09-05 at 11:33 +0200, Hans Verkuil wrote: > On 09/02/2016 02:19 PM, Tiffany Lin wrote: > > == > > Introduction > > == > > > > The purpose of this series is to add the driver for video codec hw embedded > > in the Mediatek's MT8173 SoCs. > > Mediatek

Re: [PATCH v5 0/9] Add MT8173 Video Decoder Driver

2016-09-05 Thread Hans Verkuil
On 09/02/2016 02:19 PM, Tiffany Lin wrote: > == > Introduction > == > > The purpose of this series is to add the driver for video codec hw embedded > in the Mediatek's MT8173 SoCs. > Mediatek Video Codec is able to handle video decoding and encoding of in a > range of fo

Re: [PATCH v5] [media] vimc: Virtual Media Controller core, capture and sensor

2016-09-05 Thread Hans Verkuil
On 09/04/2016 10:05 PM, Helen Koike wrote: > Hi Hans, > > Thank you for your review. > > On 2016-08-22 07:57 AM, Hans Verkuil wrote: >> Hi Helen, >> >> A few small code comments are below. >> >> Note that if I try to capture I see these two messages in the kernel log: >> >> [588197.368145] vimc v

[PATCH] v4l: rcar-fcp: Keep the coding style consistent

2016-09-05 Thread Laurent Pinchart
The Renesas multimedia drivers use ret to store return values, fix the only exception in the rcar-fcp driver to keep the coding style consistent. Signed-off-by: Laurent Pinchart --- drivers/media/platform/rcar-fcp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/driv

Re: [PATCH] [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success

2016-09-05 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Sep 5, 2016 at 10:25 AM, Laurent Pinchart wrote: > On Monday 05 Sep 2016 10:20:52 Geert Uytterhoeven wrote: >> On Mon, Sep 5, 2016 at 10:17 AM, Laurent Pinchart wrote: >> >> BTW, it seems I missed a few more s2ram resume errors: >> >> dpm_run_callback(): pm_genpd_resume_no

Re: [PATCH] [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success

2016-09-05 Thread Laurent Pinchart
Hi Geert, On Monday 05 Sep 2016 10:20:52 Geert Uytterhoeven wrote: > On Mon, Sep 5, 2016 at 10:17 AM, Laurent Pinchart wrote: > >> BTW, it seems I missed a few more s2ram resume errors: > >> dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13 > >> PM: Device fe92.vsp failed

Re: [PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver

2016-09-05 Thread Hans Verkuil
On 08/29/2016 03:21 PM, Jean-Christophe Trotin wrote: > This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder > driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework. > > This patch only contains the core parts of the driver: > - the V4L2 interface with the userland (

Re: [PATCH] v4l: Add metadata buffer type and format

2016-09-05 Thread Laurent Pinchart
Hi Hans, On Monday 05 Sep 2016 09:40:19 Hans Verkuil wrote: > On 09/02/2016 02:07 PM, Laurent Pinchart wrote: > > The metadata buffer type is used to transfer metadata between userspace > > and kernelspace through a V4L2 buffers queue. It comes with a new > > metadata capture capability and format

Re: [PATCH] [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success

2016-09-05 Thread Geert Uytterhoeven
Hi Laurent, On Mon, Sep 5, 2016 at 10:17 AM, Laurent Pinchart wrote: >> BTW, it seems I missed a few more s2ram resume errors: >> >> dpm_run_callback(): pm_genpd_resume_noirq+0x0/0x90 returns -13 >> PM: Device fe92.vsp failed to resume noirq: error -13 >> dpm_run_callback(): pm_ge

Re: [PATCH] [media] rcar-fcp: Make sure rcar_fcp_enable() returns 0 on success

2016-09-05 Thread Laurent Pinchart
Hi Geert, On Tuesday 23 Aug 2016 15:11:59 Geert Uytterhoeven wrote: > On Wed, Aug 17, 2016 at 2:55 PM, Laurent Pinchart wrote: > > On Tuesday 09 Aug 2016 17:36:41 Geert Uytterhoeven wrote: > >> When resuming from suspend-to-RAM on r8a7795/salvator-x: > >> dpm_run_callback(): pm_genpd_resume_no

Re: [PATCH v2.2 1/4] v4l: Add metadata buffer type and format

2016-09-05 Thread Hans Verkuil
On 09/05/2016 10:08 AM, Laurent Pinchart wrote: > The metadata buffer type is used to transfer metadata between userspace > and kernelspace through a V4L2 buffers queue. It comes with a new > metadata capture capability and format description. > > Signed-off-by: Laurent Pinchart > Tested-by: Guen

[PATCH v2.2 1/4] v4l: Add metadata buffer type and format

2016-09-05 Thread Laurent Pinchart
The metadata buffer type is used to transfer metadata between userspace and kernelspace through a V4L2 buffers queue. It comes with a new metadata capture capability and format description. Signed-off-by: Laurent Pinchart Tested-by: Guennadi Liakhovetski Acked-by: Sakari Ailus --- Changes since

Re: [PATCH] v4l: Add metadata buffer type and format

2016-09-05 Thread Hans Verkuil
On 09/02/2016 02:07 PM, Laurent Pinchart wrote: > The metadata buffer type is used to transfer metadata between userspace > and kernelspace through a V4L2 buffers queue. It comes with a new > metadata capture capability and format description. > > Signed-off-by: Laurent Pinchart > Tested-by: Guen

[GIT PULL FOR v4.9] Media IOCTL handling rework

2016-09-05 Thread Sakari Ailus
Hi Mauro, These four patches rework Media controller IOCTL handling for cleanups and preparation for variable sized IOCTL arguments. I've postponed the last patch of the reviewed set until the patch will actually be needed. It's available here: https://git.linuxtv.org/sailus/media_tree.git/log/?