Re: [RFC 1/1] omap3isp: Ignore endpoints with invalid configuration

Pavel Machek wrote: On Tue 2017-02-28 14:45:31, Sakari Ailus wrote: Pavel Machek wrote: Tested-by: Pavel Machek Thanks! I've applied the patch, plus yours, to the ccp2 branch. Thanks! https://git.linuxtv.org/sailus/media_tree.git/log/?h=ccp2 ? I don't see recent changes

Re: [PATCH v4 15/36] platform: add video-multiplexer subdevice driver

On 02/27/2017 06:41 AM, Rob Herring wrote: On Wed, Feb 15, 2017 at 06:19:17PM -0800, Steve Longerbeam wrote: From: Philipp Zabel This driver can handle SoC internal and external video bus multiplexers, controlled either by register bit fields or by a GPIO. The

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Mar 1 05:00:22 CET 2017 media-tree git hash:e6b377dbbb944d5e3ceef4e5d429fc5c841e3692 media_build

Streaming audio from my device in VLC causes the whole system to freeze

Hi, I have a few devices that work on Linux (for example, the Plextor ConvertX PX-AV100U which uses the em28xx driver) and I wonder: When I open their audio stream with VLC, I select the corresponding audio device (example: hw:0,0) and it starts streaming, but almost instantly freezes my OS. I

Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

Hi Laurent, Kieran > > Testing SRU-UDS scaling 768x576 - 768x576 - 640x480 in RGB24: fail > > Testing SRU-UDS scaling 768x576 - 768x576 - 768x576 in RGB24: pass > > Testing SRU-UDS scaling 768x576 - 768x576 - 1024x768 in RGB24: pass > > Testing SRU-UDS scaling 768x576 - 1536x1152 - 1280x960 in

Re: [PATCH v4 24/36] [media] add Omnivision OV5640 sensor driver

On 02/27/2017 06:45 AM, Rob Herring wrote: On Wed, Feb 15, 2017 at 06:19:26PM -0800, Steve Longerbeam wrote: This driver is based on ov5640_mipi.c from Freescale imx_3.10.17_1.0.0_beta branch, modified heavily to bring forward to latest interfaces and code cleanup. Signed-off-by: Steve

Re: [PATCH v4 01/36] [media] dt-bindings: Add bindings for i.MX media driver

Hi Rob, On 02/27/2017 06:38 AM, Rob Herring wrote: On Wed, Feb 15, 2017 at 06:19:03PM -0800, Steve Longerbeam wrote: Add bindings documentation for the i.MX media driver. Signed-off-by: Steve Longerbeam --- Documentation/devicetree/bindings/media/imx.txt | 66

[PATCH] v4l: vsp1: Disable HSV formats on Gen3 hardware

While all VSP instances can process HSV internally, on Gen3 hardware reading or writing HSV24 or HSV32 from/to memory causes the device to hang. Disable those pixel formats on Gen3 hardware. Signed-off-by: Laurent Pinchart ---

Re: [PATCH v2 3/3] v4l: vsp1: wpf: Implement rotation support

Hi Sakari, On Tuesday 28 Feb 2017 23:13:34 Sakari Ailus wrote: > On Tue, Feb 28, 2017 at 05:03:20PM +0200, Laurent Pinchart wrote: > > Some WPF instances, on Gen3 devices, can perform 90° rotation when > > writing frames to memory. Implement support for this using the > > V4L2_CID_ROTATE control.

Re: ir-keytable: infinite loops, segfaults

On Sat, Feb 25, 2017 at 02:08:39AM +1100, Vincent McIntyre wrote: > On 2/22/17, Sean Young wrote: > > > So it's still using the old keymap. I've attached a new one. > > That works, thanks. > > >> # vol down > >> 1487676637.746348: event type EV_MSC(0x04): scancode = 0x0105

Re: [PATCH] [media] tw5864: use dev_warn instead of WARN to shut up warning

On Tue, Feb 28, 2017 at 10:14:37PM +0100, Arnd Bergmann wrote: > tw5864_frameinterval_get() only initializes its output when it successfully > identifies the video standard in tw5864_input. We get a warning here because > gcc can't always track the state if initialized warnings across a WARN() >

[PATCH] [media] tw5864: use dev_warn instead of WARN to shut up warning

tw5864_frameinterval_get() only initializes its output when it successfully identifies the video standard in tw5864_input. We get a warning here because gcc can't always track the state if initialized warnings across a WARN() macro, and thinks it might get used incorrectly in tw5864_s_parm:

Re: [PATCH v2 3/3] v4l: vsp1: wpf: Implement rotation support

Hi Laurent, On Tue, Feb 28, 2017 at 05:03:20PM +0200, Laurent Pinchart wrote: > Some WPF instances, on Gen3 devices, can perform 90° rotation when > writing frames to memory. Implement support for this using the > V4L2_CID_ROTATE control. > > Signed-off-by: Laurent Pinchart

Re: [RFC 1/1] omap3isp: Ignore endpoints with invalid configuration

On Tue 2017-02-28 14:45:31, Sakari Ailus wrote: > Pavel Machek wrote: > >Tested-by: Pavel Machek > > Thanks! > > I've applied the patch, plus yours, to the ccp2 branch. Thanks! https://git.linuxtv.org/sailus/media_tree.git/log/?h=ccp2 ? I don't see recent changes there... Best

Re: [PATCH 4/6] omap3isp: Disable streaming at driver unbind time

On Tue, Feb 28, 2017 at 04:53:11PM +0200, Laurent Pinchart wrote: > Hi Sakari, > > On Tuesday 28 Feb 2017 16:00:01 Sakari Ailus wrote: > > > On Monday 20 Feb 2017 17:22:20 Sakari Ailus wrote: > > >> Once the driver is unbound accessing the hardware is not allowed anymore. > > >> Due to this,

Re: [PATCH] media: vpif: request enable-gpios

2017-02-22 14:27 GMT+01:00 Bartosz Golaszewski : > This change is needed to make vpif capture work on the da850-evm board > where the capture function must be selected on the UI expander. > > Signed-off-by: Bartosz Golaszewski > --- >

Re: em28xx: new board id [1d19:6901]

Am 27.02.2017 um 21:21 schrieb Łukasz Strzeszkowski: Hi, I’ve found a new device which is not listed model: LogiLink VG0011 vendor/product: [1d19:6901] Dexatek Technology Ltd. mode: analog I am unable to load a driver, because there is no such vendor in driver list. dmesg output: [

[PATCH v3 0/2] media: dt-bindings: extend the vpif bindings

This series adds pdata quirks and other changes required to make vpif work on the da850-evm board. v1 -> v2: - added patch 3/3 - specified the purpose of port@0 and port@1 nodes v2 -> v3: - removed patch 3/3 - it may take some more time to determine the correct solution for enable-gpios, so I

[PATCH v3 1/2] media: dt-bindings: vpif: fix whitespace errors

The examples have been copied from the DT with whitespace errors. Fix them. Signed-off-by: Bartosz Golaszewski Acked-by: Rob Herring --- Documentation/devicetree/bindings/media/ti,da850-vpif.txt | 12 ++-- 1 file changed, 6 insertions(+), 6

[PATCH v3 2/2] media: dt-bindings: vpif: extend the example with an output port

This makes the example more or less correspond with the da850-evm hardware setup. Signed-off-by: Bartosz Golaszewski Acked-by: Rob Herring --- .../devicetree/bindings/media/ti,da850-vpif.txt| 40 +- 1 file changed, 32

[PATCH v3 7/8] v4l: Define a pixel format for the R-Car VSP1 2-D histogram engine

From: Niklas Söderlund The format is used on the R-Car VSP1 video queues that carry 2-D histogram statistics data. Signed-off-by: Niklas Söderlund Reviewed-by: Laurent Pinchart

[PATCH v3 8/8] v4l: vsp1: Add HGT support

From: Niklas Söderlund The HGT is a Histogram Generator Two-Dimensions. It computes a weighted frequency histograms for hue and saturation areas over a configurable region of the image with optional subsampling. Signed-off-by: Niklas Söderlund

[PATCH v3 4/8] v4l: vsp1: Fix HGO and HGT routing register addresses

The addresses are incorrect, fix them. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_regs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_regs.h

[PATCH v3 6/8] v4l: vsp1: Add HGO support

The HGO is a Histogram Generator One-Dimension. It computes per-channel histograms over a configurable region of the image with optional subsampling. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/Makefile | 2 +-

[PATCH v3 0/8] R-Car VSP1 Histogram Support

Hello, This patch series implements support for the Renesas R-Car VSP1 1-D and 2-D histogram generators (HGO and HGT). It is based on top of the VSP1 rotation patches and available for convenience at git://linuxtv.org/pinchartl/media.git vsp1-histogram-v3-20170228 The series starts

[PATCH v3 5/8] v4l: Define a pixel format for the R-Car VSP1 1-D histogram engine

The format is used on the R-Car VSP1 video queues that carry 1-D histogram statistics data. Signed-off-by: Laurent Pinchart Acked-by: Sakari Ailus --- Documentation/media/uapi/v4l/meta-formats.rst | 15 ++

[PATCH v3 1/8] v4l: Add metadata buffer type and format

The metadata buffer type is used to transfer metadata between userspace and kernelspace through a V4L2 buffers queue. It comes with a new metadata capture capability and format description. Signed-off-by: Laurent Pinchart Tested-by: Guennadi

[PATCH v2 3/3] v4l: vsp1: wpf: Implement rotation support

Some WPF instances, on Gen3 devices, can perform 90° rotation when writing frames to memory. Implement support for this using the V4L2_CID_ROTATE control. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_rpf.c | 2 +-

[PATCH v2 2/3] v4l: Clearly document interactions between formats, controls and buffers

V4L2 exposes parameters that influence buffers sizes through the format ioctls (VIDIOC_G_FMT, VIDIOC_TRY_FMT and VIDIO_S_FMT). Other parameters not part of the format structure may also influence buffer sizes or buffer layout in general. One existing such parameter is rotation, which is

[PATCH v2 0/3] Renesas R-Car VSP1 rotation support

git://linuxtv.org/pinchartl/media.git vsp1-rotation-v2-20170228 Laurent Pinchart (3): v4l: vsp1: Fix multi-line comment style v4l: Clearly document interactions between formats, controls and buffers v4l: vsp1: wpf: Implement rotation support Documentation/media/uapi/v4l/buffer.r

[PATCH v2 1/3] v4l: vsp1: Fix multi-line comment style

Fix all multi-line comments to comply with the kernel coding style. Signed-off-by: Laurent Pinchart --- drivers/media/platform/vsp1/vsp1_bru.c| 27 - drivers/media/platform/vsp1/vsp1_dl.c | 27 -

Re: [PATCH 4/6] omap3isp: Disable streaming at driver unbind time

Hi Sakari, On Tuesday 28 Feb 2017 16:00:01 Sakari Ailus wrote: > > On Monday 20 Feb 2017 17:22:20 Sakari Ailus wrote: > >> Once the driver is unbound accessing the hardware is not allowed anymore. > >> Due to this, disable streaming when the device driver is unbound. The > >> states of the

Re: [RFC 08/13] smiapp-pll: Take existing divisor into account in minimum divisor check

On Tue, Feb 28, 2017 at 03:09:21PM +0100, Pavel Machek wrote: > Can I get you to apply this one? :-). Let me try to understand again what does that change actually do. I'll find the time during the rest of this week. I'm starting to think we need a test suite for the PLL calculator... --

Re: [RFC 08/13] smiapp-pll: Take existing divisor into account in minimum divisor check

Hi! > > On Tue, Feb 14, 2017 at 02:40:04PM +0100, Pavel Machek wrote: > > > From: Sakari Ailus > > > > > > Required added multiplier (and divisor) calculation did not take into > > > account the existing divisor when checking the values against the > > > minimum divisor. Do

Re: [PATCH 4/6] omap3isp: Disable streaming at driver unbind time

Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:20 Sakari Ailus wrote: Once the driver is unbound accessing the hardware is not allowed anymore. Due to this, disable streaming when the device driver is unbound. The states of the associated objects

Re: [WARNING: A/V UNSCANNABLE][Merge tag 'media/v4.11-1' of git] ff58d005cd: BUG: unable to handle kernel NULL pointer dereference at 0000039c

On Mon, 27 Feb 2017, Linus Torvalds wrote: > So I don't disagree that in a perfect world all drivers should just > handle it. It's just that it's not realistic. > > The fact that we have now *twice* gotten an oops report or a "this > machine doesn't boot" report etc within a week or so of merging

Re: [PATCH 4/6] omap3isp: Disable streaming at driver unbind time

Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:20 Sakari Ailus wrote: > Once the driver is unbound accessing the hardware is not allowed anymore. > Due to this, disable streaming when the device driver is unbound. The > states of the associated objects related to Media

Re: [PATCH 2/6] omap3isp: Call video_unregister_device() unconditionally

Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:18 Sakari Ailus wrote: > video_unregister_device() can be called on a never or an already > unregistered device. Drop the redundant check. > > Signed-off-by: Sakari Ailus Reviewed-by: Laurent

Re: [PATCH 3/6] omap3isp: Remove misleading comment

Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:19 Sakari Ailus wrote: > The intent of the check the comment is related to is to ensure we are > streaming --- still. Not that streaming wouldn't be enabled yet. Remove > it. > > Signed-off-by: Sakari Ailus

Re: [PATCH 6/6] media: devnode: Rename mdev argument as devnode

Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:22 Sakari Ailus wrote: > Historically, mdev argument name was being used on both struct > media_device and struct media_devnode. Recently most occurrences of mdev > referring to struct media_devnode were replaced by devnode, which

Re: [PATCH 5/6] media: Remove useless curly braces and parentheses

Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:21 Sakari Ailus wrote: > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil Reviewed-by: Laurent Pinchart > --- >

Re: [PATCH 1/6] omap3isp: Don't rely on devm for memory resource management

Laurent Pinchart wrote: Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:17 Sakari Ailus wrote: ... @@ -516,9 +516,12 @@ int omap3isp_hist_init(struct isp_device *isp) hist->event_type = V4L2_EVENT_OMAP3ISP_HIST; ret = omap3isp_stat_init(hist, "histogram",

[PATCH] cec: don't Feature Abort msgs from Unregistered

Feature Abort shouldn't be sent in reply to messages from Unregistered, since that would make it a broadcast message. Signed-off-by: Hans Verkuil --- drivers/media/cec/cec-adap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/cec/cec-adap.c

Re: [PATCH 1/6] omap3isp: Don't rely on devm for memory resource management

Hi Sakari, Thank you for the patch. On Monday 20 Feb 2017 17:22:17 Sakari Ailus wrote: > devm functions are fine for managing resources that are directly related > to the device at hand and that have no other dependencies. However, a > process holding a file handle to a device created by a

Re: [RFC 1/1] omap3isp: Ignore endpoints with invalid configuration

Pavel Machek wrote: Tested-by: Pavel Machek Thanks! I've applied the patch, plus yours, to the ccp2 branch. -- Sakari Ailus sakari.ai...@linux.intel.com

Re: [RFC 1/1] omap3isp: Ignore endpoints with invalid configuration

On Tue 2017-02-28 14:02:30, Sakari Ailus wrote: > If endpoint has an invalid configuration, ignore it instead of happily > proceeding to use it nonetheless. Ignoring such an endpoint is better than > failing since there could be multiple endpoints, only some of which are > bad. > > Signed-off-by:

[RFC 1/1] omap3isp: Ignore endpoints with invalid configuration

If endpoint has an invalid configuration, ignore it instead of happily proceeding to use it nonetheless. Ignoring such an endpoint is better than failing since there could be multiple endpoints, only some of which are bad. Signed-off-by: Sakari Ailus --- Hi Pavel,

[PATCH] omap3isp: Parse CSI1 configuration from the device tree.

Add support for parsing CSI1 configuration. Signed-off-by: Pavel Machek --- > Please find my comments below. Thanks for comments. They are fixed now, plus I fixed the checkpatch stuff that was possible. It should be ready to apply to the right branch. diff --git

Re: [PATCHv4 1/9] video: add hotplug detect notifier support

On Tue, Feb 28, 2017 at 10:23:57AM +0100, Hans Verkuil wrote: > On 02/28/17 09:51, Daniel Vetter wrote: > > On Mon, Feb 27, 2017 at 05:46:51PM +, Russell King - ARM Linux wrote: > > > On Mon, Feb 27, 2017 at 06:21:05PM +0100, Hans Verkuil wrote: > > > > On 02/27/2017 06:04 PM, Russell King -

Re: [PATCHv4 1/9] video: add hotplug detect notifier support

On 02/28/17 09:51, Daniel Vetter wrote: On Mon, Feb 27, 2017 at 05:46:51PM +, Russell King - ARM Linux wrote: On Mon, Feb 27, 2017 at 06:21:05PM +0100, Hans Verkuil wrote: On 02/27/2017 06:04 PM, Russell King - ARM Linux wrote: I'm afraid that I walked away from this after it became clear

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

On Tue, Feb 28, 2017 at 09:20:53AM +0100, Arnd Bergmann wrote: > On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin > wrote: > > Retcode checking takes place everywhere, but currently it overwrites > > supplied structs with potentially-uninitialized values. To make it

Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times

Hi! > Please find my comments below. Thanks for quick review, will fix. > > switch (vfwn.base.port) { > > case ISP_OF_PHY_CSIPHY1: > > - buscfg->interface = ISP_INTERFACE_CSI2C_PHY1; > > + if (csi1) > > You could compare vfwn.bus_type

Re: [PATCHv4 1/9] video: add hotplug detect notifier support

On Mon, Feb 27, 2017 at 05:46:51PM +, Russell King - ARM Linux wrote: > On Mon, Feb 27, 2017 at 06:21:05PM +0100, Hans Verkuil wrote: > > On 02/27/2017 06:04 PM, Russell King - ARM Linux wrote: > > > I'm afraid that I walked away from this after it became clear that there > > > was little hope

Re: [PATCH] [media] tw5864: handle unknown video std gracefully

On Tue, Feb 28, 2017 at 2:08 AM, Andrey Utkin wrote: > Hi Arnd, > > Thanks for sending this patch. > > On Mon, Feb 27, 2017 at 09:32:34PM +0100, Arnd Bergmann wrote: >> tw5864_frameinterval_get() only initializes its output when it successfully >> identifies the