Re: [PATCH v9 03/28] rcar-vin: unregister video device on driver removal

Hi Niklas, Thank you for the patch. On Friday, 8 December 2017 03:08:17 EET Niklas Söderlund wrote: > If the video device was registered by the complete() callback it should > be unregistered when the driver is removed. The .remove() operation indicates device removal, not driver removal (or,

Re: [PATCH v9 02/28] rcar-vin: rename poorly named initialize and cleanup functions

Hi Niklas, Thank you for the patch. On Friday, 8 December 2017 03:08:16 EET Niklas Söderlund wrote: > The functions to initialize and cleanup the hardware and video device > where poorly named from the start. Rename them to better describe their > intended function. It's interesting that you

Re: [PATCH v9 01/28] rcar-vin: add Gen3 devicetree bindings documentation

Hi Niklas, Thank you for the patch. On Friday, 8 December 2017 03:08:15 EET Niklas Söderlund wrote: > Document the devicetree bindings for the CSI-2 inputs available on Gen3. > > There is a need to add a custom property 'renesas,id' and to define > which CSI-2 input is described in which

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Dec 8 05:00:14 CET 2017 media-tree git hash:781b045baefdabf7e0bc9f33672ca830d3db9f27 media_build

[PATCH v8 2/2] media: i2c: Add the ov7740 image sensor driver

The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and any size smaller. Signed-off-by: Songjun Wu Signed-off-by: Wenyou Yang ---

[PATCH v8 1/2] media: ov7740: Document device tree bindings

Add the device tree binding documentation for the ov7740 sensor driver. Signed-off-by: Wenyou Yang Acked-by: Rob Herring --- Changes in v8: None Changes in v7: - Add Acked-by tag. Changes in v6: None Changes in v5: None Changes in v4: None Changes

[PATCH v8 0/2] media: ov7740: Add a V4L2 sensor-level driver

Add a Video4Linux2 sensor-level driver for the OmniVision OV7740 VGA camera image sensor. Changes in v8: - As the registers are written at stream start, remove the written code from the set fmt function. Changes in v7: - Add Acked-by tag. - Fix the wrong handle of default register

Re: [PATCH v7 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Sakari, On 2017/12/7 21:16, Sakari Ailus wrote: Hi Wenyou, On Wed, Dec 06, 2017 at 10:23:43AM +0800, Wenyou Yang wrote: The ov7740 (color) image sensor is a high performance VGA CMOS image snesor, which supports for output formats: RAW RGB and YUV and image sizes: VGA, and QVGA, CIF and

[PATCH v9 13/28] rcar-vin: fix handling of single field frames (top, bottom and alternate fields)

There was never proper support in the VIN driver to deliver ALTERNATING field format to user-space, remove this field option. For sources using this field format instead use the VIN hardware feature of combining the fields to an interlaced format. This mode of operation was previously the default

[PATCH v9 05/28] rcar-vin: move chip information to own struct

When Gen3 support is added to the driver more than chip ID will be different for the different SoCs. To avoid a lot of if statements in the code create a struct chip_info to store this information. And while we are at it sort the compatible string entries and make use of

[PATCH v9 07/28] rcar-vin: change name of video device

The rcar-vin driver needs to be part of a media controller to support Gen3. Give each VIN instance a unique name so it can be referenced from userspace. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham

[PATCH v9 03/28] rcar-vin: unregister video device on driver removal

If the video device was registered by the complete() callback it should be unregistered when the driver is removed. Protect from printing an uninitialized video device node name by adding a check in rvin_v4l2_unregister() to identify that the video device is registered. Signed-off-by: Niklas

[PATCH v9 10/28] rcar-vin: do not reset crop and compose when setting format

It was a bad idea to reset the crop and compose settings when a new format is set. This would overwrite any crop/compose set by s_select and cause unexpected behaviors, remove it. Also fold the reset helper in to the only remaining caller. Signed-off-by: Niklas Söderlund

[PATCH v9 09/28] rcar-vin: all Gen2 boards can scale simplify logic

The logic to preserve the requested format width and height are too complex and come from a premature optimization for Gen3. All Gen2 SoC can scale and the Gen3 implementation will not use these functions at all so simply preserve the width and height when interacting with the subdevice much like

[PATCH v9 06/28] rcar-vin: move max width and height information to chip information

On Gen3 the max supported width and height will be different from Gen2. Move the limits to the struct rvin_info to prepare for Gen3 support. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham Reviewed-by:

[PATCH v9 04/28] rcar-vin: move subdevice handling to async callbacks

In preparation for Gen3 support move the subdevice initialization and clean up from rvin_v4l2_{register,unregister}() directly to the async callbacks. This simplifies the addition of Gen3 support as the rvin_v4l2_register() can be shared for both Gen2 and Gen3 while direct subdevice control are

[PATCH v9 11/28] rcar-vin: do not allow changing scaling and composing while streaming

It is possible on Gen2 to change the registers controlling composing and scaling while the stream is running. It is however not a good idea to do so and could result in trouble. There are also no good reasons to allow this, remove immediate reflection in hardware registers from vidioc_s_selection

[PATCH v9 16/28] rcar-vin: add function to manipulate Gen3 chsel value

On Gen3 the CSI-2 routing is controlled by the VnCSI_IFMD register. One feature of this register is that it's only present in the VIN0 and VIN4 instances. The register in VIN0 controls the routing for VIN0-3 and the register in VIN4 controls routing for VIN4-7. To be able to control routing from

[PATCH v9 12/28] rcar-vin: read subdevice format for crop only when needed

Instead of caching the subdevice format each time the video device format is set read it directly when it's needed. As it turns out the format is only needed when figuring out the max rectangle for cropping. This simplifies the code and makes it clearer what the source format is used for.

[PATCH v9 08/28] rcar-vin: move functions regarding scaling

In preparation of refactoring the scaling code move the code regarding scaling to to the top of the file to avoid the need to add forward declarations. No code is changed in this commit only whole functions moved inside the same file. Signed-off-by: Niklas Söderlund

[PATCH v9 25/28] rcar-vin: extend {start,stop}_streaming to work with media controller

The procedure to start or stop streaming using the non-MC single subdevice and the MC graph and multiple subdevices are quite different. Create a new function to abstract which method is used based on which mode the driver is running in and add logic to start the MC graph. Signed-off-by: Niklas

[PATCH v9 24/28] rcar-vin: add link notify for Gen3

Add the ability to process media device link change request. Link enabling is a bit complicated on Gen3, whether or not it's possible to enable a link depends on what other links already are enabled. On Gen3 the 8 VINs are split into two subgroup's (VIN0-3 and VIN4-7) and from a routing

[PATCH v9 17/28] rcar-vin: add flag to switch to media controller mode

On Gen3 a media controller API needs to be used to allow userspace to configure the subdevices in the pipeline instead of directly controlling a single source subdevice, which is and will continue to be the mode of operation on Gen2. Prepare for these two modes of operation by adding a flag to

[PATCH v9 22/28] rcar-vin: add chsel information to rvin_info

Each Gen3 SoC has a limited set of predefined routing possibilities for which CSI-2 device and virtual channel can be routed to which VIN instance. Prepare to store this information in the struct rvin_info. Signed-off-by: Niklas Söderlund Reviewed-by: Hans

[PATCH v9 18/28] rcar-vin: break out format alignment and checking

Part of the format alignment and checking can be shared with the Gen3 format handling. Break that part out to its own function. While doing this clean up the checking and add more checks. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil

[PATCH v9 15/28] rcar-vin: enable Gen3 hardware configuration

Add the register needed to work with Gen3 hardware. This patch adds the logic for how to work with the Gen3 hardware. More work is required to enable the subdevice structure needed to configure capturing. Signed-off-by: Niklas Söderlund Reviewed-by: Hans

[PATCH v9 26/28] rcar-vin: enable support for r8a7795

Add the SoC specific information for Renesas r8a7795 ES1.x and ES2.0. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/Kconfig | 2 +- drivers/media/platform/rcar-vin/rcar-core.c |

[PATCH v9 28/28] rcar-vin: enable support for r8a77970

Add the SoC specific information for Renesas r8a77970. Signed-off-by: Niklas Söderlund Tested-by: Kieran Bingham Acked-by: Rob Herring Reviewed-by: Hans Verkuil ---

[PATCH v9 20/28] rcar-vin: prepare for media controller mode initialization

When running in media controller mode a media pad is needed, register one. Also set the media bus format to CSI-2. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil --- drivers/media/platform/rcar-vin/rcar-core.c | 24

[PATCH v9 27/28] rcar-vin: enable support for r8a7796

Add the SoC specific information for Renesas r8a7796. Signed-off-by: Niklas Söderlund Reviewed-by: Hans Verkuil Acked-by: Rob Herring --- .../devicetree/bindings/media/rcar_vin.txt | 1 +

[PATCH v9 23/28] rcar-vin: parse Gen3 OF and setup media graph

Parse the VIN Gen3 OF graph and register all CSI-2 devices in the VIN group common media device. Once all CSI-2 subdevices are added to the common media device create links between them. The parsing and registering CSI-2 subdevices with the v4l2 async framework is a collaborative effort shared

[PATCH v9 21/28] rcar-vin: add group allocator functions

In media controller mode all VIN instances needs to be part of the same media graph. There is also a need to each VIN instance to know and in some cases be able to communicate with other VIN instances. Add an allocator framework where the first VIN instance to be probed creates a shared data

[PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

When the driver runs in media controller mode it should not directly control the subdevice instead userspace will be responsible for configuring the pipeline. To be able to run in this mode a different set of v4l2 operations needs to be used. Add a new set of v4l2 operations to support the

[PATCH v9 02/28] rcar-vin: rename poorly named initialize and cleanup functions

The functions to initialize and cleanup the hardware and video device where poorly named from the start. Rename them to better describe their intended function. Signed-off-by: Niklas Söderlund Reviewed-by: Kieran Bingham

[PATCH v9 14/28] rcar-vin: move media bus configuration to struct rvin_info

Bus configuration will once the driver is extended to support Gen3 contain information not specific to only the directly connected parallel subdevice. Move it to struct rvin_info to show it's not always coupled to the parallel subdevice. Signed-off-by: Niklas Söderlund

[PATCH v9 00/28] rcar-vin: Add Gen3 with media controller

Hi, This series adds Gen3 VIN support to rcar-vin driver for Renesas r8a7795, r8a7796 and r8a77970. It is based on the media-tree and depends on some of Fabrizio Castro patches as they touches the order of the compatible strings in the documentation to reduce merge conflicts. The dependencies

[PATCH v9 01/28] rcar-vin: add Gen3 devicetree bindings documentation

Document the devicetree bindings for the CSI-2 inputs available on Gen3. There is a need to add a custom property 'renesas,id' and to define which CSI-2 input is described in which endpoint under the port@1 node. This information is needed since there are a set of predefined routes between each

Re: [PATCH 0/9] media: imx: Add better OF graph support

On 12/07/2017 03:23 PM, Steve Longerbeam wrote: Hi Hans, On 12/04/2017 05:44 AM, Hans Verkuil wrote: Of course, any such simplification can also be done after this series has been applied, but I don't know what your thoughts are on this. I do prefer the sub-notifier approach to

Re: [PATCH v3 07/12] dt-bindings: Document the Rockchip MIPI RX D-PHY bindings

On Wed, Dec 06, 2017 at 07:19:34PM +0800, Jacob Chen wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip MIPI D-PHY RX > > Signed-off-by: Jacob Chen > --- > .../bindings/media/rockchip-mipi-dphy.txt | 71 >

Re: [PATCH 0/9] media: imx: Add better OF graph support

Hi Hans, On 12/04/2017 05:44 AM, Hans Verkuil wrote: Hi Steve, On 10/28/2017 10:36 PM, Steve Longerbeam wrote: This is a set of patches that improve support for more complex OF graphs. Currently the imx-media driver only supports a single device with a single port connected directly to

Re: [PATCH v3 06/12] dt-bindings: Document the Rockchip ISP1 bindings

On Wed, Dec 06, 2017 at 07:19:33PM +0800, Jacob Chen wrote: > From: Jacob Chen > > Add DT bindings documentation for Rockchip ISP1 > > Signed-off-by: Jacob Chen > --- > .../devicetree/bindings/media/rockchip-isp1.txt| 57 >

[PATCH 2/3] [media] coda: allocate space for mpeg4 decoder mvcol buffer

The MPEG-4 decoder mvcol buffer was registered, but its size not added to a frame buffer allocation. This could cause the decoder to write past the end of the allocated buffer for large frame sizes. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c

[PATCH 3/3] [media] coda: use correct offset for mpeg4 decoder mvcol buffer

The mvcol buffer needs to be placed behind the chroma plane(s) when decoding MPEG-4, same as for the h.264 decoder. Use the real offset with the required rounding. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c | 16 +++- 1 file

[PATCH 1/3] [media] coda: round up frame sizes to multiples of 16 for MPEG-4 decoder

We need internal frames to be rounded up to full macroblocks for MPEG-4 decoding as well. Signed-off-by: Philipp Zabel --- drivers/media/platform/coda/coda-bit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/coda/coda-bit.c

Re: [PATCH] media: s5p-jpeg: Fix off-by-one problem

W dniu 06.12.2017 o 17:37, Flavio Ceolin pisze: s5p_jpeg_runtime_resume() does not call clk_disable_unprepare() for jpeg->clocks[0] when one of the clk_prepare_enable() fails. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Flavio Ceolin

Re: [RFC 1/1] v4l: async: Use endpoint node, not device node, for fwnode match

Hi Sakari! thanks for proposing this While we all agree that full endpoint matching is the right thing to do (see also Kieran's last reply to his "v4l2-async: Match parent devices" patch) I have some perplexity on this proposal, please see below On Mon, Dec 04, 2017 at 11:03:02PM +0200,

Re: [PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Hi Hans, On 07-12-2017 12:33, Hans Verkuil wrote: > Hi Jose, > > Some (small) comments below: Thanks for the review! > > On 12/07/17 10:47, Jose Abreu wrote: >> This is an initial submission for the Synopsys DesignWare HDMI RX >> Controller Driver. This driver interacts with a phy driver so

Re: [PATCH v3 3/5] media: dt-bindings: ov5640: add support of DVP parallel interface

Hi Hugues, On Thu, Dec 07, 2017 at 01:40:51PM +0100, Hugues Fruchet wrote: > Add bindings for OV5640 DVP parallel interface support. > > Signed-off-by: Hugues Fruchet > --- > .../devicetree/bindings/media/i2c/ov5640.txt | 27 > -- > 1 file

Re: [PATCH 09/45] drivers: media: remove duplicate includes

Hi Pravin, On Wed, Dec 06, 2017 at 10:22:02PM +0530, Pravin Shedge wrote: > These duplicate includes have been found with scripts/checkincludes.pl but > they have been removed manually to avoid removing false positives. > > Signed-off-by: Pravin Shedge While at

Re: [PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Jose, On Thu, Dec 7, 2017 at 1:33 PM, Hans Verkuil wrote: > Hi Jose, > > Some (small) comments below: > > On 12/07/17 10:47, Jose Abreu wrote: >> This is an initial submission for the Synopsys DesignWare HDMI RX >> Controller Driver. This driver interacts with a phy driver so

Re: [PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

On 12/07/17 14:00, Jose Abreu wrote: > Hi Hans, > > On 07-12-2017 12:33, Hans Verkuil wrote: >> Hi Jose, >> >> Some (small) comments below: > > Thanks for the review! > >> >> On 12/07/17 10:47, Jose Abreu wrote: >>> This is an initial submission for the Synopsys DesignWare HDMI RX >>>

Re: [PATCH v7 2/2] media: i2c: Add the ov7740 image sensor driver

Hi Wenyou, On Wed, Dec 06, 2017 at 10:23:43AM +0800, Wenyou Yang wrote: > The ov7740 (color) image sensor is a high performance VGA CMOS > image snesor, which supports for output formats: RAW RGB and YUV > and image sizes: VGA, and QVGA, CIF and any size smaller. > > Signed-off-by: Songjun Wu

Re: [PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

Hi Jose, Some (small) comments below: On 12/07/17 10:47, Jose Abreu wrote: > This is an initial submission for the Synopsys DesignWare HDMI RX > Controller Driver. This driver interacts with a phy driver so that > a communication between them is created and a video pipeline is > configured. > >

[PATCH v3 1/5] media: ov5640: switch to gpiod_set_value_cansleep()

Switch gpiod_set_value to gpiod_set_value_cansleep to avoid warnings when powering sensor. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v3 4/5] media: ov5640: add support of DVP parallel interface

Add support of DVP parallel mode in addition of existing MIPI CSI mode. The choice between two modes and configuration is made through device tree. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 114 ++--- 1 file

[PATCH v3 2/5] media: ov5640: check chip id

Verify that chip identifier is correct when probing. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 95 ++ 1 file changed, 79 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v3 0/5] Add OV5640 parallel interface and RGB565/YUYV support

Enhance OV5640 CSI driver to support also DVP parallel interface. Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing YUV422 UYVY format. Some other improvements on chip identifier check and removal of warnings in powering phase around gpio handling. === = history =

[PATCH v3 3/5] media: dt-bindings: ov5640: add support of DVP parallel interface

Add bindings for OV5640 DVP parallel interface support. Signed-off-by: Hugues Fruchet --- .../devicetree/bindings/media/i2c/ov5640.txt | 27 -- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git

[PATCH v3 5/5] media: ov5640: add support of RGB565 and YUYV formats

Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing YUV422 UYVY format. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 74 +- 1 file changed, 67 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] media: platform: sti: Adopt SPDX identifier

On 12/05/2017 03:52 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under sti directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/media/platform/sti/bdisp/bdisp-debug.c | 2 +- > drivers/media/platform/sti/bdisp/bdisp-filter.h

[PATCH] [media] coda: fix capture TRY_FMT for YUYV with non-MB-aligned widths

Since bytesperline always fulfills VDOA width requirements, detile the whole buffer instead of limiting to visible width. This stops TRY_FMT from returning -EINVAL for YUYV capture buffers that are not a multiple of 16 wide. An alternative would be to always round up width to stride, as we report

[PATCH] [media] coda: set min_buffers_needed

From: Lucas Stach The current driver implementation expects at least one buffer on all queues to start streaming. Properly signal this to the vb2 core, to avoid confusion when streamon is racing with qbuf. Signed-off-by: Lucas Stach

Re: [PATCH v5] v4l2-async: Match parent devices

Hi Sakari, On 07/12/17 07:41, Sakari Ailus wrote: > On Wed, Dec 06, 2017 at 02:58:39PM +, Kieran Bingham wrote: >> From: Kieran Bingham >> >> Devices supporting multiple endpoints on a single device node must set >> their subdevice fwnode to the

Re: [PATCH] media: platform: sti: Adopt SPDX identifier

On Tue, Dec 5, 2017 at 3:52 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under sti directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/media/platform/sti/bdisp/bdisp-debug.c | 2 +- >

Re: [PATCH] media: platform: stm32: Adopt SPDX identifier

On Tue, Dec 5, 2017 at 3:51 PM, Benjamin Gaignard wrote: > Add SPDX identifiers to files under stm32 directory > > Signed-off-by: Benjamin Gaignard > --- > drivers/media/platform/stm32/stm32-cec.c | 5 + >

[PATCH v9 0/4] Synopsys DesignWare HDMI Video Capture Controller + PHY

The Synopsys DesignWare HDMI RX controller is an HDMI receiver controller that is responsible to process digital data that comes from a phy. The final result is a stream of RAW video data that can then be connected to a video DMA, for example, and transfered into RAM so that it can be displayed.

[PATCH v9 1/4] dt-bindings: media: Document Synopsys DesignWare HDMI RX

Document the bindings for the Synopsys DesignWare HDMI RX. Signed-off-by: Jose Abreu Acked-by: Rob Herring (v8) Cc: Joao Pinto Cc: Rob Herring Cc: Mark Rutland Cc: Mauro Carvalho Chehab

[PATCH v9 4/4] [media] platform: Add Synopsys DesignWare HDMI RX Controller Driver

This is an initial submission for the Synopsys DesignWare HDMI RX Controller Driver. This driver interacts with a phy driver so that a communication between them is created and a video pipeline is configured. The controller + phy pipeline can then be integrated into a fully featured system that

[PATCH v9 2/4] MAINTAINERS: Add entry for Synopsys DesignWare HDMI drivers

Add an entry for Synopsys DesignWare HDMI Receivers drivers and phys. Signed-off-by: Jose Abreu Cc: Joao Pinto --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7a52a66..a1675bc 100644 ---

[PATCH v9 3/4] [media] platform: Add Synopsys DesignWare HDMI RX PHY e405 Driver

This adds support for the Synopsys DesignWare HDMI RX PHY e405. This phy receives and decodes HDMI video that is delivered to a controller. Main features included in this driver are: - Equalizer algorithm that chooses the phy best settings according to the detected HDMI cable