Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

On 05/08/2018 03:56 PM, Randy Dunlap wrote: > On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote: >> Em Sat, 5 May 2018 10:59:23 -0700 >> Randy Dunlap escreveu: >> >>> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote: Just checking for ifdefs cause build issues as

Re: [PATCH v3 05/13] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers

On 05/08/2018 03:28 AM, Sakari Ailus wrote: Hi Steve, Again, sorry about the delay. This thread got buried in my inbox. :-( Please see my reply below. On Mon, Apr 23, 2018 at 11:00:22AM -0700, Steve Longerbeam wrote: On 04/23/2018 12:14 AM, Sakari Ailus wrote: Hi Steve, On Tue, Mar 20,

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed May 9 05:00:12 CEST 2018 media-tree git hash:f10379aad39e9da8bc7d1822e251b5f0673067ef media_build

[PATCH] media: uvcvideo: Support realtek's UVC 1.5 device

From: ming_qian The length of UVC 1.5 video control is 48, and it id 34 for UVC 1.1. Change it to 48 for UVC 1.5 device, and the UVC 1.5 device can be recognized. More changes to the driver are needed for full UVC 1.5 compatibility. However, at least the UVC 1.5

Re: [PATCH v2 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

Hi Philipp, Jan, On 05/08/2018 07:25 AM, Philipp Zabel wrote: On Tue, 2018-05-08 at 16:14 +0200, Jan Luebbe wrote: The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic mode on the parallel bus, compared to a specific mode on MIPI CSI-2. To handle this, we extend

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

Hi Hans, On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers

Re: [PATCH] media: include/video/omapfb_dss.h: use IS_ENABLED()

On 05/05/2018 02:14 PM, Mauro Carvalho Chehab wrote: > Em Sat, 5 May 2018 10:59:23 -0700 > Randy Dunlap escreveu: > >> On 05/04/2018 01:49 PM, Mauro Carvalho Chehab wrote: >>> Just checking for ifdefs cause build issues as reported by >>> kernel test: >>> >>> config:

[PATCH 3/5] cx23885: Ryzen DMA related RiSC engine stall fixes

This bug affects all of Hauppauge QuadHD boards when used on all Ryzen platforms and some XEON platforms. On these platforms it is possible to error out the RiSC engine and cause it to stall, whereafter the only way to reset the board to a working state is to reboot. This is the fatal condition

[PATCH 1/5] cx23885: Handle additional bufs on interrupt

On Ryzen systems interrupts are occasionally missed: cx23885: cx23885_wakeup: [99b384b83c00/28] wakeup reg=5406 buf=5405 cx23885: cx23885_wakeup: [99b40bf79400/31] wakeup reg=9537 buf=9536 This patch loops up to five times on wakeup, marking any buffers found done. Since the count

[PATCH 2/5] cx23885: Use PCI and TS masks in irq functions

Currently mask is read for pci_status/ts1_status/ts2_status, but otherwise ignored. The masks are now used to determine whether action is warranted. Signed-off-by: Brad Love --- drivers/media/pci/cx23885/cx23885-core.c | 12 ++-- 1 file changed, 10 insertions(+),

[PATCH 0/5] cx23885: Ryzen/Xeon DMA/interrupt fixes

Various problems have been reported to Hauppauge related to usage of QuadHD products on Ryzen platforms and some Xeon platforms. The most serious issue causes adapters on the card to stop working. When the four tuners are in use it is possible to experience RiSc engine OP CODE errors, at which

[PATCH 5/5] cx23885: Add some missing register documentation

Document what these two register calls are doing. Signed-off-by: Brad Love --- drivers/media/pci/cx23885/cx23885-core.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/media/pci/cx23885/cx23885-core.c

[PATCH 4/5] cx23885: Expand registers in dma tsport reg dump

Include some additional useful registers in the output. Signed-off-by: Brad Love --- drivers/media/pci/cx23885/cx23885-core.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/media/pci/cx23885/cx23885-core.c

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

Hi Hans, On Tue, 2018-05-08 at 00:57:25 -0700, Hans Verkuil wrote: > On 05/07/2018 07:45 PM, Hyun Kwon wrote: > > Hi Hans, > > > > Thanks for the comment. > > > > On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: > >> Hi Satish, > >> > >> On 03/05/18 04:42, Satish Kumar Nagireddy wrote:

Re: [PATCH 0/4] media: ov2680: follow up from initial version

Hi, On Mon, May 07, 2018 at 04:56:51PM +0100, Rui Miguel Silva wrote: > Sorry I have Out-of-Office some part of last week, I had v6 of the original > series ready but since I have received the notification from patchwork that > the > v5 was accepted, I am sending this as a follow up tha address

wir bieten 2% Kredite

Sehr geehrte Damen und Herren, Sie brauchen Geld? Sie sind auf der suche nach einem Darlehen? Seriös und unkompliziert? Dann sind Sie hier bei uns genau richtig. Durch unsere jahrelange Erfahrung und kompetente Beratung sind wir Europaweit tätig. Wir bieten jedem ein GÜNSTIGES Darlehen zu TOP

Re: [PATCH v9 11/15] vb2: add in-fence support to QBUF

On Mon, 2018-05-07 at 14:07 +0200, Hans Verkuil wrote: > On 04/05/18 22:06, Ezequiel Garcia wrote: > > From: Gustavo Padovan > > > > Receive in-fence from userspace and add support for waiting on them > > before queueing the buffer to the driver. Buffers can't be

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

Hi Jan, On 05/08/2018 07:13 AM, Jan Lübbe wrote: Hi, On Mon, 2018-05-07 at 11:21 -0700, Steve Longerbeam wrote: In other words, if the sensor bus is parallel, only 8-bit bus UYVY_2x8 and YUYV_2x8 can be routed to the IC pad or component packed/unpacked by the IDMAC pad. All other sensor

[PATCH v4] media: v4l2-ioctl: replace IOCTL_INFO_STD with stub functions

This change removes IOCTL_INFO_STD and adds stub functions where needed using the DEFINE_V4L_STUB_FUNC macro. This fixes indirect call mismatches with Control-Flow Integrity, caused by calling standard ioctls using a function pointer that doesn't match the function type. Signed-off-by: Sami

Re: [PATCH v3] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

On 05/08/2018 07:35 PM, Sami Tolvanen wrote: > This change fixes indirect call mismatches with Control-Flow Integrity > checking, which are caused by calling standard ioctls using a function > pointer that doesn't match the type of the actual function. I really like the patch, but we've drifted

[PATCH v3] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

This change fixes indirect call mismatches with Control-Flow Integrity checking, which are caused by calling standard ioctls using a function pointer that doesn't match the type of the actual function. Signed-off-by: Sami Tolvanen ---

Re: [PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

On Tue, May 08, 2018 at 07:22:21PM +0200, Hans Verkuil wrote: > This looks good, I would just rename DEFINE_IOCTL_FNC to DEFINE_V4L_STUB_FUNC. > This makes it clear that it defines a v4l stub function. Sure, sounds good. I'll send v3 shortly. Thanks for the reviews! Sami

Re: [PATCH v3 13/14] media: imx7.rst: add documentation for i.MX7 media driver

Hi, I have a few editing suggestions below... On 05/07/2018 09:21 AM, Rui Miguel Silva wrote: > Add rst document to describe the i.MX7 media driver and also a working example > from the Warp7 board usage with a OV2680 sensor. > > Signed-off-by: Rui Miguel Silva > --- >

Re: [PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

On 05/08/2018 07:17 PM, Sami Tolvanen wrote: > On Tue, May 08, 2018 at 10:18:24AM +0200, Hans Verkuil wrote: >> Just call this v4l_stub_g_fbuf, conform the naming of the other functions. >> >> So just replace vidioc_ by v4l_stub_ in all these DEFINE_IOCTL_FNC macros. >> >> This way the function

Re: [PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

On Tue, May 08, 2018 at 10:18:24AM +0200, Hans Verkuil wrote: > Just call this v4l_stub_g_fbuf, conform the naming of the other functions. > > So just replace vidioc_ by v4l_stub_ in all these DEFINE_IOCTL_FNC macros. > > This way the function name in the big array matches the name in this

Re: [PATCH 1/2] media: dt-bindings: add binding for TI SCAN921226H video deserializer

On Fri, May 04, 2018 at 02:49:02PM +0200, Jan Luebbe wrote: > This deserializer can be used with sensors that directly produce a > 10-bit LVDS stream and converts it to a parallel bus. > > Controlling it via the optional GPIOs is mainly useful for avoiding > conflicts when another parallel sensor

[PATCH v8 2/3] uvcvideo: send a control event when a Control Change interrupt arrives

UVC defines a method of handling asynchronous controls, which sends a USB packet over the interrupt pipe. This patch implements support for such packets by sending a control event to the user. Since this can involve USB traffic and, therefore, scheduling, this has to be done in a work queue.

[PATCH v8 3/3] uvcvideo: handle control pipe protocol STALLs

When a command ends up in a STALL on the control pipe, use the Request Error Code control to provide a more precise error information to the user. For example, if a camera is still busy processing a control, when the same or an interrelated control set request arrives, the camera can react with a

[PATCH v8 1/3] uvcvideo: remove a redundant check

Event subscribers cannot have a NULL file handle. They are only added at a single location in the code, and the .fh pointer is used without checking there. Signed-off-by: Guennadi Liakhovetski --- drivers/media/usb/uvc/uvc_ctrl.c | 4 ++-- 1 file changed, 2

[PATCH v8 0/3] uvcvideo: asynchronous controls

Added a patch to remove a redundant check, addressed Laurent's comments. Guennadi Liakhovetski (3): uvcvideo: remove a redundant check uvcvideo: send a control event when a Control Change interrupt arrives uvcvideo: handle control pipe protocol STALLs drivers/media/usb/uvc/uvc_ctrl.c |

Re: [PATCH v3 07/14] media: dt-bindings: add bindings for i.MX7 media driver

On Mon, 2018-05-07 at 17:21 +0100, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > > Signed-off-by: Rui Miguel Silva > --- > .../devicetree/bindings/media/imx7.txt| 152 ++ > 1 file changed, 152 insertions(+) >

Re: [PATCH v2 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

On Tue, 2018-05-08 at 16:14 +0200, Jan Luebbe wrote: > The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic > mode on the parallel bus, compared to a specific mode on MIPI CSI-2. > To handle this, we extend imx_media_pixfmt with a cycles per pixel > field, which is used for

[PATCH v2 2/2] media: imx: add support for RGB565_2X8 on parallel bus

The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic mode on the parallel bus, compared to a specific mode on MIPI CSI-2. To handle this, we extend imx_media_pixfmt with a cycles per pixel field, which is used for generic formats on the parallel bus. Based on the selected format

[PATCH v2 1/2] media: imx: capture: refactor enum_/try_fmt

By checking and handling the internal IPU formats (ARGB or AYUV) first, we don't need to check whether it's a bayer format, as we can default to passing the input format on in all other cases. This simplifies handling the different configurations for RGB565 between parallel and MIPI CSI-2, as we

[PATCH v2 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

The IPU can only capture RGB565 with two 8-bit cycles in bayer/generic mode on the parallel bus, compared to a specific mode on MIPI CSI-2. To handle this, we extend imx_media_pixfmt with a cycles per pixel field, which is used for generic formats on the parallel bus. Before actually adding

Re: [PATCH 0/2] media: imx: add capture support for RGB565_2X8 on parallel bus

Hi, On Mon, 2018-05-07 at 11:21 -0700, Steve Longerbeam wrote: > On 05/07/2018 07:23 AM, Jan Lübbe wrote: > > On Sat, 2018-05-05 at 15:22 -0700, Steve Longerbeam wrote: > > > I reviewed this patch series, and while I don't have any > > > objections to the code-level changes, but my question > > >

Re: [PATCH 0/4] media: ov2680: follow up from initial version

Hi Rui, On Tue, May 8, 2018 at 10:52 AM, Rui Miguel Silva wrote: > So, my understand is that the patches will be applied or are already > applied to someone tree (strange patchwork does not send who or which > tree), but since I do not want to break someone workflow I will

Re: [PATCH 0/4] media: ov2680: follow up from initial version

Ola Fabio, On Tue 08 May 2018 at 13:29, Fabio Estevam wrote: Hi Rui, On Mon, May 7, 2018 at 12:56 PM, Rui Miguel Silva wrote: Sorry I have Out-of-Office some part of last week, I had v6 of the original series ready but since I have received the notification from

Re: [PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

On Thu, Apr 26, 2018 at 08:24:43PM +0200, Jacopo Mondi wrote: > Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. > > Reported-by: Geert Uytterhoeven > Signed-off-by: Jacopo Mondi Thanks, applied.

Re: [PATCH 0/4] media: ov2680: follow up from initial version

Hi Rui, On Mon, May 7, 2018 at 12:56 PM, Rui Miguel Silva wrote: > Sorry I have Out-of-Office some part of last week, I had v6 of the original > series ready but since I have received the notification from patchwork that > the > v5 was accepted, I am sending this as a

Re: [PATCH v3 12/14] ARM: dts: imx7s-warp: add ov2680 sensor node

Hi Rui, On Mon, May 7, 2018 at 1:21 PM, Rui Miguel Silva wrote: > + reg_peri_3p15v: regulator-peri-3p15v { > + compatible = "regulator-fixed"; > + regulator-name = "peri_3p15v_reg"; > + regulator-min-microvolt = <315>; >

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

On Tue, May 08, 2018 at 08:04:54AM -0500, Wenwen Wang wrote: > On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter > wrote: > > On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: > >> At the end of atomisp_subdev_set_selection(), the function > >>

Re: [PATCHv13 03/28] media-request: implement media requests

Hi Mauro, On Tue, May 08, 2018 at 09:41:03AM -0300, Mauro Carvalho Chehab wrote: > Em Tue, 8 May 2018 13:52:33 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, Hans, > > > > On Tue, May 08, 2018 at 07:21:16AM -0300, Mauro Carvalho Chehab wrote: > > > Em Fri, 4 May 2018

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

On Tue, May 8, 2018 at 7:16 AM, Dan Carpenter wrote: > On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: >> At the end of atomisp_subdev_set_selection(), the function >> atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since >> this

Re: [PATCHv13 03/28] media-request: implement media requests

Em Tue, 8 May 2018 13:52:33 +0300 Sakari Ailus escreveu: > Hi Mauro, Hans, > > On Tue, May 08, 2018 at 07:21:16AM -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 4 May 2018 15:27:50 +0300 > > Sakari Ailus escreveu: > > > > > Hi Hans, > > > > > >

[PATCH] media: usb: cx231xx-417: include linux/slab.h header

cx231-417 uses kmalloc/kfree functions, so slab header needs to be included in order to fix the following build errors: drivers/media/usb/cx231xx/cx231xx-417.c: In function ‘cx231xx_bulk_copy’: CC drivers/media/platform/qcom/venus/firmware.o drivers/media/usb/cx231xx/cx231xx-417.c:1389:11:

Re: [PATCH] media: staging: atomisp: fix a potential missing-check bug

On Wed, May 02, 2018 at 05:38:49PM -0500, Wenwen Wang wrote: > At the end of atomisp_subdev_set_selection(), the function > atomisp_subdev_get_rect() is invoked to get the pointer to v4l2_rect. Since > this function may return a NULL pointer, it is firstly invoked to check > the returned pointer.

Re: [PATCH v7 1/2] uvcvideo: send a control event when a Control Change interrupt arrives

Hi Laurent, One more comment-to-comment: On Mon, 7 May 2018, Laurent Pinchart wrote: > Hi Guennadi, > > On Tuesday, 10 April 2018 14:31:35 EEST Guennadi Liakhovetski wrote: > > On Fri, 23 Mar 2018, Laurent Pinchart wrote: > > > On Friday, 23 March 2018 11:24:00 EET Laurent Pinchart wrote: > >

Re: [PATCHv13 05/28] media-request: add media_request_object_find

On Fri, May 04, 2018 at 03:43:07PM +0300, Sakari Ailus wrote: > > diff --git a/include/media/media-request.h b/include/media/media-request.h > > index 997e096d7128..5367b4a2f91c 100644 > > --- a/include/media/media-request.h > > +++ b/include/media/media-request.h > > @@ -196,6 +196,22 @@ static

Re: [PATCHv13 03/28] media-request: implement media requests

Hi Mauro, Hans, On Tue, May 08, 2018 at 07:21:16AM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 4 May 2018 15:27:50 +0300 > Sakari Ailus escreveu: > > > Hi Hans, > > > > I've read this patch a large number of times and I think also the details > > begin to seem sound. A

Re: [PATCHv13 12/28] v4l2-ctrls: add core request support

Em Tue, 8 May 2018 10:07:22 +0200 Hans Verkuil escreveu: > >> diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h > >> index 76352eb59f14..a0f7c38d1a90 100644 > >> --- a/include/media/v4l2-ctrls.h > >> +++ b/include/media/v4l2-ctrls.h > >> @@ -250,6 +250,10

[GIT PULL FOR v4.18] v2: Various fixes/improvements

Fixes/improvements all over the place. Changes since v1: Replaced "media: media-device: fix ioctl function types" with the v2 version of that patch. My fault, I missed Sakari's request for a change of v1. Regards, Hans The following changes since commit

Re: [PATCHv13 06/28] v4l2-dev: lock req_queue_mutex

Em Tue, 8 May 2018 09:45:27 +0200 Hans Verkuil escreveu: > On 05/07/2018 07:20 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 3 May 2018 16:52:56 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> We need to

Re: [PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

On 08/05/18 11:38, Daniel Scheller wrote: > Hi Colin, > > Am Tue, 8 May 2018 00:08:42 +0100 > schrieb Colin King : > >> From: Colin Ian King >> >> In function stop there is a check to see if state->demod is a stopped >> value of 0xff,

Re: [PATCH][media-next] media: ddbridge: avoid out-of-bounds write on array demod_in_use

Hi Colin, Am Tue, 8 May 2018 00:08:42 +0100 schrieb Colin King : > From: Colin Ian King > > In function stop there is a check to see if state->demod is a stopped > value of 0xff, however, later on, array demod_in_use is indexed with > this

Re: [PATCHv13 04/28] media-request: add media_request_get_by_fd

Em Tue, 8 May 2018 09:34:11 +0200 Hans Verkuil escreveu: > On 05/07/2018 07:01 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 3 May 2018 16:52:54 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> Add

Re: 4.17-rc3 regression in UVC driver

On 05/05/18 11:32, Mauro Carvalho Chehab wrote: > Hi Kieran, >> I manually pull from git://linuxtv.org/pinchartl/media.git uvc/fixes >> and picked the patch. > >> It should be at media_tree.git at the fixes branch. Thank you Mauro - that's great! -- Kieran

Re: [PATCH v3 05/13] media: v4l2-fwnode: Add a convenience function for registering subdevs with notifiers

Hi Steve, Again, sorry about the delay. This thread got buried in my inbox. :-( Please see my reply below. On Mon, Apr 23, 2018 at 11:00:22AM -0700, Steve Longerbeam wrote: > > > On 04/23/2018 12:14 AM, Sakari Ailus wrote: > > Hi Steve, > > > > On Tue, Mar 20, 2018 at 05:37:21PM -0700, Steve

Re: [PATCHv13 00/28] Request API

Em Thu, 3 May 2018 16:52:50 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > Regarding locking: > > There are two request locks used: req_queue_mutex (part of media_device) > ensures high-level serialization of queueing/reiniting and canceling >

Re: [PATCHv13 03/28] media-request: implement media requests

Em Fri, 4 May 2018 15:27:50 +0300 Sakari Ailus escreveu: > Hi Hans, > > I've read this patch a large number of times and I think also the details > begin to seem sound. A few comments below. I'm sending this after analyzing the other patches in this series, as this is the

Re: [PATCH v3 03/13] media: v4l2: async: Add v4l2_async_notifier_add_subdev

On Fri, Apr 20, 2018 at 10:12:33AM -0700, Steve Longerbeam wrote: > Hi Sakari, > > > On 04/20/2018 05:24 AM, Sakari Ailus wrote: > > Hi Steve, > > > > Thanks for the patchset. > > > > On Tue, Mar 20, 2018 at 05:37:19PM -0700, Steve Longerbeam wrote: > > > v4l2_async_notifier_add_subdev() adds

Re: [PATCHv13 16/28] videobuf2-core: embed media_request_object

Em Thu, 3 May 2018 16:53:06 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Make vb2_buffer a request object. > > Signed-off-by: Hans Verkuil > --- > include/media/videobuf2-core.h | 3 +++ > 1 file changed, 3

Re: [PATCH v2] media: media-device: fix ioctl function types

On Tue, May 08, 2018 at 10:08:41AM +0200, Hans Verkuil wrote: > Hi Sami, > > This is unchanged from the previous version, right? I've already added that > to a > pull request. Casting has been removed from the void pointers as I suggested. That's the difference. > > If this v2 has changes,

Re: [PATCH v2] media: v4l: Add new 10-bit packed grayscale format

On Tue, May 08, 2018 at 11:46:17AM +0300, Todor Tomov wrote: > The new format will be called V4L2_PIX_FMT_Y10P. > It is similar to the V4L2_PIX_FMT_SBGGR10P family formats > but V4L2_PIX_FMT_Y10P is a grayscale format. > > Signed-off-by: Todor Tomov Thanks! Acked-by:

Re: [PATCH 1/2] media: v4l: Add new 2X8 10-bit grayscale media bus code

On Fri, Apr 27, 2018 at 02:40:38PM +0300, Todor Tomov wrote: > The code will be called MEDIA_BUS_FMT_Y10_2X8_PADHI_LE. > It is similar to MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_LE > but MEDIA_BUS_FMT_Y10_2X8_PADHI_LE describes grayscale > data. > > Signed-off-by: Todor Tomov

[GIT PULL for 4.18] Omap3isp fixes

Hi Mauro, Here are some fixes for the omap3isp driver. Please pull. The following changes since commit f10379aad39e9da8bc7d1822e251b5f0673067ef: media: include/video/omapfb_dss.h: use IS_ENABLED() (2018-05-05 11:45:51 -0400) are available in the git repository at:

Re: [RESEND PATCH v9 1/2] media: dt-bindings: Add bindings for Dongwoon DW9807 voice coil

On Tue, May 08, 2018 at 05:36:48AM +, Yeh, Andy wrote: > Dear reviewers, > > As the dt-binding patch has been accepted, would any help set the driver > patch be accepted too? Any missing action from my side blocked the process. > Thanks in advance. > > media: dw9807: Add dw9807 vcm driver

[PATCH v2] media: v4l: Add new 10-bit packed grayscale format

The new format will be called V4L2_PIX_FMT_Y10P. It is similar to the V4L2_PIX_FMT_SBGGR10P family formats but V4L2_PIX_FMT_Y10P is a grayscale format. Signed-off-by: Todor Tomov --- v2: - doc: improved bit-packed representation: added bit positions for LSB bits; - doc:

Re: [bug report] [media] exynos4-is: Add the FIMC-IS ISP capture DMA driver

On 05/03/2018 01:43 PM, Dan Carpenter wrote: > [ This code is five years old now. It's so weird to me that the warning > is showing up in my new warnings pile. Perhaps this wasn't included > in my allmodconfig before? - dan ] Might be, the bug found is real. The module is normally disabled

Re: [PATCHv13 01/28] v4l2-device.h: always expose mdev

On 05/07/2018 05:46 PM, Mauro Carvalho Chehab wrote: > Em Fri, 4 May 2018 13:51:28 +0300 > Sakari Ailus escreveu: > >> On Thu, May 03, 2018 at 04:52:51PM +0200, Hans Verkuil wrote: >>> From: Hans Verkuil >>> >>> The mdev field is only present if

Re: [PATCH v11] media: imx258: Add imx258 camera sensor driver

Hi Andy, Sorry, missed one problem in previous review. Would you be able to send a fixup patch? On Thu, May 3, 2018 at 12:38 AM Andy Yeh wrote: > From: Jason Chen > Add a V4L2 sub-device driver for the Sony IMX258 image sensor. > This is a camera

Re: [PATCH v2] media: v4l2-ioctl: fix function types for IOCTL_INFO_STD

Hi Sami, This looks much better. There is one thing that can be improved further though: On 05/07/2018 10:51 PM, Sami Tolvanen wrote: > This change fixes indirect call mismatches with Control-Flow Integrity > checking, which are caused by calling standard ioctls using a function > pointer that

Re: [PATCH v2] media: media-device: fix ioctl function types

Hi Sami, This is unchanged from the previous version, right? I've already added that to a pull request. If this v2 has changes, then let me know asap. Regards, Hans On 05/07/2018 08:09 PM, Sami Tolvanen wrote: > This change fixes function types for media device ioctls to avoid >

Re: [PATCHv13 12/28] v4l2-ctrls: add core request support

On 05/07/2018 08:06 PM, Mauro Carvalho Chehab wrote: > Em Thu, 3 May 2018 16:53:02 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Integrate the request support. This adds the v4l2_ctrl_request_complete >> and v4l2_ctrl_request_setup

Re: [PATCH v5 0/8] Add support for multi-planar formats and 10 bit formats

On 05/07/2018 07:45 PM, Hyun Kwon wrote: > Hi Hans, > > Thanks for the comment. > > On Mon, 2018-05-07 at 05:59:39 -0700, Hans Verkuil wrote: >> Hi Satish, >> >> On 03/05/18 04:42, Satish Kumar Nagireddy wrote: >>> The patches are for xilinx v4l. The patcheset enable support to handle >>>

Re: [PATCHv13 09/28] v4l2-ctrls: prepare internal structs for request API

On 05/07/2018 07:35 PM, Mauro Carvalho Chehab wrote: > Em Thu, 3 May 2018 16:52:59 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Embed and initialize a media_request_object in struct v4l2_ctrl_handler. >> >> Add a p_req field to struct

Re: [PATCHv13 06/28] v4l2-dev: lock req_queue_mutex

On 05/07/2018 07:20 PM, Mauro Carvalho Chehab wrote: > Em Thu, 3 May 2018 16:52:56 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> We need to serialize streamon/off with queueing new requests. >> These ioctls may trigger the cancellation

Re: [PATCHv13 04/28] media-request: add media_request_get_by_fd

On 05/07/2018 07:01 PM, Mauro Carvalho Chehab wrote: > Em Thu, 3 May 2018 16:52:54 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> Add media_request_get_by_fd() to find a request based on the file >> descriptor. >> >> The caller has to

Re: [PATCH] media: atomisp: fix spelling mistake: "diregard" -> "disregard"

On 2018-04-29 at 13:06:47 +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in ia_css_print message text Hi Colin, The atomisp drivers will soon EOL accorinding to the ML discussion. > > Signed-off-by: Colin Ian King

Re: [PATCH 2/2] media: v4l: Add new 10-bit packed grayscale format

Hi Sakari, On 7.05.2018 13:59, Sakari Ailus wrote: > Hi Todor, > > On Fri, Apr 27, 2018 at 02:40:39PM +0300, Todor Tomov wrote: >> The new format will be called V4L2_PIX_FMT_Y10P. >> It is similar to the V4L2_PIX_FMT_SBGGR10P family formats >> but V4L2_PIX_FMT_Y10P is a grayscale format. >> >>

[PATCH] media: i2c: tda1997: Fix an error handling path 'tda1997x_probe()'

If 'media_entity_pads_init()' fails, we must free the resources allocated by 'v4l2_ctrl_handler_init()', as already done in the previous error handling path. 'goto' the right label to fix it. Fixes: 9ac0038db9a7 ("media: i2c: Add TDA1997x HDMI receiver driver") Signed-off-by: Christophe JAILLET