("[media] mn88473: finalize driver")
Cc: <sta...@vger.kernel.org> # v4.8+
Signed-off-by: Antti Palosaari <cr...@iki.fi>
I can confirm that I saw something with regards to this one time before.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line &q
On 11/11/2016 02:55 PM, Mauro Carvalho Chehab wrote:
Em Thu, 10 Nov 2016 12:15:39 +0100
Benjamin,
Could you please test it?
Thanks!
Mauro
Hi, I the device is in use now. Can't test it with a new tree. I am
using an old tree for it.
MvH
Benjamin Larsson
--
To unsubscribe from this list
atch series addressing
this issue on the other drivers I touched.
Regards,
Mauro
Just for reference I got the following call trace a week ago. I looks
like this confirms that other drivers are affected also.
MvH
Benjamin Larsson
dvb-usb: found a 'Mygica T230 DVB-T/T2/C' in warm state.
BU
On 10/30/2016 01:22 PM, Benjamin Larsson wrote:
I got this for my anysee card:
dvb_usb_anysee: disagrees about version of symbol dvb_ca_en50221_init
dvb_usb_anysee: Unknown symbol dvb_ca_en50221_init (err -22)
dvb_usb_anysee: disagrees about version of symbol dvb_ca_en50221_release
00 02 00 00 00 4c 89 e7
RIP [] __mutex_lock_slowpath+0x98/0x130
RSP
CR2:
---[ end trace b28b9190ee8e4917 ]---
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
Mor
On 07/18/2016 01:59 PM, Mauro Carvalho Chehab wrote:
It would be
nice if both Philipp and Benjamin test such patch, for us to be sure
that it would work for both.
Regards,
Mauro
I added it to the dvbsky driver so I guess that Philipp has to do the
testing.
MvH
Benjamin Larsson
On 2016-06-07 09:52, Antti Palosaari wrote:
1 and 2 wasn't enough for mn88472 chip on Astrometa device,
so increase it to 3.
Signed-off-by: Antti Palosaari <cr...@iki.fi>
ACK
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media&q
On 05/21/2016 10:38 PM, Benjamin Larsson wrote:
The rtl2832 demod has 2 sets of PID filters. This patch enables
the filter support when using a slave demod.
Ignore this patch for now.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" i
The rtl2832 demod has 2 sets of PID filters. This patch enables
the filter support when using a slave demod.
Signed-off-by: Benjamin Larsson <benja...@southpole.se>
---
drivers/media/dvb-frontends/rtl2832.c | 21 ++---
drivers/media/dvb-frontends/rtl2832_priv.h |
?
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/21/2015 03:42 AM, Antti Palosaari wrote:
Patch looks acceptable, but it is broken in a mean it does not apply :(
I'll rebase on git://linuxtv.org/anttip/media_tree.git rtl2832u_pull.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-
this on the mn88473 version of this hardware
also. I just haven't had the time to test it. But I will postpone that
until the tests on the other bridges are done.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.
filters need to be forced.
The only reason would be that I suspected that high rates would not be
possible over the bridge and that this was the default mode for the
binary driver but as you proved that the bridge is able to support the
rate this patch can be nacked.
regards
Antti
MvH
Benjamin
pictures of the pcb and the chips. After that
it might be possible to identify what kind of device it is.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
On 12/12/2015 10:25 PM, Jiri Slaby wrote:
On 12/12/2015, 10:12 PM, Benjamin Larsson wrote:
On 12/12/2015 10:08 PM, Jiri Slaby wrote:
Hello,
I have a USB device which digitizes composite video into a MPEG-2 stream
(I think). It is an AF9035 device according to windows. But it has no
tuner
factor that would
fit in rack-mounted servers. You need high density and that is the only
way to get that. So I would say skip trying to find something cheap, get
something that is reliable and maintainable.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe
s2 card I could find cost ca
$60. So $50/mux is probably what you have to pay for this component if
you buy from a reseller.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majo
Signed-off-by: Benjamin Larsson <benja...@southpole.se>
---
drivers/media/dvb-core/dvb-usb-ids.h | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/media/dvb-core/dvb-usb-ids.h
b/drivers/media/dvb-core/dvb-usb-ids.h
index 1c1c298..d62ac1f 100644
--- a/drivers/media/dvb-core/d
Signed-off-by: Benjamin Larsson <benja...@southpole.se>
---
drivers/media/dvb-frontends/rtl2832.c | 21 ++---
drivers/media/dvb-frontends/rtl2832_priv.h | 1 +
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb-frontends/rtl2832.c
b/d
Signed-off-by: Benjamin Larsson <benja...@southpole.se>
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 35 -
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
-by: Benjamin Larsson <benja...@southpole.se>
---
drivers/staging/media/mn88472/mn88472.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index cf2e96b..80c5807 100644
--- a/drivers/s
Signed-off-by: Benjamin Larsson <benja...@southpole.se>
---
drivers/media/usb/dvb-usb-v2/dvbsky.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c
b/drivers/media/usb/dvb-usb-v2/dvbsky.c
index 1dd9625..2d922b9 100644
--- a/drivers/media/usb/dvb-
On 11/20/2015 02:27 PM, Honza Petrouš wrote:
2015-11-20 12:00 GMT+01:00 Benjamin Larsson <benja...@southpole.se>:
Hi, what tools can I use to test pid filter support in the drivers ?
Zap utility from dvbapps seems to be some simpler way - you can pass them
the fixed pids and record fi
Hi, what tools can I use to test pid filter support in the drivers ?
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to be no ready available
tool for that.
Adding pid selection to dvbv5-zap in monitor mode looks to be the best
way forward.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
-0018: firmware parity check succeeded=0x20
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
by Coverity CID 1295989.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
ACK
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
rfc patch you could base it on.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
register
I/O checks left ?
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
crashes on ubuntu 14.04 and I can't unload the
mn88473 module I will confirm this when I have an actual working version
of dvbv5-scan and Ubuntu.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
On 03/16/2015 11:57 PM, Antti Palosaari wrote:
On 03/17/2015 12:12 AM, Benjamin Larsson wrote:
Is this structure ok for the slave pid implementation? Or should there
be only one filters parameter? Will the overlaying pid filter framework
properly flush the set pid filters ?
Note that this code
Is this structure ok for the slave pid implementation? Or should there
be only one filters parameter? Will the overlaying pid filter framework
properly flush the set pid filters ?
Note that this code currently is only compile tested.
MvH
Benjamin Larsson
From
On 03/16/2015 11:44 PM, Antti Palosaari wrote:
On 03/16/2015 11:47 PM, Antti Palosaari wrote:
On 03/16/2015 12:57 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
Applied.
I found this does not work at least for DVB-C. After playing with
modulator I find
On 03/16/2015 10:04 PM, Antti Palosaari wrote:
On 03/16/2015 10:44 PM, Benjamin Larsson wrote:
On 03/15/2015 11:57 PM, Benjamin Larsson wrote:
Some devices have 2 demodulators, when this is the case
make the slave demod be listed first. Enumerating the slave
first will help legacy applications
On 03/15/2015 11:57 PM, Benjamin Larsson wrote:
Some devices have 2 demodulators, when this is the case
make the slave demod be listed first. Enumerating the slave
first will help legacy applications to use the hardware.
Ignore this patch for now. Stuff gets broken if applied.
/Benjamin
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88473/mn88473.c | 50 +++--
1 file changed, 48 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/mn88473/mn88473.c
b/drivers/staging/media/mn88473/mn88473.c
index a23e59e
Signed-off-by: Benjamin Larsson benja...@southpole.se
Reviewed-by: Antti Palosaari cr...@iki.fi
Signed-off-by: Antti Palosaari cr...@iki.fi
---
drivers/staging/media/mn88472/mn88472.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88473/mn88473.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/media/mn88473/mn88473.c
b/drivers/staging/media/mn88473/mn88473.c
index 84bd4fa..607ce4d 100644
--- a/drivers
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index 4a00a4d..c041fbf
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88473/mn88473.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/mn88473/mn88473.c
b/drivers/staging/media/mn88473/mn88473.c
index 607ce4d..a23e59e 100644
This will make the Astrometa DVB-T/T2/C usb stick be able to pick up
muxes around 290-314 MHz.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media
Some devices have 2 demodulators, when this is the case
make the slave demod be listed first. Enumerating the slave
first will help legacy applications to use the hardware.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 18
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 639c220..eaaf1dc 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers
The Astrometa device has issues with i2c transfers. Lowering the
poll time somehow makes these errors disappear.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb
The increase of the lock timeout is needed for dvb-t2.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b
@@
#include mt352.h
#include mt352_priv.h /* FIXME */
#include tda1002x.h
-#include drx39xyj/drx39xxj.h
+#include drx39xxj.h
This change looks unrelated.
The rest looks ok.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
On 02/23/2015 09:24 PM, Gilles Risch wrote:
On 02/22/2015 10:29 PM, Antti Palosaari wrote:
On 02/22/2015 10:04 PM, Benjamin Larsson wrote:
On 02/22/2015 02:47 PM, Gilles Risch wrote:
[...]
[ 141.423608] WARNING: You are using an experimental version of the
media stack.
[ 141.423609
On 02/23/2015 11:54 PM, Gilles Risch wrote:
On 02/23/2015 09:36 PM, Benjamin Larsson wrote:
On 02/23/2015 09:24 PM, Gilles Risch wrote:
On 02/22/2015 10:29 PM, Antti Palosaari wrote:
On 02/22/2015 10:04 PM, Benjamin Larsson wrote:
On 02/22/2015 02:47 PM, Gilles Risch wrote:
[...]
Not sure
?
The TerraTec H5 has a TDA18271 tuner.
Regards,
Gilles
So most likely the Elgato EyeTV hybrid is one of these combinations. And
it should quite feasible to add support for someone who knows the Empia
EM2884.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux
On 2014-12-06 01:25, Benjamin Larsson wrote:
The Astrometa device has issues with i2c transfers. Lowering the
poll time somehow makes these errors disappear.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +-
1 file changed, 1 insertion
On 2015-02-19 11:21, Antti Seppälä wrote:
On 19 February 2015 at 11:43, Benjamin Larsson benja...@southpole.se wrote:
On 2015-02-19 10:13, Antti Seppälä wrote:
It seems that currently the firmware download on the mn88472 is
somehow wrong for my Astrometa HD-901T2.
Reducing the download chunk
the workaround patch I sent for this.
[PATCH 1/3] rtl28xxu: lower the rc poll time to mitigate i2c transfer errors
I now see that it hasn't been merged. But I have been running with this
patch for a few months now without any major issues.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line
) should be working fine. DVB-T2 needs
working pid filters before it can work properly.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 8e040cf..639c220 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers
://support.sundtek.com/
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01/19/2015 02:15 PM, Hans Verkuil wrote:
On 12/06/2014 09:26 PM, Benjamin Larsson wrote:
Well I guess I am biased as I have spent lots of time finding a bug that
probably wouldn't exist if the policy was that drivers always should set
their memory to zero before it is free'd.
Just because
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index 8e040cf..c94c6a3 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/media/tuners/r820t.c b/drivers/media/tuners/r820t.c
index c94c6a3..b4c85ba 100644
--- a/drivers/media/tuners/r820t.c
+++ b/drivers/media
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88473/mn88473.c | 27 ++-
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/media/mn88473/mn88473.c
b/drivers/staging/media/mn88473/mn88473.c
index b65e519
Add xtal as a configuration parameter so it can be used
in the IF register value calculation. If not set in the
configuration then use a default value.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/dvb-frontends/mn88473.h| 6 ++
drivers/staging/media
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 26 +++---
1 file changed, 19 insertions(+), 7 deletions(-)
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
index ab48b5f
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 41 +++--
1 file changed, 14 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index
enough.
The code that could be shared is not enough to give any advantage over 2
drivers.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
really long time to get them). If I reload
the rtl28xxu driver 2 times it starts working again. Could this change
be related to such errors ?
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
Factor out the bw_val data to a table and load data from it
depending on the configured demod.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/dvb-frontends/mn88472.h| 30 +
drivers/staging/media/mn88472/mn88472.c | 66
to the xtal parameter.
So does the mn88473 support look ok and should the driver figure out
what demod is connected ?
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
The increase of the lock timeout is needed for dvb-t2.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 24
1 file changed, 20 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b
Hello.
On 12/16/2014 04:34 AM, Antti Palosaari wrote:
Moikka!
On 12/16/2014 01:40 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 23 ---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index 68f5036..426f0ed
changing it to 0. I look my tree FE
ID is 0. Do you have some unpublished hacks?
No hacks, it works for me that way.
Antti
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
On 12/13/2014 05:15 AM, Antti Palosaari wrote:
On 12/13/2014 02:18 AM, Benjamin Larsson wrote:
Signed-off-by: Benjamin Larsson benja...@southpole.se
Reviewed-by: Antti Palosaari cr...@iki.fi
Even I could accept that, as a staging driver, I see there some issues:
* missing commit message
On 12/13/2014 04:52 AM, Antti Palosaari wrote:
That breaks DVB-C lock check as old utmp = 0x08 was set according to
DVB-C lock check, right?
Antti
I have a dvb-c setup now. I will respin this patch with dvb-c support
tested properly.
MvH
Benjamin Larsson
--
To unsubscribe from this list
so consider the patch dropped.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index 4d80046..746cc94 100644
--- a/drivers
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index 107552a..4d80046 100644
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
b/drivers/media/usb/dvb-usb-v2/rtl28xxu.c
index ab48b5f..cdc342a 100644
On 12/07/2014 11:36 PM, Antti Palosaari wrote:
On 12/08/2014 12:10 AM, Benjamin Larsson wrote:
The firmware must be loaded one byte at a time via the 0xf6 register.
I don't think so. Currently it downloads firmware in 22 byte chunks
and it seems to work, at least for me, both mn88472
On 12/07/2014 11:36 PM, Antti Palosaari wrote:
On 12/08/2014 12:10 AM, Benjamin Larsson wrote:
The firmware must be loaded one byte at a time via the 0xf6 register.
I don't think so. Currently it downloads firmware in 22 byte chunks
and it seems to work, at least for me, both mn88472
the check succeeded but the demodulator
didn't deliver data. So I guess that the parity checker is before the 16
byte buffer and if you write more the data is
just ignored.
I will send an updated patch based on this.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index df7dbe9..1df85a7 100644
--- a/drivers
The max amount of payload bytes in each i2c transfer when
loading the demodulator firmware is 16 bytes.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
adapter which cannot write even 17 bytes.
2nd thing is to add comment mn88472.h to specify that max limit and
that's all.
regards
Antti
Ok, I'll do that.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 21 +
drivers/staging/media/mn88472/mn88472_priv.h | 558 +++
2 files changed, 579 insertions(+)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers
The firmware must be loaded one byte at a time via the 0xf6 register.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472
. At least when
the card is set in dvb mode, for sdr mode this might not be an issue.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
The current dvb framework contain several other cases where pointers are
feed'd but not nulled.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
always should set
their memory to zero before it is free'd. Maybe we should have a compile
time override so that all free calls zeroes the memory before the actual
free? Maybe there already is this kind of feature?
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index c6895ee..be8a6d5 100644
--- a/drivers
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/dvb-frontends/mn88472.h| 12 +++
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 ++
drivers/staging/media/mn88472/mn88472.c | 30 ++--
drivers/staging/media/mn88472
Using this driver with the attach dvb model might trigger a use
after free when unloading the driver. With this change the driver
will always fail on unload instead of randomly crash depending
on if the memory has been reused or not.
Signed-off-by: Benjamin Larsson benja...@southpole.se
The Astrometa device has issues with i2c transfers. Lowering the
poll time somehow makes these errors disappear.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb
the subsystem and the driver
is still in staging for a reason.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 12/02/2014 03:31 PM, Antti Palosaari wrote:
Convert that driver to I2C driver model.
Legacy DVB binding is left also for later removal...
Signed-off-by: Antti Palosaari cr...@iki.fi
Works fine. Thanks for the quick fix.
Tested-by: Benjamin Larsson benja...@southpole.se
MvH
Benjamin
could confirm my findings.
Applying the same kind of code like my patch and unplug something that
uses the affected frontend should be enough.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
on what might be causing this issue or how
to track it down ?
Keep in mind that this could be caused by me running the media_build
code or some bug in the driver. Or it could also affect the regular tree
when unplugging devices with more then 1 frontend.
MvH
Benjamin Larsson
diff --git
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/staging/media/mn88472/mn88472.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/media/mn88472/mn88472.c
b/drivers/staging/media/mn88472/mn88472.c
index f648b58..36ef39b 100644
--- a/drivers/staging/media
Add xtal as a configuration parameter so it can be used
in the IF register value calculation.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/dvb-frontends/mn88472.h| 6 ++
drivers/media/usb/dvb-usb-v2/rtl28xxu.c | 1 +
drivers/staging/media/mn88472
obtainable way.
MvH
Benjamin Larsson
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Correct the initialization values at the start of the function
and use proper variable sizes to prevent overflow.
Signed-off-by: Benjamin Larsson benja...@southpole.se
---
drivers/media/tuners/r820t.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/tuners
1 - 100 of 106 matches
Mail list logo