Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

On 11/14/2018 05:58 AM, Sakari Ailus wrote: > On Tue, Nov 13, 2018 at 07:04:01PM +0800, Bing Bu Cao wrote: >> >> On 11/13/2018 06:31 PM, Sakari Ailus wrote: >>> Hi Bing Bu, >>> >>> On Mon, Nov 12, 2018 at 12:31:16PM +0800, Bing Bu Cao wrote: >&

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

On 11/13/2018 06:31 PM, Sakari Ailus wrote: > Hi Bing Bu, > > On Mon, Nov 12, 2018 at 12:31:16PM +0800, Bing Bu Cao wrote: >> >> On 11/09/2018 06:09 PM, Sakari Ailus wrote: >>> Hi Bing Bu, >>> >>> On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing B

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

On 11/09/2018 06:09 PM, Sakari Ailus wrote: > Hi Bing Bu, > > On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: >> On 11/01/2018 08:03 PM, Sakari Ailus wrote: >>> Hi Yong, >>> >>> Thanks for the update! >>> >>> On Mo

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

On 11/01/2018 08:03 PM, Sakari Ailus wrote: > Hi Yong, > > Thanks for the update! > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: >> Hi, >> >> This series adds support for the Intel IPU3 (Image Processing Unit) >> ImgU which is essentially a modern memory-to-memory ISP. It

Re: [PATCH] media: dvb: fix a missing-check bug

I think need Cc to Lad, Prabhakar On 10/30/2018 02:46 AM, Wenwen Wang wrote: > Hello, > > Can anyone confirm this bug? Thanks! > > Wenwen > > On Fri, Oct 19, 2018 at 9:12 AM Wenwen Wang wrote: >> In dvb_audio_write(), the first byte of the user-space buffer 'buf' is >> firstly copied and

Re: [PATCH 1/2] ipu3-cio2: Unregister device nodes first, then release resources

On 10/15/2018 04:39 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Mon, Oct 15, 2018 at 03:15:05PM +0800, Bing Bu Cao wrote: >> On 10/10/2018 04:32 PM, Sakari Ailus wrote: >>> While there are issues related to object lifetime management, unregister >>> the media d

Re: [PATCH 1/2] ipu3-cio2: Unregister device nodes first, then release resources

On 10/10/2018 04:32 PM, Sakari Ailus wrote: > While there are issues related to object lifetime management, unregister > the media device first, followed immediately by other device nodes when > the driver is being unbound. Only then the resources needed by the driver > may be released. This is

Re: [PATCH] media: intel-ipu3: cio2: Remove redundant definitions

On 10/11/2018 05:33 PM, Kieran Bingham wrote: > Hi Rajmohan > > Thank you for the patch, > > On 10/10/18 00:42, Rajmohan Mani wrote: >> Removed redundant CIO2_IMAGE_MAX_* definitions >> >> Fixes: c2a6a07afe4a ("media: intel-ipu3: cio2: add new MIPI-CSI2 driver") >> >> Signed-off-by: Rajmohan

Re: [PATCH 2/2] ipu3-cio2: Use cio2_queues_exit

Tested-by: Bingbu Cao Reviewed-by: Bingbu Cao On 10/10/2018 04:32 PM, Sakari Ailus wrote: > The ipu3-cio2 driver has a function to tear down video devices as well as > the associated video buffer queues. Use it. > > Signed-off-by: Sakari Ailus > --- > drivers/media/pci/intel/ipu3/ipu3-cio2.c

Re: [PATCH 1/2] ipu3-cio2: Unregister device nodes first, then release resources

Tested-by: Bingbu Cao Reviewed-by: Bingbu Cao On 10/10/2018 04:32 PM, Sakari Ailus wrote: > While there are issues related to object lifetime management, unregister > the media device first, followed immediately by other device nodes when > the driver is being unbound. Only then the resources

Re: [PATCH v7] media: add imx319 camera sensor driver

On 09/26/2018 03:57 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Wed, Sep 26, 2018 at 10:42:18AM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2

Re: [PATCH v6] media: add imx319 camera sensor driver

On 09/25/2018 03:33 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Tue, Sep 25, 2018 at 02:59:05PM +0800, Bing Bu Cao wrote: >> >> On 09/25/2018 11:57 AM, Bing Bu Cao wrote: >>> On 09/21/2018 08:06 PM, Sakari Ailus wrote: >>>> Hi Bingbu, >>>>

Re: [PATCH v6] media: add imx319 camera sensor driver

On 09/25/2018 11:57 AM, Bing Bu Cao wrote: > > On 09/21/2018 08:06 PM, Sakari Ailus wrote: >> Hi Bingbu, >> >> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >>> From: Bingbu Cao >>> >>> Add a v4l2 sub-device driver for

Re: [PATCH v6] media: add imx319 camera sensor driver

On 09/21/2018 08:06 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2

Re: [PATCH v5] media: add imx319 camera sensor driver

On 09/21/2018 03:41 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: > ... >>>> + try_fmt->field = V4L2_FIELD_NONE; >>>> + >>>> + mutex_unlock(>mutex); >>>> + >>&g

Re: [PATCH v5] media: add imx319 camera sensor driver

On 09/17/2018 07:34 PM, Sakari Ailus wrote: > Hi Bingbu, > > Thanks for the update! A few more small comments, I think we're done after > these. > > On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319

Re: [PATCH v5] media: add imx319 camera sensor driver

Ack, I will add more explanation into the code. On 09/19/2018 12:11 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > [snip] >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) >> +{ >> + int ret; >> + >> + ret =

Re: [PATCH v5] media: add imx319 camera sensor driver

On 09/18/2018 05:49 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2 bus for data. > Please see my

Re: [PATCH v5] media: add imx319 camera sensor driver

Ack. On 09/17/2018 07:34 PM, Sakari Ailus wrote: > Hi Bingbu, > > Thanks for the update! A few more small comments, I think we're done after > these. > > On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony

Re: [PATCH v4] media: add imx319 camera sensor driver

On 06/26/2018 11:15 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Thu, May 31, 2018 at 06:19:24PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2

Re: [PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 2018年06月21日 19:25, Sakari Ailus wrote: > On Tue, Jun 19, 2018 at 02:01:47PM +0800, bingbu@intel.com wrote: >> +static int ak7375_probe(struct i2c_client *client) >> +{ >> +struct ak7375_device *ak7375_dev; >> +int val; >> + >> +ak7375_dev = devm_kzalloc(>dev,

Re: [PATCH v5 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 2018年06月21日 19:23, Sakari Ailus wrote: > Hi Bingbu, > > On Tue, Jun 19, 2018 at 02:01:47PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the ak7375 lens voice coil. >> This is a voice coil module using the i2c bus to control the >> focus

Re: [PATCH v4 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 2018年06月14日 21:02, Sakari Ailus wrote: > Hi Bingbu, > > Thanks for the update. A few comments below; then I think we're done... > > On Thu, Jun 07, 2018 at 11:50:33AM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the ak7375 lens voice coil. >>

Re: [PATCH v3 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 2018年06月06日 00:40, Mani, Rajmohan wrote: > Hi Bingbu, > >> -Original Message----- >> From: Bing Bu Cao [mailto:bingbu@linux.intel.com] >> Sent: Monday, June 04, 2018 11:27 PM >> To: Mani, Rajmohan ; Cao, Bingbu >> ; linux-media@vger.kernel.org >

Re: [PATCH v3 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 20180605 08:23, Mani, Rajmohan wrote: Hi Bingbu, Please see a couple of comments below. -Original Message- From: Cao, Bingbu Sent: Monday, June 04, 2018 2:00 AM To: linux-media@vger.kernel.org Cc: sakari.ai...@linux.intel.com; tf...@google.com; jac...@jmondi.org; Mani, Rajmohan

Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 2018年06月01日 17:42, Sakari Ailus wrote: On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote: +static int ak7375_i2c_write(struct ak7375_device *ak7375, + u8 addr, u16 data, int size) +{ + struct i2c_client *client = v4l2_get_subdevdata(>sd); + int ret; +

Re: [RESEND PATCH V2 2/2] media: ak7375: Add ak7375 lens voice coil driver

On 2018年06月01日 17:34, Sakari Ailus wrote: Hi Bingbu, A few comments below. On Fri, May 25, 2018 at 05:55:35PM +0800, bingbu@intel.com wrote: From: Bingbu Cao Add a V4L2 sub-device driver for the ak7375 lens voice coil. This is a voice coil module using the I2C bus to control the

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

On 2018年05月23日 04:08, jacopo mondi wrote: Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: From: Bingbu Cao Add a V4L2 sub-device driver for the Sony IMX319 image sensor. This is a camera sensor using the I2C

Re: [PATCH v2 1/3] media: dw9807: Add dw9807 vcm driver

Please ignore this patch. On 2018年05月21日 15:10, bingbu@intel.com wrote: From: Alan Chiang DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor. This driver creates a V4L2 subdevice and provides control to set the desired focus.

Re: [PATCH v2 2/3] media: imx258: Add imx258 camera sensor driver

Please ignore thispatch. On 2018年05月21日 15:10, bingbu@intel.com wrote: From: Jason Chen Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh