[PATCH 7/8] ir-core: fix table resize during keymap init

2010-04-15 Thread David Härdeman
drivers/media/IR/ir-keytable.c would alloc a suitably sized keymap table only to have it resized as it is populated with the initial keymap. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-keytable.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions

Re: [PATCH 0/8] Series short description

2010-04-15 Thread David Härdeman
On Thu, Apr 15, 2010 at 11:45:55PM +0200, David Härdeman wrote: The following series implements the suggested change to ir-core to use a 1:31 struct for pulse/space durations, adds two new raw decoders, converts two users of ir-functions to plain ir-core and fixes a few small bugs in ir-core

Re: [RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-10 Thread David Härdeman
on this approch, I'll write a patch to convert ir-core to use it instead. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/4] Add RC6 support to ir-core

2010-04-10 Thread David Härdeman
On Fri, Apr 09, 2010 at 09:12:08PM -0400, Andy Walls wrote: On Fri, 2010-04-09 at 01:04 +0200, David Härdeman wrote: diff --git a/drivers/media/IR/ir-rc6-decoder.c b/drivers/media/IR/ir-rc6-decoder.c new file mode 100644 index 000..ccc5be2 --- /dev/null +++ b/drivers/media/IR/ir

Re: [PATCH 4/4] Add RC6 support to ir-core

2010-04-10 Thread David Härdeman
On Fri, Apr 09, 2010 at 09:12:08PM -0400, Andy Walls wrote: On Fri, 2010-04-09 at 01:04 +0200, David Härdeman wrote: +again: + IR_dprintk(2, RC6 decode started at state %i (%i units, %ius)\n, + data-state, u, TO_US(duration)); + + if (DURATION(u) == 0 data-state

Re: [PATCH 4/4] Add RC6 support to ir-core

2010-04-09 Thread David Härdeman
? (and by the way, Mauro, how come the patches went straight to the v4l-dvb.git tree? I assume they'll be merged back to your ir.git tree at a later stage?) -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-08 Thread David Härdeman
On Thu, Apr 08, 2010 at 02:10:40AM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote: o The RX decoding is now handled via a workqueue (I can break that up into a separate patch later, but I think it helps the discussion to have it in for now), with inspiration from Andy's

[RFC3] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-08 Thread David Härdeman
: IR_PULSE); + ir_raw_event_store_edge(dev-remote-dev, space ? IR_SPACE : IR_PULSE); /* -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-08 Thread David Härdeman
perhaps make sense to remove ir_raw_event_handle() and call schedule_work() from every call to ir_raw_event_store()? One thing less for IR drivers to care about... -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-08 Thread David Härdeman
if you feel it is important) Signed-off-by: David Härdeman da...@hardeman.nu Index: ir/drivers/media/IR/ir-raw-event.c === --- ir.orig/drivers/media/IR/ir-raw-event.c 2010-04-08 12:30:28.036098192 +0200 +++ ir/drivers/media/IR/ir

[PATCH 2/4] Add RC5x support to ir-core

2010-04-08 Thread David Härdeman
This patch adds RC5x support to drivers/media/IR/ir-rc5-decoder.c Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-rc5-decoder.c | 78 - 1 files changed, 59 insertions(+), 19 deletions(-) diff --git a/drivers/media/IR/ir-rc5-decoder.c

[PATCH 3/4] Add NECx support to ir-core

2010-04-08 Thread David Härdeman
This patch adds NECx support to drivers/media/IR/ir-nec-decoder.c Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-nec-decoder.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/IR/ir-nec-decoder.c b/drivers/media/IR/ir-nec

[PATCH 4/4] Add RC6 support to ir-core

2010-04-08 Thread David Härdeman
This patch adds an RC6 decoder (modes 0 and 6A) to ir-core. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/Kconfig |9 + drivers/media/IR/Makefile |1 drivers/media/IR/ir-core-priv.h |7 + drivers/media/IR/ir-raw-event.c |1 drivers

Re: [patch 3/3] Convert drivers/media/dvb/ttpci/budget-ci.c to use ir-core

2010-04-08 Thread David Härdeman
been dropped (I even sent the same thing as part of my latest patch series before I read this mail, but if you can fixup the original patch that'd be even better). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [PATCH 00/15] ir-core: Several improvements to allow adding LIRC and decoder plugins

2010-04-07 Thread David Härdeman
On Mon, Apr 05, 2010 at 04:49:10PM -0400, Jarod Wilson wrote: On Fri, Apr 2, 2010 at 6:20 AM, David Härdeman da...@hardeman.nu wrote: Porting the msmce driver to rc-core will be high on my list of priorities once I've done some more changes to the API. Very cool. Though note

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
On Tue, Apr 06, 2010 at 11:26:35AM -0300, Mauro Carvalho Chehab wrote: Hi David, Em Tue, 6 Apr 2010 12:48:11 +0200 David Härdeman da...@hardeman.nu escreveu: Content-Type: text/plain; charset=us-ascii Content-Disposition: inline; filename=use-pulse-space-timings-in-ir-raw Thunderbird

Re: [RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
state after 1 us of silence. The ir_raw_event_duration() function of my patch is intended for exactly this kind of hardware (which I mentioned in my reply to Mauro which I just sent out). The question is though, is the kfifo and work handler really necessary? -- David Härdeman

[RFC2] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-07 Thread David Härdeman
); saa_setb(SAA7134_GPIO_GPMODE3, SAA7134_GPIO_GPRESCAN); space = saa_readl(SAA7134_GPIO_GPSTATUS0 2) ir-mask_keydown; - ir_raw_event_store(dev-remote-dev, space ? IR_SPACE : IR_PULSE); + ir_raw_event_store_edge(dev-remote-dev, space ? IR_SPACE : IR_PULSE); /* -- David

[RFC] Teach drivers/media/IR/ir-raw-event.c to use durations

2010-04-06 Thread David Härdeman
drivers/media/IR/ir-raw-event.c is currently written with the assumption that all raw hardware will generate events only on state change (i.e. when a pulse or space starts). However, some hardware (like mceusb, probably the most popular IR receiver out there) only generates duration data (and

Re: [PATCH 00/15] ir-core: Several improvements to allow adding LIRC and decoder plugins

2010-04-02 Thread David Härdeman
. It basically adds a raw decoder layer at ir-core, allowing decoders to plug into IR core, and preparing for the addition of a lirc_dev driver that will allow raw IR codes to be sent to userspace. There's no lirc patch in this series. I have also a few other patches from David Härdeman

[PATCH] drivers/media/IR - improve keyup/keydown logic

2010-04-01 Thread David Härdeman
detail in ir-core. Mauro, once this patch is merged I'll start working on patches to migrate drivers which use ir_input_* in ir-functions.c over to the ir-keytable.c code instead. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-keytable.c| 127

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-30 Thread David Härdeman
to n is appropriate) and, possibly: 3) Userspace wants to know what keycode (if any) scancode X generates (In which case approach 2 will work just as well, but this usecase seems a bit contrived anyway...) -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-30 Thread David Härdeman
the undersized scancode into its expected size. That way the interface will be binary-forwards-compatible even if scancode sizes are increased at some later date. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH] drivers/media/IR - improve keytable code

2010-03-28 Thread David Härdeman
with a different scancode and the same keycode. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/IR/ir-keymaps.c |2 + drivers/media/IR/ir-keytable.c | 516 ++- include/media/ir-core.h|4 +- 3 files changed, 190 insertions(+), 332

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-27 Thread David Härdeman
done, save keymap. Load keymap at boot. Configfs or ioctl or sysfs or netlink or blorkfs is a detail which won't matter to those users. -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-26 Thread David Härdeman
On Thu, Mar 25, 2010 at 07:32:59PM +0100, Pavel Machek wrote: struct keycode_table_entry { unsigned keycode; int len; char scancode[]; } ? gcc extension, but commonly used around kernel. Flexible array members are ok in C99, aren't they? -- David Härdeman

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-26 Thread David Härdeman
hardware will need to be reset after each parameter is changed). Then you'll end up with a few things being controlled via sysfs and some being controlled via ioctls. Maybe it's a good idea to have a bitmask of supported and enabled protocols in those ioctls instead? -- David Härdeman

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-26 Thread David Härdeman
(and RX/TX parameter setting ioctl's). The same chardev can be used for IR blasting (by writing data to it once TX parameters have been set). -- David Härdeman -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-26 Thread David Härdeman
On Fri, Mar 26, 2010 at 02:22:51PM -0300, Mauro Carvalho Chehab wrote: Dmitry Torokhov wrote: On Fri, Mar 26, 2010 at 11:40:41AM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote: I'd suggest: struct keycode_table_entry { unsigned keycode; unsigned index; unsigned len

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2010-03-26 Thread David Härdeman
On Fri, Mar 26, 2010 at 12:17:34PM -0300, Mauro Carvalho Chehab wrote: David Härdeman wrote: On Thu, Mar 25, 2010 at 11:42:33AM -0300, Mauro Carvalho Chehab wrote: 2) add current_protocol support on other drivers; Done. Patch were already merged upstream. The current_protocol

<    1   2   3   4   5   6