Re: [PATCH v2] media: rockchip vpu: remove some unused vars

2018-12-06 Thread Ezequiel Garcia
': > drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c:560:33: warning: > variable 'vpu_fmt' set but not used [-Wunused-but-set-variable] > const struct rockchip_vpu_fmt *vpu_fmt; >^~~ > > Signed-off-by: Mauro Carvalho

[PATCH v3] v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields

2018-12-06 Thread Ezequiel Garcia
Make the core set the reserved fields to zero in vv4l2_pix_format_mplane.4l2_plane_pix_format, for _MPLANE queue types. Moving this to the core avoids having to do so in each and every driver. Suggested-by: Tomasz Figa Signed-off-by: Ezequiel Garcia Acked-by: Sakari Ailus -- v3: * s/int

Re: [GIT PULL FOR v4.21] Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
t; git://linuxtv.org/hverkuil/media_tree.git tags/br-rkjpeg2 > > > > > > for you to fetch changes up to 7f608cfd52c08e7d84bd38438e330c26263eddcb: > > > > > > media: add Rockchip VPU JPEG encoder driver (2018-12-05 17:18:46 +0100) > > > > > >

[PATCH v12] media: add Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- Changes from v11: * Fix buffer timecode * Add a comment explaining dma attributes * Fix wrong parenthesis * Remove

Re: [PATCH v11 4/4] media: add Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
Hi Hans, On Wed, 2018-12-05 at 16:01 +0100, Hans Verkuil wrote: > On 11/30/18 18:34, Ezequiel Garcia wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > > Currently only JPEG encoding is supported, for RK3399 and RK3288 > > platforms. > > > &g

Re: [PATCH v11 4/4] media: add Rockchip VPU JPEG encoder driver

2018-12-05 Thread Ezequiel Garcia
On Wed, 2018-12-05 at 16:01 +0100, Hans Verkuil wrote: > Unless something unexpected happens, then v12 should be the final > version and I'll make a pull request for it. Note that it will > probably won't make 4.20, unless you manage to do it within the next > hour :-) Challenge accepted!

[PATCH v11 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-30 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Reviewed-by: Tomasz Figa Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion

[PATCH v11 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-30 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v11 0/4] Add Rockchip VPU JPEG encoder

2018-11-30 Thread Ezequiel Garcia
ns. * Fix TODO file v8: * Drop new JPEG_RAW format. * Drop quantization table user controls. * Add JPEG headers to produce JPEG frames. Ezequiel Garcia (4): media: dt-bindings: Document the Rockchip VPU bindings ARM: dts: rockchip: add VPU device node for RK3288 arm64: dts: rockchip: add

[PATCH v11 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-30 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Reviewed-by: Tomasz Figa Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13

[PATCH v11 1/4] media: dt-bindings: Document the Rockchip VPU bindings

2018-11-30 Thread Ezequiel Garcia
Add devicetree binding documentation for Rockchip Video Processing Unit IP. Reviewed-by: Rob Herring Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29 +++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-28 Thread Ezequiel Garcia
On Tue, 2018-11-27 at 19:09 +0900, Tomasz Figa wrote: > On Fri, Nov 23, 2018 at 5:24 AM Ezequiel Garcia > wrote: > [snip] > > > > +const struct rockchip_vpu_variant rk3288_vpu_variant = { > > > > + .enc_offset = 0x0, > > >

[PATCH v2] v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields

2018-11-27 Thread Ezequiel Garcia
Make the core set the reserved fields to zero in vv4l2_pix_format_mplane.4l2_plane_pix_format, for _MPLANE queue types. Moving this to the core avoids having to do so in each and every driver. Suggested-by: Tomasz Figa Signed-off-by: Ezequiel Garcia -- v2: * Drop unneeded clear in g_fmt

Re: [PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-27 Thread Ezequiel Garcia
On Tue, 2018-11-27 at 16:59 +0900, Tomasz Figa wrote: > On Tue, Nov 27, 2018 at 8:29 AM Ezequiel Garcia > wrote: > > On Mon, 2018-11-26 at 13:14 +0900, Tomasz Figa wrote: > > > Hi Ezequiel, > > > > > > On Sat, Nov 24, 2018 at 2:20 AM Ezequiel Garcia

Re: [PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-26 Thread Ezequiel Garcia
On Mon, 2018-11-26 at 13:14 +0900, Tomasz Figa wrote: > Hi Ezequiel, > > On Sat, Nov 24, 2018 at 2:20 AM Ezequiel Garcia > wrote: > > Make the core set the reserved fields to zero in > > v4l2_pix_format_mplane and v4l2_plane_pix_format structs, > > for _MPLAN

[PATCH] v4l2-ioctl: Zero v4l2_pix_format_mplane reserved fields

2018-11-23 Thread Ezequiel Garcia
Make the core set the reserved fields to zero in v4l2_pix_format_mplane and v4l2_plane_pix_format structs, for _MPLANE queue types. Moving this to the core avoids having to do so in each and every driver. Suggested-by: Tomasz Figa Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core

Re: [PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-22 Thread Ezequiel Garcia
On Thu, 2018-11-22 at 19:20 +0900, Tomasz Figa wrote: > Hi Ezequiel, > > On Thu, Nov 22, 2018 at 4:59 AM Ezequiel Garcia > wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > > Currently only JPEG encoding is supported, for RK3399 and RK3288 > &

[PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-21 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-21 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v10 0/4] Add Rockchip VPU JPEG encoder

2018-11-21 Thread Ezequiel Garcia
. Ezequiel Garcia (4): media: dt-bindings: Document the Rockchip VPU bindings ARM: dts: rockchip: add VPU device node for RK3288 arm64: dts: rockchip: add VPU device node for RK3399 media: add Rockchip VPU JPEG encoder driver .../bindings/media/rockchip-vpu.txt | 29 + MAINTAINERS

[PATCH v10 1/4] media: dt-bindings: Document the Rockchip VPU bindings

2018-11-21 Thread Ezequiel Garcia
Add devicetree binding documentation for Rockchip Video Processing Unit IP. Reviewed-by: Rob Herring Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29 +++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v10 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-21 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

[PATCH v9 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-20 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v9 2/3] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-20 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v9 1/3] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-20 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

[PATCH v9 0/3] Add Rockchip VPU JPEG encoder

2018-11-20 Thread Ezequiel Garcia
test blocking wait: OK Video Capture Multiplanar: Captured 57 buffers test MMAP: OK test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 48, Succeeded: 48, Failed: 0, Warnings: 0 Ezequiel Garcia (3): ARM: dts: rockchi

Re: [PATCH v8 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-20 Thread Ezequiel Garcia
On Tue, 2018-11-20 at 14:52 +0100, Hans Verkuil wrote: > On 11/19/2018 04:29 PM, Ezequiel Garcia wrote: > > Add a mem2mem driver for the VPU available on Rockchip SoCs. > > Currently only JPEG encoding is supported, for RK3399 and RK3288 > > platforms. > > > &g

Re: [ANN] Edinburgh Media Summit 2018 meeting report

2018-11-19 Thread Ezequiel Garcia
> > > https://www.spinics.net/lists/linux-media/msg141095.html> > > > > The raw notes can be found here: > > > > http://www.retiisi.org.uk/~sailus/v4l2/notes/osseu18-media.html> > > Thanks Sakari for editing the notes. Let me share my thoughts inli

Re: [PATCH] videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()

2018-11-19 Thread Ezequiel Garcia
ut a 0 value for bytesused. > > Just drop the WARN_ON as it serves no purpose. > > Signed-off-by: Hans Verkuil Acked-by: Ezequiel Garcia > --- > diff --git a/drivers/media/common/videobuf2/videobuf2-v4l2.c > b/drivers/media/common/videobuf2/videobuf2-v4l2.c > ind

[PATCH v8 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-19 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v8 2/3] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-19 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v8 1/3] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-19 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

[PATCH v8 0/3] Add Rockchip VPU JPEG encoder

2018-11-19 Thread Ezequiel Garcia
/write: OK (Not Supported) test blocking wait: OK Video Capture Multiplanar: Captured 57 buffers test MMAP: OK test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 48, Succeeded: 48, Failed: 0, Warnings: 0 Ezequiel Garcia (3):

[PATCH] v4l2-compliance: Remove spurious error messages

2018-11-19 Thread Ezequiel Garcia
message "pix_mp.plane_fmt[0].reserved not zeroed" is accurate. Signed-off-by: Ezequiel Garcia --- utils/v4l2-compliance/v4l2-test-formats.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-12 Thread Ezequiel Garcia
On Mon, 12 Nov 2018 at 13:52, Paul Kocialkowski wrote: > > Hi, > > On Sun, 2018-11-11 at 18:26 -0300, Ezequiel Garcia wrote: > > On Thu, 2018-10-18 at 15:02 -0300, Ezequiel Garcia wrote: > > > This series goal is to avoid drivers from having ad-hoc code > > &g

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-11 Thread Ezequiel Garcia
On Thu, 2018-10-18 at 15:02 -0300, Ezequiel Garcia wrote: > This series goal is to avoid drivers from having ad-hoc code > to call .device_run in non-atomic context. Currently, .device_run > can be called via v4l2_m2m_job_finish(), not only running > in interrupt context, but also crea

Re: [RFC v2 1/4] media: Introduce helpers to fill pixel format structs

2018-11-10 Thread Ezequiel Garcia
On Fri, 2018-11-02 at 12:52 -0300, Ezequiel Garcia wrote: > Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, > to be used by drivers to calculate plane sizes and bytes per lines. > > Note that driver-specific paddig and alignment are not yet > taken into account.

Re: [PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-10 Thread Ezequiel Garcia
On Sat, 2018-11-10 at 12:09 +0100, Hans Verkuil wrote: > On 11/10/2018 12:01 PM, Ezequiel Garcia wrote: > > On Sat, 2018-11-10 at 11:29 +0100, Hans Verkuil wrote: > > > On 11/09/2018 10:52 PM, Ezequiel Garcia wrote: > > > > This tool allows to find a device by drive

Re: [PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-10 Thread Ezequiel Garcia
On Sat, 2018-11-10 at 11:29 +0100, Hans Verkuil wrote: > On 11/09/2018 10:52 PM, Ezequiel Garcia wrote: > > This tool allows to find a device by driver name, > > this is useful for scripts to be written in a generic way. > > Why not add support for this to v4l2-sy

[PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-09 Thread Ezequiel Garcia
This tool allows to find a device by driver name, this is useful for scripts to be written in a generic way. Usage: v4l2-get-device -d uvcvideo -c V4L2_CAP_VIDEO_CAPTURE /dev/video0 /dev/video2 Signed-off-by: Ezequiel Garcia --- configure.ac| 1 + utils

[PATCH] Revert "media: dt-bindings: Document the Rockchip VPU bindings"

2018-11-09 Thread Ezequiel Garcia
This reverts commit e4183d3256e3cd668e899d06af66da5aac3a51af. The commit was picked by mistake, as the Rockchip VPU driver is not ready for inclusion yet, and it's still under discussion. Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29

Re: [Outreachy kernel] [PATCH vicodec v4 0/3] Add support to more pixel formats in vicodec

2018-11-08 Thread Ezequiel Garcia
On Thu, 8 Nov 2018 at 14:54, Sasha Levin wrote: > > On Thu, Nov 08, 2018 at 10:10:10AM +0200, Dafna Hirschfeld wrote: > >On Thu, Nov 8, 2018 at 2:51 AM Ezequiel Garcia < > >ezequ...@vanguardiasur.com.ar> wrote: > > > >> Hello Dafna, > >>

Re: [RFC] Create test script(s?) for regression testing

2018-11-07 Thread Ezequiel Garcia
upcoming stateful codec spec. Work for that is > > > > > > planned > > > > > > as part of an Outreachy project. > > > > > > > > > > > > My idea is to create a script that is maintained as part of > > > > >

Re: [RFC] Create test script(s?) for regression testing

2018-11-06 Thread Ezequiel Garcia
On Tue, 2018-11-06 at 09:37 +0100, Hans Verkuil wrote: > Hi all, > > After the media summit (heavy on test discussions) and the V4L2 event > regression > we just found it is clear we need to do a better job with testing. > > All the pieces are in place, so what is needed is to combine it and

[PATCH v2 2/4] vicodec: Use pixel format helpers

2018-11-02 Thread Ezequiel Garcia
Now that we've introduced the pixel format helpers, use them in vicodec driver, and get rid of driver specific pixel format specifiers. Signed-off-by: Ezequiel Garcia --- .../media/platform/vicodec/codec-v4l2-fwht.c | 42 .../media/platform/vicodec/codec-v4l2-fwht.h | 3 - drivers

[PATCH v2 3/4] vicodec: Propagate changes to the CAPTURE queue

2018-11-02 Thread Ezequiel Garcia
change, which fixes behavior required by some applications such as gstreamer. With this change, it's possible to run a simple T(T⁻¹) pipeline: gst-launch-1.0 videotestsrc ! v4l2fwhtenc ! v4l2fwhtdec ! fakevideosink Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/vicodec

[PATCH v2 0/4] vicodec: a couple fixes towards spec compliancy

2018-11-02 Thread Ezequiel Garcia
info to commit logs * Propagate changes on both encoders and decoders * Add pixel format helpers Ezequiel Garcia (4): media: Introduce helpers to fill pixel format structs vicodec: Use pixel format helpers vicodec: Propagate changes to the CAPTURE queue vicodec: Implement spec-compliant

[RFC v2 1/4] media: Introduce helpers to fill pixel format structs

2018-11-02 Thread Ezequiel Garcia
Add two new API helpers, v4l2_fill_pixfmt and v4l2_fill_pixfmt_mp, to be used by drivers to calculate plane sizes and bytes per lines. Note that driver-specific paddig and alignment are not yet taken into account. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/Makefile | 2

[PATCH v2 4/4] vicodec: Implement spec-compliant stop command

2018-11-02 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/vicodec-core.c | 80 ++- 1 file changed, 44 insertions(+), 36 deletions(-) diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c index cffd41c3fc17..b973833e21f5

Re: RFC: kernelCI media subsystem pilot (Test results for gtucker/kernelci-media - gtucker-kernelci-media-001-6-g1b2c6e5844d8)

2018-10-19 Thread Ezequiel Garcia
On Fri, 2018-10-19 at 09:06 +0200, Hans Verkuil wrote: > On 10/18/2018 09:23 PM, Ezequiel Garcia wrote: > > Hi everyone, > > > > In Collabora, and as part of our kernelci work, we are doing > > research on kernel functional testing with kernelci. > > > > Fo

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Ezequiel Garcia
Hi Nicolas, On Fri, 2018-10-19 at 07:41 -0400, Nicolas Dufresne wrote: > Le vendredi 19 octobre 2018 à 07:35 -0400, Nicolas Dufresne a écrit : > > Le vendredi 19 octobre 2018 à 09:28 +0200, Hans Verkuil a écrit : > > > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > >

Re: [PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-19 Thread Ezequiel Garcia
On Fri, 2018-10-19 at 09:28 +0200, Hans Verkuil wrote: > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > Set up a statically-allocated, dummy buffer to > > be used as flush buffer, which signals > > a encoding (or decoding) stop. > > > > When the flush buf

Re: [PATCH 1/2] vicodec: Have decoder propagate changes to the CAPTURE queue

2018-10-19 Thread Ezequiel Garcia
On Fri, 2018-10-19 at 09:14 +0200, Hans Verkuil wrote: > On 10/18/2018 06:08 PM, Ezequiel Garcia wrote: > > The decoder interface (not yet merged) specifies that > > width and height values set on the OUTPUT queue, must > > be propagated to the CAPTURE queue. > > >

RFC: kernelCI media subsystem pilot (Test results for gtucker/kernelci-media - gtucker-kernelci-media-001-6-g1b2c6e5844d8)

2018-10-18 Thread Ezequiel Garcia
Hi everyone, In Collabora, and as part of our kernelci work, we are doing research on kernel functional testing with kernelci. For those new to kernelci, see https://github.com/kernelci/kernelci-doc/wiki/KernelCI and https://kernelci.org/. The goal is to lay down the infrastructure required

[PATCH] media: Rename vb2_m2m_request_queue -> v4l2_m2m_request_queue

2018-10-18 Thread Ezequiel Garcia
To be consistent with the rest of the mem2mem helpers, rename vb2_m2m_request_queue to v4l2_m2m_request_queue. This is just a cosmetic change. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vim2m.c | 2 +- drivers/media/v4l2-core/v4l2-mem2mem.c | 4 ++-- drivers

[PATCH v5 1/5] mem2mem: Require capture and output mutexes to match

2018-10-18 Thread Ezequiel Garcia
capture and output mutex, or not set any mutex at all. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-mem2mem.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index

[PATCH v5 5/5] media: cedrus: Get rid of interrupt bottom-half

2018-10-18 Thread Ezequiel Garcia
Now that the mem2mem framework guarantees that .device_run won't be called from interrupt context, it is safe to call v4l2_m2m_job_finish directly in the top-half. So this means the bottom-half is no longer needed and we can get rid of it. Signed-off-by: Ezequiel Garcia --- .../staging/media

[PATCH v5 3/5] v4l2-mem2mem: Simplify exiting the function in __v4l2_m2m_try_schedule

2018-10-18 Thread Ezequiel Garcia
From: Sakari Ailus The __v4l2_m2m_try_schedule function acquires and releases multiple spinlocks. Simplify unlocking the job lock by adding labels to unlock the lock and exit the function. Signed-off-by: Sakari Ailus Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-mem2mem.c

[PATCH v5 2/5] v4l2-ioctl.c: Simplify locking for m2m devices

2018-10-18 Thread Ezequiel Garcia
Now that the mutexes for output and capture vb2 queues match, it is possible to refer to the context q_lock as the m2m lock for a given m2m context. Remove the output/capture lock selection. Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-ioctl.c | 47

[PATCH v5 4/5] v4l2-mem2mem: Avoid calling .device_run in v4l2_m2m_job_finish

2018-10-18 Thread Ezequiel Garcia
.device_run Signed-off-by: Ezequiel Garcia --- drivers/media/v4l2-core/v4l2-mem2mem.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index 0665a97ed89e..2b250fd10531

[PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-10-18 Thread Ezequiel Garcia
and the Cedrus VPU driver. Tested with cedrus driver using v4l2-request-test and vicodec driver using gstreamer. Ezequiel Garcia (4): mem2mem: Require capture and output mutexes to match v4l2-ioctl.c: Simplify locking for m2m devices v4l2-mem2mem: Avoid calling .device_run

[PATCH 0/2] vicodec: a couple fixes towards spec compliancy

2018-10-18 Thread Ezequiel Garcia
! v4l2fwhtdec ! fakevideosink Ezequiel Garcia (2): vicodec: Have decoder propagate changes to the CAPTURE queue vicodec: Implement spec-compliant stop command drivers/media/platform/vicodec/vicodec-core.c | 95 --- 1 file changed, 59 insertions(+), 36 deletions(-) -- 2.19.1

[PATCH 1/2] vicodec: Have decoder propagate changes to the CAPTURE queue

2018-10-18 Thread Ezequiel Garcia
. However, it's a relatively small change, which fixes behavior required by some applications such as gstreamer. With this change, it's possible to run a simple T(T⁻¹) pipeline: gst-launch-1.0 videotestsrc ! v4l2fwhtenc ! v4l2fwhtdec ! fakevideosink Signed-off-by: Ezequiel Garcia --- drivers/media

[PATCH 2/2] vicodec: Implement spec-compliant stop command

2018-10-18 Thread Ezequiel Garcia
possible to run a pipeline to completion: gst-launch-1.0 videotestsrc num-buffers=10 ! v4l2fwhtenc ! v4l2fwhtdec ! fakevideosink Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/vicodec-core.c | 80 ++- 1 file changed, 44 insertions(+), 36 deletions(-) diff --git

Re: [PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-10-15 Thread Ezequiel Garcia
On Fri, 2018-10-12 at 22:00 +0200, Paul Kocialkowski wrote: > Hi, > > Le mercredi 19 septembre 2018 à 13:28 +0900, Tomasz Figa a écrit : > > On Thu, Sep 13, 2018 at 9:15 PM Paul Kocialkowski wrote: > > > Hi, > > > > > > On Wed, 2018-09-05 at 19:00

Re: [RFC] Informal meeting during ELCE to discuss userspace support for stateless codecs

2018-10-09 Thread Ezequiel Garcia
On Mon, 2018-10-08 at 13:53 +0200, Hans Verkuil wrote: > Hi all, > > I would like to meet up somewhere during the ELCE to discuss userspace support > for stateless (and perhaps stateful as well?) codecs. > > It is also planned as a topic during the summit, but I would prefer to prepare > for

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Ezequiel Garcia
On Fri, 2018-10-05 at 13:49 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 05 Oct 2018 12:37:43 -0300 > Ezequiel Garcia escreveu: > > > On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote: > > > Em Thu, 04 Oct 2018 20:39:31 -0300 > > > Ezequiel Garcia

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-05 Thread Ezequiel Garcia
On Fri, 2018-10-05 at 09:10 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 04 Oct 2018 20:39:31 -0300 > Ezequiel Garcia escreveu: > > > On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote: > > > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote: > > > &

Re: [PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-05 Thread Ezequiel Garcia
On Fri, 2018-10-05 at 08:09 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 4 Oct 2018 21:12:24 -0300 > Ezequiel Garcia escreveu: > > > From: Shunqian Zheng > > > > Add V4L2_PIX_FMT_JPEG_RAW format that does not contain > > JPEG header in the output frame. >

[PATCH v7 6/6] media: add Rockchip VPU JPEG encoder driver

2018-10-04 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v7 4/6] media: Add JPEG_RAW format

2018-10-04 Thread Ezequiel Garcia
From: Shunqian Zheng Add V4L2_PIX_FMT_JPEG_RAW format that does not contain JPEG header in the output frame. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia --- Documentation/media/uapi/v4l/pixfmt-compressed.rst | 9 + drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v7 2/6] ARM: dts: rockchip: add VPU device node for RK3288

2018-10-04 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

[PATCH v7 5/6] media: Add controls for JPEG quantization tables

2018-10-04 Thread Ezequiel Garcia
From: Shunqian Zheng Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace configure the JPEG quantization tables. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia --- .../media/uapi/v4l/extended-controls.rst | 25 +++ .../media/videodev2

[PATCH v7 0/6] Add Rockchip VPU JPEG encoder

2018-10-04 Thread Ezequiel Garcia
/RockMyy/blob/master/patches/kernel/v4.18/DTS/0026-ARM-DTSI-rk3288-Set-the-VPU-MMU-power-domains.patch Ezequiel Garcia (4): dt-bindings: Document the Rockchip VPU bindings ARM: dts: rockchip: add VPU device node for RK3288 arm64: dts: rockchip: add VPU device node for RK3399 media: add

[PATCH v7 3/6] arm64: dts: rockchip: add VPU device node for RK3399

2018-10-04 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v7 1/6] dt-bindings: Document the Rockchip VPU bindings

2018-10-04 Thread Ezequiel Garcia
Add devicetree binding documentation for Rockchip Video Processing Unit IP. Reviewed-by: Rob Herring Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29 +++ 1 file changed, 29 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-04 Thread Ezequiel Garcia
On Mon, 2018-10-01 at 14:54 -0300, Ezequiel Garcia wrote: > On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote: > > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote: > > > This series adds support for JPEG encoding via the VPU block > > > present in Rockchip pl

Re: [PATCH v6 1/6] dt-bindings: Document the Rockchip VPU bindings

2018-10-04 Thread Ezequiel Garcia
On Fri, 2018-09-28 at 13:53 +0200, Hans Verkuil wrote: > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote: > > Add devicetree binding documentation for Rockchip Video Processing > > Unit IP. > > > > Reviewed-by: Rob Herring > > Signed-off-by: Ezequiel Garcia

Re: [PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-10-01 Thread Ezequiel Garcia
On Fri, 2018-09-28 at 14:33 +0200, Hans Verkuil wrote: > On 09/17/2018 07:30 PM, Ezequiel Garcia wrote: > > This series adds support for JPEG encoding via the VPU block > > present in Rockchip platforms. Currently, support for RK3288 > > and RK3399 is included. > > &

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-01 Thread Ezequiel Garcia
gt; > > I'm not aware of any difference. If there is one, then it is certainly not > > documented. > > What I can tell for sure is that many UVC devices don't include Huffman > tables > in their JPEG headers. > > > Ezequiel, since you've been working with

Re: [RFC] V4L2_PIX_FMT_MJPEG vs V4L2_PIX_FMT_JPEG

2018-10-01 Thread Ezequiel Garcia
On Mon, 2018-10-01 at 08:42 -0400, Nicolas Dufresne wrote: > Hello Hans, > > Le lundi 01 octobre 2018 à 10:43 +0200, Hans Verkuil a écrit : > > It turns out that we have both JPEG and Motion-JPEG pixel formats defined. > > > > Furthermore, some drivers support one, some the other and some both.

[PATCH v6 6/6] media: add Rockchip VPU JPEG encoder driver

2018-09-17 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v6 5/6] media: Add controls for JPEG quantization tables

2018-09-17 Thread Ezequiel Garcia
From: Shunqian Zheng Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace configure the JPEG quantization tables. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia --- .../media/uapi/v4l/extended-controls.rst | 25 +++ .../media/videodev2

[PATCH v6 4/6] media: Add JPEG_RAW format

2018-09-17 Thread Ezequiel Garcia
From: Shunqian Zheng Add V4L2_PIX_FMT_JPEG_RAW format that does not contain JPEG header in the output frame. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia --- Documentation/media/uapi/v4l/pixfmt-compressed.rst | 9 + drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v6 3/6] arm64: dts: rockchip: add VPU device node for RK3399

2018-09-17 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v6 2/6] ARM: dts: rockchip: add VPU device node for RK3288

2018-09-17 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

[PATCH v6 0/6] Add Rockchip VPU JPEG encoder

2018-09-17 Thread Ezequiel Garcia
/Miouyouyou/RockMyy/blob/master/patches/kernel/v4.18/DTS/0026-ARM-DTSI-rk3288-Set-the-VPU-MMU-power-domains.patch Ezequiel Garcia (4): dt-bindings: Document the Rockchip VPU bindings ARM: dts: rockchip: add VPU device node for RK3288 arm64: dts: rockchip: add VPU device node for RK3399 media: add

[PATCH v6 1/6] dt-bindings: Document the Rockchip VPU bindings

2018-09-17 Thread Ezequiel Garcia
Add devicetree binding documentation for Rockchip Video Processing Unit IP. Reviewed-by: Rob Herring Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 30 +++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH 2/2] vicodec: set state->info before calling the encode/decode funcs

2018-09-10 Thread Ezequiel Garcia
On Mon, 2018-09-10 at 13:16 -0400, Nicolas Dufresne wrote: > Le lundi 10 septembre 2018 à 12:37 -0300, Ezequiel Garcia a écrit : > > On Mon, 2018-09-10 at 17:00 +0200, Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > state->info was NULL since

Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency

2018-09-10 Thread Ezequiel Garcia
On Mon, 2018-09-10 at 17:23 +0200, Hans Verkuil wrote: > On 09/10/2018 05:21 PM, Ezequiel Garcia wrote: > > The vicodec doesn't use the Subdev API, so drop the dependency. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/media/platform/vicodec/Kcon

Re: [PATCH 2/2] vicodec: set state->info before calling the encode/decode funcs

2018-09-10 Thread Ezequiel Garcia
On Mon, 2018-09-10 at 17:00 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > state->info was NULL since I completely forgot to set state->info. > Oops. > > Reported-by: Ezequiel Garcia > Signed-off-by: Hans Verkuil For both patches: Tested-by: Ezequiel Garci

[PATCH 2/2] vicodec: Drop unused job_abort()

2018-09-10 Thread Ezequiel Garcia
The vicodec does not use the aborting field. In fact, this driver can't really cancel any work, since it performs all the work in device_run(). Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/vicodec-core.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 1/2] vicodec: Drop unneeded symbol dependency

2018-09-10 Thread Ezequiel Garcia
The vicodec doesn't use the Subdev API, so drop the dependency. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig index

Re: [PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-09-10 Thread Ezequiel Garcia
Hi Hans, Thanks for the review. On Mon, 2018-09-10 at 14:42 +0200, Hans Verkuil wrote: > On 09/06/2018 12:00 AM, Ezequiel Garcia wrote: > > From: Shunqian Zheng > > > > Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace > > configure t

[PATCH v5 6/6] media: add Rockchip VPU JPEG encoder driver

2018-09-05 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 + drivers

[PATCH v5 0/6] Add Rockchip VPU JPEG encoder

2018-09-05 Thread Ezequiel Garcia
for v4l2-compliance - Drop .crop support, we will add support for the selector API later, if needed. [1] https://github.com/Miouyouyou/RockMyy/blob/master/patches/kernel/v4.18/DTS/0026-ARM-DTSI-rk3288-Set-the-VPU-MMU-power-domains.patch Ezequiel Garcia (4): dt-bindings: Document the Rockchip

[PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-09-05 Thread Ezequiel Garcia
From: Shunqian Zheng Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace configure the JPEG quantization tables. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia --- .../media/uapi/v4l/extended-controls.rst | 31 +++ .../media/videodev2

[PATCH v5 3/6] arm64: dts: rockchip: add VPU device node for RK3399

2018-09-05 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH v5 4/6] media: Add JPEG_RAW format

2018-09-05 Thread Ezequiel Garcia
From: Shunqian Zheng Add V4L2_PIX_FMT_JPEG_RAW format that does not contain JPEG header in the output frame. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia --- Documentation/media/uapi/v4l/pixfmt-compressed.rst | 9 + drivers/media/v4l2-core/v4l2-ioctl.c

[PATCH v5 2/6] ARM: dts: rockchip: add VPU device node for RK3288

2018-09-05 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot

  1   2   3   4   5   6   7   8   9   >