[PATCH 1/4] em28xx: extend GPIO register definitions for the em25xx, em276x/7x/8x, em2874/174/84

2013-06-03 Thread Frank Schäfer
The em25xx/em276x/7x/8x provides 4 GPIO register sets, each of them consisting of separate read and a write registers. The same registers are also used by the em2874/174/84. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 88

[PATCH 2/4] em28xx: improve em2820-em2873/83 GPIO port register definitions and descriptions

2013-06-03 Thread Frank Schäfer
- add definition for GPIO register 0x09 (reading/input) - extend the information the chip variants that support GPIO registers 0x08/0x09 - rename EM28XX_R08_GPIO to EM2820_R08_GPIO_CTRL Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 128

[PATCH 3/4] em28xx: move snapshot button bit definition for reg 0x0C from em28xx-input.c to em28xx.h

2013-06-03 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-input.c |1 - drivers/media/usb/em28xx/em28xx-reg.h |3 ++- 2 Dateien geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-input.c b/drivers

Re: [PATCH 0/4] em28xx: GPIO registers: extend definitions and remove the caching

2013-06-03 Thread Frank Schäfer
Am 03.06.2013 20:12, schrieb Frank Schäfer: The first two patches add some missing GPIO register definitions, while the third patch is a minor code movement to clean up things. The fourth patch finally removes the GPIO register caching. Frank Schäfer (4): em28xx: extend GPIO register

[PATCH 1/2] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers

2013-05-24 Thread Frank Schäfer
em25xx/em276x/7x/8x provides 3 GPIO register sets, each of them consisting of separate read and a write registers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-reg.h | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/usb

[PATCH 2/2] em28xx: complete GPIO register caching

2013-05-24 Thread Frank Schäfer
we need to cache this register, too. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 12 - drivers/media/usb/em28xx/em28xx-core.c | 43 ++--- drivers/media/usb/em28xx/em28xx.h | 15 3

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 01:04, schrieb Chris Rankin: - Original Message - What happens with kernel 3.8 ? Does ir-keytable trigger an em28xx_ir_change_protocol() call there, too, but with type=8 ? Or is this call missing ? This is the dmesg output from 3.8, with an extra ex28xx_info() call at

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 02:45, schrieb Chris Rankin: - Original Message - I'm not familar with ir-keytable and the RC core. Mauro ? Can you take over ? ;) This patch seems to do the right thing... I doubt it will apply cleanly because of TAB/space issues, but you should get the idea :-).

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 14:38, schrieb Frank Schäfer: ... But there was a third change: 3.) the scancode passed to the RC core with rc_keypress() in case of RC_BIT_UNKNOWN changed from a 16 bit value to 32 bit value (e.g.: old: 00 00 ab cd = new: ab cd xx xx). See commit

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 15:01, schrieb Chris Rankin: - Original Message - And this is me calling ir-keytable: [ 2183.812407] em28xx #0: Changing protocol: rc_type=1 So with 3.8 the same happens as with 3.9. Yes, that does appear to be part of the RC core ABI. Well, if ir-keycode / the RC

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-20 Thread Frank Schäfer
Am 20.05.2013 16:51, schrieb Chris Rankin: - Original Message - If I had to guess, I would say you should check your rc_maps.cfg / keytable. ;) This is unchanged between 3.8.x and 3.9.x, and so is correct by definition. No, just because it didn't change it isn't automatically

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-19 Thread Frank Schäfer
Am 18.05.2013 23:02, schrieb Chris Rankin: - Original Message - For the em28xx driver: em28xx-input.c: em28xx_ir_work() is called every 100ms calls em28xx_ir_handle_key() - calls ir-get_key() which is em2874_polling_getkey() in case of your device - reports the

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-19 Thread Frank Schäfer
Am 19.05.2013 16:11, schrieb Chris Rankin: - Original Message - em28xx_ir_change_protocol() should be called at least twice: First from em28xx_ir_init() with RC_BIT_UNKNOWN (initial configuration) and later from the RC core with RC_BIT_RC5. Can you confirm that ? Yes, it does

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-19 Thread Frank Schäfer
Am 19.05.2013 21:59, schrieb Chris Rankin: - Original Message - Hmm... that's weird. Are you sure about that ? Is this really a 3.9.2 vanilla kernel ? Quite sure, although it turns out that there's a bit more to it. Here is the dmesg output with my debugging messages in: [

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-18 Thread Frank Schäfer
Am 18.05.2013 15:57, schrieb Chris Rankin: I have a PCTV 290e DVB2 adapter (em28xx, em28xx_dvb, em28xx_rc, cxd2820r), and I have just discovered that the IR remote control has stopped working with VDR when using a vanilla 3.9.2 kernel. Downgrading the kernel to 3.8.12 fixes things again.

Re: 3.9.2 kernel - IR / em28xx_rc broken?

2013-05-18 Thread Frank Schäfer
Am 18.05.2013 17:17, schrieb Chris Rankin: - Original Message - Am 18.05.2013 15:57, schrieb Chris Rankin: I have a PCTV 290e DVB2 adapter (em28xx, em28xx_dvb, em28xx_rc, cxd2820r), and I have just discovered that the IR remote control has stopped working with VDR when using a

Fwd: Device no longer handled by em28xx kernel drivers

2013-04-23 Thread Frank Schäfer
(forwarding to the linux-media mailing list) (2nd try) Am 18.04.2013 21:04, schrieb Michael .: Hi I hope you don't mind me contacting you directly. Issues like this should always be discussed on the linux-media mailing list, so please CC it in the future. Neither I'm the em28xx maintainer

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-23 Thread Frank Schäfer
... Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: Writing is sane: GPIO input lines requires writing as well, in order to set it to either pull-up or pull-down mode (not sure if em28xx supports both ways). So, the driver needs to know if it will write there a 0 or 1, and this is

[PATCH] em28xx: add a missing le16_to_cpu conversion

2013-04-19 Thread Frank Schäfer
commit 61ff5d69 em28xx: improve em2710/em2820 distinction missed the le16_to_cpu conversion of the USB vendor ID. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 14:51, schrieb Mauro Carvalho Chehab: Em Sun, 14 Apr 2013 22:35:05 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 19:46:20 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: Patch update notification: 1 patch updated

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 17:23, schrieb Patchwork: Hello, The following patch (submitted by you) has been updated in patchwork: * em28xx: add basic support for the SpeedLink Vicious And Devine Laplace webcam - http://patchwork.linuxtv.org/patch/17928/ was: New now: Under Review This

Patchwork and em28xx delegates

2013-04-15 Thread Frank Schäfer
I've just noticed that my 2 pending em28xx patches have got delegate assigned: https://patchwork.linuxtv.org/patch/17834/ = delegated to mkrufky https://patchwork.linuxtv.org/patch/17928/ (Obsoleted) = delegated to hverkuil Ist this a patchwork failure or is the new submaintainers workflow

Re: Patchwork and em28xx delegates

2013-04-15 Thread Frank Schäfer
Am 15.04.2013 18:50, schrieb Mauro Carvalho Chehab: Em Mon, 15 Apr 2013 18:41:44 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: I've just noticed that my 2 pending em28xx patches have got delegate assigned: https://patchwork.linuxtv.org/patch/17834/ = delegated to mkrufky

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-14 Thread Frank Schäfer
Am 13.04.2013 20:08, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 19:46:20 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 17:33:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: [PATCH RFC] em28xx: split analog part into a separate module

2013-04-14 Thread Frank Schäfer
Am 14.04.2013 20:32, schrieb Mauro Carvalho Chehab: Now that dvb-only devices start to happen, it makes sense to split the analog part on a separate module. Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com --- This was compiled-tested only, and it is not ready yet for merging. Yes,

[PATCH 0/3] em28xx: clean up end extend the GPIO port handling

2013-04-13 Thread Frank Schäfer
Patch 1 removes the unneeded and broken gpio register caching code. Patch 2 adds the gpio register defintions for the em25xx/em276x/7x/8x and patch 3 finally adds a new helper function for gpio ports with separate registers for read and write access. Frank Schäfer (3): em28xx: give up GPIO

[PATCH 2/3] em28xx: add register defines for em25xx/em276x/7x/8x GPIO registers

2013-04-13 Thread Frank Schäfer
em25xx/em276x/7x/8x provides 3 GPIO register sets, each of them consisting of separate read and a write registers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-reg.h |8 1 Datei geändert, 8 Zeilen hinzugefügt(+) diff --git a/drivers

[PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
where input lines are connected to buttons etc. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 12 drivers/media/usb/em28xx/em28xx-core.c | 27 ++- drivers/media/usb/em28xx/em28xx.h |6

[PATCH 3/3] em28xx: add helper function for handling the GPIO registers of newer devices

2013-04-13 Thread Frank Schäfer
). Make em28xx_write_reg_bits() a wrapper function calling this new function with the same value for both registers. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c | 26 +++--- drivers/media/usb/em28xx/em28xx.h |5

[PATCH] em28xx: add basic support for the SpeedLink Vicious And Devine Laplace webcam

2013-04-13 Thread Frank Schäfer
- support for the 3 buttons (snapshot, mute, illumination) is missing - illumination/flash LED support is missing (capturing LED is functional) Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 34 ++- drivers/media/usb

Re: [PATCH 0/3] em28xx: clean up end extend the GPIO port handling

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 16:25, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 16:15:39 +0300 Antti Palosaari cr...@iki.fi escreveu: On 04/13/2013 12:48 PM, Frank Schäfer wrote: Patch 1 removes the unneeded and broken gpio register caching code. Patch 2 adds the gpio register defintions

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 16:41, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 11:48:39 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: The GPIO register tracking/caching code is partially broken, because newer devices provide more than one GPIO register and some of them are even using

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 17:33:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 16:41, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 11:48:39 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: The GPIO

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 19:46, schrieb Frank Schäfer: Am 13.04.2013 19:04, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 17:33:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 13.04.2013 16:41, schrieb Mauro Carvalho Chehab: Em Sat, 13 Apr 2013 11:48:39 +0200 Frank Schäfer

Re: [PATCH 1/3] em28xx: give up GPIO register tracking/caching

2013-04-13 Thread Frank Schäfer
Am 13.04.2013 20:19, schrieb Frank Schäfer: Am 13.04.2013 19:46, schrieb Frank Schäfer: ... We always write to the GPIO register. That's why these functions are called em28xx_write_* ;) Whether the write operation is sane or not (e.g. because it modifies the bit corresponding to an input

[PATCH] em28xx: fix snapshot button support

2013-04-11 Thread Frank Schäfer
The snapshot button support is currently broken, because module em28xx-rc is loaded only if the device has remote control support. Fix it by also loading this module if the device has a snapshot button. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH] em28xx: improve em2710/em2820 distinction

2013-04-11 Thread Frank Schäfer
. Fortunately both variants are using different generic USD IDs which give us a hint about the used chip. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 16 1 Datei geändert, 8 Zeilen hinzugefügt(+), 8 Zeilen entfernt(-) diff --git

Re: em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-08 Thread Frank Schäfer
Am 08.04.2013 10:38, schrieb Hans Verkuil: On Mon April 8 2013 00:02:15 Frank Schäfer wrote: In em28xx_start_streaming() and also em28xx_stop_streaming() we do struct em28xx *dev = dvb-adapter.priv; which I would say should be the culprit. Are you sure that dvb-adapter.priv needs

[PATCH] em28xx: save isoc endpoint number for DVB only if endpoint has alt settings with xMaxPacketSize != 0

2013-04-08 Thread Frank Schäfer
as indicator that the device provides DVB support. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb

Re: em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-07 Thread Frank Schäfer
Am 06.04.2013 08:38, schrieb Hans Verkuil: On Fri April 5 2013 18:11:59 Frank Schäfer wrote: Mauro, Hans, with the latest media-tree, I'm getting the following kernel oops when starting to watch digital TV with em28xx devices: [ 124.297707] BUG: unable to handle kernel paging request

Re: Terratec Grabby hwrev 2

2013-04-05 Thread Frank Schäfer
Am 03.04.2013 10:27, schrieb Timo Teras: On Tue, 02 Apr 2013 18:39:25 +0200 Frank Schäfer fschaefer@googlemail.com wrote: Am 02.04.2013 07:43, schrieb Timo Teras: On Mon, 01 Apr 2013 19:26:53 +0200 Frank Schäfer fschaefer@googlemail.com wrote: Am 30.03.2013 10:54, schrieb Timo

em28xx: kernel oops in em28xx_tuner_callback() when watching digital TV

2013-04-05 Thread Frank Schäfer
Mauro, Hans, with the latest media-tree, I'm getting the following kernel oops when starting to watch digital TV with em28xx devices: [ 124.297707] BUG: unable to handle kernel paging request at 38326f3d [ 124.297770] IP: [f8bf1026] em28xx_tuner_callback+0x6/0x40 [em28xx] [ 124.297825] *pdpt =

Re: Terratec Grabby hwrev 2

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 07:43, schrieb Timo Teras: On Mon, 01 Apr 2013 19:26:53 +0200 Frank Schäfer fschaefer@googlemail.com wrote: Am 30.03.2013 10:54, schrieb Timo Teras: On Thu, 28 Mar 2013 12:22:52 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: On the W7 driver, I don't get any

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 00:12, schrieb Mauro Carvalho Chehab: Em Mon, 01 Apr 2013 22:39:28 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 01.04.2013 21:22, schrieb Mauro Carvalho Chehab: Em Mon, 01 Apr 2013 19:14:03 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-02 Thread Frank Schäfer
Am 02.04.2013 02:48, schrieb Devin Heitmueller: On Mon, Apr 1, 2013 at 6:14 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: In time, I meant to say: So, it seems very unlikely that any change here will keep it working for model 16009 while breaking it for other HVR-930

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-01 Thread Frank Schäfer
Am 18.03.2013 22:22, schrieb Mauro Carvalho Chehab: Em Wed, 06 Mar 2013 18:44:07 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am 05.03.2013 16:43, schrieb Devin Heitmueller: 2013/3/5 Mauro Carvalho Chehab mche...@redhat.com: The em2874 chips and upper have 2 buses. On all known

Re: Terratec Grabby hwrev 2

2013-04-01 Thread Frank Schäfer
Am 30.03.2013 10:54, schrieb Timo Teras: On Thu, 28 Mar 2013 12:22:52 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: On the W7 driver, I don't get any of the above mentioned problems. I looked at the saa7113 register init sequence, and copied that over to linux saa7113 init, but that

Re: [PATCH 0/3] em28xx: add support for two buses on em2874 and upper

2013-04-01 Thread Frank Schäfer
Am 01.04.2013 21:22, schrieb Mauro Carvalho Chehab: Em Mon, 01 Apr 2013 19:14:03 +0200 Frank Schäfer fschaefer@googlemail.com escreveu: Am 18.03.2013 22:22, schrieb Mauro Carvalho Chehab: Em Wed, 06 Mar 2013 18:44:07 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am

Re: [PATCH] em28xx: fix typo in scale_to_size().

2013-03-30 Thread Frank Schäfer
-fmt.pix.height = height; Acked-by: Frank Schäfer fschaefer@googlemail.com Thanks for catching this ! Regards, Frank -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH 3/9] em28xx: rename em28xx_hint_sensor() to em28xx_detect_sensor()

2013-03-27 Thread Frank Schäfer
Now that the board hints and the sensor initialization/configuration have been separated, em28xx_detect_sensor() is the better name for this function. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |7 +++ 1 Datei geändert, 3 Zeilen

[PATCH 4/9] em28xx: move sensor code to a separate source code file em28xx-camera.c

2013-03-27 Thread Frank Schäfer
em28xx-cards.c is very large and the sensor/camera related code is growing, so move this code to a separate source code file em28xx-camera.c. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/Makefile|2 +- drivers/media/usb/em28xx/em28xx-camera.c

[PATCH 5/9] em28xx: detect further Micron sensors

2013-03-27 Thread Frank Schäfer
Add further Micron chip IDs to be able to identify all Micron sensors listed by Empiatech. Also probe the two alternate i2c addresses used by Micron sensors with 8 bit address and 16 bit register width. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx

[PATCH 6/9] em28xx: move the probing of Micron sensors to a separate function

2013-03-27 Thread Frank Schäfer
Other sensors like the ones from OmniVision need a different probing procedure, so it makes sense have separate functions for each manufacturer/sensor type. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 23 +++ 1

[PATCH 7/9] em28xx: add probing procedure for OmniVision sensors

2013-03-27 Thread Frank Schäfer
different client addresses). The most commonly used sensors (including the ones listed by Empiatech) are detected properly, although there is no support for them yet. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 114

[PATCH 8/9] em28xx: add comment about Samsung and Kodak sensor probing addresses

2013-03-27 Thread Frank Schäfer
them properly, so leave a comment. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c |5 + 1 Datei geändert, 5 Zeilen hinzugefügt(+) diff --git a/drivers/media/usb/em28xx/em28xx-camera.c b/drivers/media/usb/em28xx/em28xx-camera.c

[PATCH 9/9] em28xx: add basic support for OmniVision OV2640 sensors

2013-03-27 Thread Frank Schäfer
changes), bridge xclk adjustment and disabling of 16 bit (12 bit) output formats at high resolutions. Image quality should also needs to be improved. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-camera.c | 49 ++ drivers

Re: Terratec Grabby hwrev 2

2013-03-27 Thread Frank Schäfer
Am 25.03.2013 18:08, schrieb Timo Teras: I just bought a Terratec Grabby hardware revision 2 in hopes that it would work on my linux box. But alas, I got only sound working. It seems that analog video picture grabbing does not work. I tried kernels 3.4.34-grsec, 3.7.1 (vanilla), 3.8.2-grsec

[PATCH] em28xx: ignore isoc DVB USB endpoints with wMaxPacketSize = 0 bytes for all alt settings

2013-03-27 Thread Frank Schäfer
-by: Frank Schäfer fschaefer@googlemail.com Cc: sta...@kernel.org --- drivers/media/usb/em28xx/em28xx-cards.c |9 - 1 Datei geändert, 8 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c index 54e0362

Re: Terratec Grabby hwrev 2

2013-03-27 Thread Frank Schäfer
Am 27.03.2013 19:04, schrieb Timo Teras: On Wed, 27 Mar 2013 19:57:49 +0200 Timo Teras timo.te...@iki.fi wrote: The errors are weird. strace gives: open(/dev/bus/usb/005/028, O_RDONLY) = -1 ENOENT (No such file or directory) open(/dev/bus/usb/005/028, O_RDONLY) = -1 ENOENT (No such file

[PATCH 0/9] em28xx: improve the sensor device code

2013-03-27 Thread Frank Schäfer
and identification (patches 5, 7 and 8) - adding (basic) support for the OmniVision OV2640 sensor (patch 9) Frank Schäfer (9): em28xx: fix and separate the board hints for sensor devices em28xx: separate sensor detection and initialization/configuration em28xx: rename em28xx_hint_sensor

[PATCH 1/9] em28xx: fix and separate the board hints for sensor devices

2013-03-27 Thread Frank Schäfer
and EM2860_BOARD_NETGMBH_CAM (using the module parameter card). NOTE: the current board hint logic for webcams is preserved. Not more not less. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 40 +++ 1 Datei

[PATCH 2/9] em28xx: separate sensor detection and initialization/configuration

2013-03-27 Thread Frank Schäfer
and future proof. This also makes the code more consistent, because the initialization of the MT9V011 sensor subdevice is already separated. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 122 ++- 1 Datei geändert, 72

[PATCH v3 0/5] em28xx: add support for the em2765 bridge

2013-03-26 Thread Frank Schäfer
on the recent em28xx i2c bus changes (real support for 2 busses) - moved i2c algorithm depending transfer function calls to separate functions Changes since v2: - fixed some coding style issues and comments Frank Schäfer (5): em28xx: add support for em25xx i2c bus B read/write/check device

[PATCH v3 2/5] em28xx: add chip id of the em2765

2013-03-26 Thread Frank Schäfer
This chip can be found in the SpeedLink VAD Laplace webcam (1ae7:9003 and 1ae7:9004). Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 13 - drivers/media/usb/em28xx/em28xx-reg.h |1 + drivers/media/usb/em28xx/em28xx.h

[PATCH v3 4/5] em28xx: make em28xx_set_outfmt() working with EM25xx family bridges

2013-03-26 Thread Frank Schäfer
Streaming doesn't work with the EM2765 if bit 5 of the output format register 0x27 is set. It's actually not clear if really has to be set for the other chips, but for now let's keep it to avoid regressions and add a comment to the code. Signed-off-by: Frank Schäfer fschaefer@googlemail.com

[PATCH v3 5/5] em28xx: write output frame resolution to regs 0x34+0x35 for em25xx family bridges

2013-03-26 Thread Frank Schäfer
The Windows driver writes the output resolution to registers 0x34 (width / 16) and 0x35 (height / 16) always. We don't know yet what these registers are used for. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |7 +++ drivers/media

[PATCH v3 1/5] em28xx: add support for em25xx i2c bus B read/write/check device operations

2013-03-26 Thread Frank Schäfer
-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |8 +- drivers/media/usb/em28xx/em28xx-i2c.c | 236 ++- drivers/media/usb/em28xx/em28xx.h | 10 +- 3 Dateien geändert, 212 Zeilen hinzugefügt(+), 42 Zeilen entfernt

[PATCH v3 3/5] em28xx: add support for em25xx/em276x/em277x/em278x frame data processing

2013-03-26 Thread Frank Schäfer
The em25xx/em276x/em277x/em278x frame data format is different to the one used by the em2710/em2750/em28xx chips. With the recent cleanups and reorganization of the frame data processing code it can be easily extended to support these devices. Signed-off-by: Frank Schäfer fschaefer

Re: [PATCH v2 1/5] em28xx: add support for em25xx i2c bus B read/write/check device operations

2013-03-24 Thread Frank Schäfer
Am 24.03.2013 12:38, schrieb Mauro Carvalho Chehab: Em Sat, 23 Mar 2013 18:27:08 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: The webcam SpeedLink VAD Laplace (em2765 + ov2640) uses a special algorithm for i2c communication with the sensor, which is connected to a second i2c

Re: [PATCH v2 5/5] em28xx: write output frame resolution to regs 0x34+0x35 for em25xx family bridges

2013-03-24 Thread Frank Schäfer
Am 24.03.2013 12:44, schrieb Mauro Carvalho Chehab: Em Sat, 23 Mar 2013 18:27:12 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: The Windows driver writes the output resolution to registers 0x34 (width / 16) and 0x35 (height / 16) always. We don't know yet what these registers

Re: [PATCH v2 1/5] em28xx: add support for em25xx i2c bus B read/write/check device operations

2013-03-24 Thread Frank Schäfer
/checkpatch.pl complains for this patch: WARNING: please, no spaces at the start of a line #69: FILE: drivers/media/usb/em28xx/em28xx-i2c.c:8: + Copyright (C) 2013 Frank Schäfer fschaefer@googlemail.com$ WARNING: space prohibited between function name and open parenthesis '(' #69: FILE: drivers

[PATCH] em28xx-i2c: do not break strings across lines

2013-03-24 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-i2c.c | 45 +++-- 1 Datei geändert, 20 Zeilen hinzugefügt(+), 25 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx

[PATCH] em28xx-i2c: fix coding style of multi line comments

2013-03-24 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-i2c.c | 52 + 1 Datei geändert, 34 Zeilen hinzugefügt(+), 18 Zeilen entfernt(-) diff --git a/drivers/media/usb/em28xx/em28xx-i2c.c b/drivers/media/usb/em28xx/em28xx

Re: [PATCH v2 1/5] em28xx: add support for em25xx i2c bus B read/write/check device operations

2013-03-24 Thread Frank Schäfer
Am 24.03.2013 15:02, schrieb Mauro Carvalho Chehab: Em Sun, 24 Mar 2013 13:53:40 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: Am 24.03.2013 12:38, schrieb Mauro Carvalho Chehab: Em Sat, 23 Mar 2013 18:27:08 +0100 Frank Schäfer fschaefer@googlemail.com escreveu: The webcam

[PATCH v2 0/5] em28xx: add support for the em2765 bridge

2013-03-23 Thread Frank Schäfer
on the recent em28xx i2c bus changes (real support for 2 busses) - moved i2c algorithm depending transfer function calls to separate functions Frank Schäfer (5): em28xx: add support for em25xx i2c bus B read/write/check device operations em28xx: add chip id of the em2765 em28xx: add support

[PATCH v2 2/5] em28xx: add chip id of the em2765

2013-03-23 Thread Frank Schäfer
This chip can be found in the SpeedLink VAD Laplace webcam (1ae7:9003 and 1ae7:9004). Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c | 11 ++- drivers/media/usb/em28xx/em28xx-reg.h |1 + drivers/media/usb/em28xx/em28xx.h

[PATCH v2 1/5] em28xx: add support for em25xx i2c bus B read/write/check device operations

2013-03-23 Thread Frank Schäfer
-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-cards.c |8 +- drivers/media/usb/em28xx/em28xx-i2c.c | 229 +-- drivers/media/usb/em28xx/em28xx.h | 10 +- 3 Dateien geändert, 205 Zeilen hinzugefügt(+), 42 Zeilen entfernt

[PATCH v2 4/5] em28xx: make em28xx_set_outfmt() working with EM25xx family bridges

2013-03-23 Thread Frank Schäfer
Streaming doesn't work with the EM2765 if bit 5 of the output format register 0x27 is set. It's actually not clear if really has to be set for the other chips, but for now let's keep it to avoid regressions and add a comment to the code. Signed-off-by: Frank Schäfer fschaefer@googlemail.com

[PATCH v2 3/5] em28xx: add support for em25xx/em276x/em277x/em278x frame data processing

2013-03-23 Thread Frank Schäfer
The em25xx/em276x/em277x/em278x frame data format is different to the one used by the em2710/em2750/em28xx chips. With the recent cleanups and reorganization of the frame data processing code it can be easily extended to support these devices. Signed-off-by: Frank Schäfer fschaefer

[PATCH v2 5/5] em28xx: write output frame resolution to regs 0x34+0x35 for em25xx family bridges

2013-03-23 Thread Frank Schäfer
The Windows driver writes the output resolution to registers 0x34 (width / 16) and 0x35 (height / 16) always. We don't know yet what these registers are used for. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/usb/em28xx/em28xx-core.c |7 +++ drivers/media

Re: [RFC PATCH 09/10] bttv: fix mute on last close of the video device node

2013-03-21 Thread Frank Schäfer
Am 21.03.2013 11:56, schrieb Hans Verkuil: On Wed 20 March 2013 20:24:49 Frank Schäfer wrote: Instead of applying the current mute setting on last device node close, always mute the device. I am very pleased with the preceding 8 patches. That does exactly what I had in mind. For this patch

[PATCH 0/8] bttv: refactor audio_mux() and fix muting/unmuting

2013-03-21 Thread Frank Schäfer
This patch series refactors function audio_mux() and fixes several issues related to muting/unmuting on probing and first open. Mute on last close will be fixed with further patches which are currently under review. Tested with a Hauppauge WinTV Theatre (model 37284, Rev B421). Frank Schäfer

[PATCH 1/8] bttv: audio_mux(): use a local variable gpio_mute instead of modifying the function parameter mute

2013-03-21 Thread Frank Schäfer
Function audio_mux() actually deals with two types of mute: gpio mute and subdevice muting. This patch claryfies the meaning of these values, but mainly prepares the code for the next patch. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com

[PATCH 3/8] bttv: do not save the audio input in audio_mux()

2013-03-21 Thread Frank Schäfer
We can't and do not save the mute setting in function audio_mux(), so we should also not save the input in this function for consistency. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/bt8xx/bttv-driver.c | 10

[PATCH 4/8] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'

2013-03-21 Thread Frank Schäfer
'audio_input' better describes the meaning of this field. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/bt8xx/bttv-cards.c |2 +- drivers/media/pci/bt8xx/bttv-driver.c | 12 ++-- drivers/media/pci

[PATCH 2/8] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-21 Thread Frank Schäfer
There are cases where we want to call audio_mux() without changing the value of the v4l2 mute control, for example - mute mute on last close - mute on device probing Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci

[PATCH 6/8] bttv: untangle audio input and mute setting

2013-03-21 Thread Frank Schäfer
Split function audio_mux(): move the mute setting part to function audio_mute() and the input setting part to function audio_input(). Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/bt8xx/bttv-driver.c | 51

[PATCH 8/8] bttv: apply mute settings on open

2013-03-21 Thread Frank Schäfer
(). Also apply the mute setting when the radio device node gets opened. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/bt8xx/bttv-driver.c |3 ++- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git

[PATCH 7/8] bttv: do not unmute the device before the first open

2013-03-21 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci/bt8xx/bttv-driver.c |4 +++- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci

[PATCH 5/8] bttv: separate GPIO part from function audio_mux()

2013-03-21 Thread Frank Schäfer
Move the GPIO part of function audio_mux() to a separate function audio_mux_gpio(). This prepares the code for the next patch which will separate mute and input setting. Signed-off-by: Frank Schäfer fschaefer@googlemail.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- drivers/media/pci

media-tree build is broken

2013-03-21 Thread Frank Schäfer
... Kernel: arch/x86/boot/bzImage is ready (#2) ERROR: __divdi3 [drivers/media/common/siano/smsdvb.ko] undefined! make[1]: *** [__modpost] Fehler 1 make: *** [modules] Fehler 2 Mauro, I assume this is caused by one of the recent Siano patches ? Regards, Frank -- To unsubscribe from this list:

Re: em28xx: commit aab3125c43d8fecc7134e5f1e729fabf4dd196da broke HVR 900

2013-03-21 Thread Frank Schäfer
Am 21.03.2013 16:34, schrieb Hans Verkuil: On Thu March 21 2013 11:03:27 Mauro Carvalho Chehab wrote: Em Thu, 21 Mar 2013 09:33:41 +0100 Hans Verkuil hverk...@xs4all.nl escreveu: I tried to use my HVR 900 stick today and discovered that it no longer worked. I traced it to commit

[RFC PATCH 00/10] bttv: refactor audio_mux() and fix muting/unmuting

2013-03-20 Thread Frank Schäfer
, the new patches 3-6 untagle the mute and input setting code as much as possible as suggested by hans Verkuil. Tested with a Hauppauge WinTV Theatre (model 37284, Rev B421). Frank Schäfer (10): bttv: audio_mux(): use a local variable gpio_mute instead of modifying the function parameter mute

[RFC PATCH 01/10] bttv: audio_mux(): use a local variable gpio_mute instead of modifying the function parameter mute

2013-03-20 Thread Frank Schäfer
Function audio_mux() actually deals with two types of mute: gpio mute and subdevice muting. This patch claryfies the meaning of these values, but mainly prepares the code for the next patch. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-driver.c

[RFC PATCH 03/10] bttv: do not save the audio input in audio_mux()

2013-03-20 Thread Frank Schäfer
We can't and do not save the mute setting in function audio_mux(), so we should also not save the input in this function for consistency. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-driver.c | 10 +- 1 Datei geändert, 5 Zeilen hinzugefügt

[RFC PATCH 02/10] bttv: audio_mux(): do not change the value of the v4l2 mute control

2013-03-20 Thread Frank Schäfer
There are cases where we want to call audio_mux() without changing the value of the v4l2 mute control, for example - mute mute on last close - mute on device probing Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-driver.c |8 1 Datei

[RFC PATCH 05/10] bttv: separate GPIO part from function audio_mux()

2013-03-20 Thread Frank Schäfer
Move the GPIO part of function audio_mux() to a separate function audio_mux_gpio(). This prepares the code for the next patch which will separate mute and input setting. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-driver.c | 18

[RFC PATCH 07/10] bttv: do not unmute the device before the first open

2013-03-20 Thread Frank Schäfer
Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-driver.c |4 +++- 1 Datei geändert, 3 Zeilen hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c index 0df4a16..55eab61

[RFC PATCH 09/10] bttv: fix mute on last close of the video device node

2013-03-20 Thread Frank Schäfer
Instead of applying the current mute setting on last device node close, always mute the device. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-driver.c |2 +- 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-) diff --git a/drivers/media

[RFC PATCH 04/10] bttv: rename field 'audio' in struct 'bttv' to 'audio_input'

2013-03-20 Thread Frank Schäfer
'audio_input' better describes the meaning of this field. Signed-off-by: Frank Schäfer fschaefer@googlemail.com --- drivers/media/pci/bt8xx/bttv-cards.c |2 +- drivers/media/pci/bt8xx/bttv-driver.c | 12 ++-- drivers/media/pci/bt8xx/bttvp.h |2 +- 3 Dateien geändert

<    1   2   3   4   5   6   7   8   9   >