On Mon, 2018-11-12 at 11:03 +0100, Paul Kocialkowski wrote:
> On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote:
> > Fix the following build-time warning:
> > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type
> > without #include
>
> We
Fix the following build-time warning:
./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without
#include
Signed-off-by: Jean Delvare
Fixes: c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and
metadata")
Cc: Paul Kocialkowski
Cc: Mauro Carva
MEDIA_CEC is no longer a tristate option, so the user can't actually
choose M. Whether the code is built-in or built as a module is
decided somewhere else.
Signed-off-by: Jean Delvare <jdelv...@suse.de>
Fixes: 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems")
;-) The patch should be discarded.
Thanks,
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
to make that
two separate patches with better descriptions.
And if I'm wrong then the patch needs a better description too ;-)
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo
The sh_mobile_ceu_camera and sh_mobile_csi2 drivers are only useful on
SuperH and shmobile unless build testing.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Cc: Mauro Carvalho Chehab m.che...@samsung.com
---
drivers/media/platform/soc_camera
The R-Car Video Input driver is only useful on shmobile unless build
testing.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Vladimir Barinov vladimir.bari...@cogentembedded.com
Cc: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
Cc: Guennadi Liakhovetski g.liakhovet...@gmx.de
Cc: Mauro
to the gspca_sonixb
driver now, so that it gets sufficient testing before the sn9c102
driver is finally phased out.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Hans de Goede hdego...@redhat.com
Cc: Mauro Carvalho Chehab m.che...@samsung.com
Cc: Luca Risolia luca.riso...@studio.unibo.it
Cc: Greg Kroah
to the TIMB_DMA dependencies silenced the
kconfig warning about unmet direct dependencies but it was wrong:
without MFD_TIMBERDALE, TIMB_DMA is useless as the driver has no
device to bind to.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Vinod Koul vinod.k...@intel.com
Cc: Dan Williams
Hi Manu,
On Sun, 24 Nov 2013 22:51:33 +0530, Manu Abraham wrote:
Sorry, that I came upon this patch quite late.
No problem, better late than never! :)
On Mon, Jun 3, 2013 at 8:51 PM, Jean Delvare kh...@linux-fr.org wrote:
SNR is supposed to be reported by the frontend drivers in dB, so
probe?
Oh, i2c_new_probed_device() probes the device, what a surprise! :D
Try, I don't know, i2c_new_device() maybe if you don't want the
probe? ;)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More
to
i2c_new_probed_device(). That probe function can read whatever chip ID
register exists to decide if the probe should be successful or not.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
Hi Antti,
The driver's .probe() after i2c_new_device() is simply not supposed to
fail. You should only use i2c_new_device() if you are 100% sure that
there is a device of the given type at the given address. Checking
i2c_get_clientdata() is an ugly trick that you should no longer need to
use.
of debugging or
experimentation.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Improvements to dvb-apps/femon:
* femon: Share common code
* femon: Display SNR in dB
* femon: Handle -EOPNOTSUPP
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
);
} else {
printf (signal %04x | snr %04x | ber %08x | unc %08x |
,
fe_info.signal_strength,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
| );
}
if (fe_info.lock)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Module parameter descriptions need not be terminated with a newline.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hans.verk...@cisco.com
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/i2c/sony-btf-mpx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
.
OTOH the initialization of ret in m920x_init is needless, the function
returns with an error as soon as an error happens, so the last return
can only be a success and we can hard-code 0 there.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Antonio
.
OTOH the initialization of ret in m920x_init is needless, the function
returns with an error as soon as an error happens, so the last return
can only be a success and we can hard-code 0 there.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
Cc: Antonio
Last parameter of function GetLockStatus() isn't used so drop it.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/dvb-frontends/drxk_hard.c |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--- linux-3.8.orig/drivers
results.
How would I debug this further?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, what antenna are you using? The
Terratec-provided one, or another one?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
I would like to see these statistics improved. I am willing to help,
however the drxk driver is rather complex (at least to my eyes) and I
do not have a datasheet so I wouldn't know where to start. Is there
anyone who can work on this and/or provide some guidance?
Thanks,
--
Jean Delvare
Hi Oliver,
On Wed, 06 Mar 2013 19:07:01 +0100, Oliver Schinagl wrote:
On 03/06/13 16:03, Jean Delvare wrote:
It turns out that my problem is the antenna. I was using the antenna I
have been using with my previous card, which is an internal DVB-T
antenna with amplification (external power
subsystem
maintainer, so I will not handle this. If you think this is important,
you'll have to resubmit and Wolfram will decide what he wants to do
about it.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
that.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
can't, not in the general case at least. sizeof(*val) will
return the size of the _first_ element of the destination buffer, which
has nothing to do with the length of that buffer (which in turn might
be rightfully longer than the read length for this specific message.)
--
Jean Delvare
not opposed to the idea of i2c_msg initialization helper macros,
but please don't mix that with actual code changes which could have bad
side effects.
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
priority list. And
I see the extra work for the pre-processor, so we need a good reason
for doing that.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
Hi Mauro,
On Tue, 18 Sep 2012 12:49:53 -0300, Mauro Carvalho Chehab wrote:
Em 01-09-2012 15:53, Jean Delvare escreveu:
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be
dealing with unsigned dividends.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Andrew Morton
The Terratec Cinergy T PCIe Dual is based on the CX23885, and uses
MT2063, DRX-3913k and DRX-3916k chips, so select the relevant drivers.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Stefan Ringel linu...@stefanringel.de
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
drivers/media
DIV_ROUND_CLOSEST is faster if the compiler knows it will only be
dealing with unsigned dividends.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Andrew Morton a...@linux-foundation.org
Cc: Guenter Roeck li...@roeck-us.net
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
drivers/media/rc
i2c_transfer(), not at its boundaries. I'm looking
into this now.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
messages are logged. We don't want to log messages while
holding a rt_mutex.
* No check is done on the existence of adap-algo-master_xfer. It
is thus the caller's responsibility to ensure that the function is
OK to call.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche
Hi Mauro,
On Tue, 20 Mar 2012 09:17:54 -0300, Mauro Carvalho Chehab wrote:
Em 20-03-2012 04:20, Jean Delvare escreveu:
On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote:
Yet, I'd be more happy if Jean's patch could check first if the status is
below 0, in order to prevent
Hi Mauro,
On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote:
On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare kh...@linux-fr.org wrote:
--- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_core.c
2012-03-13 11:09:13.0 +0100
+++ linux-3.3-rc7/drivers/media/dvb
On Mon, 12 Mar 2012 07:28:02 -0300, Mauro Carvalho Chehab wrote:
Em 12-03-2012 07:04, Jean Delvare escreveu:
!d can't actually happen, so it doesn't matter. d is passed by
dib0700_rc_setup() when calling usb_fill_bulk_urb(), and
dib0700_rc_setup() starts with dereferencing d, if it was NULL
would crash right away.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller dheitmuel...@kernellabs.com
---
Devin, am I missing something?
drivers/media/dvb/dvb-usb/dib0700_core.c |3 ---
1 file changed, 3 deletions(-)
--- linux
Reported by kmemleak.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller dheitmuel...@kernellabs.com
---
Changes since v1:
* Don't free the URB when it is still in use.
* Fix a second leak (transfer_buffer).
drivers/media/dvb/dvb
Hi Mauro,
Thanks for your reply.
On Thu, 08 Mar 2012 08:21:20 -0300, Mauro Carvalho Chehab wrote:
Em 12-02-2012 08:19, Jean Delvare escreveu:
Reported by kmemleak.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller
Reported by kmemleak.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Devin Heitmueller dheitmuel...@kernellabs.com
---
I am not familiar with the usb API, are we also supposed to call
usb_kill_urb() in the error case maybe?
drivers/media/dvb
.
In practice I get 67% with my antenna fully amplified and 51% with
no amplification. This is close enough to what I get on my other
DVB-T adapter with the same antenna.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Steven Toth st...@kernellabs.com
---
This was written without a datasheet so
is supported since kernel 2.6.26, which looks promising.
However, before I actually buy it, I would love to hear from someone
actually using this device under Linux. Anyone? Is there anything to
worry about, or can I just buy it?
Thanks,
--
Jean Delvare
--
To unsubscribe from this list: send the line
Hi Antti,
As an additional note, it just occurred to me that what you are working
on is somewhat related to Mark Brown's regmap. Look in
drivers/base/regmap and see if maybe you can reuse and/or extend Mark's
approach.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe
on me to drive it, I am afraid it will take months, given
my current workload and various tasks with a much higher priority than
this. I will however be happy to help with code review.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
On Wed, 09 Nov 2011 10:02:08 -0200, Mauro Carvalho Chehab wrote:
Em 09-11-2011 08:37, Jean Delvare escreveu:
Speaking of struct i2c_client, I seem to remember that the dvb
subsystem doesn't use it much at the moment. This might be an issue if
you intend to get the generic code into i2c-core
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
messages in the first place.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
drivers, to avoid any confusion. This
is the best way to ensure that the comments won't go out of sync
again. Anyone interested in the implementation details would rather
look at the code itself.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/au0828/au0828-i2c.c |2
or the like.
So let's simply get rid of the broken and useless code.
I'm also adding I2C_FUNC_I2C, as the driver and hardware support plain
I2C messaging.
[1] http://marc.info/?l=linux-i2cm=117499415208244w=2
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/usbvision
...@ideasonboard.com
As far as I can tell, this fixes a bug too, the original code would not
work on big-endian machines.
Acked-by: Jean Delvare kh...@linux-fr.org
---
drivers/media/video/mt9p031.c |5 ++---
drivers/media/video/mt9t001.c |5 ++---
2 files changed, 4 insertions(+), 6
(client, reg);
+
Stray blank line.
}
(...)
Other than this, looks all OK:
Acked-by: Jean Delvare kh...@linux-fr.org
Obviously depends on the i2c patch, which will go upstream during the
next merge window.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media
+ depends on INPUT
+ select INPUT_POLLDEV
+ default n
+
If you patch gets applied, then this one would better be moved to
drivers/misc/lis3lv02d/Kconfig.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
to Samuel to decide which patch he wants to apply.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 5 Sep 2011 16:19:35 +0200, Arnd Bergmann wrote:
On Monday 05 September 2011, Jean Delvare wrote:
As said before, I'm not sure. Yes, it makes it easier to select misc
device drivers from Kconfig files. But it also makes it impossible to
deselect all misc device drivers at once
Dunlap rdun...@xenotime.net
Reported-by: Johannes Berg johan...@sipsolutions.net
Cc: Jean Delvare kh...@linux-fr.org
Cc: Tony Lindgren t...@atomide.com
Cc: Grant Likely grant.lik...@secretlab.ca
Signed-off-by: Luciano Coelho coe...@ti.com
---
I guess this should fix the problem. I've
-driven system wakeups
Signed-off-by: Randy Dunlap rdun...@xenotime.net
Reported-by: Johannes Berg johan...@sipsolutions.net
Cc: Jean Delvare kh...@linux-fr.org
Cc: Tony Lindgren t...@atomide.com
Cc: Grant Likely grant.lik...@secretlab.ca
Signed-off-by: Luciano Coelho coe...@ti.com
---
I
((.\n));
Looks correct.
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
on a system when you
try to identify it.
At this point, I see the work needed to review your patches, the risk
of regressions due to the large size of the patch set, but I don't see
any immediate benefit. Thus I am not going to look into it at all,
sorry.
--
Jean Delvare
--
To unsubscribe from this list
Hi Andy,
On Friday 08 July 2011 12:34:38 pm Andy Walls wrote:
Jean Delvare jdelv...@suse.de wrote:
The third parameter of module_param is supposed to represent sysfs
file permissions. A value of 1 leads to the following:
$ ls -l /sys/module/radio_tea5764/parameters/
total 0
-x 1
in
this driver.
Signed-off-by: Jean Delvare jdelv...@suse.de
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: Fabio Belavenuto belaven...@gmail.com
---
drivers/media/radio/radio-tea5764.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.0-rc6.orig/drivers/media/radio/radio
Hi Mauro,
Sorry for the late reply.
On Thu, 05 May 2011 13:18:04 -0300, Mauro Carvalho Chehab wrote:
Em 05-05-2011 12:09, Jean Delvare escreveu:
Hi Mauro, Steven,
On Thu, 05 May 2011 10:15:04 -0300, Mauro Carvalho Chehab wrote:
As you pointed, there are two ways of solving this issue
(i2c_adapter, msgs, num);
Note that you lose the automatic retry mechanism though. That being
said, I don't think this is the right approach in general, as explained
above.
Hope I helped a bit, if you have more questions, feel free!
--
Jean Delvare
--
To unsubscribe from this list: send the line
The ability to force the encoder or decoder chip was broken by commit
0ab6e1c38d80ab586e3a1ca9e71844131d9f51dc in February 2009. As nobody
complained for over 2 years, I take it that these parameters were no
longer used so we can simply drop them.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc
44835f197bf1e3f57464f23dfb239fef06cf89be
Author: Jean Delvare kh...@linux-fr.org
Date: Sun Jul 18 16:52:05 2010 -0300
V4L/DVB: cx23885: Check for slave nack on all transactions
Don't just check for nacks on zero-length transactions. Check on
other transactions too.
Signed-off-by: Jean Delvare kh
/cx25840/cx25840-core.c |3 ++-
2 files changed, 2 insertions(+), 11 deletions(-)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for probing purpose.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
and pvrusb2 currently do the former.
Yes, that's exactly how things are supposed to work now. And hopefully
it makes sense and helps you all write cleaner code (that was the
intent at least.)
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body
TX-oriented for a mutex that is supposed to synchronize TX and RX
access. It's particularly surprising for the ir-kbd-i2c driver, which
as far as I know only supports RX. The name xcvr_lock you used for
lirc_zilog seems more appropriate.
--
Jean Delvare
--
To unsubscribe from this list: send
On Wed, 19 Jan 2011 09:09:47 -0600 (CST), Mike Isely wrote:
On Wed, 19 Jan 2011, Jean Delvare wrote:
Hi Andy,
On Sun, 16 Jan 2011 14:20:49 -0500, Andy Walls wrote:
3. I hear from Jean, or whomever really cares about ir-kbd-i2c, if
adding some new fields for struct IR_i2c_init_data
On Wed, 19 Jan 2011 12:12:49 -0500, Jarod Wilson wrote:
On Jan 19, 2011, at 8:50 AM, Jean Delvare wrote:
Hi Andy,
On Wed, 19 Jan 2011 08:38:02 -0500, Andy Walls wrote:
As I understand it, the rules/guidelines for I2C probing are now
something like this:
1. I2C device driver
behavior
of IR receive with hdpvr hardware.
Maybe. But the fact that the Zilog is unresponsive during processing of
sent data certainly contributes to this feeling too.
Reported-by: Jean Delvare kh...@linux-fr.org
Signed-off-by: Jarod Wilson ja...@redhat.com
---
Nb: This patch was done
-i2c_buf)) [Jean Delvare]
Reported-by: Jean Delvare kh...@linux-fr.org
Signed-off-by: Jarod Wilson ja...@redhat.com
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord
for the lifetime of the
driver, as you prefer.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
will fail. The
failure documented for the HD PVR simply suggests that the wait loop
isn't long enough. It is 20 * 50 ms currently, i.e. 1 second total,
maybe this isn't sufficient. Have you ever tried a longer delay?
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe
On Wed, 05 Jan 2011 20:02:41 -0200, Mauro Carvalho Chehab wrote:
Em 05-01-2011 19:51, Jean Delvare escreveu:
If you have specific cases you don't know how to solve, please point me
to them and I'll take a look.
You can take a look at saa7134-cards.c, for example. saa7134_tuner_setup()
has
stretching by slaves. Apparently
it doesn't support repeated start conditions either, so it wouldn't
surprise me.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
On Thu, 13 Jan 2011 12:07:34 -0500, Devin Heitmueller wrote:
On Thu, Jan 13, 2011 at 11:48 AM, Jean Delvare kh...@linux-fr.org wrote:
On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote:
How should clock stretches by slaves be handled using i2c-algo-bit?
It is already handled. But hdpvr
the main address, and register the secondary addresses
in your probe() function using i2c_new_dummy(). See
drivers/misc/eeprom/at24.c for an example of how this is done.
I'm not sure I understand the problem at hand exactly though, so my
advice might be inappropriate.
--
Jean Delvare
--
To unsubscribe
it looks strange to update code which is
apparently disabled for quite a while...)
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
here */
{ ir_rx_z8f0811_haup, 0 },
+ { ir_rx_z8f0811_hdpvr, 0 },
{ }
};
Acked-by: Jean Delvare kh...@linux-fr.org
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info
-ir_lock);
mutex_init(ir-buf_lock);
ir-need_boot = 1;
+ ir-is_hdpvr = (id-driver_data ID_FLAG_HDPVR) ? true : false;
memcpy(ir-l, lirc_template, sizeof(struct lirc_driver));
ir-l.minor = -1;
--
Jean Delvare
--
To unsubscribe from this list: send the line
to show my support to Andy's
work, I don't care if I'm not counted as a reviewer for these small
patches.
Em 05-01-2011 12:45, Jean Delvare escreveu:
From a purely technical perspective, changing client-addr in the
probe() function is totally prohibited.
Agreed. Btw, there are some other hacks
Hi Wolfram,
Sorry for the late answer.
On Mon, 15 Nov 2010 23:28:15 +0100, Wolfram Sang wrote:
On Wed, Nov 10, 2010 at 03:14:13PM +0100, Wolfram Sang wrote:
The i2c-core does this already.
Reported-by: Jean Delvare kh...@linux-fr.org
Signed-off-by: Wolfram Sang w.s...@pengutronix.de
On Sat, 13 Nov 2010 12:34:23 -0200, Mauro Carvalho Chehab wrote:
Em 05-11-2010 18:07, Jean Delvare escreveu:
Drivers don't need to include linux/i2c-id.h, especially not when
they don't use anything that header file provides.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michael
for this, as there are 5
other drivers doing the same.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
) and properly return error on adapter registration failure.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michel Ludwig michel.lud...@gmail.com
Cc: Stefan Ringel stefan.rin...@arcor.de
---
Untested, I don't have the hardware.
drivers/staging/tm6000/tm6000-i2c.c | 27
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michel Ludwig michel.lud...@gmail.com
Cc: Stefan Ringel stefan.rin...@arcor.de
---
drivers/staging/tm6000/tm6000-i2c.c | 12
1 file changed, 12 deletions(-)
--- linux-2.6.36-rc7.orig/drivers/staging/tm6000/tm6000-i2c.c 2010-10
Commit a90f933507859941c4a58028d7593a80f57895c4 accidentally removed
the piece of code setting the i2c algo pointer. Restore it.
That's what happens when you put two code statements on the same
line...
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
the code in question never
runs. As the code additionally expects that I2C_HW_B_HDPVR may not
be defined, we can delete it now and let the lirc_zilog driver
maintainer rewrite this piece of code.
Big thanks for Hans Verkuil for doing all the hard work :)
Signed-off-by: Jean Delvare kh...@linux
Drivers don't need to include linux/i2c-id.h, especially not when
they don't use anything that header file provides.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Michael Hunold mich...@mihu.de
Cc: Mauro Carvalho Chehab mche...@infradead.org
---
drivers/media/common/saa7146_i2c.c|1
It's about time to make it clear that i2c_adapter.id is deprecated.
Hopefully this will remind the last user to move over to a different
strategy.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Hans Verkuil hverk...@xs4all.nl
Cc: Jarod Wilson ja...@redhat.com
---
drivers/i2c/i2c-mux.c |1
Detection class I2C_CLASS_TV_ANALOG is set by a few adapters but no
I2C device driver is setting it anymore, which means it can be
dropped. I2C devices on analog TV adapters are instantiated
explicitly these days, which is much better.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers
Detection class I2C_CLASS_TV_DIGITAL is set by many adapters but no
I2C device driver is setting it anymore, which means it can be
dropped. I2C devices on digital TV adapters are instantiated
explicitly these days, which is much better.
Signed-off-by: Jean Delvare kh...@linux-fr.org
---
drivers
On Sun, 26 Sep 2010 16:25:53 +0200, Jean Delvare wrote:
Commit 8dc09004978538d211ccc36b5046919489e30a55 assumes that
dev-rc_input_dev is always set. It is, however, NULL if dvb-usb was
loaded with option disable_rc_polling=1.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho
more good reason to use module aliases where possible,
BTW... Respecting user-defined blacklisting is desirable.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
Commit 8dc09004978538d211ccc36b5046919489e30a55 assumes that
dev-rc_input_dev is always set. It is, however, NULL if dvb-usb was
loaded with option disable_rc_polling=1.
Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Mauro Carvalho Chehab mche...@redhat.com
---
drivers/media/dvb/dvb-usb
.
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
. After that, I can kill the whole thing without a thinking and
without the need to explain why it is safe to do - because it will be
totally obvious then.
Thanks a lot for your work!
--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe linux-media in
the body of a message
1 - 100 of 309 matches
Mail list logo
