[PATCH] udmabuf: fix odd_ptr_err.cocci warnings

From: kbuild test robot drivers/dma-buf/udmabuf.c:167:6-12: inconsistent IS_ERR and PTR_ERR on line 168. PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call to IS_ERR

Re: [PATCH 2/3] media: staging: atomisp: Fix an error handling path in 'lm3554_probe()'

On Fri, 11 May 2018, Christophe JAILLET wrote: > The use of 'fail1' and 'fail2' is not correct. Reorder these calls to > branch at the right place of the error handling path. Maybe it would be good to improve the names at the same time? julia > > Signed-off-by: Christophe JAILLET

[PATCH v2] [media] pvrusb2: delete unneeded include

pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not use pvr2_saa7115_subdev_update and it explicitly includes pvrusb2-hdw-internal.h. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: Make the subjec

[PATCH] [media] media: delete unneeded include

pvrusb2-video-v4l.h only declares pvr2_saa7115_subdev_update and includes pvrusb2-hdw-internal.h. pvrusb2-cx2584x-v4l.c does not use pvr2_saa7115_subdev_update and it explicitly includes pvrusb2-hdw-internal.h. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/p

Re: [PATCH][RFC] kernel.h: provide array iterator

Le 16.03.2018 05:21, Kees Cook a écrit : On Thu, Mar 15, 2018 at 3:00 AM, Kieran Bingham wrote: Simplify array iteration with a helper to iterate each entry in an array. Utilise the existing ARRAY_SIZE macro to identify the length of the array and pointer

Re: [Outreachy kernel] [PATCH 0/3] staging: media: cleanup

On Sun, 4 Mar 2018, Arushi Singhal wrote: > Spellcheck the comments. > Remove the repeated, consecutive words with single word. For the series: Acked-by: Julia Lawall <julia.law...@lip6.fr> But please look out for things to change in the code, not just in the comments. julia

Re: [Outreachy kernel] [PATCH] staging: media: Remove unnecessary semicolon

On Sun, 4 Mar 2018, Arushi Singhal wrote: > Remove unnecessary semicolon found using semicolon.cocci Coccinelle > script. > > Signed-off-by: Arushi Singhal <arushisinghal19971...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > .../media/atomis

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > That found 4 that I think Wolfram's grep missed. > > arch/um/drivers/vector_user.h |2 -- > drivers/gpu/drm/mxsfb/mxsfb_regs.h|2 -- > drivers/video/fbdev/mxsfb.c |2 -- > include/drm/drm_scdc_helper.h

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Wolfram Sang wrote: > Hi Julia, > > > and got the results below. I can make a version for the kernel shortly. > > It should probably take care of right-shifting, too? I did that too but got no results. Perhaps right shifting constants is pretty uncommon. I can put that

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Tue, Feb 06, 2018 at 02:15:51PM +0100, Julia Lawall wrote: > > > > > > On Tue, 6 Feb 2018, Dan Carpenter wrote: > > > > > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > > > In

Re: [PATCH 0/4] tree-wide: fix comparison to bitshift when dealing with a mask

On Tue, 6 Feb 2018, Dan Carpenter wrote: > On Mon, Feb 05, 2018 at 09:09:57PM +0100, Wolfram Sang wrote: > > In one Renesas driver, I found a typo which turned an intended bit shift > > ('<<') > > into a comparison ('<'). Because this is a subtle issue, I looked tree wide > > for > > similar

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bart Van Assche wrote: > On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > > On Tue, 2 Jan 2018, Bob Peterson wrote: > > > - Original Message - > > > > - Original Message - > > > > > > > Still, the G

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | - Original Message - > | | Drop newline at the end of a message string when the printing function > adds > | | a newline. > | > | Hi Julia, > | > | NACK. > | > | As much as it's a pain when searching the source

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | Drop newline at the end of a message string when the printing function adds > | a newline. > > Hi Julia, > > NACK. > > As much as it's a pain when searching the source code for output strings, > this patch set goes

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

On Tue, 2 Jan 2018, Dan Carpenter wrote: > On Wed, Dec 20, 2017 at 11:30:01AM +0100, Julia Lawall wrote: > > > > > > On Wed, 20 Dec 2017, Dan Carpenter wrote: > > > > > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > > > > @@

[PATCH 00/12] drop unneeded newline

Drop newline at the end of a message string when the printing function adds a newline. The complete semantic patch that detects this issue is as shown below (http://coccinelle.lip6.fr/). It works in two phases - the first phase counts how many uses of a function involve a newline and how many

[PATCH 09/12] [media] pvrusb2: drop unneeded newline

pvr2_trace prints a newline at the end of the message string, so the message string does not need to include a newline explicitly. Done using Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/pvrusb2/pvrusb2-hdw.c |3 ++- 1 file changed, 2 inse

Re: [PATCH v1 05/10] staging: atomisp: Remove non-ACPI leftovers

On Wed, 20 Dec 2017, Dan Carpenter wrote: > On Tue, Dec 19, 2017 at 10:59:52PM +0200, Andy Shevchenko wrote: > > @@ -914,9 +904,7 @@ static int lm3554_probe(struct i2c_client *client) > > dev_err(>dev, "gpio request/direction_output fail"); > > goto fail2; > > } > >

Re: Adjustments for a lot of function implementations

On Mon, 30 Oct 2017, SF Markus Elfring wrote: > > While we do not mind cleanup patches, the way you post them (one fix per > > file) > > I find it safer in this way while I was browsing through the landscape of > Linux > software components. > > > > is really annoying and takes us too much

Re: [PATCH] [media] bdisp: remove redundant assignment to pix

On Sun, 29 Oct 2017, Colin King wrote: > From: Colin Ian King > > Pointer pix is being initialized to a value and a little later > being assigned the same value again. Remove the redundant second > duplicate assignment. Cleans up the clang warning: > >

Re: [Outreachy kernel] [PATCH v2 1/2] staging: atomisp2: cleanup null check on memory allocation

e_alloc_node\|kmalloc_node\|kzalloc_node\|devm_kzalloc\)(...) > ...when != p > > if ( > - p == NULL > + !p > ) s > else s1 > > Signed-off-by: Aishwarya Pant <aishp...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > > -- > Changes in atomisp2/css

Re: [Outreachy kernel] [PATCH] Staging: media: atomisp: pci: Eliminate use of typedefs for struct

gt; ... > } > - T > ; > > @r3@ > type r1.T; > identifier p.T1; > @@ > > - T > + struct T1 > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > .../media/atomisp/pci/atomisp2/css2400

Re: [PATCH] [media] ov5645: I2C address change (fwd)

Hello, It seems that an unlock is missing on line 764. julia -- Forwarded message -- Date: Wed, 4 Oct 2017 05:59:09 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH] [media] ov5645:

Re: [media] spca500: Use common error handling code in spca500_synch310()

On Fri, 22 Sep 2017, SF Markus Elfring wrote: > >>return 0; > >> -error: > >> + > >> +report_failure: > >> + PERR("Set packet size: set interface error"); > >>return -EBUSY; > >> } > > > > Why change the label name? > > I find the suggested variant a bi better. > > > > They are both

Re: [PATCH] [media] spca500: Use common error handling code in spca500_synch310()

On Fri, 22 Sep 2017, SF Markus Elfring wrote: > From: Markus Elfring > Date: Fri, 22 Sep 2017 18:45:07 +0200 > > Adjust a jump target so that a bit of exception handling can be better > reused at the end of this function. > > This issue was detected by using the

Re: [Outreachy kernel] [PATCH] Staging: media: atomisp: Merge assignment with return

e; > -return ret; > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff

Re: [Outreachy kernel] [PATCH] Staging: media: atomisp: Merge assignment with return

e; > -return ret; > > Signed-off-by: Srishti Sharma <srishtis...@gmail.com> Acked-by: Julia Lawall <julia.law...@lip6.fr> > --- > drivers/staging/media/atomisp/i2c/ov5693/ov5693.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff -

Re: [Outreachy kernel] [PATCH] Staging: media: omap4iss: Use WARN_ON() instead of BUG_ON().

On Fri, 8 Sep 2017, Srishti Sharma wrote: > Use WARN_ON() instead of BUG_ON() to avoid crashing the kernel. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/media/omap4iss/iss.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH v2] media: ddbridge: constify stv0910_p and lnbh25_cfg

These structures are only copied into other structures, so they can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- v2: fix typo in the commit message drivers/media/pci/ddbridge/ddbridge-core.c |4 ++-- 1 file changed, 2 insertions

[PATCH] media: ddbridge: constify stv0910_p and lnbh25_cfg

These structures are only copied into other stuructures, so they can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/pci/ddbridge/ddbridge-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH] [media] pxa_camera: constify v4l2_clk_ops structure

This v4l2_clk_ops structure is only passed as the first argument of v4l2_clk_register, which is const, so the v4l2_clk_ops structure can also be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/platform/pxa_camera.c |2 +-

[PATCH] [media] v4l2: av7110_v4l: constify v4l2_audio structure

This v4l2_audio structure is only copied into other structures, so it can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/pci/ttpci/av7110_v4l.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 6/6] [media] uvcvideo: constify video_subdev structures

On Tue, 8 Aug 2017, Laurent Pinchart wrote: > Hi Julia, > > Thank you for the patch. > > On Tuesday 08 Aug 2017 12:58:32 Julia Lawall wrote: > > uvc_subdev_ops is only passed as the second argument of > > v4l2_subdev_init, which is const, so uvc_subdev_ops can be >

[PATCH 1/6] [media] v4l: mt9t001: constify video_subdev structures

be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/i2c/mt9t001.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/mt9t001.c b/drivers/media/i2c/mt9t001.c index 842017f..9d981d9

[PATCH 6/6] [media] uvcvideo: constify video_subdev structures

uvc_subdev_ops is only passed as the second argument of v4l2_subdev_init, which is const, so uvc_subdev_ops can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/uvc/uvc_entity.c |2 +- 1 file changed, 1 ins

[PATCH 3/6] staging: atomisp: constify video_subdev structures

These structures are both stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/staging/media/atomisp/i2c/ap1302.c |2 +- d

[PATCH 0/6] constify video_subdev structures

The structures of type v4l2_subdev_ops are only passed as the second argument of v4l2_subdev_init or as the third argument of v4l2_i2c_subdev_init, both of which are const. The structures of type v4l2_subdev_core_ops, v4l2_subdev_pad_ops, v4l2_subdev_sensor_ops, v4l2_subdev_video_ops are only

[PATCH 2/6] [media] vimc: constify video_subdev structures

These structures are all only stored in fields of v4l2_subdev_ops structures, all of which are const, so these structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/platform/vimc/vimc-debayer.c |2 +- d

[PATCH 5/6] [media] exynos4-is: constify video_subdev structures

The v4l2_subdev_ops structures are only passed as the second argument of v4l2_subdev_init, which is const, so the v4l2_subdev_ops structures can be const as well. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/platform/exynos4-i

[PATCH 4/6] [media] media: mt9m111: constify video_subdev structures

be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/i2c/mt9m111.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c index 72e71b7..99b992e

[PATCH] [media] vs6624: constify vs6624_default_fmt

The structure vs6624_default_fmt is only copied into another structure field, so it can be const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/i2c/vs6624.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 02/12] [media] media: ti-vpe: vpe: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 04/12] [media] V4L2: platform: rcar_jpu: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 03/12] [media] s5p-g2d: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 01/12] [media] st-delta: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 05/12] [media] vcodec: mediatek: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 00/12] constify v4l2_m2m_ops structures

The v4l2_m2m_ops structures are only passed as the only argument to v4l2_m2m_init, which is declared as const. Thus the v4l2_m2m_ops structures themselves can be const. Done with the help of Coccinelle. --- drivers/media/platform/exynos-gsc/gsc-m2m.c |2 +-

[PATCH 06/12] [media] exynos-gsc: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 07/12] [media] bdisp: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 12/12] [media] mtk-mdp: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 11/12] [media] exynos4-is: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 09/12] [media] media: mx2-emmaprp: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 08/12] [media] m2m-deinterlace: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 10/12] [media] vim2m: constify v4l2_m2m_ops structures

@p = { ... }; @ok1@ identifier r.i; position p; @@ v4l2_m2m_init(@p) @bad@ position p != {r.p,ok1.p}; identifier r.i; struct v4l2_m2m_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct v4l2_m2m_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 1/6] [media] v4l2-pci-skeleton: constify vb2_ops structures

= { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = @p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 0/6] constify vb2_ops structures

These vb2_ops structures are only stored in the ops field of a vb2_queue structure, which is declared as const. Thus the vb2_ops structures themselves can be const. Done with the help of Coccinelle. --- drivers/media/platform/blackfin/bfin_capture.c|2 +-

[PATCH 2/6] [media] media: davinci: vpbe: constify vb2_ops structures

= { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = @p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 4/6] [media] media: blackfin: bfin_capture: constify vb2_ops structures

= { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = @p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 6/6] [media] media: imx: capture: constify vb2_ops structures

= { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = @p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 3/6] [media] staging: media: davinci_vpfe: constify vb2_ops structures

= { ... }; @ok@ identifier r.i; struct vb2_queue e; position p; @@ e.ops = @p; @bad@ position p != {r.p,ok.p}; identifier r.i; struct vb2_ops e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct vb2_ops i = { ... }; // Signed-off-by: Julia Lawall

[PATCH 1/5] [media] cx18: constify videobuf_queue_ops structures

+const struct videobuf_queue_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/pci/cx18/cx18-streams.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/cx18/cx18-streams.c b/drivers/media/pci/cx18/cx18-str

[PATCH 2/5] [media] atomisp: constify videobuf_queue_ops structures

+const struct videobuf_queue_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/staging/media/atomisp/pci/atomisp2/atomisp_fops.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_

[PATCH 0/5] constify videobuf_queue_ops structures

These videobuf_queue_ops structures are only passed as the second argument to videobuf_queue_vmalloc_init, which is declared as const. Thus the videobuf_queue_ops structures themselves can be const. Done with the help of Coccinelle. --- drivers/media/pci/cx18/cx18-streams.c

[PATCH 3/5] [media] cx231xx: constify videobuf_queue_ops structures

. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/cx231xx/cx231xx-417.c |2 +- drivers/media/usb/cx231xx/cx231xx-video.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/c

[PATCH 4/5] [media] tm6000: constify videobuf_queue_ops structures

+const struct videobuf_queue_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/tm6000/tm6000-video.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/

[PATCH 5/5] [media] zr364xx: constify videobuf_queue_ops structures

+const struct videobuf_queue_ops i = { ... }; // Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/media/usb/zr364xx/zr364xx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/zr364xx/zr364xx.c b/drivers/media/usb/zr364xx/zr364xx.c

[PATCH] staging: media: use relevant lock

The data protected is video_out2 and the lock that is released is _out2->dma_queue_lock, so it seems that that lock should be taken as well. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/staging/media/davinci_vpfe/dm365_resizer.c |2 +- 1 file changed, 1 insert

[PATCH] [media] DaVinci-VPBE: constify vpbe_dev_ops

vpbe_dev_ops is only copied into the ops field at the end of a vpbe_device structure, so it can be const. Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- Does the ops field need to be inlined into the vpbe_device structure? drivers/media/platform/davinci/vpbe.c |2 +-

[ragnatech:media-tree 2075/2144] drivers/media/dvb-frontends/stv0910.c:1185:2-8: preceding lock on line 1176 (fwd)

com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: [ragnatech:media-tree 2075/2144] drivers/media/dvb-frontends/stv0910.c:1185:2-8: preceding lock on line 1176 CC: kbuild-...@01.org TO: Daniel Scheller <d.schel...@gmx.net> CC: Mauro Carvalho Chehab <m.che...@s

Re: [PATCH 1/3] [media] uvcvideo: variable size controls (fwd)

There is a double free on data if the goto is taken on line 1815. julia -- Forwarded message -- Date: Sat, 15 Jul 2017 21:07:03 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH

Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver (fwd)

Please check on this (line 199). julia -- Forwarded message -- Date: Thu, 6 Jul 2017 13:58:29 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH 2/2] v4l: cadence: Add Cadence MIPI-CS

Re: [PATCH v1 5/6] [media] ov9650: add multiple variant support (fwd)

Braces are probably missing aroud lines 1618-1620. julia -- Forwarded message -- Date: Sun, 25 Jun 2017 23:06:03 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v1 5/6] [media]

[ragnatech:media-tree 1869/1907] drivers/media/dvb-frontends/stv0367.c:3127:3-16: duplicated argument to & or | (fwd)

It seems that some of the constants on lines 3127 and on are the same as the ones on lines 3134 and on. julia -- Forwarded message -- Date: Wed, 21 Jun 2017 18:20:03 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law..

Re: [PATCH v4 2/2] cec: add STM32 cec driver (fwd)

BRDNOGEN is duplicate in the #defined on line 46. julia -- Forwarded message -- Date: Mon, 29 May 2017 19:16:10 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [PATCH v4 2/2] cec: add STM3

Re: [PATCH 04/22] target: Make use of the new sg_map function at 16 call sites (fwd)

It looks like >cmdr_lock should be released at line 512 if it has not been released otherwise. The lock was taken at line 438. julia -- Forwarded message -- Date: Fri, 14 Apr 2017 22:21:44 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Jul

Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)

On Tue, 11 Apr 2017, Sylwester Nawrocki wrote: > Hi, > > On 04/03/2017 08:17 AM, Smitha T Murthy wrote: > > On Mon, 2017-04-03 at 08:00 +0200, Julia Lawall wrote: > > > See line 2101 > > > > > > julia > > > > > Thank you for bring

Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encoder (fwd)

See line 2101 julia - Forwarded message -- Date: Mon, 3 Apr 2017 05:04:39 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: Re: [Patch v3 10/11] [media] s5p-mfc: Add support for HEVC encode

Re: [Outreachy kernel] [PATCH v2] staging: media: davinci_vpfe:Replace a bit shift.

There should be a spac after every colon in the subject. Please pay attention to these small details, so you don't have to send the same patch over and over. julia On Fri, 24 Mar 2017, Arushi Singhal wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro. > This was done with

Re: [Outreachy kernel] Re: [PATCH v1] staging: media: Remove unused function atomisp_set_stop_timeout()

On Sun, 12 Mar 2017, SIMRAN SINGHAL wrote: > On Sun, Mar 12, 2017 at 7:24 PM, Greg KH wrote: > > On Fri, Mar 10, 2017 at 07:05:05PM +0530, simran singhal wrote: > >> The function atomisp_set_stop_timeout on being called, simply returns > >> back. The function hasn't

Re: [PATCH] staging: atomisp: clean up return logic, remove redunant code

On Sun, 12 Mar 2017, walter harms wrote: > > > Am 11.03.2017 20:32, schrieb Colin King: > > From: Colin Ian King > > > > There is no need to check if ret is non-zero, remove this > > redundant check and just return the error status from the call > > to

Re: [Outreachy kernel] Re: [PATCH 1/7] staging: media: Remove unnecessary typecast of c90 int constant

On Fri, 3 Mar 2017, SIMRAN SINGHAL wrote: > On Fri, Mar 3, 2017 at 11:15 PM, Sakari Ailus wrote: > > Hi Simran, > > > > On Fri, Mar 03, 2017 at 01:21:56AM +0530, simran singhal wrote: > >> This patch removes unnecessary typecast of c90 int constant. > >> > >> WARNING:

Re: [Outreachy kernel] [PATCH] staging: media: Remove parentheses from return arguments

On Fri, 3 Mar 2017, simran singhal wrote: > The sematic patch used for this is: > @@ > identifier i; > constant c; > @@ > return > - ( > \(i\|-i\|i(...)\|c\) > - ) > ; > > Signed-off-by: simran singhal <singhalsimr...@gmail.com> Ac

Re: [patch] [media] uvcvideo: freeing an error pointer

To put it another way, tools can figure out what is missing if they have access to good exmples of what should be there. To be clear, I can see both points of view. julia -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to

Re: [patch] [media] uvcvideo: freeing an error pointer

On Mon, 28 Nov 2016, Dan Carpenter wrote: > I understand the comparison, but I just think it's better if people > always keep track of what has been allocated and what has not. I tried > so hard to get Markus to stop sending those hundreds of patches where > he's like "this function has a

question about hva_hw_probe

The function hva_hw_probe in the file drivers/media/platform/sti/hva/hva-hw.c contains the following code: /* get memory for esram */ esram = platform_get_resource(pdev, IORESOURCE_MEM, 1); if (IS_ERR_OR_NULL(esram)) { dev_err(dev, "%s failed to get

Re: [PATCH] Staging:media:davinci_vpfe: used devm_kzalloc in place of kzalloc

On Wed, 2 Nov 2016, Nadim Almas wrote: > Switch to resource-managed function devm_kzalloc instead > of kzolloc and remove unneeded kzfree > > Also, remove kzfree in probe function and remove > function,vpfe_remove as it is now has nothing to do. > The Coccinelle semantic patch used to make

Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()

On Mon, 24 Oct 2016, Mauro Carvalho Chehab wrote: > Em Mon, 24 Oct 2016 23:28:44 +0100 > Andrey Utkin escreveu: > > > On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote: > > > From: Markus Elfring > > > Date: Mon, 24 Oct

Re: [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

On Tue, 11 Oct 2016, Mauro Carvalho Chehab wrote: > Em Tue, 11 Oct 2016 15:16:24 +0200 (CEST) > Julia Lawall <julia.law...@lip6.fr> escreveu: > > > On Tue, 11 Oct 2016, Julia Lawall wrote: > > > > > It looks like a lock may be needed before line 174. >

Re: [linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

On Tue, 11 Oct 2016, Julia Lawall wrote: > It looks like a lock may be needed before line 174. Sorry, an unlock. > > julia > > -- Forwarded message -- > Date: Tue, 11 Oct 2016 21:06:18 +0800 > From: kbuild test robot <fengguang...@intel.com> >

[linux-review:Mauro-Carvalho-Chehab/Don-t-use-stack-for-DMA-transers-on-media-usb-drivers/20161011-182408 3/31] drivers/media/usb/dvb-usb/cinergyT2-core.c:174:2-8: preceding lock on line 169

It looks like a lock may be needed before line 174. julia -- Forwarded message -- Date: Tue, 11 Oct 2016 21:06:18 +0800 From: kbuild test robot <fengguang...@intel.com> To: kbu...@01.org Cc: Julia Lawall <julia.law...@lip6.fr> Subject: [linux-review:Mauro-Carvalh

Re: kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation)

On Wed, 5 Oct 2016, Jani Nikula wrote: > On Wed, 05 Oct 2016, Daniel Vetter wrote: > > Jani Nikula has a patch with a scrip to make the one kernel-doc parser > > into a lint/checker pass over the entire kernel. I think that'd would > > be more robust instead of trying to

Re: [PATCH 00/15] improve function-level documentation

parameters etc. But the set of patches is not exhaustive with respect to the remaining interesting ones either. julia > > Jani, can you pls digg out these patches? Can't find them right now ... > -Daniel > > > On Sat, Oct 1, 2016 at 9:46 PM, Julia Lawall <julia.law...@lip6.fr> w

Re: [PATCH 00/15] improve function-level documentation

On Sat, 1 Oct 2016, Joe Perches wrote: > On Sat, 2016-10-01 at 21:46 +0200, Julia Lawall wrote: > > These patches fix cases where the documentation above a function definition > > is not consistent with the function header. Issues are detected using the > > seman

[PATCH 00/15] improve function-level documentation

These patches fix cases where the documentation above a function definition is not consistent with the function header. Issues are detected using the semantic patch below (http://coccinelle.lip6.fr/). Basically, the semantic patch parses a file to find comments, then matches each function

[PATCH 05/15] dma-buf/sw_sync: improve function-level documentation

Adjust the documentation to use the names that appear in the function parameter list. Issue detected using Coccinelle (http://coccinelle.lip6.fr/) Signed-off-by: Julia Lawall <julia.law...@lip6.fr> --- drivers/dma-buf/sw_sync.c |6 +++--- 1 file changed, 3 insertions(+), 3 del

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 04:43:58PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> writes: > > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Felipe Balbi wrote: > > Hi, > > Jarkko Sakkinen <jarkko.sakki...@linux.intel.com> writes: > > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > >> > >> > >> On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > >

Re: [PATCH 00/26] constify local structures

On Mon, 12 Sep 2016, Jarkko Sakkinen wrote: > On Mon, Sep 12, 2016 at 10:54:07AM +0200, Julia Lawall wrote: > > > > > > On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > > > > > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrot

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Jarkko Sakkinen wrote: > On Sun, Sep 11, 2016 at 03:05:42PM +0200, Julia Lawall wrote: > > Constify local structures. > > > > The semantic patch that makes this change is as follows: > > (http://coccinelle.lip6.fr/) > > Just my two cents b

Re: [PATCH 00/26] constify local structures

On Sun, 11 Sep 2016, Joe Perches wrote: > On Sun, 2016-09-11 at 15:05 +0200, Julia Lawall wrote: > > Constify local structures. > > Thanks Julia. > > A few suggestions & questions: > > Perhaps the script should go into scripts/coccinelle/ > so that future

  1   2   3   4   >