[PATCH 7/7 v2] mx2-emmaprp: Add copy time stamp handling

Since the introduction of the timestamp_type field, it is necessary that the driver chooses which type it will use. This patch adds support for the timestamp_type. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Sylwester Nawrocki

[GIT PULL] m2m: Time stamp related fixes

Hi Mauro, Sorry for posting this so late. The patches in this pull request add timestamp_type handling to mem2mem drivers. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center The following changes since commit 5f3f254f7c138a22a544b80ce2c14a3fc4ed711e

RE: [GIT PULL] m2m: Time stamp related fixes

Hi, From: Mauro Carvalho Chehab [mailto:mche...@redhat.com] Sent: Thursday, April 25, 2013 2:45 PM Em Thu, 25 Apr 2013 14:11:04 +0200 Kamil Debski k.deb...@samsung.com escreveu: Hi Mauro, Sorry for posting this so late. The patches in this pull request add timestamp_type handling

RE: [PATCH 4/7 v2] coda: Add copy time stamp handling

Hi Philipp, Thank you for testing the patch. I would love to add your Tested-by tag to the commit, but I had already sent the pull request to Mauro. It was already very late to post fixes. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message

RE: [PATCH -next] [media] s5p-mfc: fix error return code in s5p_mfc_probe()

Hi Wei, Thank you for your patch. Best wishes, Kamil Debski From: Wei Yongjun [mailto:weiyj...@gmail.com] Sent: Thursday, April 18, 2013 5:18 AM From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as returned

RE: Exact behavior of the EOS event?

this? Regards, Hans -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GIT PULL] s5p-mfc: decoder fix

was decoded. This is the recommended way to end decoding. It was originally sent in January as a part of a 3 patch series. Other patches were pure fixes and already got merged. In addition, I included a recent fix by Hans Verkuil. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD

RE: [PATCH v2] [media] s5p-mfc: Modify encoder buffer alloc sequence

, + .init_enc_buffers = s5p_mfc_run_init_enc_buffers_v6, .encode_one_frame = s5p_mfc_encode_one_frame_v6, .try_run = s5p_mfc_try_run_v6, .cleanup_queue = s5p_mfc_cleanup_queue_v6, -- 1.7.9.5 Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from

RE: MFC decode failed in S5PV210 in kernel 3.8

for Exynos4 series : for s5p-mfc.fw- For v5 firmware used in Exynos4 series Does the firmware have any relation with compiler armhf or armef? There is no relation. s5p-mfc.fw is good for Exynos4 you are using (S5PV210). Thanks. -- Kamil Debski Linux Platform Group Samsung Poland RD Center

RE: MFC decode failed in S5PV210 in kernel 3.8

-c mpeg4 -i shrek.m4v V4L2 Codec decoding example application Kamil Debski k.deb...@samsung.com Copyright 2012 Samsung Electronics Co., Ltd. (fb.c:fb_open:51): Framebuffer properties: xres=1024, yres=768, bpp=32 (fb.c:fb_open:53): Virtual resolution: vxres=1024 vyres=768 (fimc.c:fimc_open

RE: MFC decode failed in S5PV210 in kernel 3.8

Hi, This problem is known to us and Marek is planning a fix. However, the problem proved to be quite difficult, so please be patient. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Lonsn [mailto:lonsn2...@gmail.com] Sent

RE: [PATCH] [media] s5p-mfc: Fix frame skip bug

Hi Arun, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Arun Kumar K [mailto:arun...@samsung.com] Sent: Tuesday, February 26, 2013 11:02 PM To: linux-media@vger.kernel.org Cc: k.deb...@samsung.com

[PATCH 0/3 v2] Add proper timestamp types handling in videobuf2

timestamp type. Best wishes, Kamil Debski PS. Below please find the original cover letter. Hi, The recent addition of timestamp types (and monotonic timestamp) left some room for improvement. First of all not all drivers use monotonic timestamp. There are for example mem2mem drivers that copy

RE: [PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

Hi, From: Sakari Ailus [mailto:sakari.ai...@iki.fi] Sent: Saturday, January 19, 2013 6:43 PM Hi Kamil, Thanks for the patch. On Mon, Jan 14, 2013 at 10:36:04AM +0100, Kamil Debski wrote: Set proper timestamp type in drivers that I am sure that use either MONOTONIC or COPY timestamps

RE: [PATCH] s5p-g2d: Add support for G2D H/W Rev.4.1

Hi Sachin, I tested your patch on Exynos 4210 and it works. Ack on my side. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Wednesday, January 16, 2013 11:24 AM To: Sylwester Nawrocki Cc: linux-media

[PATCH/RFC 0/3] Add proper timestamp types handling in videobuf2

or COPY in vb2_queue_init. This patch also adds setting proper timestamp type value in case of drivers where I determined that type. This list might be missing some drivers, but in these cases it will leave the UNKNOWN type which is a safe assumption. Best wishes, Kamil Debski Kamil Debski (3

[PATCH 3/3] v4l: Set proper timestamp type in selected drivers which use videobuf2

Set proper timestamp type in drivers that I am sure that use either MONOTONIC or COPY timestamps. Other drivers will correctly report UNKNOWN timestamp type instead of assuming that all drivers use monotonic timestamps. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park

[PATCH 1/3] v4l: Define video buffer flag for the COPY timestamp type

Define video buffer flag for the COPY timestamp. In this case the timestamp value is copied from the OUTPUT to the corresponding CAPTURE buffer. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/io.xml

[PATCH 2/3] vb2: Add support for non monotonic timestamps

Not all drivers use monotonic timestamps. This patch adds a way to set the timestamp type per every queue. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/v4l2-core/videobuf2-core.c |5 +++-- include/media/videobuf2

[PATCH 1/3] s5p-mfc: Fix a watchdog bug

Fixed wrong condition in firmware reload function used by the watchdog. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/3] s5p-mfc: Add support for EOS command and EOS event in video decoder

Add support for V4L2_DEC_CMD_STOP command which will instruct MFC device to finish decoding and release all remaining frames kept for reference to the user. After dequeueing last decoded frame the driver will generate an V4L2_EVENT_EOS event. Signed-off-by: Kamil Debski k.deb...@samsung.com

[PATCH 3/3] s5p-mfc: end-of-stream handling in encoder bug fix

In some circumstances after issuing the V4L2_ENC_CMD_STOP the application could freeze. This patch prevents this behavior. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c |2 ++ 1 file

[PATCH 1/3 RESEND] s5p-mfc: Move firmware allocation point to avoid allocation problems

Move firmware allocation from open to probe to avoid problems when using CMA for allocation. In certain circumstances CMA may allocate buffer that is not in the beginning of the MFC memory area. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 2/3 RESEND] s5p-mfc: Correct check of vb2_dma_contig_init_ctx return value

vb2_dma_contig_init_ctx returns an error if failed, NULL check is not necessary. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/3 RESEND] s5p-mfc: Change internal buffer allocation from vb2 ops to dma_alloc_coherent

Change internal buffer allocation from vb2 memory ops call to direct calls of dma_alloc_coherent. This change shortens the code and makes it much more readable. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p

RE: [PATCH -next] [media] s5p-mfc: remove unused variable

Hi Wei, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Wei Yongjun Sent: Sunday, December 02, 2012 1:17 PM

RE: [PATCH-Trivial] [media] s5p-mfc: Fix a typo in error message in s5p_mfc_pm.c

Hi Sachin, Thank you for this patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Wednesday, January 02, 2013 10:14 AM To: linux-media@vger.kernel.org Cc: k.deb

RE: [PATCH Resend] [media] s5p-mfc: Fix an error check

Hi Sachin, Thank you for finding and correcting this. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: Wednesday, January 02, 2013 11:46 AM To: linux-media@vger.kernel.org Cc

RE: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break'

Hi Sachin, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Sachin Kamat Sent: Friday, December 28, 2012 11:18 AM

RE: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk

Hi Sachin, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Sachin Kamat Sent: Friday, December 28, 2012 11:18 AM To: linux-media

[PATCH v2] s5p-mfc: Fix interrupt error handling routine

New context states were added but handling in s5p_mfc_handle_error for these states was not. After this patch these states are be handled correctly. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Hi, This is exatly the same patch

RE: [PATCH] [media] s5p-mfc: Flush DPB buffers during stream off

Hi Arun, Thank you for your patch. Tested in my environment (Exynos4/MFC5.1) Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Arun Kumar K [mailto:arun...@samsung.com] Sent: Thursday, November 22, 2012 11:16 AM To: linux-media

RE: [PATCH 4/4] v4l: Tell user space we're using monotonic timestamps

-v4l2_buf.flags = b-flags ~V4L2_BUFFER_MASK_FLAGS; } /** Acked-by: Hans Verkuil hans.verk...@cisco.com Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

RE: [PATCH 4/4] v4l: Tell user space we're using monotonic timestamps

From: 'Sakari Ailus' [mailto:sakari.ai...@iki.fi] Sent: Monday, December 17, 2012 12:35 PM Subject: Re: [PATCH 4/4] v4l: Tell user space we're using monotonic timestamps Hi Kamil, On Mon, Dec 17, 2012 at 12:19:51PM +0100, Kamil Debski wrote: ... @@ -367,7 +368,8 @@ static void

RE: [PATCH] s5p-mfc: Fix interrupt error handling routine

, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Hi Kamil, Please add some description about the fix (in the commit log/message). On 12 December 2012 16:49, Kamil Debski k.deb...@samsung.com wrote: Signed-off

[PATCH] s5p-mfc: Fix interrupt error handling routine

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 88 +- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b

RE: [PATCH 4/6] [media] s5p-g2d: Use devm_clk_get APIs.

it is included in the kernel. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Sachin Kamat Sent: Friday, November 23, 2012 12:51 PM

RE: [PATCH 6/6] [media] s5p-mfc: Use devm_clk_get APIs

it is included in the kernel. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Sachin Kamat Sent: Friday, November 23, 2012 12:51 PM

[PATCH] MAINTAINERS: add g2d entry.

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b623679..c675df0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1092,6 +1092,14

RE: [PATCH] [media] exynos-gsc: propagate timestamps from src to dst buffers

? Definite yes, if my assumption above is true. I did reply to your RFC suggesting to include this, but got no reply whatsoever. Maybe it got lost somewhere. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH] s5p-mfc: Context handling in open() bugfix

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p

RE: [PATCH] [media] s5p-mfc: Bug fix of timestamp/timecode copy mechanism

. Signed-off-by: Sunil Mazhavanchery sun...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Acked-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media

[PATCH] s5p-mfc: Fix buffer allocation in s5p_mfc_alloc_instance_buffer_v5

The s5p-mfc: Change internal buffer allocation from vb2 ops to dma_alloc_coherent patch has introduced a bug with allocation of instance buffers buffers in MFC 5.1. This patch fixes this bug. Reported-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off

RE: [PATCH v1] s5p-mfc: Add device tree support

Hi Arun, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: Saturday, November 03, 2012 1:02 PM Subject: [PATCH v1] s5p-mfc: Add device tree support This patch will add the device tree

[PATCH 1/4] s5p-mfc: Move firmware allocation point to avoid allocation problems

Move firmware allocation from open to probe to avoid problems when using CMA for allocation. In certain circumstances CMA may allocate buffer that is not in the beginning of the MFC memory area. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 2/4] s5p-mfc: Correct check of vb2_dma_contig_init_ctx return value

vb2_dma_contig_init_ctx returns an error if failed, NULL check is not necessary. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 3/4] s5p-mfc: Fix vidioc_subscribe_event declaration

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc_enc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_enc.c b/drivers/media/platform

[PATCH 4/4] s5p-mfc: Change internal buffer allocation from vb2 ops to dma_alloc_coherent

Change internal buffer allocation from vb2 memory ops call to direct calls of dma_alloc_coherent. This change shortens the code and makes it much more readable. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p

RE: [PATCH v9 0/6] Update MFC v4l2 driver to support MFC6.x

Hi Arun, Thank you for your hard work with these patches. I think that they are ready to be merged. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 02 October 2012 16:56 The patchset adds support for MFCv6

RE: [PATCH v9 1/6] [media] v4l: Add fourcc definitions for new formats

Signed-off-by: Jeongtae Park jtp.p...@samsung.com Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Acked-by: Kamil Debski k.deb...@samsung.com --- Documentation/DocBook/media/v4l/pixfmt-nv12m.xml | 17 - Documentation

RE: [PATCH v9 2/6] [media] v4l: Add control definitions for new H264 encoder features

...@samsung.com Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Acked-by: Kamil Debski k.deb...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml | 268 +- drivers/media/v4l2-core/v4l2-ctrls.c

RE: [PATCH v9 4/6] [media] s5p-mfc: Add MFC variant data to device context

jtp.p...@samsung.com Signed-off-by: Janghyuck Kim janghyuck@samsung.com Signed-off-by: Jaeryul Oh jaeryul...@samsung.com Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Acked-by: Kamil Debski k.deb...@samsung.com --- drivers

RE: [PATCH v9 5/6] [media] s5p-mfc: MFCv6 register definitions

-by: Jaeryul Oh jaeryul...@samsung.com Signed-off-by: Naveen Krishna Chatradhi ch.nav...@samsung.com Signed-off-by: Arun Kumar K arun...@samsung.com Acked-by: Kamil Debski k.deb...@samsung.com --- drivers/media/platform/s5p-mfc/regs-mfc-v6.h | 408 ++ 1 files changed, 408

RE: [PATCH] [media] s5p-mfc: Fix misplaced return statement in s5p_mfc_suspend()

Hi Sachin, Thank you for your patch, fixing this bug and testing suspend/resume. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 28 September 2012 09:02 To: linux-media

RE: [PATCH v6 6/6] [media] s5p-mfc: Update MFC v4l2 driver to support MFC6.x

Hi Arun, Please find my comment inline. It seems that we're very close to an ACK :) PS - you missed me in CC when posting this patch (6/6). Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center Subject: [PATCH v6 6/6] [media] s5p-mfc: Update MFC v4l2 driver to support

RE: Re: [RFC] Timestamps and V4L2

, but is not that necessary, as they return buffers CAPTURE in the same order as OTUPUT buffers, which they were generated from. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

RE: [PATCH] v4l/s5p-mfc: added support for end of stream handling in MFC encoder

Hi Andrzej, Thank you for your patch and sorry for such a late reply. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Andrzej Hajda Sent

RE: [PATCH v5 2/4] [media] s5p-mfc: Add MFC variant data to device context

Hi Arun, Please find my comments below. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 27 August 2012 04:58 [...] diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_common.h b/drivers/media/video/s5p-mfc

RE: [PATCH v5 1/4] [media] s5p-mfc: Update MFCv5 driver for callback based architecture

Hi Arun, Please find my comments inline. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 27 August 2012 04:58 [...] diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p- mfc/s5p_mfc.c

RE: [PATCH v4 1/4] [media] s5p-mfc: Update MFCv5 driver for callback based architecture

) ? \ + (f)-pipeline_ops-op((p), ##args) : -ENOIOCTLCMD)) (from commit by Sylwester Nawrocki http://goo.gl/Q657j) In addition, your code does not check whether the ops pointer is null and I think that it should be done. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland

RE: [PATCH v4 2/4] [media] s5p-mfc: Add MFC variant data to device context

Hi Arun, Please find the comments in the patch contents. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 09 August 2012 12:28 From: Jeongtae Park jtp.p...@samsung.com MFC variant data replaces various

RE: [PATCH v4 3/4] [media] s5p-mfc: MFCv6 register definitions

Hi Arun, Please find the comments in the patch contents. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 09 August 2012 12:28 From: Jeongtae Park jtp.p...@samsung.com Adds register definitions for MFC v6.x

RE: [PATCH v4 4/4] [media] s5p-mfc: Update MFC v4l2 driver to support MFC6.x

Hi Arun, Please find the comments in the patch contents. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 09 August 2012 12:29 From: Jeongtae Park jtp.p...@samsung.com [snip] diff --git a/drivers/media

RE: [PATCH] v4l/s5p-mfc: optimized code related to working contextes

Hi Andrzej, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Andrzej Hajda [mailto:a.ha...@samsung.com] Sent: 14 August 2012 11:14 All code setting/clearing working context bits has been moved to separate functions. set_bit

RE: [PATCH] v4l/s5p-mfc: added DMABUF support for encoder

Hi Andrzej, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Andrzej Hajda [mailto:a.ha...@samsung.com] Sent: 14 August 2012 11:30 Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

RE: [PATCH,RESEND] v4l/s5p-mfc: added support for end of stream handling in MFC encoder

Hi Andrzej, Thank you for your patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Andrzej Hajda [mailto:a.ha...@samsung.com] Sent: 10 August 2012 14:47 s5p-mfc encoder after receiving V4L2_ENC_CMD_STOP command will instruct MFC device to release all

RE: [PATCH v3 0/4] update MFC v4l2 driver to support MFC6.x

compiles. If you look at the patches it can be seen that the order is wrong. First Kconfig is modified and it requires files added in further patches. More comments in reply to specific patches. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message

RE: [PATCH v3 4/4] [media] s5p-mfc: New files for MFCv6 support

Hi Arun, Please find my comments below. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 23 July 2012 14:29 From: Jeongtae Park jtp.p...@samsung.com New register definitions, commands and hardware

RE: [PATCH v3 1/4] [media] s5p-mfc: update MFC v4l2 driver to support MFC6.x

Hi Arun, Please find my comments below. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 23 July 2012 14:29 From: Jeongtae Park jtp.p...@samsung.com Multi Format Codec 6.x is a hardware video coding

RE: [PATCH/RFC 1/2] V4L: Add capability flags for memory-to-memory devices

Nawrocki sylvester.nawro...@gmail.com For s5p-mfc and g2d: Acked-by: Kamil Debski k.deb...@samsung.com -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] s5p-mfc: Fix second memory bank alignment

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/video/s5p

[PATCH 2/2] s5p-mfc: support for dmabuf exporting fix

Added select DMA_SHARED_BUFFER to the Kconfig of the MFC. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/Kconfig b

RE: [PATCH v2 2/2] [media] s5p-mfc: update MFC v4l2 driver to support MFC6.x

Hi Arun, Please find some additional comments below. From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 06 July 2012 16:00 [snip] diff --git a/drivers/media/video/s5p-mfc/Makefile b/drivers/media/video/s5p-mfc/Makefile index d066340..0308d74 100644 ---

RE: [PATCH v2 0/2] update MFC v4l2 driver to support MFC6.x

not compile. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Arun Kumar K [mailto:arun...@samsung.com] Sent: 06 July 2012 16:00 To: linux-media@vger.kernel.org Cc: jtp.p...@samsung.com; janghyuck@samsung.com; jaeryul...@samsung.com

RE: [PATCH v1] s5p-mfc: update MFC v4l2 driver to support MFC6.x

Hi Arun, First of all - your patch is incomplete. I cannot find a modified videodev2.h file. Compilation fails with a lot of undefined symbols - attached below. Please supply this file, then I will be able to provide you with more comments and a proper review. Best wishes, -- Kamil Debski Linux

[PATCH] s5p-mfc: Fixed setup of custom controls in decoder and encoder

Fixed bugs in functions that initialize custom controls. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-mfc/s5p_mfc_dec.c |1 + drivers/media/video/s5p-mfc/s5p_mfc_enc.c |1 + 2 files changed, 2

RE: [PATCH] s5p-mfc: Fix setting controls

Hi Naveen, Today I have posted a patch that should resolve your problems with setting controls ([PATCH] s5p-mfc: Fixed setup of custom controls in decoder and encoder). Please check if it works now. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original

RE: [RFC PATCH 25/26] s5p-mfc: remove V4L2_FL_LOCK_ALL_FOPS

Hi Hans, Thank you for your patch. I have tested it on our hardware and MFC works. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: 24 June 2012 13:26 To: linux-media@vger.kernel.org

RE: [RFC PATCH 21/26] s5p-g2d: remove V4L2_FL_LOCK_ALL_FOPS

Hi Hans, Thank you for your patch. I have tested it on our hardware and G2D works. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: 24 June 2012 13:26 To: linux-media@vger.kernel.org

[PATCH] s5p-fimc: Fix control creation function

Fixed the size of the V4L2_CID_COLORFX control cluster. Prior to this fix V4L2_CID_ROTATE was also icluded in the cluster preventing applications from enabling rotation. Reported-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin

[PATCH] s5p-mfc: Fix setting controls

Fixed s_ctrl function when setting the following controls: - V4L2_CID_MPEG_VIDEO_DECODER_MPEG4_DEBLOCK_FILTER - V4L2_CID_MPEG_MFC51_VIDEO_DECODER_H264_DISPLAY_DELAY Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p

RE: [PATCH] v4l/s5p-mfc: added image size align in VIDIOC_TRY_FMT

Hi Andrzej, Thank you for the patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Andrzej Hajda [mailto:a.ha...@samsung.com] Sent: 14 June 2012 09:11 To: linux-media@vger.kernel.org Cc: Hans Verkuil; Marek Szyprowski; Kamil

RE: [PATCH] v4l/s5p-mfc: corrected encoder v4l control definitions

Hi Andrzej, Thank you for the patch. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Andrzej Hajda [mailto:a.ha...@samsung.com] Sent: 14 June 2012 09:04 To: linux-media@vger.kernel.org Cc: Hans Verkuil; Marek Szyprowski; Kamil

RE: [PATCH] [media] s5p-mfc: Fix checkpatch error in s5p_mfc_shm.h file

Hi, Thanks for the patch. Best wishes, Kamil Debski From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 11 June 2012 12:59 Fixes the following error: ERROR: open brace '{' following enum go on the same line +enum MFC_SHM_OFS +{ Signed-off-by: Sachin Kamat sachin.ka

RE: [PATCH 2/3] [media] s5p-mfc: Replace printk with pr_* functions

pr_err I share the opinion on these patch with Sylwester's opinion on the similar patch for FIMC - I don't think it's worth the effort. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent

[PATCH] s5p-mfc: Bug fix of timestamp/timecode copy mechanism

Fixed the code copying timecode/timestamp to corresponding frames between OUTPUT and CAPTURE. Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-mfc/regs-mfc.h|5 + drivers/media/video/s5p-mfc

RE: [PATCH 1/2] [media] s5p-mfc: Fix NULL pointer warnings

Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland RD Center From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 10 May 2012 08:32 Fixes the following type of warnings detected by sparse: warning: Using plain integer as NULL pointer

RE: [PATCH 2/2] [media] s5p-mfc: Add missing static storage class to silence warnings

Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 10 May 2012 08:32 To: linux-media@vger.kernel.org Cc: mche...@infradead.org; k.deb

RE: [PATCH 1/2] [media] s5p-g2d: Fix NULL pointer warnings in g2d.c file

Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 10 May 2012 08:36 To: linux-media@vger.kernel.org Cc: mche...@infradead.org; k.deb

RE: [PATCH 2/2] [media] s5p-g2d: Add missing static storage class in g2d.c file

Hi Sachin, Thanks for the patch. Best regards, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -Original Message- From: Sachin Kamat [mailto:sachin.ka...@linaro.org] Sent: 10 May 2012 08:36 To: linux-media@vger.kernel.org Cc: mche...@infradead.org; k.deb

RE: [RFC/PATCH] v4l: added V4L2_BUF_FLAG_EOS flag indicating the last frame in the stream

decoding - now it is done by setting bytesused to 0. The EOS flag could be used in addition to that. Comments are welcome. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

RE: [Q] media: V4L2 compressed frames and s_fmt.

Hi Javier, hi Jeongtae, Please see my comments below. -Original Message- From: javier Martin [mailto:javier.mar...@vista-silicon.com] Sent: 15 March 2012 15:31 To: Kamil Debski Cc: Sakari Ailus; linux-media@vger.kernel.org Subject: Re: [Q] media: V4L2 compressed frames and s_fmt

RE: [Q] media: V4L2 compressed frames and s_fmt.

decoding. Here the question is about encoding. Kamil: do you have plans to update the RFC? As Javier is now working on a codec driver then it might the right time to bring the discussion back to life. Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe

RE: [PATCH 1/1] media: video: s5p-g2d: Add support for FIMG2D v4 H/W logic

g2d_cmd_stretch(u32 e); +void g2d_cmd_stretch(struct g2d_dev *d, + struct g2d_frame *src, struct g2d_frame *dst); void g2d_set_cmd(struct g2d_dev *d, u32 c); -- 1.7.0.4 Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from

RE: [PATCH 1/3] v4l: add contorl definitions for codec devices.

Park jtp.p...@samsung.com Cc: Marek Szyprowski m.szyprow...@samsung.com Cc: Kamil Debski k.deb...@samsung.com --- include/linux/videodev2.h | 51 ++-- 1 files changed, 48 insertions(+), 3 deletions(-) diff --git a/include/linux/videodev2.h b

RE: [PATCH 0/3] Multi Format Codec 6.x driver for Exynos5

/video/s5p-mfc/s5p_mfc_cmd_v6.c create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_opr_v6.c create mode 100644 drivers/media/video/s5p-mfc/s5p_mfc_opr_v6.h Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe

V4L2 MFC video decoding example application

-example Best wishes, -- Kamil Debski Linux Platform Group Samsung Poland RD Center The above message is intended solely for the named addressee and may contain trade secret, industrial technology or privileged and confidential information otherwise protected under applicable law. Any

[PATCH] s5p-g2d: Added support for clk_prepare

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/s5p-g2d/g2d.c | 22 -- 1 files changed, 20 insertions(+), 2 deletions(-) diff --git

[PATCH] s5p-g2d: Added locking for writing control values to registers

While at it I have removed an unused default case (control fw takes care of that). Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/s5p-g2d/g2d.c | 14

[PATCH] s5p-mfc: Added support for clk_prepare

Signed-off-by: Kamil Debski k.deb...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com --- drivers/media/video/s5p-mfc/s5p_mfc_pm.c | 24 ++-- 1 files changed, 22 insertions(+), 2 deletions(-) diff

<    1   2   3   4   5   6   >