[PATCH v8 1/3] media: dt: bindings: Add binding for tango HW IR decoder

2017-10-06 Thread Marc Gonzalez
Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- .../devicetree/bindings/media/tango-ir.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devi

[PATCH v8 3/3] media: rc: Add driver for tango HW IR decoder

2017-10-06 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Mans Rullgard <m...@mansr.com> Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- Changes between v7 and v8 * RC_MAP_TANGO as default keymap * Defi

[PATCH v8 2/3] media: rc: Add tango keymap

2017-10-06 Thread Marc Gonzalez
Add a keymap for the Sigma Designs Vantage (dev board) remote control. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- Changes between v7 and v8 * Add legalese boiler plate * Define RC_PROTO_NECX * Move RC_MAP_TANGO to alphabetical order --- drivers/media/rc/keymaps/Ma

Re: [PATCH v7 3/3] media: rc: Add tango keymap

2017-10-06 Thread Marc Gonzalez
On 06/10/2017 12:47, Måns Rullgård wrote: > Sean Young writes: > >> Looks great, just some minor nitpicks. >> >> I think you need a header with copyright statement and GPL version(s). > > Is this even copyrightable? My thoughts, exactly. I don't mind *not* providing a copyright statement and

[PATCH v7 2/3] media: rc: Add driver for tango HW IR decoder

2017-10-05 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Mans Rullgard <m...@mansr.com> Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- drivers/media/rc/Kconfig| 10 ++ drivers/media/rc/Makefile

[PATCH v7 1/3] media: dt: bindings: Add binding for tango HW IR decoder

2017-10-05 Thread Marc Gonzalez
Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- .../devicetree/bindings/media/tango-ir.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devi

[PATCH v7 3/3] media: rc: Add tango keymap

2017-10-05 Thread Marc Gonzalez
Add a keymap for the Sigma Designs Vantage (dev board) remote control. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- drivers/media/rc/keymaps/Makefile | 1 + drivers/media/rc/keymaps/rc-tango.c | 84 + drivers/media/rc/tang

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-10-04 Thread Marc Gonzalez
On 26/09/2017 10:51, Marc Gonzalez wrote: > From: Mans Rullgard <m...@mansr.com> > > The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. > > Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> > --- > Changes between v5 and v6 > * Move &qu

Re: [PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-26 Thread Marc Gonzalez
On 26/09/2017 15:02, Måns Rullgård wrote: > I could continue nit-picking, but I think this is good enough. > Thanks for being patient. > > Signed-off-by: Mans Rullgard Smirk. If you feel like making a final round of changes on top of this patch, then go for it. It's your code,

[PATCH v6 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-26 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- Changes between v5 and v6 * Move "register fields" macros to top of file * Restore IRQ pending writes --- dr

[PATCH v5 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- Changes between v4 and v5 * Restore inits in same order as original driver (except for devm_rc_allocate_d

Re: [PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Marc Gonzalez
On 25/09/2017 16:08, Måns Rullgård wrote: > Marc Gonzalez writes: > > Why did you put this way early now? Registering the device should be > the last thing you do (LIKE I DID IT, DAMMIT). Otherwise something might > try to use it before it is fully configured.

[PATCH v4 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-25 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- Changes between v3 and v4 * Add one line to Kconfig help message * Add DRIVER_NAME macro * Move devm_request_irq() cal

[PATCH v4 1/2] media: dt: bindings: Add binding for tango HW IR decoder

2017-09-25 Thread Marc Gonzalez
Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- .../devicetree/bindings/media/tango-ir.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devi

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
On 21/09/2017 17:57, Sean Young wrote: > On Thu, Sep 21, 2017 at 04:49:53PM +0200, Marc Gonzalez wrote: > >> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. >> >> Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> > > Missing signed-of

Re: [PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
On 21/09/2017 17:46, Måns Rullgård wrote: > Marc Gonzalez writes: > >> From: Mans Rullgard <m...@mansr.com> >> >> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. >> >> Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> &

[PATCH v3 2/2] media: rc: Add driver for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- drivers/media/rc/Kconfig| 9 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/tang

[PATCH v3 1/2] media: dt: bindings: Add binding for tango HW IR decoder

2017-09-21 Thread Marc Gonzalez
Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- .../devicetree/bindings/media/tango-ir.txt | 21 + 1 file changed, 21 insertions(+) create mode 100644 Documentation/devi

Re: [PATCH v2] media: rc: Add driver for tango IR decoder

2017-09-21 Thread Marc Gonzalez
On 21/09/2017 13:25, Sean Young wrote: > On Wed, Sep 20, 2017 at 10:39:11AM +0200, Marc Gonzalez wrote: > >> From: Mans Rullgard <m...@mansr.com> >> >> The tango IR decoder supports NEC, RC-5, RC-6 protocols. >> >> Signed-off-by: Marc Gonzalez <ma

[PATCH v2] media: rc: Add driver for tango IR decoder

2017-09-20 Thread Marc Gonzalez
From: Mans Rullgard <m...@mansr.com> The tango IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- Changes from v1 to v2 o Fixup a syntax error introduced by search & replace o Bring back support for linux,rc-map

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
+ Rob & Mark for the DT bindings question. On 19/09/2017 14:21, Måns Rullgård wrote: > Marc Gonzalez writes: > >> On 18/09/2017 17:33, Måns Rullgård wrote: >> >>> What have you changed compared to my original code? >> >> I forgot to mention one

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
On 18/09/2017 17:33, Måns Rullgård wrote: > What have you changed compared to my original code? I forgot to mention one change you may not approve of, so we should probably discuss it. Your driver supported an optional DT property "linux,rc-map-name" to override the RC_MAP_EMPTY map. Since the

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
On 19/09/2017 11:48, Måns Rullgård wrote: > Did you test the NEC32 variant? I don't have anything that produces > such codes. I don't have a NEC32 IR remote control either. IIUC, NEC32 means 16-bit address and 16-bit command. I checked the RTL with a HW engineer. The HW block translates the

Re: [PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-19 Thread Marc Gonzalez
On 18/09/2017 17:33, Måns Rullgård wrote: > Marc Gonzalez writes: > >> diff --git a/drivers/media/rc/Kconfig b/drivers/media/rc/Kconfig >> index d9ce8ff55d0c..f84923289964 100644 >> --- a/drivers/media/rc/Kconfig >> +++ b/drivers/media/rc/Kconfig >>

[PATCH] media: rc: Delete duplicate debug message

2017-09-18 Thread Marc Gonzalez
ir_setkeytable() and ir_create_table() print the same debug message. Delete the one in ir_setkeytable() Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- drivers/media/rc/rc-main.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/media/rc/rc-main.c b/drivers

[PATCH v1] media: rc: Add driver for tango IR decoder

2017-09-18 Thread Marc Gonzalez
The tango IR decoder supports NEC, RC-5, RC-6 protocols. NB: Only the NEC decoder was tested. Signed-off-by: Marc Gonzalez <marc_gonza...@sigmadesigns.com> --- drivers/media/rc/Kconfig| 5 + drivers/media/rc/Makefile | 1 + drivers/media/rc/tango-ir.c