On 18-11-27 23:15, Sakari Ailus wrote:
> On Tue, Nov 27, 2018 at 11:02:53AM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling edge of PIXCLK (Datasheet R58:1[9]), default
Hi Sakari,
On 18-11-27 15:13, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Nov 27, 2018 at 11:02:52AM +0100, Marco Felsch wrote:
> > Add the pclk-sample property to the list of optional properties
> > for the mt9m111 camera sensor.
> >
> > Signed-off-by: M
Hi Sakari,
On 18-11-27 15:19, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Nov 27, 2018 at 11:02:53AM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling edge of PIX
Replace the vague binding by a more verbose. Remove the remote property
from the example since the driver don't support such a property. Also
remove the bus-width property from the endpoint since the driver don't
take care of it.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index 03559669de9f..9b0a3689fa98 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt9m111
function)
(m.fel...@pengutronix.de: adapt commit msg)
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- call mt9m111_probe_fw() before v4l2_clk_get() to avoid error handling
v2:
- make use of fwnode_*() to drop OF dependency and ifdef's
- mt9m111_g_mbus_config: fix pclk_sample logic which I made
Add callback to check if we are already streaming. Now other callbacks
can check the state and return -EBUSY if we already streaming.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers
Signed-off-by: Marco Felsch
---
Changelog
v3:
- check if sensor window size is set to default and return if not
- check if requested fps is supported by image size and do not update
the image size if requested fps is not supported by selected image
size
- update fps mode only if a mode
Add the pclk-sample property to the list of optional properties
for the mt9m111 camera sensor.
Signed-off-by: Marco Felsch
Reviewed-by: Rob Herring
---
Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree
to setup pixclk polarity
Marco Felsch (3):
media: mt9m111: add s_stream callback
dt-bindings: media: mt9m111: adapt documentation to be more clear
dt-bindings: media: mt9m111: add pclk-sample property
Michael Grzeschik (2):
media: mt9m111: add streaming check to set_fmt
media: mt9m111
Hi Sakari, Hans,
On 18-11-16 15:33, Sakari Ailus wrote:
> Hi Hans,
>
> On Fri, Nov 16, 2018 at 02:31:01PM +0100, Hans Verkuil wrote:
> > On 11/16/2018 02:26 PM, Sakari Ailus wrote:
> > > Hi Marco, Michael,
> > >
> > > On Mon, Oct 29, 2018 at 07:24:0
Hi Sakari,
On 18-11-16 15:32, Sakari Ailus wrote:
> Hi Marco, Enrico,
>
> On Mon, Oct 29, 2018 at 07:24:08PM +0100, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
> > rising or falling
Hi Mauro,
I don't want to spam you. Can you give me some feedback? I know the
merge window is a busy time, so maybe you have some time now.
Regards,
Marco
On 18-10-29 19:41, Marco Felsch wrote:
> Hi Mauro,
>
> just a reminder, Rob already added his ack/rev-by tags.
>
>
Hi Mauro,
just a reminder, Rob already added his ack/rev-by tags.
Thanks,
Marco
On 18-09-18 15:14, Marco Felsch wrote:
> Hi,
>
> this is my v3 with the integrated reviews from my v2 [1]. This serie
> applies to Mauro's experimental.git [2].
>
> @Mauro:
> Patch
-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index e0ac5aa6ea64..1f8789fe28af 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt9m111
Signed-off-by: Marco Felsch
---
Changelog
v2:
- fix updating read mode register, use mt9m111_reg_mask() to update the
relevant bits only. For this purpose add reg_mask field to
struct mt9m111_mode_info.
drivers/media/i2c/mt9m111.c | 163
1 file changed
Add the pclk-sample property to the list of optional properties
for the mt9m111 camera sensor.
Signed-off-by: Marco Felsch
---
Documentation/devicetree/bindings/media/i2c/mt9m111.txt | 5 +
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/i2c/mt9m111.txt
function)
(m.fel...@pengutronix.de: adapt commit msg)
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- make use of fwnode_*() to drop OF dependency and ifdef's
- mt9m111_g_mbus_config: fix pclk_sample logic which I made due the
conversion from Enrico's patch.
drivers/media/i2c/mt9m111.c | 46
Add callback to check if we are already streaming. Now other callbacks
can check the state and return -EBUSY if we already streaming.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers
/lists/linux-media/msg141975.html
[2] https://www.spinics.net/lists/linux-media/msg141987.html
Regards,
Marco
Enrico Scholz (1):
media: mt9m111: allow to setup pixclk polarity
Marco Felsch (3):
media: mt9m111: add s_stream callback
dt-bindings: media: mt9m111: adapt documentation to be more
Replace the vague binding by a more verbose. Remove the remote property
from the example since the driver don't support such a property. Also
remove the bus-width property from the endpoint since the driver don't
take care of it.
Signed-off-by: Marco Felsch
---
.../devicetree/bindings/media/i2c
Hi Sakari,
On 18-10-20 00:24, Sakari Ailus wrote:
> Hi Marco,
>
> Thanks for the patchset.
>
> On Fri, Oct 19, 2018 at 05:50:27PM +0200, Marco Felsch wrote:
> > From: Enrico Scholz
> >
> > The chip can be configured to output data transitions on the
>
-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index 78d08a81e0e2..d060075a670b 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers/media/i2c/mt9m111
: mt9m111: allow to setup pixclk polarity
Marco Felsch (1):
media: mt9m111: add s_stream callback
Michael Grzeschik (2):
media: mt9m111: add streaming check to set_fmt
media: mt9m111: add support to select formats and fps for {Q,SXGA}
drivers/media/i2c/mt9m111.c | 221
function)
(m.fel...@pengutronix.de: adapt commit msg)
Signed-off-by: Marco Felsch
Reviewed-by: Philipp Zabel
---
drivers/media/i2c/mt9m111.c | 52 -
1 file changed, 51 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c
Add callback to check if we are already streaming. Now other callbacks
can check the state and return -EBUSY if we already streaming.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers
Signed-off-by: Marco Felsch
---
drivers/media/i2c/mt9m111.c | 156
1 file changed, 156 insertions(+)
diff --git a/drivers/media/i2c/mt9m111.c b/drivers/media/i2c/mt9m111.c
index d060075a670b..13080c6c1ba3 100644
--- a/drivers/media/i2c/mt9m111.c
+++ b/drivers
Hi Sakari,
On 18-09-19 13:45, Sakari Ailus wrote:
> Hi Marco,
>
> On Tue, Sep 18, 2018 at 03:14:50PM +0200, Marco Felsch wrote:
> > These helpers make us of the media-controller entity which is only
> > available if the CONFIG_MEDIA_CONTROLLER is enabled.
> >
>
?h=tvp5150-4
Javier Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (7):
media: tvp5150: fix irq_request error path during probe
media: tvp5150: add input source selection of_graph support
media: dt-bindings: tvp5150: Add inp
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Signed-
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 23
() callback ensures that only one
connector is active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- probe(): s/err/err_free_v4l2_ctrls
- drop MC dependency for tvp5150_pads
to AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- remove examples for one and two inputs
- replace space by tabs
v2:
- adapt
Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
introduced the interrupt handling. But we have to free the
v4l2_ctrl_handler before we can return the error code.
Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
Signed-
These helpers make us of the media-controller entity which is only
available if the CONFIG_MEDIA_CONTROLLER is enabled.
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- add CONFIG_MEDIA_CONTROLLER switch instead of moving the
v4l2_subdev_get_try_* APIs into the existing one.
v2:
- Initial
or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 109 +---
1 fi
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index b34d0e883c06..535e97c7b266 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
is less error prone too.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 9102d6ca566e..ce48f1fcf295 100644
--- a/include/media/v4l2
Hi,
On 18-09-14 15:57, Mauro Carvalho Chehab wrote:
> Em Fri, 14 Sep 2018 20:20:46 +0200
> Marco Felsch escreveu:
>
> > Hi Sakari,
> >
> > On 18-09-14 16:23, Sakari Ailus wrote:
> > > Hi Marco,
> > >
> > > On Mon, Aug 13, 2018 at 11
Hi Sakari,
On 18-09-14 16:23, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote:
> > Don't en-/disable the interrupts during s_stream because someone can
> > disable the stream but wants to get informed if the stream is lock
Hi Sakari,
On 18-09-14 16:25, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Aug 13, 2018 at 11:25:05AM +0200, Marco Felsch wrote:
> > These helpers make us of the media-controller entity which is only
> > available if the CONFIG_MEDIA_CONTROLLER is enabled.
> >
>
Hi Sakari,
thanks for the review.
On 18-09-14 16:31, Sakari Ailus wrote:
> Hi Marco,
>
> On Mon, Aug 13, 2018 at 11:25:02AM +0200, Marco Felsch wrote:
> ...
> > +static void tvp5150_dt_cleanup(struct tvp5150 *decoder)
> > +{
> > + unsigned int i;
> > +
>
On 18-09-13 18:36, Mauro Carvalho Chehab wrote:
> The parameters of v4l2_ctrl_new_std_menu_items() are tricky: instead of
> the number of possible values, it requires the number of the maximum
> value. In other words, the ARRAY_SIZE() value should be decremented,
> otherwise it will go past the
Hi,
since I sent this series I only got feedback from Rob.
Regards,
Marco
On 18-08-13 11:25, Marco Felsch wrote:
> Hi,
>
> this is my v2 with the integrated reviews from my v1 [1]. Since Mauro
> applied the most patches from my v1 to his experimental/tvp5150-3
> branch [2], t
On 18-08-13 15:41, Rob Herring wrote:
> On Mon, Aug 13, 2018 at 11:25:03AM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video input sources to their
> > AIP1A/B pins.
> >
> > Possible configurations are as follows:
> > - Analog Co
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 825dcf3a9d83..e736f609fecd 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 23
These helpers make us of the media-controller entity which is only
available if the CONFIG_MEDIA_CONTROLLER is enabled.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 100 ++--
1 file changed, 50 insertions(+), 50 deletions(-)
diff --git a/include
/msg236650.html
[2] https://git.linuxtv.org/mchehab/experimental.git/log/?h=tvp5150-3
[3] https://www.spinics.net/lists/devicetree/msg243181.html
[4] https://www.spinics.net/lists/devicetree/msg243840.html
Regards,
Marco
Marco Felsch (6):
[media] tvp5150: add input source selection of_graph support
is less error prone too.
Signed-off-by: Marco Felsch
---
include/media/v4l2-subdev.h | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h
index 9102d6ca566e..ce48f1fcf295 100644
--- a/include/media/v4l2
or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 109 +---
1 fi
() callback ensures that only one
connector is active.
[1] https://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- adapt commit message
- unify ifdef switches
- rename
to AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
---
Changelog:
v2:
- adapt port layout in accordance with
https://www.spinics.net/lists/linux
Hi Mauro,
On 18-08-09 13:04, Mauro Carvalho Chehab wrote:
> Em Thu, 9 Aug 2018 16:35:20 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > Thanks for your feedback.
>
> > > > > > + dev_dbg(sd->dev, "link setup '%s':%d->'%s':%d
Hi Mauro,
Thanks for your feedback.
On 18-08-09 10:36, Mauro Carvalho Chehab wrote:
> Em Thu, 9 Aug 2018 14:55:07 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-08-08 15:52, Mauro Carvalho Chehab wrote:
> > > Em Wed, 8 Aug 2018 17:29:4
attached both inline as an RFC, can give me your feedback?
I removed the devicetree guys to aviod noise.
On 18-07-30 21:01, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:38 +0200
> Marco Felsch escreveu:
>
> > Since commit 10d5509c8d50 ("[media] v4l2: remove g/s
Hi Mauro,
On 18-08-08 15:52, Mauro Carvalho Chehab wrote:
> Em Wed, 8 Aug 2018 17:29:49 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > the discussion about the correct binding was spread around some patches.
> > So I will try use the correct threa
://www.spinics.net/lists/linux-media/msg138545.html
[2] https://www.spinics.net/lists/linux-media/msg138546.html
On 18-07-30 15:29, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:51 +0200
> Marco Felsch escreveu:
>
> > The currrent driver layout had the f
Hi Mauro,
On 18-08-03 14:30, Mauro Carvalho Chehab wrote:
> Em Fri, 3 Aug 2018 09:29:53 +0200
> Marco Felsch escreveu:
>
> > Hi Rob,
> >
> > first of all, thanks for the review. After some discussion with the
> > media guys I have a question about the dt-bin
Hi Rob,
first of all, thanks for the review. After some discussion with the
media guys I have a question about the dt-bindings.
On 18-07-03 17:23, Rob Herring wrote:
> On Thu, Jun 28, 2018 at 06:20:52PM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video inpu
Hi Ian,
On 18-08-02 11:54, Ian Arkver wrote:
> On 02/08/18 10:49, Mauro Carvalho Chehab wrote:
> > Em Thu, 2 Aug 2018 10:01:01 +0200
> > Marco Felsch escreveu:
> >
> > > Hi Mauro,
> > >
> > > On 18-08-01 12:50, Mauro Carvalho Chehab
Hi Mauro,
On 18-08-02 06:49, Mauro Carvalho Chehab wrote:
> Em Thu, 2 Aug 2018 10:01:01 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-08-01 12:50, Mauro Carvalho Chehab wrote:
> > > Em Wed, 1 Aug 2018 16:49:26 +0200
> > > Marc
Hi Mauro,
On 18-08-01 12:50, Mauro Carvalho Chehab wrote:
> Em Wed, 1 Aug 2018 16:49:26 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-08-01 11:22, Mauro Carvalho Chehab wrote:
> > > Em Wed, 1 Aug 2018 15:21:25 +0200
> > > Marc
Hi Javier,
On 18-07-31 15:30, Marco Felsch wrote:
> Hi Javier,
>
> On 18-07-31 14:52, Javier Martinez Canillas wrote:
> > Hi Marco,
> >
> > On 07/31/2018 02:36 PM, Marco Felsch wrote:
> >
> > [snip]
> >
> > >>
> > >>
Hi Mauro,
On 18-08-01 11:22, Mauro Carvalho Chehab wrote:
> Em Wed, 1 Aug 2018 15:21:25 +0200
> Marco Felsch escreveu:
>
> > Hi Mauro,
> >
> > On 18-07-30 15:09, Mauro Carvalho Chehab wrote:
> > > Em Thu, 28 Jun 2018 18:20:48 +0200
> > > Marco Fel
Hi Mauro,
On 18-07-30 15:09, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:48 +0200
> Marco Felsch escreveu:
>
> > From: Philipp Zabel
> >
> > Add the querystd video_op and make it return V4L2_STD_UNKNOWN while the
> > TVP5150 is not locked
Hi Mauro,
On 18-07-31 16:56, Mauro Carvalho Chehab wrote:
> Em Tue, 31 Jul 2018 15:30:56 +0200
> Marco Felsch escreveu:
>
> > Hi Javier,
> >
> > On 18-07-31 14:52, Javier Martinez Canillas wrote:
> > > Hi Marco,
> > >
> > > On 07/31
Hi Javier,
On 18-07-31 14:52, Javier Martinez Canillas wrote:
> Hi Marco,
>
> On 07/31/2018 02:36 PM, Marco Felsch wrote:
>
> [snip]
>
> >>
> >> Yes, another thing that patch 19/22 should take into account is DTs that
> >> don't have input conn
;
> >> On 07/30/2018 08:18 PM, Mauro Carvalho Chehab wrote:
> >>> Em Thu, 28 Jun 2018 18:20:50 +0200
> >>> Marco Felsch escreveu:
> >>>
> >>>> From: Javier Martinez Canillas
> >>>>
> >>>> Commit f7b4b54e6
Hi Mauro,
On 18-07-30 15:18, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:50 +0200
> Marco Felsch escreveu:
>
> > From: Javier Martinez Canillas
> >
> > Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> >
Hi Mauro,
thanks for your feedback.
On 18-07-30 15:00, Mauro Carvalho Chehab wrote:
> Em Thu, 28 Jun 2018 18:20:45 +0200
> Marco Felsch escreveu:
>
> > From: Philipp Zabel
> >
> > To avoid short frames on stream start, keep output pins at high impedance
> >
Hi Rob,
On 18-07-03 17:23, Rob Herring wrote:
> On Thu, Jun 28, 2018 at 06:20:52PM +0200, Marco Felsch wrote:
> > The TVP5150/1 decoders support different video input sources to their
> > AIP1A/B pins.
> >
> > Possible configurations are as follows:
> > -
From: Philipp Zabel
Make sure to not overwrite decoder->norm when setting the standard
in hardware, but only when instructed by V4L2 API calls.
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 56 -
1 file chan
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 76e6bed5a1da..da7ad455d4a8 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c
ly one connector is active. To change the input src the link between
the TVP5150 pad and the connector must be disabled, then a new link can
be enabled.
The patch tries to reduce the '#ifdef CONFIG_MEDIA_CONTROLLER' usage to
a minimum.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c
or
driver state) which will be set/returned.
The TVP5150 AVID will be updated if the 'which' field is FORMAT_ACTIVE
and the requested selection rectangle differs from the already set one.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 107
1 fi
to AIP1A and AIP1B respectively.
This patch extends the device tree bindings documentation to describe
how the input connectors for these devices should be defined in a DT.
Signed-off-by: Marco Felsch
---
.../devicetree/bindings/media/i2c/tvp5150.txt | 118 +-
1 file changed, 113
From: Philipp Zabel
Add the querystd video_op and make it return V4L2_STD_UNKNOWN while the
TVP5150 is not locked to a signal.
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers
From: Philipp Zabel
Regmap provides built in debugging, caching and provides dedicated
accessors for bit manipulations in registers, which make the following
changes a lot simpler.
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 199
Add callback to retrieve the current set norm.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 1990aaa17749..3b51b6b67736 100644
--- a/drivers/media/i2c
...@pengutronix.de: make use of tvp5150_set_default() helper]
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index c73536cfcc62..dbfc56c87434 100644
allowing the commit to be reverted cleanly anymore. But all the code
related to the DT parsing logic and input entities creation are removed.
Suggested-by: Laurent Pinchart
Signed-off-by: Javier Martinez Canillas
Acked-by: Laurent Pinchart
[m.fel...@pengutronix.de: rm TVP5150_INPUT_NUM define]
Signed-
From: Philipp Zabel
Issue a V4L2_EVENT_SOURCE_CHANGE notification when the TVP5150 locks
onto a signal and when it loses the lock.
Signed-off-by: Philipp Zabel
[m.fel...@pengutronix.de: partly mainline part port]
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 8 +++-
1
From: Philipp Zabel
This patch adds an optional interrupt handler to handle the sync
lock interrupt and sync lock status.
Signed-off-by: Philipp Zabel
Signed-off-by: Lucas Stach
[m.fel...@pengutronix.de: move added .g_std callback to separate patch]
Signed-off-by: Marco Felsch
---
drivers
Add two helper functions to check if two rectangles have the same
position (top/left) and if two rectangles equals (same size and
same position).
Signed-off-by: Marco Felsch
---
include/media/v4l2-rect.h | 27 +++
1 file changed, 27 insertions(+)
diff --git a/include
-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 6ac29c62d99b..3645d1166118 100644
--- a/drivers/media/i2c/tvp5150.c
+++ b/drivers/media/i2c/tvp5150.c
[3] https://git.linuxtv.org/media_tree.git/log/
Javier Martinez Canillas (1):
partial revert of "[media] tvp5150: add HW input connectors support"
Marco Felsch (10):
[media] tvp5150: fix width alignment during set_selection()
[media] tvp5150: fix switch exit in set control handler
[medi
() to tvp5150_s_stream()]
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 19 +--
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 895bc2bfb1d1..284694c21556 100644
--- a/drivers/media/i2c/tvp5150.c
From: Philipp Zabel
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 6296c68ac816..99d887936ea0 100644
--- a/drivers/media/i2c/tvp5150
Since commit a27e33e3dd27 ("[media] tvp5150: convert register access to
regmap") the driver supports regmap. Now we can drop the handmade bit
update sequence and move to the regmap provided helpers.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5
control is supported and a zero should be returned instead.
Replace the break by a 'return 0' to fix this behaviour.
Fixes: d183e4efcae8 ("[media] v4l: tvp5150: Add missing break in set
control handler")
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 2 +-
1 file changed, 1
The default input is still TVP5150_COMPOSITE1, but if the platform
supports DT the default will be changed to the first valid connector.
First in this context means the connector at the lowest port number.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 11 ++-
1 file
: fix regmap access during reset()]
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/tvp5150.c b/drivers/media/i2c/tvp5150.c
index 284694c21556..c66a962d873a 100644
--- a/drivers/media/i2c
From: Philipp Zabel
To avoid short frames on stream start, keep output pins at high impedance
while we are not properly locked onto the input signal.
Signed-off-by: Philipp Zabel
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 39 ++---
1 file
The patch adds three macros to bundle the mbus_framefmt default
values and a helper function to set the the default crop and
mbus_framefmt values.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 42 ++---
1 file changed, 25 insertions(+), 17
95 matches
Mail list logo
