Re: [PATCH] Documentation/media: uapi: Explicitly say there are no Invariant Sections

published by the Free Software Foundation. A copy of > > -the license is included in the chapter entitled "GNU Free Documentation > > -License". > > +any later version published by the Free Software Foundation, with no > > +Invariant Sections. A copy of the license is included in the chapter > > +entitled "GNU Free Documentation License". The original founders / authors / coders of LinuxDVB have signed off on this, and that is most important to me. Signed-off-by: Michael Ira Krufky

[GIT PULL] [RESEND] urgent em28xx bug fixes for immediate merge

em28xx: Fix DualHD disconnect oops em28xx: Remove duplicate PID drivers/media/usb/em28xx/em28xx-cards.c | 6 +++--- drivers/media/usb/em28xx/em28xx-dvb.c | 4 +++- 2 files changed, 6 insertions(+), 4 deletions(-) On Thu, Jul 26, 2018 at 8:27 AM Michael Ira Krufky wrote: > > This is a

[PULL] urgent em28xx bug fixes for immediate merge

This is a resend of https://patchwork.linuxtv.org/patch/51227/ - I forgot to include an email subject in the pull request :-/ Hello Mauro, The following three patches from Brad Love are urgently needed for merge ASAP. One just removes a duplicated PID, so it's not as important but should be

[no subject]

Hello Mauro, The following three patches from Brad Love are urgently needed for merge ASAP. One just removes a duplicated PID, so it's not as important but should be merged ASAP nonetheless. The other two fix an OOPS along with broken dual transport streaming operation. Please merge ASAP. The

Re: [PATCH 1/2] media: dvb: convert tuner_info frequencies to Hz

On Wed, Jul 4, 2018 at 10:47 PM Mauro Carvalho Chehab wrote: > > Right now, satellite tuner drivers specify frequencies in kHz, > while terrestrial/cable ones specify in Hz. That's confusing > for developers. > > However, the main problem is that universal tuners capable > of handling both

Re: [PATCH] media: dvb: fix noderef.cocci warnings

parg; > - memset(info, 0, sizeof(info)); > + memset(info, 0, sizeof(*info)); > > dvb_frontend_get_frequency_limits(fe, >frequency_min, > >frequency_max); > strcpy(info->name, fe->ops.info.name); Nice catch! (even for a robot) I think we'll find more of these sprinkled throughout the tree. Reviewed-by: Michael Ira Krufky

Re: [PULL] DVB-mmap Kconfig typo fix

On Thu, Mar 1, 2018 at 7:55 AM, Michael Ira Krufky <mkru...@linuxtv.org> wrote: > Please pull the following typo fix in the Kconfig for dvb-mmap: > > The following changes since commit 4df7ac5f42087dc9bcbed04b5cada0f025fbf9ef: > > drivers/media/Kconfig: typo: replace `with`

[PULL] DVB-mmap Kconfig typo fix

insertion(+), 1 deletion(-) Cheers, Michael Ira Krufky

Re: [PATCH 7/9] lgdt3306a: Set fe ops.release to NULL if probed

On Tue, Jan 9, 2018 at 12:17 AM, Matthias Schwarzott <z...@gentoo.org> wrote: > Am 05.01.2018 um 01:19 schrieb Michael Ira Krufky: >> On Thu, Jan 4, 2018 at 7:04 PM, Brad Love <b...@nextdimension.cc> wrote: >>> If release is part of frontend ops then

Re: [PATCH v2 8/9] lgdt3306a: QAM streaming improvement

Signed-off-by: Brad Love <b...@nextdimension.cc> Looks good - Thanks. Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/dvb-frontends/lgdt3306a.c | 22 ++ > 1 file changed, 22 insertions(+) > > diff --git a/drivers/media/dvb-

Re: [PATCH 9/9] lgdt3306a: Add QAM AUTO support

kwards compatible with current behaviour. > > Signed-off-by: Brad Love <b...@nextdimension.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/dvb-frontends/lgdt3306a.c | 42 > ++--- > 1 file changed, 33 inse

Re: [PATCH 8/9] lgdt3306a: QAM streaming improvement

et */ > ret = lgdt3306a_soft_reset(state); > if (lg_chkerr(ret)) Brad, The change looks good, but can you resubmit this using lowercase hex? Cheers, Michael Ira Krufky

Re: [PATCH 6/9] em28xx: Enable Hauppauge SoloHD rebranded 292e SE

On Thu, Jan 4, 2018 at 7:04 PM, Brad Love <b...@nextdimension.cc> wrote: > Add a missing device to the driver table. > > Signed-off-by: Brad Love <b...@nextdimension.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/usb/em28x

Re: [PATCH 5/9] em28xx: Add Hauppauge SoloHD/DualHD bulk models

On Thu, Jan 4, 2018 at 7:04 PM, Brad Love <b...@nextdimension.cc> wrote: > Add additional pids to driver list > > Signed-off-by: Brad Love <b...@nextdimension.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/med

Re: [PATCH 4/9] em28xx: Increase max em28xx boards to max dvb adapters

on.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/usb/em28xx/em28xx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/em28xx/em28xx.h > b/drivers/media/usb/em28xx/em28xx.h > index 7be8a

Re: [PATCH 3/9] em28xx: USB bulk packet size fix

gt; > Signed-off-by: Brad Love <b...@nextdimension.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/usb/em28xx/em28xx.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/usb/em28xx/em28xx.h >

Re: [PATCH 2/9] em28xx: Bulk transfer implementation fix

mum allowed according to Empia. > > Signed-off-by: Brad Love <b...@nextdimension.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/usb/em28xx/em28xx-core.c | 12 > 1 file changed, 12 insertions(+) > > diff --git a/drivers

Re: [PATCH 1/9] em28xx: Hauppauge DualHD second tuner functionality

ature. > > Signed-off-by: Brad Love <b...@nextdimension.cc> :+1 Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/usb/em28xx/em28xx-cards.c | 126 > +++- > drivers/media/usb/em28xx/em28xx-core.c | 42 +

Re: [PATCH 7/9] lgdt3306a: Set fe ops.release to NULL if probed

On Thu, Jan 4, 2018 at 7:04 PM, Brad Love wrote: > If release is part of frontend ops then it is called in the > course of dvb_frontend_detach. The process also decrements > the module usage count. The problem is if the lgdt3306a > driver is reached via i2c_new_device, then

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

correct - they can be CONSTified. My bad -- a lot of the code I wrote many years ago has this problem -- I wasn't so stack-conscious back then. The bytes in `enable` / `disable` don't get changed, but they may be copied to another byte array that does get changed. If would be best to make these `static const` Best regards, Michael Ira Krufky

Re: [PATCH] tuners: tda8290: reduce stack usage with kasan

t; actually want both of them. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thank you, Arnd. Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/tuners/tda8290.c | 76 > ++ > 1 file changed, 39 insertio

Re: [PATCH] [media] mxl111sf: remove redundant assignment to index

of index to zero. Cleans up the clang > warning: > > drivers/media/usb/dvb-usb-v2/mxl111sf-i2c.c:519:3: warning: Value > stored to 'index' is never read > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>

Re: [PATCHv3 2/2] dib0700: add support for Xbox One Digital TV Tuner

0700C > Demodulator: Panasonic MN88472 > Tuner: TDA18250BHN > > The demodulator requires firmware. Download one from here: > http://palosaari.fi/linux/v4l-dvb/firmware/MN88472/02/latest/ > > Signed-off-by: Olli Salonen <olli.salo...@iki.fi> Reviewed-by: Michael Ira Krufky &

Re: [PATCHv3 1/2] tda18250: support for new silicon tuner

gt; > Signed-off-by: Olli Salonen <olli.salo...@iki.fi> Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/tuners/Kconfig | 7 + > drivers/media/tuners/Makefile| 1 + > drivers/media/tuners/tda18250.c | 921 > +++

Re: [PATCH 03/18] media: use ARRAY_SIZE

le with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | > (sizeof(E)@p /sizeof(E[...])) > | > (sizeof(E)@p /sizeof(T)) > ) > > Signed-off-by: Jérémy Lefaure <je

Re: [PATCH 03/25] media: dvbdev: convert DVB device types into an enum

On Wed, Sep 20, 2017 at 3:11 PM, Mauro Carvalho Chehab wrote: > Enums can be documented via kernel-doc. So, convert the > DVB_DEVICE_* macros to an enum. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-core/dvbdev.c | 34

Re: [RFC 3/5] media: get rid of get_property() callback

ntend(). > > So, get rid of it. > > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org>

Re: __tda18271_write_regs ERROR

bration is a sensitive process that requires silence on the i2c bus. My guess is that the em28xx i2c bus is not as quiet as it should be during this initialization. However, first I would check to see whether the device works with the windows driver. Maybe it's broken. -Michael Ira Krufky

Re: [PATCH] [media] mxl111sf: Fix potential null pointer dereference

336f3f65 ("[media] mxl111sf: Fix driver to use heap allocate > buffers for USB messages") > Signed-off-by: Eugeniu Rosca <ero...@de.adit-jv.com> > --- > drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by:

Re: Problem with Hauppauge WinTV-HVR-1250

On Fri, Jan 13, 2017 at 11:56 PM, Justin Husted wrote: > Hi! > > I recently got one of these cards on ebay to do some analog video capturing, > and I'm having a few problems with it on the 4.4.0 kernel. > > I wasn't really sure who the maintainer is for this stuff, but I saw

Re: [PATCH 1/3] [media] dvb-usb: move data_mutex to struct dvb_usb_device

2: > > So, move it to the struct dvb_usb_device and initialize it > before calling the driver's callbacks. > > Reported-by: Jörg Otte <jrg.o...@gmail.com> > Tested-by: Jörg Otte <jrg.o...@gmail.com> > Signed-off-by: Mauro Carvalho Chehab <mche...@s-opensourc

Re: [PATCH] [media] lgdt3306a: remove 20*50 msec unnecessary timeout

On Mon, Jul 25, 2016 at 9:36 PM, Mauro Carvalho Chehab <mche...@osg.samsung.com> wrote: > Em Mon, 25 Jul 2016 15:37:14 -0400 > Michael Ira Krufky <mkru...@linuxtv.org> escreveu: > >> On Mon, Jul 25, 2016 at 3:28 PM, Mauro Carvalho Chehab >> <mche...@osg

Re: [PATCH] [media] lgdt3306a: remove 20*50 msec unnecessary timeout

On Mon, Jul 25, 2016 at 3:28 PM, Mauro Carvalho Chehab <mche...@osg.samsung.com> wrote: > Hi Michael, > > Em Mon, 25 Jul 2016 14:55:51 -0400 > Michael Ira Krufky <mkru...@linuxtv.org> escreveu: > >> On Mon, Jul 25, 2016 at 2:38 PM, Abylay Ospan <aos...@netup.ru&

Re: [PATCH] [media] lgdt3306a: remove 20*50 msec unnecessary timeout

K) > - break; > - } > + ret = lgdt3306a_read_status(fe, ); > + if (ret) > + goto error; > > /* check if we have a valid signal */ > if (status & FE_HAS_LOCK) Your patch removes a loop that was purposefully writt

Re: Linux Media Summit in April, 7 - San Diego - CA - USA

On Sat, Mar 5, 2016 at 10:08 AM, Mauro Carvalho Chehab wrote: > As discussed on our IRC #v4l channel at Freenode, we'll be running a 1-day > Linux Media Summit in San Diego on Aug, 7, just after the Embedded > Linux Conference. > > Feel free to submit relevant topics

Re: [PATCH] drivers/media/usb/dvb-usb-v2: constify mxl111sf_tuner_config structure

t; Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Thank you for this, Julia Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > > --- > drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.c |6 +++--- > drivers/media/usb/dvb-usb-v2/mxl111sf-tuner.h |8 &

Re: [PATCH] drivers/media/usb/dvb-usb-v2: constify mxl111sf_demod_config structure

Thanks for this! Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> On Fri, Nov 13, 2015 at 7:24 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > The mxl111sf_demod_config structure is never modified, so declare it > as const. > > Done with the help of Coccinelle.

Re: [PATCH] mxl111sf: missing return values validation

offending code. My bad O:-) Thank you for this patch. Mauro, please apply it. Reviewed-by: Michael Ira Krufky <mkru...@linuxtv.org> > --- > drivers/media/usb/dvb-usb-v2/mxl111sf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/usb

Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner.

On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky mkru...@linuxtv.org wrote: On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches j...@perches.com wrote: On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote: Hi Mauro / Joe, On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote: Em Wed, 24 Jun 2015

Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner.

to my series. Joe - Can I add your signed-off-by? Signed-off-by: Joe Perches j...@perches.com Reviewed-by: Michael Ira Krufky mkru...@samsung.com Joe, nice optimization - thanks for that. With regards to Peter's patch, is this a digital-only tuner, or is it a hybrid tuner? The 5th byte that you

Re: [PATCH 02/12] [media] dvb-pll: Add support for THOMSON DTT7546X tuner.

On Thu, Jul 30, 2015 at 7:14 AM, Michael Ira Krufky mkru...@linuxtv.org wrote: On Thu, Jul 30, 2015 at 6:08 AM, Joe Perches j...@perches.com wrote: On Thu, 2015-07-30 at 10:47 +0100, Peter Griffin wrote: Hi Mauro / Joe, On Wed, 22 Jul 2015, Mauro Carvalho Chehab wrote: Em Wed, 24 Jun 2015

[PULL] git://git.linuxtv.org/mkrufky/dvb lgdt3305 - add support for fixed tp clock mode

to 85796f7c9a2c59ebf5e8a94384fa827aa3ce3e98: lgdt3305: add support for fixed tp clock mode (2014-12-21 16:54:55 -0500) Michael Ira Krufky (2): lgdt3305: we only need to pass state into lgdt3305_mpeg_mode_polarity

Re: [PATCH] drivers:media: Add proper sanity checking for register setting to variable in lg2160.c

of this function :-P If you want to send a patch that just removes the FIXME comment, that would be accepted, but this patch should not be merged. Cheers, Michael Ira Krufky -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] [media] tda18271: Fix identation

On Wed, Nov 26, 2014 at 10:26 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: As reported by smatch: drivers/media/tuners/tda18271-common.c:176 tda18271_read_extended() warn: if statement not indented Signed-off-by: Mauro Carvalho Chehab mche...@osg.samsung.com diff --git

Re: [PATCH] [media] tda18271: Fix identation

On Thu, Nov 27, 2014 at 1:59 PM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Em Thu, 27 Nov 2014 13:47:09 -0500 Michael Ira Krufky mkru...@linuxtv.org escreveu: On Wed, Nov 26, 2014 at 10:26 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: As reported by smatch

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

On Thu, Oct 30, 2014 at 9:37 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Hi Devin, Em Thu, 30 Oct 2014 09:15:31 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: Hi Mauro, Syncronize it and put them on the same order as found at au0828 driver, as all the au0828

Re: [PATCH v2 2/2] [media] sound: Update au0828 quirks table

On Thu, Oct 30, 2014 at 3:52 PM, Michael Ira Krufky mkru...@linuxtv.org wrote: On Thu, Oct 30, 2014 at 9:37 AM, Mauro Carvalho Chehab mche...@osg.samsung.com wrote: Hi Devin, Em Thu, 30 Oct 2014 09:15:31 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: Hi Mauro, Syncronize

Re: [PATCH 1/3] xc5000: tuner firmware update

...@kernellabs.com Signed-off-by: Michael Ira Krufky mkru...@linuxtv.org Hi Michael, Please use a logic that would allow the old firmware files to allow falling back to the previous firmware version if the new one is not available. Regards, Mauro --- drivers/media/tuners/xc5000.c | 14

Re: [PATCH 1/3] xc5000: tuner firmware update

On Mon, Oct 27, 2014 at 12:22 PM, Johannes Stezenbach j...@linuxtv.org wrote: On Mon, Oct 27, 2014 at 01:57:27PM -0200, Mauro Carvalho Chehab wrote: Em Mon, 27 Oct 2014 10:25:48 -0400 Michael Ira Krufky mkru...@linuxtv.org escreveu: I like the idea of supporting older firmware revisions

[GIT PULL] DVB: add support for LG Electronics LGDT3306A ATSC/QAM-B Demodulator

): DVB: add support for LG Electronics LGDT3306A ATSC/QAM-B Demodulator Michael Ira Krufky (9): lgdt3306a: clean up whitespace unneeded brackets lgdt3306a: remove unnecessary 'else' lgdt3306a: fix WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable

Re: [ANNOUNCE] Linux Kernel Media mini-summit on Oct, 16-17 in Düsseldorf, Germany

Hey all... It looks like I will be in Dusseldorf that week as well. :-) See you next month! -Mike Ira Krufky On Tue, Sep 2, 2014 at 8:58 AM, Mauro Carvalho Chehab m.che...@samsung.com wrote: Em Tue, 02 Sep 2014 12:03:34 +0200 Philipp Zabel p.za...@pengutronix.de escreveu: Hi, Am