Re: [PATCH 1/3] [media] v4l2-mem2mem: use CAPTURE queue lock

Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/v4l2-mem2mem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c index 438ea45..c52a2c5 100644 --- a/drivers/media/v4l2-core/v4l2-mem2mem.c

Re: [PATCH 2/3] [media]: v4l2-mem2mem: drop rdy_queue on STREAMOFF

. * Deschedule the context, as it now has at least one empty queue and cannot run. Signed-off-by: John Sheu s...@google.com Acked-by: Pawel Osciak pa...@osciak.com --- drivers/media/v4l2-core/v4l2-mem2mem.c | 31 --- 1 file changed, 28 insertions(+), 3 deletions

Re: [PATCH v2] videobuf2-core: Verify planes lengths for output buffers

-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Hans Verkuil hans.verk...@cisco.com --- Acked-by: Pawel Osciak pa...@osciak.com drivers/media/v4l2-core/videobuf2-core.c | 39 ++ 1 files changed, 39 insertions(+), 0 deletions(-) Changes compared to v1

Re: [PATCHv10 08/26] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

of this patch. If the device can do DMA SG, why use videobuf2-dma-contig and not videobuf2-dma-sg? What would be the difference design-wise between them if this patch is merged? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [PATCH 1/2] media v4l2-mem2mem: Use list_first_entry

On Fri, Aug 31, 2012 at 6:18 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Use list_first_entry instead of list_entry which makes the intention of the code more clear. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- Acked-by: Pawel Osciak pa...@osciak.com Thanks for the patch Sascha

Re: [PATCH 2/2] media v4l2-mem2mem: fix src/out and dst/cap num_rdy

...@pengutronix.de --- Acked-by: Pawel Osciak pa...@osciak.com include/media/v4l2-mem2mem.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h index 16ac473..131cc4a 100644 --- a/include/media/v4l2-mem2mem.h +++ b/include

Re: [MINI SUMMIT] media mini-summit at KS/2012

naveen.krishnamur...@st.com Palash Bandyopadhyay palash.bandyopadh...@conexant.com Pawel Osciak pa...@osciak.com Rémi Denis-Courmont r...@remlab.net Sakari Ailus sakari.ai...@iki.fi Sri Deevi srinivasa.de...@conexant.com Steven Toth st...@kernellabs.com Bartlomiej Zolnierkiewicz b.zolnier

Re: Media summit at the Kernel Summit - was: Fwd: Re: [Ksummit-2012-discuss] Organising Mini Summits within the Kernel Summit

maintenance, dmabuf hint/caching sglists, sharing mappings between drivers, etc. Perhaps others would also have something to add to this list. Thanks! Pawel Osciak On Tue, Jul 17, 2012 at 10:30 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: As we did in 2012, we're planning to do a media summit

Re: [PATCH 03/10] media: vb2: add prepare/finish callbacks to allocators

documentation in code. Apart from that the patch looks good. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 05/10] v4l: add buffer exporting via dmabuf

future additions to V4L2 and/or dmabuf. I feel we should use a structure here instead and keep it symmetric with REQBUFS and other ioctls (with regards to memory types, union for offset/etc.), and also add a few reserved fields. [snip] -- Best regards, Pawel Osciak -- To unsubscribe from this list

Please tag proof-of-concept patches as RFC

Hi All, There's been a lot of proof-of-concept patch series posted recently. I think it's great, but I would just like to suggest the RFC tag is used in the topic of such patches. I feel this would be helpful not only for Mauro, but for all of us. Thanks! Pawel -- To unsubscribe from this list:

Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)

{        VB2_MMAP        = (1 0),        VB2_USERPTR     = (1 1),        VB2_READ        = (1 2),        VB2_WRITE       = (1 3), +       VB2_DMABUF      = (1 4),  };  /** -- 1.7.5.4 -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [PATCH v1 2/2] vb2: add support for app_offset field of the v4l2_plane struct

Hi Hans, Thanks for comments. On Tue, Nov 22, 2011 at 02:38, Hans Verkuil hverk...@xs4all.nl wrote: Hi Pawel! Thanks for doing this work, but I have a few comments... On Tuesday, November 22, 2011 06:26:37 Pawel Osciak wrote: The app_offset can only be set by userspace and will be passed

[PATCH/RFC v1 0/2] app_offset field for plane format

--|-- data_offset --|-- image data --| Regards, Pawel Osciak Pawel Osciak (2): media: Add app_offset field to the v4l2_plane structure vb2: add support for app_offset field of the v4l2_plane struct Documentation/DocBook/media/v4l/io.xml| 21 - drivers/media/video/v4l2-compat

[PATCH v1 1/2] media: Add app_offset field to the v4l2_plane structure

app_offset allows the userspace to reserve memory at the beginning of a plane that will not be touched by the kernel or hardware. Signed-off-by: Pawel Osciak pa...@osciak.com --- Documentation/DocBook/media/v4l/io.xml| 21 - drivers/media/video/v4l2-compat-ioctl32.c

[PATCH v1 2/2] vb2: add support for app_offset field of the v4l2_plane struct

The app_offset can only be set by userspace and will be passed by vb2 to the driver. Signed-off-by: Pawel Osciak pa...@osciak.com CC: Marek Szyprowski m.szyprow...@samsung.com --- drivers/media/video/videobuf2-core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

Re: [PATCH] media: vb2: reset queued list on REQBUFS(0) call

/videobuf2-core.c +++ b/drivers/media/video/videobuf2-core.c @@ -254,6 +254,7 @@ static void __vb2_queue_free(struct vb2_queue *q)        q-num_buffers = 0;        q-memory = 0; +       INIT_LIST_HEAD(q-queued_list);  }  /** -- 1.7.1 Acked-by: Pawel Osciak pa...@osciak.com -- Best

Re: [PATCH] media: vb2: reset queued list on REQBUFS(0) call

, neither of those can be active for reqbufs to proceed. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] media: vb2: add a check for uninitialized buffer

. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Pawel Osciak pa...@osciak.com ---  drivers/media/video/videobuf2-core.c |    4 ++--  1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video

Re: [PATCH] media: vb2: fix incorrect return value

; +                       ret = -EINVAL;                        goto err;                } -- 1.7.1.569.g6f426 Acked-by: Pawel Osciak pa...@osciak.com -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org

Re: Status of the patches under review at LMML (28 patches)

. (...)                == Waiting for Pawel Osiak pa...@osciak.com review == Jul,12 2011: v4l: mem2mem: add wait_{prepare,finish} ops to m2m_testdev             http://patchwork.linuxtv.org/patch/7431   Michael Olbrich m.olbr...@pengutronix.de This is an ack from me. -- Best regards, Pawel Osciak

Re: Patches at patchwork.linuxtv.org (127 patches)

, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/7 v5] V4L: vb2: add support for buffers of different sizes on a single queue

m.szyprow...@samsung.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Pawel Osciak pa...@osciak.com Cc: Sakari Ailus sakari.ai...@maxwell.research.nokia.com ---  drivers/media/video/videobuf2-core.c |  278 --  include/media/videobuf2-core.h

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

later. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

Marek? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

Hi On Wed, Aug 17, 2011 at 02:11, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Tue, 16 Aug 2011, Pawel Osciak wrote: Hi Guennadi, On Tue, Aug 16, 2011 at 06:13, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 15 Aug 2011, Guennadi Liakhovetski wrote: On Mon, 15 Aug

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

, buf_sizes, plane_sizes, alloc_ctxs); } If the driver didn't want create_bufs, it'd just not implement it. What do you think? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 1/6 v4] V4L: add two new ioctl()s for multi-size videobuffer management

v4l2_create_buffers *b); +       int (*vidioc_prepare_buf)(struct file *file, void *fh, struct v4l2_buffer *b);        int (*vidioc_overlay) (struct file *file, void *fh, unsigned int i);        int (*vidioc_g_fbuf)   (struct file *file, void *fh, -- 1.7.2.5 -- Best regards, Pawel Osciak

Re: Possible issue in videobuf2 with buffer length check at QBUF time

solution is maybe a bit simpler for drivers that do not, as they would only have to return the sizes in queue_setup, but implementing buf_init instead wouldn't be a big of a difference I think. So I'm leaning towards the second solution. Any comments, did I miss something? -- Best regards, Pawel Osciak

Re: Possible issue in videobuf2 with buffer length check at QBUF time

were to have the new callback, it could only be allowed when not streaming. Otherwise we'd have to forcibly dequeue buffers if they became too small and this would be confusing for applications. Pawel On Fri, Aug 5, 2011 at 08:01, Pawel Osciak pa...@osciak.com wrote: Hi Laurent, On Fri, Aug 5

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

Hi Hans, On Wed, Jul 27, 2011 at 23:56, Hans Verkuil hverk...@xs4all.nl wrote: On Thursday, July 28, 2011 06:11:38 Pawel Osciak wrote: Hi Guennadi, On Wed, Jul 20, 2011 at 01:43, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: A possibility to preallocate and initialise buffers

Re: [PATCH v3] V4L: add two new ioctl()s for multi-size videobuffer management

and QBUF? Why not queue in advance? Could you give a full sequence of ioctls how it will be used (including streamons, etc.)? I'm trying to picture how passing of both types of buffers will have to look like between vb2 and a driver. snip -- Best regards, Pawel Osciak -- To unsubscribe from

Re: [PATCH] videobuf2: call buf_finish() on unprocessed buffers

both lists on dqbuf. This means that you shouldn't call buf_finish for buffers on both lists, only for all buffers in the queued_list, as it is a superset of both. -- Best regards, Pawel Osciak On Thu, Jul 14, 2011 at 14:09, Jonathan Corbet cor...@lwn.net wrote: When user space stops streaming

Re: [PATCH/RFC] media: vb2: change queue initialization order

for it itself in start_streaming. Makes it simpler, and there would be no default either. But there is one catch: if we allow buf_queue() to be called without streaming on, all drivers will have to implement start_streaming, so it will have to become mandatory. Am I right Marek? -- Best regards, Pawel

Re: [RFCv1 PATCH 5/6] videobuf2-core: also test for pending events.

Acked-by: Pawel Osciak pa...@osciak.com ---  drivers/media/video/videobuf2-core.c |   41 +++--- ---  1 files changed, 28 insertions(+), 13 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c index 1892bb8..1922bf8

Re: [RFCv1 PATCH 3/6] videobuf2: only start streaming in poll() if so requested by the poll mask.

...@samsung.com Acked-by: Pawel Osciak pa...@osciak.com I have to say, this is cool stuff! Pawel ---  drivers/media/video/videobuf2-core.c |    7 +--  1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video/videobuf2-core.c

Re: [RFC] vb2: Push buffer allocation and freeing into drivers

the memory when you buf_cleanup(), which happens in USERPTR case. Oh, well.  I'd like to see the change merged, I think it makes things a little better.  But I've said my piece now and don't intend to argue it further - I'll keep using vb2 either way :) Thanks, jon -- Best regards, Pawel

Re: [PATCH] v4l: remove single to multiplane conversion

Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Acked-by: Pawel Osciak pa...@osciak.com  drivers/media/video/v4l2-ioctl.c |  250 ++  1 files changed, 12 insertions(+), 238 deletions(-) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers

Re: [PATCH] v4l: mem2mem: add wait_{prepare,finish} ops to m2m_testdev

Acked-by: Pawel Osciak pa...@osciak.com Thanks Michael! Pawel On Tue, Jul 12, 2011 at 06:46, Michael Olbrich m.olbr...@pengutronix.de wrote: These are necessary to prevent dead-locks e.g. if one thread waits in dqbuf at one end and another tries to queue a buffer at the other end. Signed

Re: vb2: holding buffers until after start_streaming()

reordered, it's possible for start_streaming to be called without passing any buffers to the driver first. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] MAINTAINERS: Add videobuf2 maintainers

changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 29801f7..63be58b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6720,6 +6720,15 @@ S:       Maintained  F:     Documentation/filesystems/vfat.txt  F:     fs/fat/ +VIDEOBUF2 FRAMEWORK +M:     Pawel Osciak

Re: vb2: stop_streaming() callback redesign

Hi Laurent, On Mon, Apr 4, 2011 at 03:27, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Pawel, On Monday 04 April 2011 01:51:05 Pawel Osciak wrote: Hi, This series implements a slight redesign of the stop_streaming() callback in vb2. The callback has been made obligatory

Re: [PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

On Sun, Apr 3, 2011 at 22:49, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote: Drivers are now required to implement the stop_streaming() callback to ensure that all ongoing hardware operations are finished and their ownership

Re: [PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

Hi again Marek On Sun, Apr 3, 2011 at 22:49, Marek Szyprowski m.szyprow...@samsung.com wrote: Hello, On Monday, April 04, 2011 1:51 AM Pawel Osciak wrote: Drivers are now required to implement the stop_streaming() callback to ensure that all ongoing hardware operations are finished

Re: vb2_plane 'mapped' signed bit field

                    mapped:1; }; that probably should be an unsigned int (I can see code that assigns 1 to it that just won't fit). Hi David, Thanks for the report, will fix soon. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH/RFC 0/4] V4L: new ioctl()s to support multi-sized video-buffers

is worth it... - I understand SUBMIT is optional? - Could you give an example of how this could be used in an application? -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH/RFC 2/4 v2] V4L: add videobuf2 helper functions to support multi-size video-buffers

vb2_queue_release(struct vb2_queue *q); -- 1.7.2.5 -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html -- Best regards, Pawel Osciak -- To unsubscribe from

[PATCH 1/3] [media] vb2: update and fix interface documentation

Update documentation for videobuf2 driver callbacks and memory operations. Signed-off-by: Pawel Osciak pa...@osciak.com --- include/media/videobuf2-core.h | 146 +--- 1 files changed, 91 insertions(+), 55 deletions(-) diff --git a/include/media/videobuf2

[PATCH 2/3] [media] vb2: use unsigned int for the `mapped' bitfield

Signed-off-by: Pawel Osciak pa...@osciak.com Reported-by: David Alan Gilbert li...@treblig.org --- include/media/videobuf2-core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h index 4c1e91f..f3bdbb2 100644

[PATCH 3/3] [media] vb2: prevent drivers from requesting too many buffers/planes.

Add a sanity check to make sure drivers do not adjust the number of buffers or planes above the supported limit on reqbufs. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/videobuf2-core.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers

vb2: stop_streaming() callback redesign

[PATCH 4/5] [media] sh_mobile_ceu_camera: remove stop_streaming() callback return [PATCH 5/5] [media] mx3_camera: remove stop_streaming() callback return -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH 1/5] [media] vb2: redesign the stop_streaming() callback and make it obligatory

. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/videobuf2-core.c | 16 ++-- include/media/videobuf2-core.h | 16 +++- 2 files changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video

[PATCH 4/5] [media] sh_mobile_ceu_camera: remove stop_streaming() callback return

The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/sh_mobile_ceu_camera.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/sh_mobile_ceu_camera.c b/drivers/media/video

[PATCH 5/5] [media] mx3_camera: remove stop_streaming() callback return

The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/mx3_camera.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/mx3_camera.c b/drivers/media/video/mx3_camera.c index

[PATCH 3/5] [media] s5p-fimc: remove stop_streaming() callback return

The stop_streaming() callback does not return a value anymore. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/s5p-fimc/fimc-capture.c |4 ++-- drivers/media/video/s5p-fimc/fimc-core.c|4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 2/5] [media] vivi: adapt to the new stop_streaming() callback behavior

Drivers are no longer required to call vb2_buffer_done() for all buffers they have queued in stop_streaming(). The return value for stop_streaming() has also been removed. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/vivi.c |9 +++-- 1 files changed, 3 insertions

Re: [PATCH 2/2] [media] videobuf2-dma-contig: make cookie() return a pointer to dma_addr_t

Hi Guennadi, On Mon, Mar 21, 2011 at 03:47, Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: On Mon, 14 Mar 2011, Pawel Osciak wrote: dma_addr_t may not fit into void* on some architectures. To be safe, make vb2_dma_contig_cookie() return a pointer to dma_addr_t and dereference

[PATCH 2/2] [media] vb2: Handle return value from start_streaming callback

Fix vb2 not handling return value from start_streaming() callback. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/videobuf2-core.c | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/videobuf2-core.c b/drivers/media/video

[PATCH] [media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added

Multi-planar API was added to 2.6.39 version of Video for Linux 2 API. Signed-off-by: Pawel Osciak pa...@osciak.com --- Documentation/DocBook/v4l/compat.xml | 13 - Documentation/DocBook/v4l/v4l2.xml | 13 ++--- 2 files changed, 6 insertions(+), 20 deletions(-) diff

[GIT PULL for 2.6.39] videobuf2 fixes, docbook fix and update e-mail address

18:09:02 -0300) are available in the git repository at: ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.39 Pawel Osciak (4): [media] Make 2.6.39 not 2.6.38 the version when Multi-planar API was added Update Pawel Osciak's e-mail address. [media] vb2: vb2_poll

[PATCH 1/2] [media] sh_mobile_ceu_camera: Do not call vb2's mem_ops directly

Use vb2_dma_contig_plane_paddr to retrieve a physical address for a plane instead of calling an internal mem_ops callback. Signed-off-by: Pawel Osciak pa...@osciak.com --- drivers/media/video/sh_mobile_ceu_camera.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git

[PATCH 2/2] [media] videobuf2-dma-contig: make cookie() return a pointer to dma_addr_t

dma_addr_t may not fit into void* on some architectures. To be safe, make vb2_dma_contig_cookie() return a pointer to dma_addr_t and dereference it in vb2_dma_contig_plane_paddr() back to dma_addr_t. Signed-off-by: Pawel Osciak pa...@osciak.com Reported-by: Hans Verkuil hverk...@xs4all.nl

Re: [Query] VIDIOC_QBUF and VIDIOC_STREAMON order

would be faster without having to call STREAMON anyway... -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

Hi Laurent, On Tue, Mar 1, 2011 at 02:54, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Pawel, On Monday 28 February 2011 16:44:38 Pawel Osciak wrote: Hi Laurent, A few questions from me below. I feel we need to talk about this change a bit more, it introduces some recovery

Re: [RFC/PATCH 1/2] v4l: videobuf2: Handle buf_queue errors

in documentation above. As we are returning buf_queue return values to userspace directly, drivers need to be careful what they return. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: Mulling over multi-planar formats and videobuf2 for cx18

a PCM audio data plane in there too, if I though I could get away with it. ;) ] Those are all good ideas. It'd be great if we could do some more brainstorming, gather requirements for different devices and come up with an universal solution. -- Best regards, Pawel Osciak -- To unsubscribe from

[GIT FIXES for 2.6.38] Fix double free of video_device in mem2mem_testdev

-0800) are available in the git repository at:  ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.38rc Pawel Osciak (1):      [media] Fix double free of video_device in mem2mem_testdev drivers/media/video/mem2mem_testdev.c |    1 - 1 files changed, 0 insertions(+), 1 deletions

[GIT PATCHES for 2.6.39] Remove compatibility layer from multi-planar API documentation

streaming mode (2011-02-02 12:06:14 -0200) are available in the git repository at: ssh://linuxtv.org/git/posciak/media_tree.git staging/for_v2.6.39 Pawel Osciak (1): [media] Remove compatibility layer from multi-planar API documentation Documentation/DocBook/v4l/planar-apis.xml | 35

[PATCH for 2.6.38] [media] Fix double free of video_device in mem2mem_testdev

video_device is already being freed in video_device.release callback on release. Signed-off-by: Pawel Osciak pa...@osciak.com Reported-by: Roland Kletzing devz...@web.de --- drivers/media/video/mem2mem_testdev.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH v3] [media] Add multi-planar API documentation

Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel Osciak pa...@osciak.com --- Removed references to single-multi planar API conversion layer. Documentation/DocBook/media-entities.tmpl |4 + Documentation/DocBook

[PATCH] [media] Remove compatibility layer from multi-planar API documentation

This feature will probably be moved to libv4l2. Signed-off-by: Pawel Osciak pa...@osciak.com --- Documentation/DocBook/v4l/planar-apis.xml | 35 +--- Documentation/DocBook/v4l/vidioc-querycap.xml | 22 +++ 2 files changed, 18 insertions(+), 39 deletions

Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

be commenting the patches as I'll be seeing any issues. Pawel Osciak (2):       Fix mmap() example in the V4L2 API DocBook In fact, the check for retval 0 instead of retval == -1 is not a fix. According with mmap man pages:        RETURN VALUE               On  success,  mmap() returns

Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

Hi Mauro, On Tue, Jan 11, 2011 at 10:23, Mauro Carvalho Chehab mche...@redhat.com wrote: Pawel Osciak (8):       v4l: Add multi-planar API definitions to the V4L2 API       v4l: Add multi-planar ioctl handling code       v4l: Add compat functions for the multi-planar API       v4l: fix copy

Re: [GIT PATCHES FOR 2.6.38] Videbuf2 framework, NOON010PC30 sensor driver and s5p-fimc updates

Hi Mauro, On Tue, Jan 11, 2011 at 13:57, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 03-01-2011 14:48, Sylwester Nawrocki escreveu: Pawel Osciak (8):       v4l: Add multi-planar API definitions to the V4L2 API Where are the corresponding DocBook changes? They are at: https

[PATCH 1/2] [media] Fix mmap() example in the V4L2 API DocBook

Correct ioctl return value handling and fix coding style issues. Signed-off-by: Pawel Osciak pa...@osciak.com --- Documentation/DocBook/v4l/io.xml | 40 +++--- 1 files changed, 20 insertions(+), 20 deletions(-) diff --git a/Documentation/DocBook/v4l/io.xml b

[PATCH v2] [media] Add multi-planar API documentation

Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel Osciak pa...@osciak.com --- Documentation/DocBook/media-entities.tmpl |4 + Documentation/DocBook/v4l/common.xml |2 + Documentation/DocBook/v4l

Re: [PATCH 1/2] [media] Fix mmap() example in the V4L2 API DocBook

On Thu, Jan 6, 2011 at 20:40, Pawel Osciak pa...@osciak.com wrote: Correct ioctl return value handling and fix coding style issues. Signed-off-by: Pawel Osciak pa...@osciak.com ---  Documentation/DocBook/v4l/io.xml |   40 +++---  1 files changed, 20

Re: [PATCH] [media] Add multi-planar API documentation

Hi Hans, Huge thanks for the review! On Mon, Jan 3, 2011 at 23:53, Hans Verkuil hverk...@xs4all.nl wrote: On Tuesday, January 04, 2011 05:20:45 Pawel Osciak wrote: Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel

[PATCH] [media] Add multi-planar API documentation

Add DocBook documentation for the new multi-planar API extensions to the Video for Linux 2 API DocBook. Signed-off-by: Pawel Osciak pa...@osciak.com --- Documentation/DocBook/media-entities.tmpl |4 + Documentation/DocBook/v4l/common.xml |2 + Documentation/DocBook/v4l

Re: bug? oops with mem2mem_testdev module

Hi, Thanks for reporting the bug, and thanks to Sylwester for a quick response, that should fix it. I intend to change my e-mail address in one larger batch during the merge window, if vb2 patches are taken in. Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe

[PATCH 02/13] v4l: Add multi-planar ioctl handling code

From: Pawel Osciak p.osc...@samsung.com Add multi-planar API core ioctl handling and conversion functions. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/media/video/v4l2

Re: [PATCH 02/13] v4l: Add multi-planar ioctl handling code

On Wed, Dec 22, 2010 at 12:38, Hans Verkuil hverk...@xs4all.nl wrote: On Wednesday, December 22, 2010 18:10:26 Pawel Osciak wrote: From: Pawel Osciak p.osc...@samsung.com Add multi-planar API core ioctl handling and conversion functions. Signed-off-by: Pawel Osciak p.osc...@samsung.com

Re: [PATCH 7/7] v4l: videobuf2: add CMA allocator

, On Wednesday, December 01, 2010 9:36 AM Jonghun Han wrote: Marek Szyprowski wrote: 2010/11/20 Marek Szyprowski m.szyprow...@samsung.com: From: Pawel Osciak p.osc...@samsung.com Add support for the CMA contiguous memory allocator to videobuf2. Signed-off-by: Pawel Osciak p.osc...@samsung.com

Re: RFC: Problem of using v4l2 spec with codec function

Hi all, I would side with Laurent on this. Judging by formats seems to be enough for this driver and it has great, in my opinion, advantages of a) not overcomplicating things for applications b) not adding new pieces to the API... -- Best regards, Pawel Osciak -- To unsubscribe from this list

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

: From: Pawel Osciak p.osc...@samsung.com Videobuf2 is a Video for Linux 2 API-compatible driver framework for [snip] +/** + * __vb2_queue_alloc() - allocate videobuf buffer structures and (for MMAP type) + * video buffer memory for all buffers/planes on the queue and initializes

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

Hi, On Thu, Nov 25, 2010 at 03:23, Hans Verkuil hverk...@xs4all.nl wrote: On Thursday, November 25, 2010 10:48:39 Marek Szyprowski wrote: Hello, On Thursday, November 25, 2010 2:17 AM Laurent Pinchart wrote: On Friday 19 November 2010 16:55:38 Marek Szyprowski wrote: From: Pawel Osciak

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

Hi Hans, On Thu, Nov 18, 2010 at 01:17, Hans Verkuil hverk...@xs4all.nl wrote: Hi Marek! Some comments below... On Wednesday, November 17, 2010 09:39:28 Marek Szyprowski wrote: From: Pawel Osciak p.osc...@samsung.com +/** + * struct vb2_mem_ops - memory handling/memory allocator

Re: Allocating videobuf_buffer, but lists not being initialized

for driver's buffer queue. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 7/8] v4l: Add EBUSY error description for VIDIOC_STREAMON

On Fri, Oct 22, 2010 at 17:18, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 06-09-2010 03:53, Marek Szyprowski escreveu: From: Pawel Osciak p.osc...@samsung.com VIDIOC_STREAMON should return EBUSY if streaming is already active. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed

Re: [PATCH 5/7] v4l: videobuf2: add read() emulator

of buffers used by emulator and detemines the style of read() emulation ('streaming' or 'one shot'). Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Pawel Osciak pa...@osciak.com ---  drivers/media/video/videobuf2-core.c |  322

Re: [PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

Hi Marek, Thanks for your patches, I went through your changes. Minor comments below. On Tue, Oct 19, 2010 at 23:41, Marek Szyprowski m.szyprow...@samsung.com wrote: From: Pawel Osciak p.osc...@samsung.com +/** + * __vb2_queue_cancel() - cancel and stop (pause) streaming + * + * Removes all

Re: V4L/DVB/IR patches pending merge

to clean the list.                == Videobuf2 series == Oct,20 2010: [7/7] v4l: videobuf2: add CMA allocator                                http://patchwork.kernel.org/patch/267521  Pawel Osciak p.osc...@samsung.com Oct,20 2010: [2/7] v4l: videobuf2: add generic memory handling routines

Re: [PATCH v1 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

Hi Hans, Big thanks for the review! On 09/25/2010 07:27 AM, Hans Verkuil wrote: Hi Pawel, I finally had some time for a code review: On Thursday, September 09, 2010 11:19:42 Pawel Osciak wrote: Videobuf2 is a Video for Linux 2 API-compatible driver framework for multimedia devices

Re: [PATCH v1 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

Hello Mauro, Thank you for the review. Please see my responses inline. Please also note that my e-mail address has changed. On 09/09/2010 07:29 PM, Mauro Carvalho Chehab wrote: Em 09-09-2010 06:19, Pawel Osciak escreveu: Videobuf2 is a Video for Linux 2 API-compatible driver framework

Re: [PATCH v1 7/7] v4l: videobuf2: add CMA allocator

not always call VIDIOC_REQBUFS(0) after finishing. If an application just closes the file descriptor (or even dies), we need a way to clean up the memory. -- Best regards, Pawel Osciak -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[GIT FIXES FOR 2.6.36] mem2mem_testdev fixes

-2.6-samsung v4l/fixes_for_v2.6.36 Pawel Osciak (2): v4l: mem2mem_testdev: fix errorenous comparison v4l: mem2mem_testdev: add missing release for video_device drivers/media/video/mem2mem_testdev.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) -- Best regards, Pawel

[PATCH v1 3/7] v4l: mem2mem: port to videobuf2

Port memory-to-memory framework to videobuf2 framework. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/Kconfig|3 +- drivers/media/video/v4l2-mem2mem.c | 185

[PATCH v1 5/7] v4l: videobuf2: add DMA coherent allocator

Add an implementation of DMA coherent memory allocator and handling routines for videobuf2, implemented on top of dma_alloc_coherent() call. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/Kconfig

[PATCH v1 4/7] v4l: videobuf2: add vmalloc allocator

Add an implementation of contiguous virtual memory allocator and handling routines for videobuf2, implemented on top of vmalloc()/vfree() calls. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/Kconfig

<    1   2   3   4   >