Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

2013-07-11 Thread Takashi Iwai
: Takashi Iwai ti...@suse.de Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei ming@canonical.com --- sound/usb/usx2y/usbusx2yaudio.c |4 1 file changed, 4 insertions(+) diff --git a/sound/usb/usx2y/usbusx2yaudio.c b/sound/usb/usx2y/usbusx2yaudio.c index 4967fe9

Re: [PATCH 45/50] sound: usb: usx2y: spin_lock in complete() cleanup

2013-07-11 Thread Takashi Iwai
At Thu, 11 Jul 2013 22:13:35 +0800, Ming Lei wrote: On Thu, Jul 11, 2013 at 9:50 PM, Takashi Iwai ti...@suse.de wrote: At Thu, 11 Jul 2013 17:08:30 +0400, Sergei Shtylyov wrote: On 11-07-2013 13:06, Ming Lei wrote: Complete() will be run with interrupt enabled, so change

Re: [Ksummit-2012-discuss] [MINI SUMMIT] media mini-summit at KS/2012

2012-08-02 Thread Takashi Iwai
KS/LPC that work on those subsystems are welcome. The names that came up during our discussions for those panels are: Rob Clark rob.cl...@linaro.org (HDMI CEC, ALSA, ARM) Takashi Iwai ti...@suse.de (ALSA) Catalin Marinas catalin.mari...@arm.com (ARM) Mark Brown broo

Re: [PATCH v6] media: Add stk1160 new driver

2012-07-27 Thread Takashi Iwai
...@redhat.com Cc: Takashi Iwai ti...@suse.de Cc: Hans Verkuil hverk...@xs4all.nl Cc: Sylwester Nawrocki sylvester.nawro...@gmail.com Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- Here we are once again, As stk1160 allows communication with an ac97 codec chip, this driver

Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)

2011-08-07 Thread Takashi Iwai
At Sat, 6 Aug 2011 09:50:04 -0700, Randy Dunlap wrote: On Sat, 06 Aug 2011 10:33:39 +0200 Takashi Iwai wrote: At Fri, 5 Aug 2011 16:56:11 -0700, Randy Dunlap wrote: On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote: Hi all, [The kernel.org mirroring

Re: linux-next: Tree for Aug 5 (media/radio/radio-sf16fmr2)

2011-08-06 Thread Takashi Iwai
At Fri, 5 Aug 2011 16:56:11 -0700, Randy Dunlap wrote: On Fri, 5 Aug 2011 14:31:03 +1000 Stephen Rothwell wrote: Hi all, [The kernel.org mirroring is running slowly today] Is media/radio/radio-sf16fmr2 an ISA driver or a PCI driver? ugh. Or is it an I2C driver? linux-next

Re: [alsa-devel] [PATCH] MEDIA: Fix non-ISA_DMA_API link failure of sound code

2011-06-25 Thread Takashi Iwai
...@linux-mips.org Acked-by: Takashi Iwai ti...@suse.de thanks, Takashi drivers/media/radio/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig index e4c97fd..0aeed28 100644 --- a/drivers/media/radio

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Thu, 23 Jun 2011 15:47:50 +0100, Ralf Baechle wrote: A build with ISA ISA_DMA !ISA_DMA_API results in: CC sound/isa/es18xx.o sound/isa/es18xx.c: In function ‘snd_es18xx_playback1_prepare’: sound/isa/es18xx.c:501:9: error: implicit declaration of function ‘snd_dma_program’

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Fri, 24 Jun 2011 12:16:08 +0100, Ralf Baechle wrote: On Fri, Jun 24, 2011 at 10:26:13AM +0200, Takashi Iwai wrote: Hrm... I still don't understand why ES18XX or others were selected at the first place. Isn't it covered by the conditional in sound/isa/Kconfig like below

Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure

2011-06-24 Thread Takashi Iwai
At Fri, 24 Jun 2011 14:08:18 +0100, Ralf Baechle wrote: On Fri, Jun 24, 2011 at 02:22:41PM +0200, Takashi Iwai wrote: o The drivers/media/radio/Kconfig part should be applied for 3.0 and maybe -stable. Yes, this will be good. I just tested that segment only and it works

Re: [alsa-devel] [PATCH] tea575x: allow multiple opens

2011-06-12 Thread Takashi Iwai
At Sat, 11 Jun 2011 15:36:39 +0200, Hans Verkuil wrote: On Saturday, June 11, 2011 15:28:59 Ondrej Zary wrote: Change locking to allow tea575x-radio device to be opened multiple times. Very nice! Signed-off-by: Hans Verkuil hverk...@xs4all.nl Hans, would you apply this and another one

Re: [alsa-devel] [PATCH] tea575x: allow multiple opens

2011-06-12 Thread Takashi Iwai
At Sun, 12 Jun 2011 19:48:47 +0200, Hans Verkuil wrote: On Sunday, June 12, 2011 18:52:56 Takashi Iwai wrote: At Sat, 11 Jun 2011 15:36:39 +0200, Hans Verkuil wrote: On Saturday, June 11, 2011 15:28:59 Ondrej Zary wrote: Change locking to allow tea575x-radio device to be opened

Re: [alsa-devel] [PATCH v5] [resend] radio-sf16fmr2: convert to generic TEA575x interface

2011-05-26 Thread Takashi Iwai
that Mauro or Hans applies these through V4L tree. In that case, you can take my acks for both patches. Acked-by: Takashi Iwai ti...@suse.de Of if it's preferred through sound tree, I can take them later. thanks, Takashi Thanks, Mauro. Signed-off-by: Ondrej Zary li...@rainbow

Re: [PATCH v2] fm801: clean-up radio-related Kconfig

2011-05-15 Thread Takashi Iwai
At Sat, 14 May 2011 22:51:01 +0200, Ondrej Zary wrote: Remove TEA575X_RADIO define from fm801.c. Also update Kconfig help text to include all supported cards. Signed-off-by: Ondrej Zary li...@rainbow-software.org Thanks, applied now. Takashi --- linux-2.6.39-rc2-/sound/pci/Kconfig

Re: [alsa-devel] [PATCH] fm801: clean-up radio-related Kconfig

2011-05-14 Thread Takashi Iwai
At Fri, 13 May 2011 20:26:38 +0200, Ondrej Zary wrote: Change the weird SND_FM801_TEA575X_BOOL define in Kconfig to SND_FM801_RADIO and remove TEA575X_RADIO define from fm801.c. Well, this config is used over years, and if it's about only renaming, it won't be worth enough. Removing

Re: [alsa-devel] [PATCH 1/3] tea575x: remove freq_fixup from struct

2011-05-14 Thread Takashi Iwai
At Thu, 12 May 2011 22:17:56 +0200, Ondrej Zary wrote: freq_fixup is a constant, no need to hold it in struct snd_tea575x and set in each driver. Signed-off-by: Ondrej Zary li...@rainbow-software.org Thanks, applied all three patches. Takashi ---

Re: [alsa-devel] [PATCH RFC] radio-sf16fmr2: convert to generic TEA575x interface

2011-05-14 Thread Takashi Iwai
At Sat, 14 May 2011 00:17:23 +0200, Ondrej Zary wrote: Hello, the SF16-FMR2 radio card is basically a TEA5757 tuner connected to ISA bus but the driver currently uses its own implementation. I converted the driver to use generic tea575x-tuner implementation (see patch below) and it works

Re: [alsa-devel] fm801: implement TEA575x tuner autodetection

2011-05-11 Thread Takashi Iwai
At Tue, 10 May 2011 23:24:15 +0200, Ondrej Zary wrote: Autodetect TEA575x tuner connection type during init. This allows tuner to work out-of-the box. tea575x_tuner module parameter remains functional to force tuner type. Tested with SF256-PCP and SF64-PCR. Signed-off-by: Ondrej Zary

Re: [alsa-devel] [PATCH 1/3] tea575x: unify read/write functions

2011-05-10 Thread Takashi Iwai
At Mon, 9 May 2011 23:39:26 +0200, Ondrej Zary wrote: Implement generic read/write functions to access TEA575x tuners. They're now implemented 4 times (once in es1968 and 3 times in fm801). This also allows mute to work on all cards. Also improve tuner detection/initialization.

Re: [RFC PATCH 4/3] remove radio-maestro

2011-03-23 Thread Takashi Iwai
At Tue, 22 Mar 2011 15:44:05 -0300, Mauro Carvalho Chehab wrote: Hi Takashi, Em 19-03-2011 13:23, Ondrej Zary escreveu: Remove broken radio-maestro driver as the radio functionality is now integrated in the es1968 driver. I prefer if you could also add it on your tree, as we want to

Re: [RFC PATCH 1/3] tea575x-tuner: various improvements

2011-03-21 Thread Takashi Iwai
At Sat, 19 Mar 2011 16:32:53 +0100, Ondrej Zary wrote: Improve tea575x-tuner with various good things from radio-maestro: - extend frequency range to 50-150MHz - fix querycap(): card name, CAP_RADIO - improve g_tuner(): CAP_STEREO, stereo and tuned indication - improve g_frequency(): tuner

Re: [alsa-devel] radio-maestro broken (conflicts with snd-es1968)

2011-03-14 Thread Takashi Iwai
At Sat, 12 Mar 2011 19:19:00 +0100, Ondrej Zary wrote: Hello, the radio-maestro driver is badly broken. It's intended to drive the radio on MediaForte ESS Maestro-based sound cards with integrated radio (like SF64-PCE2-04). But it conflicts with snd_es1968, ALSA driver for the sound chip

Re: [alsa-devel] radio-maestro broken (conflicts with snd-es1968)

2011-03-14 Thread Takashi Iwai
At Sat, 12 Mar 2011 19:52:39 +0100, Hans Verkuil wrote: On Saturday, March 12, 2011 19:19:00 Ondrej Zary wrote: Hello, the radio-maestro driver is badly broken. It's intended to drive the radio on MediaForte ESS Maestro-based sound cards with integrated radio (like SF64-PCE2-04).

Re: [alsa-devel] radio-maestro broken (conflicts with snd-es1968)

2011-03-14 Thread Takashi Iwai
At Mon, 14 Mar 2011 11:28:01 +0100, Ondrej Zary wrote: On Monday 14 March 2011, Hans Verkuil wrote: At Sat, 12 Mar 2011 19:52:39 +0100, Hans Verkuil wrote: On Saturday, March 12, 2011 19:19:00 Ondrej Zary wrote: Hello, the radio-maestro driver is badly broken. It's intended

Re: BUG at mm/mmap.c:2309 when cx18.ko and cx18-alsa.ko loaded

2011-03-07 Thread Takashi Iwai
At Fri, 04 Mar 2011 12:13:04 -0500, Andy Walls wrote: On Fri, 2011-03-04 at 10:50 -0500, Devin Heitmueller wrote: On Thu, Mar 3, 2011 at 9:06 PM, Andy Walls awa...@md.metrocast.net wrote: Hi, I got a BUG when loading the cx18.ko module (which in turn requests the cx18-alsa.ko

Re: [alsa-devel] [RFC/PATCH v6 03/12] media: Entities, pads and links

2010-12-14 Thread Takashi Iwai
At Tue, 14 Dec 2010 14:31:55 +0100, Clemens Ladisch wrote: Should we have an AUDIO category ? Probably not, because there are combined audio/video jacks, any maybe other entities. Yes, nowadays HDMI / DP are pretty common, for example. Takashi -- To unsubscribe from this list: send the

Re: [patch v2] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-23 Thread Takashi Iwai
At Mon, 22 Mar 2010 18:39:09 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter erro...@gmail.com --- In version 2, I used a better name that Takashi Iwai suggested. Acked-by: Takashi Iwai

Re: [patch] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-22 Thread Takashi Iwai
At Fri, 19 Mar 2010 14:49:57 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL, the original code could cause a buffer overflow. Signed-off-by: Dan Carpenter erro...@gmail.com This should rather a string without spaces because this string is used as an identifier in

Re: [patch v2] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 08:43:47 -0700, Joe Perches wrote: On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL, the original code could cause a buffer overflow. In version 2, I used a better name that Takashi Iwai suggested. Perhaps it's

Re: [patch v2] cx231xx: card-driver Conexant cx231xx Audio too long

2010-03-22 Thread Takashi Iwai
At Mon, 22 Mar 2010 19:54:30 +0300, Dan Carpenter wrote: On Mon, Mar 22, 2010 at 05:04:55PM +0100, Takashi Iwai wrote: At Mon, 22 Mar 2010 08:43:47 -0700, Joe Perches wrote: On Mon, 2010-03-22 at 18:39 +0300, Dan Carpenter wrote: card-driver is 15 characters and a NULL

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-22 Thread Takashi Iwai
At Mon, 21 Dec 2009 12:30:48 -0500, Devin Heitmueller wrote: On Mon, Dec 21, 2009 at 12:21 PM, Takashi Iwai ti...@suse.de wrote: Just a very quick look through the files, here are some comments: - snd_card_free() can't be called with NULL, but the error path in  snd_cx18_init() may

Re: [PULL] http://www.kernellabs.com/hg/~dheitmueller/hvr-1600-alsa-2

2009-12-21 Thread Takashi Iwai
At Sun, 13 Dec 2009 10:22:44 -0500, Devin Heitmueller wrote: On Sat, Dec 12, 2009 at 5:34 PM, Mauro Carvalho Chehab mche...@infradead.org wrote: Hi Devin, It is better to submit the RFC patches to alsa ML for they to take a look. Cheers, Mauro Is there something specific you

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-27 Thread Takashi Iwai
pointed by Takashi Iwai. Thanks, I merged now this to sound tree exceptionally since it's purely depends on snd-miro driver. Will appear in the next linux-next. Takashi drivers/media/radio/Kconfig | 18 +++ drivers/media/radio/Makefile |1 + drivers/media/radio

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-26 Thread Takashi Iwai
At Thu, 26 Nov 2009 13:50:17 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found on Miro PCM20 sound cards. This driver was removed around the 2.6.2x kernels because it relied on the removed OSS module. Now, it uses a

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-26 Thread Takashi Iwai
At Thu, 26 Nov 2009 18:38:27 +0100, Krzysztof Helt wrote: On Thu, 26 Nov 2009 16:43:15 +0100 Takashi Iwai ti...@suse.de wrote: At Thu, 26 Nov 2009 13:50:17 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-25 Thread Takashi Iwai
At Tue, 24 Nov 2009 22:12:36 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found on Miro PCM20 sound cards. This driver was removed around the 2.6.2x kernels because it relied on the removed OSS module. Now, it uses a

Re: [PATCH] New driver for the radio FM module on Miro PCM20 sound card

2009-11-25 Thread Takashi Iwai
At Wed, 25 Nov 2009 10:13:53 +0100, I wrote: At Tue, 24 Nov 2009 22:12:36 +0100, Krzysztof Helt wrote: From: Krzysztof Helt krzysztof...@wp.pl This is recreated driver for the FM module found on Miro PCM20 sound cards. This driver was removed around the 2.6.2x kernels because it

Re: [alsa-devel] NULL pointer dereference in ALSA triggered through saa7134-alsa

2009-08-10 Thread Takashi Iwai
At Mon, 10 Aug 2009 16:50:55 +0300, Ozan Çağlayan wrote: Hi, I've finally succesfully compiled and linked saa7134-alsa driver using an external alsa-driver and its Module.symvers file. Everything seems okay, no undefined symbol or something else: - An installed 2.6.30.4 kernel which

Re: [alsa-devel] NULL pointer dereference in ALSA triggered through saa7134-alsa

2009-08-10 Thread Takashi Iwai
At Mon, 10 Aug 2009 18:42:20 +0300, Ozan Çağlayan wrote: Takashi Iwai wrote: At Mon, 10 Aug 2009 16:50:55 +0300, Ozan Çağlayan wrote: Hi, I've finally succesfully compiled and linked saa7134-alsa driver using an external alsa-driver and its Module.symvers file. Everything seems

Re: [alsa-devel] NULL pointer dereference in ALSA triggered through saa7134-alsa

2009-08-10 Thread Takashi Iwai
At Mon, 10 Aug 2009 19:06:29 +0300, Ozan Çağlayan wrote: Takashi Iwai wrote: But /usr/include/sound isn't used for building kernel modules normally. Unless any hack is added, these files have to be installed to the kernel header directory. Ah you're right, I totally missed

<    1   2