On 4 April 2018 at 21:56, Boris Brezillon wrote:
> On Wed, 04 Apr 2018 21:49:26 +0200
> Robert Jarzmik wrote:
>
>> Ulf Hansson writes:
>>
>> > On 2 April 2018 at 16:26, Robert Jarzmik wrote:
>> >> Hi,
>> >>
>> >> T
k or "I want to take through my tree" will be spared in the next
> iterations
> of this serie.
Perhaps an option is to send this hole series as PR for 3.17 rc1, that
would removed some churns and make this faster/easier? Well, if you
receive the needed acks of course.
For the mmc c
On 11 November 2016 at 10:47, Ulf Hansson wrote:
> On 10 November 2016 at 04:44, kbuild test robot wrote:
>> Hi Ulf,
>>
>> [auto build test ERROR on linuxtv-media/master]
>> [also build test ERROR on v4.9-rc4 next-20161109]
>> [if your patch is applied to the
On 10 November 2016 at 04:44, kbuild test robot wrote:
> Hi Ulf,
>
> [auto build test ERROR on linuxtv-media/master]
> [also build test ERROR on v4.9-rc4 next-20161109]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improve the system]
>
> url:
> https://gi
On 9 November 2016 at 15:23, Marek Szyprowski wrote:
> System pm callbacks only ensures that device is runtime suspended/resumed,
> so remove them and use generic pm_runtime_force_suspend/resume helper.
>
> Signed-off-by: Marek Szyprowski
Reviewed-by: Ulf Hansson
Kind
d-off-by: Peter Ujfalusi
> CC: Ulf Hansson
Acked-by: Ulf Hansson
Kind regards
Uffe
> ---
> drivers/mmc/host/davinci_mmc.c | 26 +++---
> 1 file changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/d
OBE_DEFER
>
> Signed-off-by: Peter Ujfalusi
> CC: Ulf Hansson
With the minor change above.
Acked-by: Ulf Hansson
Kind regards
Uffe
> ---
> drivers/mmc/host/omap_hsmmc.c | 22 ++
> 1 file changed, 10 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mm
On 26 May 2015 at 15:25, Peter Ujfalusi wrote:
> The driver will not probe without valid DMA channels so no need to check
> if they are valid when the module is removed.
>
> Signed-off-by: Peter Ujfalusi
> CC: Ulf Hansson
Acked-by: Ulf Hansson
Kind regards
Uffe
> ---
&
On 19 January 2015 at 14:22, Ulf Hansson wrote:
> Changes in v2:
> - Rebase patches.
> - Adapt to changes for the PM core. Especially, the Kconfig option for
> CONFIG_PM_RUNTIME has been removed and the runtime PM core is now
> build for CONF
Instead of having separate functions that fecthes, prepares and
unprepares the clock, let's encapsulate this code into ->probe().
This makes error handling easier and decreases the lines of code.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-cor
To make sure the clock is fully gated in ->remove(), we first need to
to bring the device into full power by invoking pm_runtime_get_sync().
Then, let's both unprepare and disable the clock.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 7 +--
1 file
The driver depended on CONFIG_PM to be functional. Let's remove that
dependency, by enable the runtime PM resourses during ->probe() and
update the device's runtime PM status to reflect this.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 19 +
To potentially save more power in runtime PM suspend state, let's also
prepare/unprepare the clock from the runtime PM callbacks.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/
There are no need to set up the runtime PM callbacks unless they are
being used. It also causes compiler warnings about unused functions.
Silence the warnings by making them available for CONFIG_PM.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 79
There are no need to set up the system PM callbacks unless they are
being used. It also causes compiler warnings about unused functions.
Silence the warnings by making them available for CONFIG_PM_SLEEP.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 5 +++--
1
It's not needed to keep a local flag about the current system PM state.
Let's just remove that code and the corresponding debug print.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 21 -
drivers/media/platform/exynos-gsc/gsc-core.h |
potentially save some more power at runtime PM suspend.
Ulf Hansson (8):
[media] exynos-gsc: Simplify clock management
[media] exynos-gsc: Convert gsc_m2m_resume() from int to void
[media] exynos-gsc: Make driver functional when CONFIG_PM is unset
[media] exynos-gsc: Make runtime PM
Since gsc_m2m_resume() always returns 0, convert it to a void instead.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c
b/drivers/media/platform
On 23 October 2014 13:57, Philipp Zabel wrote:
> Hi Ulf,
>
> Am Montag, den 22.09.2014, 20:44 +0200 schrieb Ulf Hansson:
>> On 22 September 2014 18:05, Philipp Zabel wrote:
>> > From: Ulf Hansson
>> >
>> > For several reasons it's good practice t
There are no need to set up the runtime PM callbacks unless they are
being used. Let's make them available for CONFIG_PM.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/pla
Since gsc_m2m_resume() always returns 0, convert it into void instead.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c
b/drivers/media/platform
reflected properly.
Solve all the above issues by using pm_runtime_force_suspend|resume() as
the system PM callbacks.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 41 ++--
drivers/media/platform/exynos-gsc/gsc-core.h | 3 --
2 files changed
devices will be runtime PM suspended and thus we will still benefit
from using CONFIG_PM_RUNTIME.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/media/platform/exynos-g
We want to make sure that the clock is fully gated after ->remove(). To
do this, we need to bring the device into full power and not only
unprepare the clock, but also disable it.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 7 +--
1 file changed
Instead of having separate functions that fecthes, prepares and
unprepares the clock, let's encapsulate this code into ->probe().
This makes error handling easier and decreases the lines of code.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-cor
To potentially save more power in runtime PM suspend state, let's also
prepare/unprepare the clock from the runtime PM callbacks.
Signed-off-by: Ulf Hansson
---
drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/
11&r=1&w=2
The conserns from the above discussions are intended to be solved by a reworked
approach for the generic PM domain, link below.
http://marc.info/?l=linux-pm&m=141320895122707&w=2
Ulf Hansson (7):
[media] exynos-gsc: Simplify clock management
[media] exynos-gsc: Conve
On 22 September 2014 18:05, Philipp Zabel wrote:
> From: Ulf Hansson
>
> For several reasons it's good practice to leave devices in runtime PM
> active state while those have been probed.
>
> In this cases we also want to prevent the device from going inactive,
> u
For several reasons it's good practice to leave devices in runtime PM
active state while those have been probed.
In this cases we also want to prevent the device from going inactive,
until the firmware has been completely installed, especially when using
a PM domain.
Signed-off-by: Ulf Ha
29 matches
Mail list logo
