[PATCH 4/5] arch: sh: ms7724se: Use new renesas-ceu camera driver

covec: Use new renesas-ceu camera driver") already updated it to the new ceu driver name for all SH7724 boards (possibly breaking ms7724se before this commit). Compile tested only. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/sh/boards/mach-se/77

[PATCH 5/5] arch: sh: ap325rxa: Use new renesas-ceu camera driver

(of 'magic blobs) from the board file itself. I removed the sensor registration from this new version as it used soc_camera components that will be later removed. While at there update license to SPDX header and sort headers alphabetically. Compile tested only. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH 2/5] media: i2c: rj54n1: Remove soc_camera dependencies

to test. This commits does not remove the original soc_camera based driver. Compiled tested only. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- MAINTAINERS| 8 +++ drivers/media/i2c/Kconfig | 11 +++ drivers/media/i2c/Makefile | 1 + drivers

[PATCH 1/5] media: i2c: Copy rj54n1cb0c soc_camera sensor driver

Copy the soc_camera based driver in v4l2 sensor driver directory. This commit just copies the original file without modifying it. No modification to KConfig and Makefile as soc_camera framework dependencies need to be removed first in next commit. Signed-off-by: Jacopo Mondi <jacopo+r

Re: [PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

Hi Niklas, I might have another question before sending v5. On Fri, May 25, 2018 at 12:29:44AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > I really like what you did with this patch in v4. > > On 2018-05-25 00:02:15 +0200, Jacopo Mondi wr

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Tomasz, On Fri, May 25, 2018 at 04:31:07PM +0900, Tomasz Figa wrote: > On Fri, May 25, 2018 at 4:12 PM jacopo mondi <jac...@jmondi.org> wrote: > > > Hi Tomasz, > [snip] > > > the controls set before powering on will actually be programmed into the > > &

Re: [PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

n 2018-05-25 00:02:15 +0200, Jacopo Mondi wrote: > > The rcar-vin driver so far had a mutually exclusive code path for > > handling parallel and CSI-2 video input subdevices, with only the CSI-2 > > use case supporting media-controller. As we add support for parallel > > inputs

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Tomasz, On Fri, May 25, 2018 at 03:18:38PM +0900, Tomasz Figa wrote: > On Fri, May 25, 2018 at 5:47 AM Sakari Ailus <sakari.ai...@linux.intel.com> > wrote: > > > Hi Jacopo, > > > On Thu, May 24, 2018 at 10:07:38PM +0200, jacopo mondi wrote: > > ... &g

[PATCH v4 5/9] media: rcar-vin: Parse parallel input on Gen3

, handling the media-controller use case in the parallel bound/unbind notifier operations. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- v3 -> v4: - Change the mc/parallel initialization order. Initialize mc first, then parallel - As a consequence no need to delay parallel

[PATCH v4 0/9] rcar-vin: Add support for parallel input on Gen3

give this one a spin please? No changelog reported here, except from the one reported above. Most of the other changes are minors, the most notable ones are reported in each patch commit message. Thanks j Jacopo Mondi (9): media: rcar-vin: Rename 'digital' to 'parallel' media: rcar-vin

[PATCH v4 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

As the term 'digital' is used all over the rcar-vin code in place of 'parallel', rename all the occurrencies. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar

[PATCH v4 8/9] media: rcar-vin: Rename _rcar_info to rcar_info

Remove leading underscore to align all rcar_group_route structure declarations. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-core.c | 4 ++-- 1 file changed, 2 inse

[PATCH v4 6/9] media: rcar-vin: Link parallel input media entities

When running with media-controller link the parallel input media entities with the VIN entities at 'complete' callback time. To create media links the v4l2_device should be registered first. Check if the device is already registered, to avoid double registrations. Signed-off-by: Jacopo Mondi

[PATCH v4 7/9] media: rcar-vin: Handle parallel subdev in link_notify

-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-core.c | 35 - 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vin

[PATCH v4 3/9] media: rcar-vin: Create a group notifier

-compliant code path, each VIN may register its own notifier if any parallel subdevice is connected there. To avoid registering a notifier twice (once for parallel subdev and one for the CSI-2 subdevs) create a group notifier, shared by all the VIN instances. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v4 2/9] media: rcar-vin: Remove two empty lines

Remove un-necessary empty lines. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- drivers/media/platform/rcar-vin/rcar-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/r

[PATCH v4 9/9] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rc

[PATCH v4 4/9] media: rcar-vin: Cache the mbus configuration flags

to the link state change notification function. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 21 --- drivers/media/platform/rcar-vin/rcar-dma.c | 32 +++-- drivers/media/platform/rcar-vin/rcar

Re: [PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

Hi Niklas, On Thu, May 24, 2018 at 12:42:25AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > On 2018-05-18 16:40:37 +0200, Jacopo Mondi wrote: > > As the term 'digital' is used all over the rcar-vin code in place of > > 'parallel',

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Sakari, On Wed, May 23, 2018 at 10:38:33AM +0300, Sakari Ailus wrote: > Hi Jacopo and Bingbu, > > On Tue, May 22, 2018 at 10:08:48PM +0200, jacopo mondi wrote: > ... > > > +/* Get bayer order based on flip setting. */ > > > +static __u32 imx319_get_for

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a V4L2 sub-device driver for the Sony IMX319 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for

[PATCH v2 1/4] dt-bindings: media: rcar-vin: Describe optional ep properties

Describe the optional properties for endpoint nodes of port@0 and port@1 of the R-Car VIN driver device tree bindings documentation. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Acked-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> --- Documentation/devicet

[PATCH v2 2/4] dt-bindings: media: rcar-vin: Document data-active

Document 'data-active' property in R-Car VIN device tree bindings. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> v1 -> v2: - HSYNC is used in place of data enable signal only when running with explicit synchronizations. - The property is no more mandatory when running with

[PATCH v2 4/4] ARM: dts: rcar-gen2: Remove unused VIN properties

The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN driver and only confuse users. Remove them in all Gen2 SoC that use them. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 3 --- arch/arm/boot/dts/r8a7791-koelsch.d

[PATCH v2 3/4] media: rcar-vin: Handle CLOCKENB pin polarity

and ignore flags when on CSI-2. Also change comments style to remove un-necessary camel case and add a full stop at the end of sentences. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 34 ++ 1 file chang

[PATCH v2 0/4] media: rcar-vin: Brush endpoint properties

/salvator-x-dts_csi2/d3-vin-driver-v3 Thanks j v1 -> v2: - Change data-active properties handling: the property is only considered when running with explicit synchronization signals. - Drop patch 3/6 and 6/6 from v1 as they're not needed anymore as data-active handling logic changed. Jacopo Mo

[PATCH v3 9/9] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rc

[PATCH v3 8/9] media: rcar-vin: Rename _rcar_info to rcar_info

Remove trailing underscore to align all rcar_group_route structure declarations. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rcar-vi

[PATCH v3 7/9] media: rcar-vin: Handle parallel subdev in link_notify

-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 36 +++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index d

[PATCH v3 4/9] media: rcar-vin: Cache the mbus configuration flags

to the link state change notification function. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 23 ++- drivers/media/platform/rcar-vin/rcar-dma.c | 24 +--- drivers/media/platform/rcar-vin/rcar

[PATCH v3 5/9] media: rcar-vin: Parse parallel input on Gen3

, handling the media-controller use case in the parallel bound/unbind notifier operations and delay notifier registration to the last probing VIN instance in case we have links to setup between media entities. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rc

[PATCH v3 6/9] media: rcar-vin: Link parallel input media entities

When running with media-controller link the parallel input media entities with the VIN entities at 'complete' callback time. To create media links the v4l2_device should be registered first. Check if the device is already registered, to avoid double registrations. Signed-off-by: Jacopo Mondi

[PATCH v3 1/9] media: rcar-vin: Rename 'digital' to 'parallel'

As the term 'digital' is used all over the rcar-vin code in place of 'parallel', rename all the occurrencies. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 72 ++--- drivers/media/platform/rcar-vin/rcar

[PATCH v3 2/9] media: rcar-vin: Remove two empty lines

Remove un-necessary empty lines. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers/media/platform/rcar-vin/rcar-core.c index 6

[PATCH v3 3/9] media: rcar-vin: Create a group notifier

-compliant code path, each VIN may register its own notifier if any parallel subdevice is connected there. To avoid registering a notifier twice (once for parallel subdev and one for the CSI-2 subdevs) create a group notifier, shared by all the VIN instances. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH v3 0/9] rcar-vin: Add support for parallel input on Gen3

review of v1 and v2, I hope this one is closer to what is expected to properly support parallel capture on Gen3 boards. (On a side note, am I wrong or with this series we may easily move all Gen2 devices to run with media-controller without any major modifications?) Thanks j Jacopo Mondi (9

Re: [PATCH v2 1/4] media: rcar-vin: Parse digital input in mc-path

fine with > that too. I would go with a major s/digital/parallel/ after this has been merged, if that' fine with you. > > On 2018-05-16 14:16:53 +0200, Jacopo Mondi wrote: > > Add support for digital input subdevices to Gen-3 rcar-vin. > > The Gen-3, media-controller compl

Re: [PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

Hi Niklas, On Thu, May 17, 2018 at 12:13:07AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:31 +0200, Jacopo Mondi wrote: > > The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN > > driver and only

Re: [PATCH 4/6] media: rcar-vin: Handle CLOCKENB pin polarity

Hi Niklas, On Thu, May 17, 2018 at 12:11:03AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your patch. > > I'm happy that you dig into this as it clearly needs doing! > > On 2018-05-16 18:32:30 +0200, Jacopo Mondi wrote: > > Handle CLOCKENB pin polarity

Re: [PATCH 3/6] media: rcar-vin: Handle data-active property

Hi Niklas, On Wed, May 16, 2018 at 11:58:47PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:29 +0200, Jacopo Mondi wrote: > > The data-active property has to be specified when running with embedded > > synchronization.

Re: [PATCH 2/6] dt-bindings: media: rcar-vin: Document data-active

Hi Niklas, On Wed, May 16, 2018 at 11:55:38PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work. > > On 2018-05-16 18:32:28 +0200, Jacopo Mondi wrote: > > Document 'data-active' property in R-Car VIN device tree bindings. > > The property is optional

[PATCH 6/6] ARM: dts: rcar-gen2: Add 'data-active' property

The 'data-active' property needs to be specified when using embedded synchronization. Add it to the Gen-2 boards using composite video input. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 1 + arch/arm/boot/dts/r8a7791-koelsch.dts | 1 +

[PATCH 0/6] media: rcar-vin: Brush endpoint properties

bindings, as they are not parsed by the VIN driver and only confuse users. Niklas, as you already know I don't have any Gen2 board. Could you give this a spin on Koelsch if you like the series? Thanks j Jacopo Mondi (6): dt-bindings: media: rcar-vin: Describe optional ep properties dt-bindings

[PATCH 4/6] media: rcar-vin: Handle CLOCKENB pin polarity

Handle CLOCKENB pin polarity, or use HSYNC in its place if polarity is not specified. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar

[PATCH 2/6] dt-bindings: media: rcar-vin: Document data-active

Document 'data-active' property in R-Car VIN device tree bindings. The property is optional when running with explicit synchronization (eg. BT.601) but mandatory when embedded synchronization is in use (eg. BT.656) as specified by the hardware manual. Signed-off-by: Jacopo Mondi <jacopo+r

[PATCH 5/6] ARM: dts: rcar-gen2: Remove unused VIN properties

The 'bus-width' and 'pclk-sample' properties are not parsed by the VIN driver and only confuse users. Remove them in all Gen2 SoC that used them. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7790-lager.dts | 3 --- arch/arm/boot/dts/r8a7791-koelsch.d

[PATCH 1/6] dt-bindings: media: rcar-vin: Describe optional ep properties

Describe the optional endpoint properties for endpoint nodes of port@0 and port@1 of the R-Car VIN driver device tree bindings documentation. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Documentation/devicetree/bindings/media/rcar_vin.txt | 13 - 1 file chang

[PATCH 3/6] media: rcar-vin: Handle data-active property

not sense to zero the mbus configuration flags when running with implicit synch (V4L2_MBUS_BT656). Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH v2 3/4] media: rcar-vin: Handle digital subdev in link_notify

Handle digital subdevices in link_notify callback. If the notified link involves a digital subdevice, do not change routing of the VIN-CSI-2 devices. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 30 +++--

[PATCH v2 4/4] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Reviewed-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/media/platform/rc

[PATCH v2 0/4] rcar-vin: Add support for digital input on Gen3

://jmondi.org/linux d3/renesas-drivers/test Thanks j Jacopo Mondi (4): media: rcar-vin: Parse digital input in mc-path media: rcar-vin: Handle mc in digital notifier ops media: rcar-vin: Handle digital subdev in link_notify media: rcar-vin: Add support for R-Car R8A77995 SoC drivers/media

[PATCH v2 2/4] media: rcar-vin: Handle mc in digital notifier ops

Handle media-controller in the digital notifier operations (bound, unbind and complete) registered for VIN instances handling a digital input subdevice. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 94 --

[PATCH v2 1/4] media: rcar-vin: Parse digital input in mc-path

-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 99 +++-- drivers/media/platform/rcar-vin/rcar-vin.h | 15 + 2 files changed, 93 insertions(+), 21 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-cor

Re: [PATCH v16 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

axime.rip...@bootlin.com> I forgot to add it to v15, as my comments there pointed to non blocking issues. Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Thanks j > > --- > > * Changes since v15 > - Merge struct phtw_mbps and struct phypll_hsfreqrange into a

Re: [PATCH 2/2] media: i2c: mt9t112: Add device tree support

Hi Sakari, On Tue, May 15, 2018 at 12:50:04AM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 14, 2018 at 04:30:44PM +0200, jacopo mondi wrote: > > Hi Sakari, > > > > On Mon, May 07, 2018 at 12:32:19PM +0300, Sakari Ailus wrote: > > > Hi Jacopo, >

Re: [PATCH 2/2] media: i2c: mt9t112: Add device tree support

Hi Sakari, On Mon, May 07, 2018 at 12:32:19PM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Wed, Apr 25, 2018 at 01:00:14PM +0200, Jacopo Mondi wrote: [snip] > > static int mt9t112_probe(struct i2c_client *client, > > const struct i2c_device_id *did)

Re: [PATCH v15 1/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver documentation

ndpoint properties in the hardware module, and those should be described here. Eg. the clock lane shall be fixed in position 0 (that's more an HW design choice, I agree), and the number of supported data lanes is either 1, 2 or 4 and 3 is not supported. Apart from that, w

Re: [PATCH v15 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, thanks for the patch On Sun, May 13, 2018 at 09:19:17PM +0200, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources and the video

Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

Hi Sakari, thanks for the clarification, please ignore my comment then. Thanks j On Mon, May 14, 2018 at 12:49:19PM +0300, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, May 14, 2018 at 11:06:46AM +0200, jacopo mondi wrote: > > Hi Akinobu, > > > >a small nit b

Re: [PATCH v5 08/14] media: ov772x: support device tree probing

probing. > > > > Note that the platform data probe can select auto or manual edge control > > mode, but the device tree probling can only select auto edge control mode > > for now. > > > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > > Cc: Laurent Pinchar

Re: [PATCH v5 14/14] media: ov772x: create subdevice device node

Hi Akinobu, thanks for the patch. On Sun, May 06, 2018 at 11:19:29PM +0900, Akinobu Mita wrote: > Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the > subdevice device node is created. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pi

Re: [PATCH v5 13/14] media: ov772x: make set_fmt() and s_frame_interval() return -EBUSY while streaming

requests are preferred to fail while > the video stream on the device is active. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai

Re: [PATCH v5 12/14] media: ov772x: avoid accessing registers under power saving mode

ving mode. These callbacks for ov772x driver > cause updating H/W registers that will fail under power saving mode. > > This avoids it by not apply any changes to H/W if the device is not powered > up. Instead the changes will be restored right after power-up. > > Cc: Jacopo Mondi <jacopo+ren

Re: [PATCH v5 10/14] media: ov772x: reconstruct s_frame_interval()

under power > saving mode. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Mauro Carvalho Chehab

Re: [PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

Hi Niklas, On Fri, May 11, 2018 at 01:01:24PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your work! > > The comments here apply to both 2/5 and 3/5. > > On 2018-05-11 11:59:38 +0200, Jacopo Mondi wrote: > > Add support for digital input subdevices to Ge

Re: [PATCH 5/5] media: rcar-vin: Use FTEV for digital input

Hi Hans, On Fri, May 11, 2018 at 12:28:55PM +0200, Hans Verkuil wrote: > On 05/11/18 11:59, Jacopo Mondi wrote: > > Since commit (015060cb "media: rcar-vin: enable field toggle after a set > > number of lines for Gen3) the VIN generates an internal field signal > > t

[PATCH 4/5] media: rcar-vin: Do not use crop if not configured

. Fix this by using the actual format width and height when no crop rectangle has been programmed. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 5/5] media: rcar-vin: Use FTEV for digital input

uture. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-dma.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/rcar-vin/rcar-dma.c b/drivers/media/platform/rcar-vin/rcar-dma.c index ea7a1

[PATCH 3/5] media: rcar-vin: [un]bind and link digital subdevice

Add support for binding and unbinding digital subdevices to rcar-vin. On 'complete' also create direct links between the VIN instance and the digital subdevice. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c

[PATCH 0/5] rcar-vin: Add support for digital input on Gen3

Thanks j Jacopo Mondi (5): media: rcar-vin: Add support for R-Car R8A77995 SoC media: rcar-vin: Add digital input subdevice parsing media: rcar-vin: [un]bind and link digital subdevice media: rcar-vin: Do not use crop if not configured media: rcar-vin: Use FTEV for digital input

[PATCH 1/5] media: rcar-vin: Add support for R-Car R8A77995 SoC

Add R-Car R8A77995 SoC to the rcar-vin supported ones. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-core.c b/drivers

[PATCH 2/5] media: rcar-vin: Add digital input subdevice parsing

-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- drivers/media/platform/rcar-vin/rcar-core.c | 166 +++- drivers/media/platform/rcar-vin/rcar-vin.h | 13 +++ 2 files changed, 153 insertions(+), 26 deletions(-) diff --git a/drivers/media/platform/rcar-vin/rcar-cor

Re: [PATCH v4 12/14] media: ov772x: avoid accessing registers under power saving mode

Hi Akinobu, On Fri, May 04, 2018 at 11:50:39PM +0900, Akinobu Mita wrote: > 2018-05-04 6:03 GMT+09:00 jacopo mondi <jac...@jmondi.org>: > > Hi Akinobu, > > let me see if I got this right... > > > > On Mon, Apr 30, 2018 at 02:13:11AM +0900, Akinobu Mita wrote:

[PATCH] media: renesas-ceu: Set mbus_fmt on subdev operations

] ov7670_try_fmt_internal -- Try mbus_code 0x3001 [0.891584] ov7670_try_fmt_internal -- mbus_code defaulted to 0x2008 With this patch applied: [0.867015] ov7670_try_fmt_internal -- Looking for mbus_code 0x2008 [0.873205] ov7670_try_fmt_internal -- Try mbus_code 0x2008: match Signed-off-by: Jacopo

Re: [PATCH v4 12/14] media: ov772x: avoid accessing registers under power saving mode

ving mode. These callbacks for ov772x driver > cause updating H/W registers that will fail under power saving mode. > > This avoids it by not apply any changes to H/W if the device is not powered > up. Instead the changes will be restored right after power-up. > > Cc: Jacopo Mondi

Re: [PATCH v4 10/14] media: ov772x: reconstruct s_frame_interval()

under power > saving mode. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil <hans.verk...@cisco.com> > Cc: Sakari Ailus <sakari.ai...@linux.intel.com> > Cc: Mauro Carvalho C

Re: [PATCH v4 08/14] media: ov772x: support device tree probing

m data probe can select auto or manual edge control > mode, but the device tree probling can only select auto edge control mode > for now. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Hans Verkuil &

Re: [PATCH v4 03/14] media: ov772x: allow i2c controllers without I2C_FUNC_PROTOCOL_MANGLING

OTOCOL_MANGLING is that > it doesn't support repeated starts. > > This changes the reading ov772x register method so that it doesn't > require I2C_FUNC_PROTOCOL_MANGLING by calling two separated i2c messages. > > Cc: Jacopo Mondi <jacopo+rene...@jmondi.org> > Cc: Laurent Pinchar

Re: [PATCH v4 02/14] media: ov772x: correct setting of banding filter

client, COM8, BNDF_ON_OFF, 1); > > But this unexpectedly results disabling the banding filter, because the > mask and set bits are exclusive. > > On the other hand, ov772x_s_ctrl() correctly sets the bit by: > > ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, BNDF_ON_OFF);

Re: [PATCH v3 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

inchart <laurent.pinchart+rene...@ideasonboard.com> > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Thanks j > --- > Changes since v2: > > - Reduce indentation in vsp1_du_insert_uif() > - Use

Re: [PATCH v3 5/8] v4l: vsp1: Extend the DU API to support CRC computation

ompletion callback. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo+rene...@jmondi.org> Thanks j > --- > Changes since v2: &g

Re: [RESEND PATCH v8 2/2] media: dw9807: Add dw9807 vcm driver

is driver creates a V4L2 subdevice and > provides control to set the desired focus. > > Signed-off-by: Andy Yeh <andy....@intel.com> Reviewed-by: Jacopo Mondi <jac...@jmondi.org> Thanks j > --- > since v1: > - changed author. > since v2: > - addressed outstanding

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Sat, Apr 28, 2018 at 03:31:14PM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your feedback. > > On 2018-04-28 13:28:27 +0200, Jacopo Mondi wrote: > > Hi Niklas, > >apart from a small comment, as my comments on v13 have been > &

Re: [PATCH v14 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, apart from a small comment, as my comments on v13 have been clarified Reviewed-by: Jacopo Mondi <jac...@jmondi.org> On Thu, Apr 26, 2018 at 10:21:21PM +0200, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-C

Re: [PATCH v2 7/8] v4l: vsp1: Integrate DISCOM in display pipeline

HI Laurent, On Mon, Apr 23, 2018 at 01:34:29AM +0300, Laurent Pinchart wrote: > The DISCOM is used to compute CRCs on display frames. Integrate it in > the display pipeline at the output of the blending unit to process > output frames. > > Computing CRCs on input frames is possible by positioning

Re: [PATCH v2 6/8] v4l: vsp1: Add support for the DISCOM entity

DOCMPMR_SEL(9)); > + > + crop = vsp1_entity_get_pad_selection(entity, entity->config, > + UIF_PAD_SINK, V4L2_SEL_TGT_CROP); > + > + /* On M3-W the horizontal coordinates are twice the register value. */ > + if (uif->m3w_quirk

Re: [PATCH v2 5/8] v4l: vsp1: Extend the DU API to support CRC computation

Hi Laurent, just one minor comment below On Mon, Apr 23, 2018 at 01:34:27AM +0300, Laurent Pinchart wrote: > Add a parameter (in the form of a structure to ease future API > extensions) to the VSP atomic flush handler to pass CRC source > configuration, and pass the CRC value to the completion

Re: [PATCH v2 3/8] v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper

; Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Jacopo Mondi <jac...@jmondi.org> > --- > drivers/media/platform/vsp1/vsp1_entity.c | 16 + > drivers/media/platform/vsp1/vsp1_histo.c | 59 > +++ > 2 fil

Re: [PATCH v2 2/8] v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code

Hi Laurent, very minor comments below On Mon, Apr 23, 2018 at 01:34:24AM +0300, Laurent Pinchart wrote: > The implementation of the set_fmt pad operation is identical in the > three modules. Move it to a generic helper function. > > Signed-off-by: Laurent Pinchart

[PATCH v2 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740

Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU unit. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- drivers/media/platform/renesas-ceu.c| 1 + 2 files chan

[PATCH v2 2/2] ARM: dts: r8a7740: Add CEU0

Describe CEU0 peripheral for Renesas R-Mobile A1 R8A7740 Soc. Reported-by: Geert Uytterhoeven <ge...@glider.be> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7740.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot

[PATCH v2 0/2]

Thanks j v1 -> v2: - Enlarge the memory range as suggested by Simon - Fix power domain, as reported by Simon - s/Enable/[Describe|Add] in commit message Jacopo Mondi (2): dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 ARM: dts: r8a7740: Add CEU0 Documentation/devicetree/bindings/me

Re: [PATCH 1/8] drm: bridge: Add support for static image formats

Hi Peter, On Sun, Apr 22, 2018 at 10:02:23PM +0200, Peter Rosin wrote: > On 2018-04-19 11:31, Jacopo Mondi wrote: > > Add support for storing image format information in DRM bridges with > > associated helper function. > > > > This patch

Re: [PATCH 1/8] drm: bridge: Add support for static image formats

Hi Laurent, On Mon, Apr 23, 2018 at 12:27:39PM +0300, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 19 April 2018 12:31:02 EEST Jacopo Mondi wrote: > > Add support for storing image format information in DRM bridges with > >

Re: [PATCH v3 01/11] media: dt-bindings: ov772x: add device tree binding

2018-04-24 0:54 GMT+09:00 Akinobu Mita <akinobu.m...@gmail.com>: > >> > 2018-04-23 18:17 GMT+09:00 Laurent Pinchart: > >> >> On Sunday, 22 April 2018 18:56:07 EEST Akinobu Mita wrote: > >> >>> This adds a device tree binding documentation for OV7720

Re: [PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

d, Apr 25, 2018 at 01:15:20PM +0200, Jacopo Mondi wrote: > > Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. > > Given 'status = "disabled"' below I think you > are describing but not enabling CEU0. Also in the subject. Right. > > Should we also describe

[PATCH 1/2] dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740

Add R-Mobile A1 R8A7740 SoC to the list of compatible values for the CEU unit. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- drivers/media/platform/renesas-ceu.c| 1 + 2 files chan

[PATCH 2/2] ARM: dts: r8a7740: Enable CEU0

Enable CEU0 peripheral for Renesas R-Mobile A1 R8A7740. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- arch/arm/boot/dts/r8a7740.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi index a

[PATCH 0/2] renesas: ceu: Add R-Mobile A1

Thanks j Jacopo Mondi (2): dt-bindings: media: renesas-ceu: Add R-Mobile R8A7740 ARM: dts: r8a7740: Enable CEU0 Documentation/devicetree/bindings/media/renesas,ceu.txt | 7 --- arch/arm/boot/dts/r8a7740.dtsi | 10 ++ drivers/media/platform/renesas-ceu.c

[PATCH 1/2] dt-bindings: media: i2c: Add mt9t111 image sensor

Add device tree bindings documentation for Micron MT9T111/MT9T112 image sensors. Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org> --- Documentation/devicetree/bindings/mt9t112.txt | 41 +++ 1 file changed, 41 insertions(+) create mode 100644 Documen

<    1   2   3   4   5   6   >