Re: [PATCH] videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()

2018-11-19 Thread Ezequiel Garcia
On Mon, 2018-11-19 at 16:33 +0100, Hans Verkuil wrote: > Userspace shouldn't set bytesused to 0 for output buffers. > vb2_warn_zero_bytesused() warns about this (only once!), but it also > calls WARN_ON(1), which is confusing since it is not immediately clear > that it warns about a 0 value for

[PATCH] videobuf2-v4l2: drop WARN_ON in vb2_warn_zero_bytesused()

2018-11-19 Thread Hans Verkuil
Userspace shouldn't set bytesused to 0 for output buffers. vb2_warn_zero_bytesused() warns about this (only once!), but it also calls WARN_ON(1), which is confusing since it is not immediately clear that it warns about a 0 value for bytesused. Just drop the WARN_ON as it serves no purpose.