Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Tony Lindgren
* Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]: --- a/drivers/media/rc/ir-rx51.c +++ b/drivers/media/rc/ir-rx51.c @@ -74,6 +74,19 @@ static void lirc_rx51_off(struct lirc_rx51 *lirc_rx51)

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]: --- a/drivers/media/rc/ir-rx51.c +++ b/drivers/media/rc/ir-rx51.c @@ -74,6 +74,19 @@ static void

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [121214 09:36]: Hi, On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]: --- a/drivers/media/rc/ir-rx51.c +++

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 09:46:29AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:36]: Hi, On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Tony Lindgren
* Felipe Balbi ba...@ti.com [121214 09:59]: On Fri, Dec 14, 2012 at 09:46:29AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:36]: if it's really for PWM, shouldn't we be using drivers/pwm/ ?? Meaning that $SUBJECT would just request a PWM device and use it.

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Felipe Balbi
Hi, On Fri, Dec 14, 2012 at 10:06:45AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:59]: On Fri, Dec 14, 2012 at 09:46:29AM -0800, Tony Lindgren wrote: * Felipe Balbi ba...@ti.com [121214 09:36]: if it's really for PWM, shouldn't we be using drivers/pwm/ ??

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Timo Kokkonen
On 12/14/12 19:26, Felipe Balbi wrote: Hi, On Fri, Dec 14, 2012 at 09:28:09AM -0800, Tony Lindgren wrote: * Tony Lindgren t...@atomide.com [121120 12:00]: Hi, * Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]: --- a/drivers/media/rc/ir-rx51.c +++ b/drivers/media/rc/ir-rx51.c @@

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-12-14 Thread Tony Lindgren
* Timo Kokkonen timo.t.kokko...@iki.fi [121214 11:33]: On 12/14/12 19:26, Felipe Balbi wrote: if it's really for PWM, shouldn't we be using drivers/pwm/ ?? Now that Neil Brown posted the PWM driver for omap, I've been thinking about whether converting the ir-rx51 into the PWM API

Re: [PATCH 1/7] ir-rx51: Handle signals properly

2012-11-20 Thread Tony Lindgren
Hi, * Timo Kokkonen timo.t.kokko...@iki.fi [121118 07:15]: --- a/drivers/media/rc/ir-rx51.c +++ b/drivers/media/rc/ir-rx51.c @@ -74,6 +74,19 @@ static void lirc_rx51_off(struct lirc_rx51 *lirc_rx51) OMAP_TIMER_TRIGGER_NONE); } +static void

[PATCH 1/7] ir-rx51: Handle signals properly

2012-11-18 Thread Timo Kokkonen
The lirc-dev expects the ir-code to be transmitted when the write call returns back to the user space. We should not leave TX ongoing no matter what is the reason we return to the user space. Easiest solution for that is to simply remove interruptible sleeps. The first wait_event_interruptible is