Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-12-08 Thread Jacek Anaszewski
Hhi Sakari, On 12/09/2016 12:05 AM, Sakari Ailus wrote: Hi Jacek, On Thu, Dec 08, 2016 at 11:04:20PM +0100, Jacek Anaszewski wrote: Hi Sakari, On 11/24/2016 01:17 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patchset. On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote:

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-12-08 Thread Sakari Ailus
Hi Jacek, On Thu, Dec 08, 2016 at 11:04:20PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > On 11/24/2016 01:17 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thanks for the patchset. > > > >On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: > >>Add helper functions that allow for

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-12-08 Thread Jacek Anaszewski
Hi Sakari, On 11/24/2016 01:17 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patchset. On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: Add helper functions that allow for easy instantiation of media_device object basing on whether the media device contains v4l2 subdev

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-11-24 Thread Jacek Anaszewski
On 11/24/2016 03:32 PM, Sakari Ailus wrote: [...] + sprintf(device_dir_path, "/sys/class/video4linux/%s/device/", p + 1); + + device_dir = opendir(device_dir_path); + if (device_dir == NULL) + return NULL; + + while ((entry = readdir(device_dir))) { +

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-11-24 Thread Sakari Ailus
Hi Jacek, On Thu, Nov 24, 2016 at 02:50:39PM +0100, Jacek Anaszewski wrote: > Hi Sakari, > > Thanks for the review. > > On 11/24/2016 01:17 PM, Sakari Ailus wrote: > >Hi Jacek, > > > >Thanks for the patchset. > > > >On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: > >>Add

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-11-24 Thread Jacek Anaszewski
Hi Sakari, Thanks for the review. On 11/24/2016 01:17 PM, Sakari Ailus wrote: Hi Jacek, Thanks for the patchset. On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: Add helper functions that allow for easy instantiation of media_device object basing on whether the media device

Re: [PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-11-24 Thread Sakari Ailus
Hi Jacek, Thanks for the patchset. On Wed, Oct 12, 2016 at 04:35:19PM +0200, Jacek Anaszewski wrote: > Add helper functions that allow for easy instantiation of media_device > object basing on whether the media device contains v4l2 subdev with > given file descriptor. Doesn't this work with

[PATCH v4l-utils v7 4/7] mediactl: Add media_device creation helpers

2016-10-12 Thread Jacek Anaszewski
Add helper functions that allow for easy instantiation of media_device object basing on whether the media device contains v4l2 subdev with given file descriptor. Signed-off-by: Jacek Anaszewski Acked-by: Kyungmin Park ---