Re: [RFC] ISP lane shifter support

2011-02-24 Thread Hans Verkuil
Hi Michael, Sorry for the delay, the last 2-3 weeks were very busy. On Tuesday, February 22, 2011 13:36:08 Michael Jones wrote: > Hans, can you weigh in on this? I'm waiting to submit a patch to > implement lane shifter support until I get a consensus what the best > approach is. Laurent and Sa

Re: [RFC] ISP lane shifter support

2011-02-22 Thread Michael Jones
Hans, can you weigh in on this? I'm waiting to submit a patch to implement lane shifter support until I get a consensus what the best approach is. Laurent and Sakari favor having a different format on the sensor output than on the CCDC input to indicate a shift. If you agree that this is a sensi

Re: [RFC] ISP lane shifter support

2011-02-11 Thread Laurent Pinchart
Hi Michael, On Friday 11 February 2011 13:07:33 Michael Jones wrote: > On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote: > > Looking at the "Data-Lane Shifter" table (12.27 in my datasheet, in the > > "Bridge-Lane Shifter" chapter), I think, the first two columns are fixed > > by the board desi

Re: [RFC] ISP lane shifter support

2011-02-11 Thread Michael Jones
Hi Laurent, On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote: > Looking at the "Data-Lane Shifter" table (12.27 in my datasheet, in the > "Bridge-Lane Shifter" chapter), I think, the first two columns are fixed > by the board design, right? So, our freedom lies only in one line there > and

Re: [RFC] ISP lane shifter support

2011-02-02 Thread Michael Jones
Hi Guennadi, Laurent, On 01/27/2011 12:46 AM, Guennadi Liakhovetski wrote: >> >>> I didn't realize the video port can further shift the data. Where can I >>> find this in the TRM? >> >> VPIN field of the CCDC_FMTCFG register. > > This only plays a role, if cam_d is set to 10 bits raw in > CC

Re: [RFC] ISP lane shifter support

2011-01-26 Thread Guennadi Liakhovetski
On Tue, 25 Jan 2011, Laurent Pinchart wrote: > Hi Michael, > > On Tuesday 25 January 2011 10:10:50 Michael Jones wrote: > > On 01/24/2011 08:45 PM, Laurent Pinchart wrote: > > > On Monday 24 January 2011 15:16:28 Michael Jones wrote: > > >> On 01/24/2011 02:57 PM, Laurent Pinchart wrote: > > >>

Re: [RFC] ISP lane shifter support

2011-01-25 Thread Laurent Pinchart
Hi Michael, On Tuesday 25 January 2011 10:10:50 Michael Jones wrote: > On 01/24/2011 08:45 PM, Laurent Pinchart wrote: > > On Monday 24 January 2011 15:16:28 Michael Jones wrote: > >> On 01/24/2011 02:57 PM, Laurent Pinchart wrote: > >> > >> > > As the lane shifter is located at the CCDC inp

Re: [RFC] ISP lane shifter support

2011-01-25 Thread Michael Jones
Hi Laurent, On 01/24/2011 08:45 PM, Laurent Pinchart wrote: > Hi Michael, > > On Monday 24 January 2011 15:16:28 Michael Jones wrote: >> On 01/24/2011 02:57 PM, Laurent Pinchart wrote: >> >> > As the lane shifter is located at the CCDC input, it might be easier to > implement support for

Re: [RFC] ISP lane shifter support

2011-01-24 Thread Laurent Pinchart
Hi Michael, On Monday 24 January 2011 15:16:28 Michael Jones wrote: > On 01/24/2011 02:57 PM, Laurent Pinchart wrote: > > > >>> As the lane shifter is located at the CCDC input, it might be easier to > >>> implement support for this using the CCDC input format. ispvideo.c > >>> would need to val

Re: [RFC] ISP lane shifter support

2011-01-24 Thread Michael Jones
Hi Laurent, On 01/24/2011 02:57 PM, Laurent Pinchart wrote: >>> >>> As the lane shifter is located at the CCDC input, it might be easier to >>> implement support for this using the CCDC input format. ispvideo.c would >>> need to validate the pipeline when the output of the entity connected to >>>

Re: [RFC] ISP lane shifter support

2011-01-24 Thread Laurent Pinchart
Hi Michael, On Monday 24 January 2011 14:47:04 Michael Jones wrote: > On 01/24/2011 01:10 AM, Laurent Pinchart wrote: > > On Friday 21 January 2011 09:40:21 Michael Jones wrote: > >> Hi all, > >> > >> In the OMAP ISP driver, I'm interested in being able to choose between > >> 8-bit and 12-bit for

Re: [RFC] ISP lane shifter support

2011-01-24 Thread Michael Jones
Hi Laurent, Thanks for the feedback. On 01/24/2011 01:10 AM, Laurent Pinchart wrote: > Hi Michael, > > On Friday 21 January 2011 09:40:21 Michael Jones wrote: >> Hi all, >> >> In the OMAP ISP driver, I'm interested in being able to choose between >> 8-bit and 12-bit formats when I have a 12-bit

Re: [RFC] ISP lane shifter support

2011-01-23 Thread Laurent Pinchart
Hi Michael, On Friday 21 January 2011 09:40:21 Michael Jones wrote: > Hi all, > > In the OMAP ISP driver, I'm interested in being able to choose between > 8-bit and 12-bit formats when I have a 12-bit sensor attached. At the > moment it looks like it's only possible to define this statically wit

[RFC] ISP lane shifter support

2011-01-21 Thread Michael Jones
Hi all, In the OMAP ISP driver, I'm interested in being able to choose between 8-bit and 12-bit formats when I have a 12-bit sensor attached. At the moment it looks like it's only possible to define this statically with data_lane_shift in the board definition. But with the ISP's lane shifter, it