Re: [PATCH 0/7] media: i2c: small enhancements for camera sensor drivers

Hello Mita-san, thanks for the patches On Tue, Nov 13, 2018 at 01:00:47AM +0900, Akinobu Mita wrote: > This patchset addds relatively small enhancements (log_status ioctl, event > interface, V4L2_CID_TEST_PATTERN control, and V4L2_CID_COLORFX control) for > mt9m111, ov2640, ov5640, ov7670, and

[PATCH 0/7] media: i2c: small enhancements for camera sensor drivers

This patchset addds relatively small enhancements (log_status ioctl, event interface, V4L2_CID_TEST_PATTERN control, and V4L2_CID_COLORFX control) for mt9m111, ov2640, ov5640, ov7670, and ov772x drivers. I have these devices so these patches are tested with real devices. Akinobu Mita (7):

Re: [PATCH v7] media: add imx319 camera sensor driver

900, Tomasz Figa wrote: > > > > > > Hi Sakari, > > > > > > > > > > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > > > > > > > > > From: Bingbu Cao > > > > > > > > > > &g

Re: [PATCH v7] media: add imx319 camera sensor driver

38 AM wrote: > > > > > > > > > > > > From: Bingbu Cao > > > > > > > > > > > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > > > > > This is a camera sensor using the i2c bus

Re: [PATCH v7] media: add imx319 camera sensor driver

On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote: > > > > Hi Sakari, > > > > > > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > > > > > From: Bingbu Cao > > > > > > > > > > Add a v

Re: [PATCH v7] media: add imx319 camera sensor driver

t; > > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > > > > > From: Bingbu Cao > > > > > > > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > > > This is a camera sensor using the i2c bus for control and the >

Re: [PATCH v7] media: add imx319 camera sensor driver

; > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > > This is a camera sensor using the i2c bus for control and the > > > csi-2 bus for data. > > > > > > This driver supports following features: > > > - manual exposure and ana

Re: [PATCH v7] media: add imx319 camera sensor driver

Hi Tomasz, On Fri, Oct 12, 2018 at 01:51:10PM +0900, Tomasz Figa wrote: > Hi Sakari, > > On Wed, Sep 26, 2018 at 11:38 AM wrote: > > > > From: Bingbu Cao > > > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > > This is a came

Re: [PATCH v7] media: add imx319 camera sensor driver

Hi Sakari, On Wed, Sep 26, 2018 at 11:38 AM wrote: > > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driver supports following featu

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Thu, Sep 27, 2018 at 03:19:07AM +, Chen, Ping-chung wrote: > Hi, > > >-Original Message- > >From: Yeh, Andy > >Sent: Wednesday, September 26, 2018 11:19 PM > >To: Sakari Ailus ; Chen, Ping-chung > > > > >Hi Sakari, PC, > > >sensors that do need >digital gain

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi, On Mon, Oct 01, 2018 at 12:50:02PM +0200, Helmut Grohne wrote: > Hi Laurent, > > On Fri, Sep 28, 2018 at 03:49:38PM +0200, Laurent Pinchart wrote: > > I don't think we'll reach an agreement here if we don't start talking about > > real use cases. Would you have some to share ? > > Fair

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Laurent, On Fri, Sep 28, 2018 at 03:49:38PM +0200, Laurent Pinchart wrote: > I don't think we'll reach an agreement here if we don't start talking about > real use cases. Would you have some to share ? Fair enough, but at that point, we very much disconnect from the imx208 in the subject.

Re: [PATCH v3] media: add imx355 camera sensor driver

Hi Bingbu, On Sat, Sep 29, 2018 at 06:03:54PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx355 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v3] media: add imx355 camera sensor driver

From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx355 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Helmut, On Friday, 21 September 2018 10:23:37 EEST Helmut Grohne wrote: > On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > >> On 09/20/2018 06:49 PM, Grant Grundler wrote: > >>> On Thu, Sep 20, 2018

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi, >-Original Message- >From: Yeh, Andy >Sent: Wednesday, September 26, 2018 11:19 PM >To: Sakari Ailus ; Chen, Ping-chung > >Hi Sakari, PC, >sensors that do need >digital gain applied, too --- assuming it'd be >combined with the TRY_EXT_CTRLS rounding flags. >> >> There might be

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

mail.com; linux-media me...@vger.kernel.org>; Yeh, Andy ; Lai, Jim >; grund...@chromium.org; Mani, Rajmohan > >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver > >Hi Ping-chung, > >On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrot

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Wed, Sep 26, 2018 at 02:27:01AM +, Chen, Ping-chung wrote: > Hi Sakari, > > >-Original Message- > >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > >Sent: Wednesday, September 26, 2018 5:55 AM > > >Hi Ping-chung, > > >On Tue, Sep 25, 2018 at 10:17:48AM

Re: [PATCH v7] media: add imx319 camera sensor driver

On 09/26/2018 03:57 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Wed, Sep 26, 2018 at 10:42:18AM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c

Re: [PATCH v7] media: add imx319 camera sensor driver

Hi Bingbu, On Wed, Sep 26, 2018 at 10:42:18AM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v7] media: add imx319 camera sensor driver

From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Wednesday, September 26, 2018 5:55 AM >Hi Ping-chung, >On Tue, Sep 25, 2018 at 10:17:48AM +, Chen, Ping-chung wrote: >... > > > > Controls that have a documented unit use that unit ---

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Tue, Sep 25, 2018 at 10:17:48AM +, Chen, Ping-chung wrote: ... > > > > Controls that have a documented unit use that unit --- as long as > > > > that's the unit used by the hardware. If it's not, it tends to be > > > > that another unit is used but the user space has

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Sakari, >-Original Message- >From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] >Sent: Tuesday, September 25, 2018 5:25 PM >To: Chen, Ping-chung >Cc: Ricardo Ribalda Delgado ; Laurent Pinchart >Subject: Re: [PATCH v5] media: imx208: Add imx208 camera senso

Re: [PATCH v6] media: add imx319 camera sensor driver

Hi Bingbu, On Tue, Sep 25, 2018 at 05:10:59PM +0800, Bing Bu Cao wrote: ... > > +/* Initialize control handlers */ > > +static int imx319_init_controls(struct imx319 *imx319) > > +{ > > + struct i2c_client *client = v4l2_get_subdevdata(>sd); > > + struct

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

...@chromium.org; Sakari Ailus > ; sylwester.nawro...@gmail.com; linux-media > ; Yeh, Andy ; Lai, Jim > ; grund...@chromium.org; Mani, Rajmohan > > Subject: RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver > > Hi Sakari, > > >-Original Message-

Re: [PATCH v6] media: add imx319 camera sensor driver

>>>> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >>>>> From: Bingbu Cao >>>>> >>>>> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >>>>> This is a camera sensor using the i2c bus for con

Re: [PATCH v6] media: add imx319 camera sensor driver

ngbu@intel.com wrote: > >>> From: Bingbu Cao > >>> > >>> Add a v4l2 sub-device driver for the Sony imx319 image sensor. > >>> This is a camera sensor using the i2c bus for control and the > >>> csi-2 bus for data. > >>> >

Re: [PATCH v6] media: add imx319 camera sensor driver

On 09/25/2018 11:57 AM, Bing Bu Cao wrote: > > On 09/21/2018 08:06 PM, Sakari Ailus wrote: >> Hi Bingbu, >> >> On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >>> From: Bingbu Cao >>> >>> Add a v4l2 sub-device driver for

Re: [PATCH v6] media: add imx319 camera sensor driver

On 09/21/2018 08:06 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c

Re: [PATCH v6] media: add imx319 camera sensor driver

/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180922-115504 base: git://linuxtv.org/media_tree.git master config: openrisc-allmodconfig (attached as .config) compiler: or1k-linux-gcc (GCC) 6.0.0 20160327 (experimental) reproduce: wget https

Re: [PATCH v6] media: add imx319 camera sensor driver

Hi Bingbu, On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v6] media: add imx319 camera sensor driver

From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

Re: [PATCH v5] media: add imx319 camera sensor driver

On 09/21/2018 03:41 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: > ... + try_fmt->field = V4L2_FIELD_NONE; + + mutex_unlock(>mutex); + + return 0; +} + +static int

Re: [PATCH v5] media: add imx319 camera sensor driver

On Fri, Sep 21, 2018 at 11:28 AM Bing Bu Cao wrote: > > > On 09/18/2018 05:49 PM, Tomasz Figa wrote: > > Hi Bingbu, > > > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > >> From: Bingbu Cao > >> > >> Add a v4l2 sub-device driver for the Sony i

Re: [PATCH v5] media: add imx319 camera sensor driver

Hi Bingbu, On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: ... > >> + try_fmt->field = V4L2_FIELD_NONE; > >> + > >> + mutex_unlock(>mutex); > >> + > >> + return 0; > >> +} > >> + > >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) > >> +{ > >> + int

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > >> We have a problem here. The sensor supports

Re: [PATCH v5] media: add imx319 camera sensor driver

ub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2 bus for data. >> >> This driver supports following features: >> - manual exposure and analog/digital gain control support >> - vblank/hblan

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

; Mani, Rajmohan Subject: RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinc

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: >

Re: [PATCH v5] media: add imx319 camera sensor driver

Ack, I will add more explanation into the code. On 09/19/2018 12:11 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > [snip] >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) >> +{ >> + int ret; >> + >> + ret =

Re: [PATCH v5] media: add imx319 camera sensor driver

On 09/18/2018 05:49 PM, Tomasz Figa wrote: > Hi Bingbu, > > On Mon, Sep 17, 2018 at 2:53 PM wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >&

Re: [PATCH v5] media: add imx319 camera sensor driver

v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c bus for control and the >> csi-2 bus for data. >> >> This driver supports following features: >> - manual exposure and analog/digital gain control support >> - vblank

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > > [snip] > > > > > > > +

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Sakari, On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: > On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > > [snip] > > > > > + > > > +/* Digital gain control */ > > > +#define IMX208_REG_GR_DIGITAL_GAIN

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hello, (CC'ing Helmut Grohne) On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: > >>> +/* Digital gain control */

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Tomasz, On Thu, Sep 20, 2018 at 05:51:55PM +0900, Tomasz Figa wrote: > [+Laurent and Sylwester] > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen > wrote: > [snip] > > + > > +/* Digital gain control */ > > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > > +#define IMX208_REG_R_DIGITAL_GAIN

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

On 09/20/2018 06:49 PM, Grant Grundler wrote: > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: >> On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen >> wrote: >>> +/* Digital gain control */ >>> +#define IMX208_DGTL_GAIN_MIN 0 >>> +#define IMX208_DGTL_GAIN_MAX 4096 >>>

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

[resend in plain text - sorry!] On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > [+Laurent and Sylwester] > > On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen > wrote: > [snip] > > + > > +/* Digital gain control */ > > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > > +#define

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

[+Laurent and Sylwester] On Wed, Aug 8, 2018 at 4:08 PM Ping-chung Chen wrote: [snip] > + > +/* Digital gain control */ > +#define IMX208_REG_GR_DIGITAL_GAIN 0x020e > +#define IMX208_REG_R_DIGITAL_GAIN 0x0210 > +#define IMX208_REG_B_DIGITAL_GAIN 0x0212 > +#define

Re: [PATCH v5] media: add imx319 camera sensor driver

Hi Bingbu, On Mon, Sep 17, 2018 at 2:53 PM wrote: [snip] > +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) > +{ > + int ret; > + > + ret = imx319_write_reg(imx319, IMX319_REG_DPGA_USE_GLOBAL_GAIN, 1, 1); > + if (ret) > + return ret; > + >

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Grant, On Mon, Sep 17, 2018 at 03:52:30PM -0700, Grant Grundler wrote: > On Fri, Sep 14, 2018 at 4:41 AM Sakari Ailus > wrote: > > > > Hi Ping-chung, > > > > My apologies for the late review. > > Yeah...I had the impression this was already accepted. Though it > should be straight forward to

Re: [PATCH v5] media: add imx319 camera sensor driver

Hi Bingbu, On Mon, Sep 17, 2018 at 2:53 PM wrote: > > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. Please see my comments inline. Also, I'd app

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

On Fri, Sep 14, 2018 at 4:41 AM Sakari Ailus wrote: > > Hi Ping-chung, > > My apologies for the late review. Yeah...I had the impression this was already accepted. Though it should be straight forward to fix up additional things as normal patches. [sorry pruning heavily] ... > > +/* HBLANK

Re: [PATCH v5] media: add imx319 camera sensor driver

Hi Bingbu, Thanks for the update! A few more small comments, I think we're done after these. On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using

Re: [PATCH v5] media: add imx319 camera sensor driver

/linux/commits/bingbu-cao-intel-com/media-add-imx319-camera-sensor-driver/20180917-135744 base: git://linuxtv.org/media_tree.git master config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make

[PATCH v5] media: add imx319 camera sensor driver

From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, My apologies for the late review. On Wed, Aug 08, 2018 at 03:16:00PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and th

[PATCH v5] media: imx208: Add imx208 camera sensor driver

From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen Reviewed-by: Tomasz Figa --- since v1: -- Update the function media_entity

Re: [RESEND PATCH v4] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Fri, Aug 03, 2018 at 11:04:57AM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > >

RE: [RESEND PATCH v4] media: imx208: Add imx208 camera sensor driver

Hi Tomasz, >On Fri, Aug 3, 2018 at 11:57 AM Ping-chung Chen >wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data.

Re: [RESEND PATCH v4] media: imx208: Add imx208 camera sensor driver

On Fri, Aug 3, 2018 at 11:57 AM Ping-chung Chen wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > > Signed-off-by:

[RESEND PATCH v4] media: imx208: Add imx208 camera sensor driver

From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- since v1: -- Update the function media_entity_pads_init for upstreaming.

[PATCH v4] media: imx208: Add imx208 camera sensor driver

From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- since v1: -- Update the function media_entity_pads_init for upstreaming.

RE: [PATCH v3] media: imx208: Add imx208 camera sensor driver

Hi Tomasz, Please see my comments. -Original Message- >Hi Ping-chung, >On Wed, Aug 1, 2018 at 11:31 AM Ping-chung Chen >wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera se

Re: [PATCH v3] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Wed, Aug 1, 2018 at 11:31 AM Ping-chung Chen wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > &

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

Hi Tomasz, Please check my comments below. >Hi Ping-chung, >On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen >wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C b

[PATCH v3] media: imx208: Add imx208 camera sensor driver

From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- since v1: -- Update the function media_entity_pads_init for upstreaming.

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

On Tue, Jul 31, 2018 at 12:54 PM Chen, Ping-chung wrote: > > Hi Tomasz, > > >-Original Message- > > +/* Get bayer order based on flip setting. */ static __u32 > > +imx208_get_format_code(struct imx208 *imx208) > > >Why not just "u32"? > > Its return value will be assigned to the variable

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

Hi Tomasz, >-Original Message- > +/* Get bayer order based on flip setting. */ static __u32 > +imx208_get_format_code(struct imx208 *imx208) >Why not just "u32"? Its return value will be assigned to the variable code which belongs to the structure v4l2_subdev_mbus_code_enum, and the

RE: [PATCH v2] media: imx208: Add imx208 camera sensor driver

@vger.kernel.org; Yeh, Andy ; Lai, Jim ; tf...@google.com; grund...@chromium.org; Mani, Rajmohan Subject: Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver Hi Ping-chung, On Mon, Jul 30, 2018 at 05:26:39PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Ad

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

On Mon, Jul 30, 2018 at 8:39 PM Sakari Ailus wrote: > > Hi Tomasz, > > On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote: > ... > > > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl) > > > +{ > > > + struct imx208 *imx208 = > > > + container_of(ctrl->handler,

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

Hi Tomasz, On Mon, Jul 30, 2018 at 07:19:56PM +0900, Tomasz Figa wrote: ... > > +static int imx208_set_ctrl(struct v4l2_ctrl *ctrl) > > +{ > > + struct imx208 *imx208 = > > + container_of(ctrl->handler, struct imx208, ctrl_handler); > > + struct i2c_client *client =

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Mon, Jul 30, 2018 at 05:26:39PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > >

Re: [PATCH v2] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Mon, Jul 30, 2018 at 6:19 PM Ping-chung Chen wrote: > > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using the I2C bus for control and the > CSI-2 bus for data. > Please

[PATCH v2] media: imx208: Add imx208 camera sensor driver

From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- since v1: -- Update the function media_entity_pads_init for upstreaming.

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, On Tue, Jul 17, 2018 at 3:53 PM Chen, Ping-chung wrote: > > Hi Sakari, > > Some of suggestions below has been added in to [PATCH v2] or [PATCH v3]. > We will fix others in PATCH v4 soon. I don't see v2 or v3 on linux-media (or my inbox). Where were they sent? I'd like to review

RE: [PATCH] media: imx208: Add imx208 camera sensor driver

@vger.kernel.org; Yeh, Andy ; tf...@chromium.org Subject: Re: [PATCH] media: imx208: Add imx208 camera sensor driver Hi Ping-chung, Thanks for the patch. Please see my comments below. On Tue, Jul 10, 2018 at 03:15:36PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" >

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

ux-media@vger.kernel.org > > Cc: sakari.ai...@linux.intel.com; Yeh, Andy ; > > tf...@chromium.org; Chen, Ping-chung > > Subject: [PATCH] media: imx208: Add imx208 camera sensor driver > > +}; > > + > > +static int imx208_enum_mbus_code(struct v4l2_su

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

Hi Ping-chung, Thanks for the patch. Please see my comments below. On Tue, Jul 10, 2018 at 03:15:36PM +0800, Ping-chung Chen wrote: > From: "Chen, Ping-chung" > > Add a V4L2 sub-device driver for the Sony IMX208 image sensor. > This is a camera sensor using t

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

/0day-ci/linux/commits/Ping-chung-Chen/media-imx208-Add-imx208-camera-sensor-driver/20180710-153546 base: git://linuxtv.org/media_tree.git master config: i386-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build tree

Re: [PATCH] media: imx208: Add imx208 camera sensor driver

/0day-ci/linux/commits/Ping-chung-Chen/media-imx208-Add-imx208-camera-sensor-driver/20180710-153546 base: git://linuxtv.org/media_tree.git master config: x86_64-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce: # save the attached .config to linux build

RE: [PATCH] media: imx208: Add imx208 camera sensor driver

> Subject: [PATCH] media: imx208: Add imx208 camera sensor driver > +}; > + > +static int imx208_enum_mbus_code(struct v4l2_subdev *sd, > + struct v4l2_subdev_pad_config *cfg, > + struct v4l2_subdev_mbus_code_enum *cod

[PATCH] media: imx208: Add imx208 camera sensor driver

From: "Chen, Ping-chung" Add a V4L2 sub-device driver for the Sony IMX208 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Ping-Chung Chen --- drivers/media/i2c/Kconfig | 11 + drivers/media/i2c/Makefile | 1 + dri

Re: [PATCH v4] media: add imx319 camera sensor driver

On 06/26/2018 11:15 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Thu, May 31, 2018 at 06:19:24PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. >> This is a camera sensor using the i2c

Re: [PATCH v4] media: add imx319 camera sensor driver

Hi Bingbu, On Thu, May 31, 2018 at 06:19:24PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driv

[PATCH v2] media: add imx355 camera sensor driver

From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx355 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Tomasz, On Fri, May 25, 2018 at 04:31:07PM +0900, Tomasz Figa wrote: > On Fri, May 25, 2018 at 4:12 PM jacopo mondi wrote: > > > Hi Tomasz, > [snip] > > > the controls set before powering on will actually be programmed into the > > > hardware registers. > > > Thanks, I

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

On Fri, May 25, 2018 at 4:12 PM jacopo mondi wrote: > Hi Tomasz, > On Fri, May 25, 2018 at 03:18:38PM +0900, Tomasz Figa wrote: > > On Fri, May 25, 2018 at 5:47 AM Sakari Ailus < sakari.ai...@linux.intel.com> > > wrote: > > > > > Hi Jacopo, > > > > > On Thu, May 24, 2018 at

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Tomasz, On Fri, May 25, 2018 at 03:18:38PM +0900, Tomasz Figa wrote: > On Fri, May 25, 2018 at 5:47 AM Sakari Ailus > wrote: > > > Hi Jacopo, > > > On Thu, May 24, 2018 at 10:07:38PM +0200, jacopo mondi wrote: > > ... > > > > > about that, but I wonder why

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

On Fri, May 25, 2018 at 5:47 AM Sakari Ailus wrote: > Hi Jacopo, > On Thu, May 24, 2018 at 10:07:38PM +0200, jacopo mondi wrote: > ... > > > > about that, but I wonder why setting controls should be enabled only > > > > when streaming. I would have expected

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Jacopo, On Thu, May 24, 2018 at 10:07:38PM +0200, jacopo mondi wrote: ... > > > about that, but I wonder why setting controls should be enabled only > > > when streaming. I would have expected runtime_pm_get/put in subdevices > > > node open/close functions not only when streaming. Am I

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Sakari, On Wed, May 23, 2018 at 10:38:33AM +0300, Sakari Ailus wrote: > Hi Jacopo and Bingbu, > > On Tue, May 22, 2018 at 10:08:48PM +0200, jacopo mondi wrote: > ... > > > +/* Get bayer order based on flip setting. */ > > > +static __u32 imx319_get_format_code(struct imx319 *imx319) > > > +{ >

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hi Jacopo and Bingbu, On Tue, May 22, 2018 at 10:08:48PM +0200, jacopo mondi wrote: ... > > +/* Get bayer order based on flip setting. */ > > +static __u32 imx319_get_format_code(struct imx319 *imx319) > > +{ > > + /* > > +* Only one bayer order is supported. > > +* It depends on the

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

On 2018年05月23日 04:08, jacopo mondi wrote: Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: From: Bingbu Cao <bingbu@intel.com> Add a V4L2 sub-device driver for the Sony IMX319 image sensor. This is a camera sensor using t

Re: [PATCH v3] media: imx319: Add imx319 camera sensor driver

Hello Bingbu, thanks for the patch On Tue, May 22, 2018 at 12:33:01PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao <bingbu@intel.com> > > Add a V4L2 sub-device driver for the Sony IMX319 image sensor. > This is a camera sensor using the I2C bus for control a

[PATCH v3] media: imx319: Add imx319 camera sensor driver

From: Bingbu Cao <bingbu@intel.com> Add a V4L2 sub-device driver for the Sony IMX319 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Bingbu Cao <bingbu@intel.com> Signed-off-by: Tianshu Qiu <tian.sh

Re: [PATCH v2] media: imx319: Add imx319 camera sensor driver

to help improve the system] url: https://github.com/0day-ci/linux/commits/bingbu-cao-intel-com/media-imx319-Add-imx319-camera-sensor-driver/20180522-020817 coccinelle warnings: (new ones prefixed by >>) >> drivers/media/i2c/imx319.c:1874:2-3: Unneeded semicolon drivers/media/

Re: [PATCH v2 2/3] media: imx258: Add imx258 camera sensor driver

Please ignore thispatch. On 2018年05月21日 15:10, bingbu@intel.com wrote: From: Jason Chen <jasonx.z.c...@intel.com> Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh

[PATCH v2] media: imx319: Add imx319 camera sensor driver

From: Bingbu Cao <bingbu@intel.com> Add a V4L2 sub-device driver for the Sony IMX319 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Bingbu Cao <bingbu@intel.com> Signed-off-by: Tianshu Qiu <tian.sh

  1   2   3   4   5   >