Re: [PATCH v5 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-25 Thread 'Sakari Ailus'
On Tue, Feb 25, 2014 at 02:09:41PM +0100, Kamil Debski wrote: > Hi Sakari, > > > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > > Sent: Saturday, February 15, 2014 9:53 PM > > > > Some devices do not produce timestamps that correspond to the end of > > the frame. The user space should be infor

RE: [PATCH v5 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-25 Thread Kamil Debski
Hi Sakari, > From: Sakari Ailus [mailto:sakari.ai...@iki.fi] > Sent: Saturday, February 15, 2014 9:53 PM > > Some devices do not produce timestamps that correspond to the end of > the frame. The user space should be informed on the matter. This patch > achieves that by adding buffer flags (and a

Re: [PATCH v5 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-17 Thread Sakari Ailus
Hi Hans, Thanks for your comments. On Mon, Feb 17, 2014 at 09:54:53AM +0100, Hans Verkuil wrote: ... > > @@ -1119,6 +1113,31 @@ in which case caches have not been used. > > The CAPTURE buffer timestamp has been taken from the > > corresponding OUTPUT buffer. This flag applies only

Re: [PATCH v5 3/7] v4l: Add timestamp source flags, mask and document them

2014-02-17 Thread Hans Verkuil
Hi Sakari, Some minor comments: On 02/15/2014 09:53 PM, Sakari Ailus wrote: > Some devices do not produce timestamps that correspond to the end of the > frame. The user space should be informed on the matter. This patch achieves > that by adding buffer flags (and a mask) for timestamp sources sin