Re: [PATCH] media: venus: fix build on 32bit environments

Hi Mauro, Thanks for the fix! On 10/7/19 4:37 PM, Mauro Carvalho Chehab wrote: > As reported by jenk...@linuxtv.org, the build with i386 fails > with: > > ld: drivers/media/platform/qcom/venus/helpers.o: in function > `venus_helper_load_scale_clocks': > (.text+0x1d77): undefined ref

Re: [PATCH v9] vivid: Add metadata capture support

On 10/4/19 12:24 PM, Vandana BN wrote: > +void vivid_meta_cap_fillbuff(struct vivid_dev *dev, > + struct vivid_buffer *buf, u32 soe) soe should have been a u64 since f_time is a u64. > +{ > + struct vivid_uvc_meta_buf *meta = vb2_plane_vaddr(&buf->vb.vb2_buf, 0); > +

Re: [PATCH v3 2/2] vivid: Add metadata output support

On 10/4/19 2:08 PM, Vandana BN wrote: > Support metadata output in vivid driver. > Metadata output is used to set brightness, contrast, saturation > and hue. > Adds new files for metadata output. > > Signed-off-by: Vandana BN > --- > drivers/media/platform/vivid/Makefile | 2 +- > driv

Re: [PATCH v2 09/10] media: i2c: ov5670: Report native size and crop bounds

deo source > > before cropping/composing/scaling takes place. > > > > So in the example of a cross-shaped sensor ENUM_FRAMESIZES would report > > two sizes (landscape/portrait), binning/cropping controls (optional, this > > might be implicit in the enumerated framesizes)

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

ot be accessible to the guest at all That said, the common desktop Linux model bases on allocating from the producer device (which is why videobuf2 has allocation capability) and we definitely need to consider this model, even if we just think about Linux V4L2 compliance. That's why I

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

y allocated buffer/resource descriptor and then are made available for processing by the device using a dedicated command from the driver. > > > Referencing virtio-gpu buffers needs a better plan than just re-using > > virtio-gpu resource handles. The handles are device-speci

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

On Mon, Oct 07, 2019 at 07:11:03PM +0800, Chen-Yu Tsai wrote: > On Mon, Oct 7, 2019 at 7:09 PM Maxime Ripard wrote: > > > > Hi, > > > > On Fri, Oct 04, 2019 at 02:33:41PM +0800, Chen-Yu Tsai wrote: > > > On Fri, Oct 4, 2019 at 12:37 AM Maxime Ripard wrote: > > > > On Thu, Oct 03, 2019 at 11:51:05

Re: [ANN] Media sessions in Lyon in October: codecs

HI Tomasz On Mon, Oct 7, 2019 at 11:43 AM Tomasz Figa wrote: > > Hi Ricardo, > > On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado > wrote: > > > > HI Nicolas > > > > Sorry to hijack the thread. Do you know if anyone at AMD is working on > > making a v4l driver for the encoder? Or they want

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

On Mon, Oct 7, 2019 at 7:09 PM Maxime Ripard wrote: > > Hi, > > On Fri, Oct 04, 2019 at 02:33:41PM +0800, Chen-Yu Tsai wrote: > > On Fri, Oct 4, 2019 at 12:37 AM Maxime Ripard wrote: > > > On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > > > > On Thu, Oct 3, 2019 at 11:48 PM Maxime

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

Hi, On Fri, Oct 04, 2019 at 02:33:41PM +0800, Chen-Yu Tsai wrote: > On Fri, Oct 4, 2019 at 12:37 AM Maxime Ripard wrote: > > On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > > > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > > > > > It turns out that what was thought

Re: [ANN] Media sessions in Lyon in October: codecs

Hi Ricardo, On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado wrote: > > HI Nicolas > > Sorry to hijack the thread. Do you know if anyone at AMD is working on > making a v4l driver for the encoder? Or they want to continue with > their mesa approach? > > Converting a mesa-vappi to v4l is som

Re: [ANN] Media sessions in Lyon in October: codecs

HI Nicolas Sorry to hijack the thread. Do you know if anyone at AMD is working on making a v4l driver for the encoder? Or they want to continue with their mesa approach? Converting a mesa-vappi to v4l is something doable by the mortals? Just changing the API or is a complete rewrite of the code?

Re: [GIT FIXES FOR v5.4] Regression fix for meson CEC drivers

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59240/ Build log: https://builder.linuxtv.org/job/patchwork/19353/ Build time: 00:02:30 Link: https://lore.kernel.org/linux-media/19c02424-d128-2f56-8e4e-04f11e9e3...@xs4all.nl gpg: Signature made Mon 07 Oct 2019 07:41:5

Re: [ANN] Media sessions in Lyon in October: codecs

On Mon, Oct 7, 2019 at 9:03 AM Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > > >

Re: [ANN] Media sessions in Lyon in October: codecs

Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > Hi all, > > > > Since we have three separate half-day sessions for different topics I > > decided > > to split the announcement for this in three emails as well, so these th

Re: [PATCH v3] media: cxd2841er: avoid too many status inquires

Em Sat, 5 Oct 2019 10:02:05 +0200 Daniel Scheller escreveu: > Am Fri, 4 Oct 2019 11:02:28 -0300 > schrieb Mauro Carvalho Chehab : > > > As reported at: > > https://tvheadend.org/issues/5625 > > > > Retrieving certain status can cause discontinuity issues. > > > > Prevent that by adding a

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

> > > > > would need to have a conditional block that selects default or > > > > > per-slice value based on the flag. The goal was to be able for the > > > > > driver to just passively write num_ref_idx_l[01]_active_minus1 (or the > > > >

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

> > IMHO it would only add further logic to the drivers, because they > > > > would need to have a conditional block that selects default or > > > > per-slice value based on the flag. The goal was to be able for the > > > > driver to just passively write num_ref_

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

st passively write num_ref_idx_l[01]_active_minus1 (or the > > > default one for slice-parsing hardware) to corresponding hardware > > > registers. > > > > Well, the Allwinner block has both set of fields and a field for the flag, > > so in this case I find that it

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

e flag. The goal was to be able for the > > driver to just passively write num_ref_idx_l[01]_active_minus1 (or the > > default one for slice-parsing hardware) to corresponding hardware > > registers. > > Well, the Allwinner block has both set of fields and a field for the flag

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

lock has both set of fields and a field for the flag, so in this case I find that it is cleaner to just copy the values and flag rather than always setting the flag even when it's the default value used. More generally, the two sets + flag are closer to bitstream which feels less confusin

Re: [ANN] Media sessions in Lyon in October: codecs

On Fri, Sep 27, 2019 at 12:28 AM Nicolas Dufresne wrote: > > Le jeudi 26 septembre 2019 à 19:21 +0900, Tomasz Figa a écrit : > > On Mon, Sep 23, 2019 at 11:13 PM Hans Verkuil wrote: > > > Hi all, > > > > > > Since we have three separate half-day sessions for different topics I > > > decided > >

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

On Fri, Oct 4, 2019 at 6:12 AM Paul Kocialkowski wrote: > > Hi, > > On Thu 05 Sep 19, 13:42, Philipp Zabel wrote: > > To explain why num_ref_idx_active_override_flag is not part of the API, > > describe how the num_ref_idx_l[01]_active_minus1 fields and the > > num_ref_idx_l[01]_default_active_min

Re: [PATCH v3] media: cxd2841er: avoid too many status inquires

Am Fri, 4 Oct 2019 11:02:28 -0300 schrieb Mauro Carvalho Chehab : > As reported at: > https://tvheadend.org/issues/5625 > > Retrieving certain status can cause discontinuity issues. > > Prevent that by adding a timeout to each status logic. > > Currently, the timeout is estimated based a

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

userspace can access decoded frame from those pages; back to 3 Is that something you have in mind? > > Referencing virtio-gpu buffers needs a better plan than just re-using > virtio-gpu resource handles. The handles are device-specific. What if > there are multiple virtio-gpu devic

[linux-review:UPDATE-20191005-052600/Mauro-Carvalho-Chehab/Re-PATCH-si2157-Add-support-for-Logilink-VG0022A/20191003-040233 1/1] drivers/media//usb/dvb-usb-v2/af9035.c:1273:16: error: 'struct si2168_c

tree: https://github.com/0day-ci/linux/commits/UPDATE-20191005-052600/Mauro-Carvalho-Chehab/Re-PATCH-si2157-Add-support-for-Logilink-VG0022A/20191003-040233 head: 78db06b57e0c9d156d5487ffcab15aaee479ffb4 commit: 78db06b57e0c9d156d5487ffcab15aaee479ffb4 [1/1] media: af9035: add support for

Re: [PATCH] si2157: Add support for Logilink VG0022A.

Em Fri, 4 Oct 2019 13:50:43 +0200 JP escreveu: > On 10/3/19 10:03 PM, Mauro Carvalho Chehab wrote: > > Em Thu, 3 Oct 2019 21:51:35 +0200 > > Gonsolo escreveu: > > > >>> 1) The firmware file is likely at the Windows driver for this device > >>> (probably using a different format). It should be

Re: [PATCH] Documentation:media:v4l2:Add vivid metadata doc

On 10/4/19 1:55 PM, Vandana BN wrote: > Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in > vivid driver. > > Signed-off-by: Vandana BN > --- > Documentation/media/uapi/v4l/meta-formats.rst | 1 + > .../media/uapi/v4l/pixfmt-meta-vivid.rst | 43

Re: [PATCH v4] venus: venc: Fix enum frameintervals

Em Thu, 3 Oct 2019 13:10:38 +0300 Stanimir Varbanov escreveu: > This fixes an issue when setting the encoder framerate because of > missing precision. Now the frameinterval type is changed to > TYPE_CONTINUOUS and step = 1. Also the math is changed when > framerate property is called - the firmw

Re: [PATCH v8] vivid: Add metadata capture support

On 10/4/19 11:44 AM, Vandana BN wrote: > This patch adds meatadata capture support in vivid driver. > Adds new files for metadata capture. > Adds vivid controls to generate PTS and SCR for metadata stream. > > Signed-off-by: Vandana BN > --- > V8 - squash commit:fixes for v4l2-compliance issues.

Re: [Linux-kernel-mentees] [PATCH v2 2/2] vivid: Add metadata output support

On 10/3/19 7:38 PM, Shuah Khan wrote: > On 10/3/19 5:08 AM, Vandana BN wrote: >> Support metadata output in vivid driver. >> Metadata output is used to set brightness, contrast, saturation >> and hue. >> Adds new files for metadata output. >> >> Signed-off-by: Vandana BN >> --- >> drivers/media/

Re: The potential uninitialized variables used in function isc_interrupt()

On 04.10.2019 06:07, Yizhuo Zhai wrote: > Hi Eugen: > > In function isc_interrupt(), variable "isc_intsr" and "isc_intmask" > (drivers/media/platform/atmel/atmel-isc-base.c) > could be uninitialized if regmap_read() fails and return -EINVAL . > However, they are used to decide the control flow l

Re: [GIT PULL for v5.5] Venus updates, take 3

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59184/ Build log: https://builder.linuxtv.org/job/patchwork/18922/ Build time: 00:03:40 Link: https://lore.kernel.org/linux-media/20191004075617.17328-1-stanimir.varba...@linaro.org gpg: Signature made Fri 04 Oct 2019 07

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

On Fri, Oct 4, 2019 at 12:37 AM Maxime Ripard wrote: > > Hi, > > On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > > > It turns out that what was thought to be the module clock was actually the > > > clock meant to be us

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

Hi, On Thu 05 Sep 19, 13:42, Philipp Zabel wrote: > To explain why num_ref_idx_active_override_flag is not part of the API, > describe how the num_ref_idx_l[01]_active_minus1 fields and the > num_ref_idx_l[01]_default_active_minus1 fields are used, depending on > whether the decoder parses slice h

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

Hi, On Thu 05 Sep 19, 12:15, Philipp Zabel wrote: > This flag tells the kernel whether the slice header contained the > num_ref_idx_l[01]_active_minus1 syntax elements, or whether the > num_ref_idx_l[01]_default_active_minus1 from PPS should be used > instead. Looks good to me: Reviewed-by: Paul

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

Hi, On Mon 09 Sep 19, 18:40, Tomasz Figa wrote: > On Mon, Sep 9, 2019 at 4:30 PM Philipp Zabel wrote: > > > > On Mon, 2019-09-09 at 16:09 +0900, Tomasz Figa wrote: > > > On Thu, Sep 5, 2019 at 11:17 PM Nicolas Dufresne > > > wrote: > > > > > > > > Le jeudi 05 septembre 2019 à 12:39 +0200, Philip

Re: [Linux-kernel-mentees] [PATCH v2 2/2] vivid: Add metadata output support

On 10/3/19 5:08 AM, Vandana BN wrote: Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/plat

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

Hi, On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > It turns out that what was thought to be the module clock was actually the > > clock meant to be used by the sensor, and isn't playing any role with the > > CSI control

Re: [Linux-kernel-mentees] [PATCH v2 1/2] v4l2-core: Add new metadata format

On 10/3/19 5:08 AM, Vandana BN wrote: Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

Hi, On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > It turns out that what was thought to be the module clock was actually the > clock meant to be used by the sensor, and isn't playing any role with the > CSI controller itself. Let's drop that clock from our binding. > > Fixes: c5e8f4ccd

Re: [PATCH v2 5/5] media: vimc: remove the helper function vimc_ent_sd_unregister

On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > since this function only calls v4l2_device_unregister_subdev, > it is pointless. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike > --- > drivers/media/platform/vimc/vimc-common.c | 5 - > drivers/media/platform/vimc/vimc-common.

Re: [PATCH v2 3/5] media: vimc: sensor: register subdevice only after initialization

Hi Dafna, Could you just rename the title tags to "media: vimc: sen: " to follow the model of the other commits? Thanks Helen On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > vimc_sen_add function first registers the subdevice and then > calls tpg_alloc. If tpg_alloc fails it unregisters the subdev

Re: [PATCH v2 2/5] media: vimc: cleanup code that assigns entity in entities array

On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > Since the add callback returns NULL on failure and the array > is initialized to NULLs, there is no need for the intermediate > assignment to local var. > > Signed-off-by: Dafna Hirschfeld I would just rename the title to something like: "media: v

Re: [PATCH v2 1/5] media: vimc: initialize vim entity pointers to NULL

On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > since NULL value for vimc entity pointer indicates > that entity creation failed and this is tested, the > pointers should be initialized to NULL. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike > --- > drivers/media/platform/vimc/vim

Re: [PATCH v2 2/2] vivid: Add metadata output support

On 10/3/19 1:08 PM, Vandana BN wrote: > Support metadata output in vivid driver. > Metadata output is used to set brightness, contrast, saturation > and hue. > Adds new files for metadata output. > > Signed-off-by: Vandana BN > --- > drivers/media/platform/vivid/Makefile | 2 +- > driv

Re: [PATCH v2 1/2] v4l2-core: Add new metadata format

On 10/3/19 1:08 PM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/

Re: [PATCH v7 2/2] vivid: fixes for v4l2-compliance issues.

On 9/25/19 10:27 AM, Vandana BN wrote: > From: Hans Verkuil > > This patch fixes v4l2-compliance issues seen on metadata device. > > Signed-off-by: Hans Verkuil Can you squash this patch into the previous one? It's really all fixes for the previous patch, and it is better to apply one good pat

Re: [PATCH v7 1/2] vivid: Add metadata capture support

On 9/25/19 10:27 AM, Vandana BN wrote: > This patch adds meatadata capture support in vivid driver. > Adds new files for metadata capture. > Adds vivid controls to generate PTS and SCR for metadata stream. > > Signed-off-by: Vandana BN > --- > drivers/media/platform/vivid/Makefile | 2

Re: [GIT PULL FOR v5.5] [v2] Two cec fixes

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59163/ Build log: https://builder.linuxtv.org/job/patchwork/18800/ Build time: 00:02:49 Link: https://lore.kernel.org/linux-media/e19af1d9-8a06-cedf-4982-29a72d1d1...@xs4all.nl gpg: Signature made Thu 03 Oct 2019 11:37:3

Re: [GIT PULL FOR v5.5] Two cec fixes

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59161/ Build log: https://builder.linuxtv.org/job/patchwork/18798/ Build time: 00:03:26 Link: https://lore.kernel.org/linux-media/df1e93e3-25d9-6ff3-4ad2-2293c2fee...@xs4all.nl gpg: Signature made Thu 03 Oct 2019 11:08:5

Re: [PATCH v4] venus: venc: Fix enum frameintervals

I have tested this on db410c with following gst pipeline: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12,width=1280,height=960,framerate=24/1 ! v4l2h264enc extra-controls="controls,h264_profile=4,h264_level="5",video_bitrate=1000;" ! filesink location=gstenc.h264 Loic, could you giv

Re: venus: venc: Fix enum frameintervals - was: [GIT PULL for v5.5] Venus updates, take 2

Hi Mauro, On 10/2/19 5:09 PM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2019 14:29:53 +0300 > Stanimir Varbanov escreveu: > >> Hi Mauro, >> >> The Venus driver updates include: >> >> * three fixes: fail to suspend, enum frameinterval issue with encoder >> and frequency table modifications fo

Re: [PATCH 1/2] v4l2-core: Add new metadata format

On 10/3/19 9:18 AM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/

Re: [PATCH 1/2] v4l2-core: Add new metadata format

On 10/3/19 9:18 AM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/

Re: [PATCH] v4l2-ctl: support for metadata output

Hi Vandana, Since the videodev2.h header is copied from the header I can't apply this yet until support for V4L2_META_FMT_VIVID is merged into the kernel. I also have a few other comments, see below: On 10/3/19 9:06 AM, Vandana BN wrote: > Adds support to test metadata output format V4L2_META_FM

Re: [PATCH v5 2/2] Add test for new features in cec-follower

On 10/3/19 5:18 AM, Jiunn Chang wrote: > Analog tuner control test tuner_ctl_test(): > - give analog tuner status > - select tuner analog service > - analog tuner step features > > Signed-off-by: Jiunn Chang > --- > utils/cec-compliance/cec-test.cpp | 74 +++ >

Re: [GIT PULL FOR v5.5] DVB & RC (I)

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59133/ Build log: https://builder.linuxtv.org/job/patchwork/18716/ Build time: 00:07:49 Link: https://lore.kernel.org/linux-media/20191002213433.ga12...@gofer.mess.org gpg: Signature made Wed 02 Oct 2019 09:26:41 PM UTC g

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Wed, Oct 2, 2019 at 10:58 AM Alan Stern wrote: > > On Wed, 2 Oct 2019, Tim Harvey wrote: > > > On Tue, Oct 1, 2019 at 12:19 PM Alan Stern > > wrote: > > > > > > On Tue, 1 Oct 2019, Tim Harvey wrote: > > > > > > > On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey > > > > wrote: > > > > > > > > > >

Re: [PATCH v2] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

Laurent, > Would it make sense to split the calculation from v4l2_fill_pixfmt() to > a helper function that the UVC driver could call ? It would of course be possible, and would benefit v4l2-common.c as it would be common between v4l2_fill_pixfmt() and v4l2_fill_pixfmt_mp(), but as I noted before

Re: [PATCH] dt-bindings: media: rc: Fix redundant string

On Wed, 2 Oct 2019 16:44:00 +0200, Maxime Ripard wrote: > The linux,rc-map-name property is described using an enum, yet a value has > been put in that enum twice, resulting in a warning. Let's fix that. > > Fixes: 7c31b9d67342 ("media: dt-bindings: media: Add YAML schemas for the > generic RC b

Re: [PATCH v2] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

Hi Sergey, On Wed, Oct 02, 2019 at 09:15:45PM +0400, Sergey Zakharchenko wrote: > Sergey Zakharchenko : > > Laurent Pinchart : > > > Do you think it would make sense to do this by default, without > > > requiring a quirk ? Or are there cases where this calculation would lead > > > to incorrect res

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Wed, 2 Oct 2019, Tim Harvey wrote: > On Tue, Oct 1, 2019 at 12:19 PM Alan Stern wrote: > > > > On Tue, 1 Oct 2019, Tim Harvey wrote: > > > > > On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote: > > > > > > > > Greetings, > > > > > > > > I'm running into an issue with a USB UVC Full speed camer

Re: [PATCH v2] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

Sergey Zakharchenko : > Laurent Pinchart : > > Do you think it would make sense to do this by default, without > > requiring a quirk ? Or are there cases where this calculation would lead > > to incorrect results while the bpp reported by the camera would be right > > ? > > The loop is a simplified

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Tue, Oct 1, 2019 at 12:19 PM Alan Stern wrote: > > On Tue, 1 Oct 2019, Tim Harvey wrote: > > > On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote: > > > > > > Greetings, > > > > > > I'm running into an issue with a USB UVC Full speed camera, the > > > PureThermal2 [1] on an IMX6 based ARM board.

Re: [PATCH v2] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

Hi Laurent, Laurent Pinchart : > Do you think it would make sense to do this by default, without > requiring a quirk ? Or are there cases where this calculation would lead > to incorrect results while the bpp reported by the camera would be right > ? I don't nearly have the experience with a broa

Re: [PATCH 7/7] dt-bindings: smia: Remove documentation of nokia,nvm-size

On Tue, 24 Sep 2019 14:23:38 +0300, Sakari Ailus wrote: > The nokia,nvm-size property was used to tell the size of the NVM memory > accessible through the sensor's register interface. However, while the > size isn't directly readable through the sensor's register interface, it > can be detected rea

Re: [GIT PULL for v5.5] Venus updates, take 2

Hi Mauro, On 10/2/19 5:01 PM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2019 14:29:53 +0300 > Stanimir Varbanov escreveu: > >> Hi Mauro, >> >> The Venus driver updates include: >> >> * three fixes: fail to suspend, enum frameinterval issue with encoder >> and frequency table modifications fo

Re: venus: venc: Fix enum frameintervals - was: [GIT PULL for v5.5] Venus updates, take 2

Em Wed, 2 Oct 2019 14:29:53 +0300 Stanimir Varbanov escreveu: > Hi Mauro, > > The Venus driver updates include: > > * three fixes: fail to suspend, enum frameinterval issue with encoder > and frequency table modifications for v3 to handle performance issues. > * two new features: interconnect

Re: [PATCH v2] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

Hi Sergey, Thank you for the patch. On Wed, Oct 02, 2019 at 01:01:02PM +, Sergey Zakharchenko wrote: > This device does not function correctly in raw mode in kernel > versions validating buffer sizes in bulk mode. It erroneously > announces 16 bits per pixel instead of 12 for NV12 format, so

Re: [GIT PULL for v5.5] Venus updates, take 2

Em Wed, 2 Oct 2019 14:29:53 +0300 Stanimir Varbanov escreveu: > Hi Mauro, > > The Venus driver updates include: > > * three fixes: fail to suspend, enum frameinterval issue with encoder > and frequency table modifications for v3 to handle performance issues. > * two new features: interconnect

Re: [PATCHv2 2/2] v4l2-ioctl.c: use new v4l2_fourcc_conv/args macros

On Mon, 2019-09-16 at 12:04 +0200, Hans Verkuil wrote: > Use these new standard macros to log the fourcc value in a > human readable format. > > Signed-off-by: Hans Verkuil > Acked-by: Sakari Ailus > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 58 +--- > 1 file changed,

Re: [PATCHv2 1/2] v4l: Add macros for printing V4L fourcc values

On Mon, 2019-09-16 at 12:04 +0200, Hans Verkuil wrote: > From: Sakari Ailus > > Add two macros that facilitate printing V4L fourcc values with printf > family of functions. v4l2_fourcc_conv provides the printf conversion > specifier for printing formats and v4l2_fourcc_args provides the actual >

Re: [PATCH] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

Hi Sergey, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [cannot apply to v5.4-rc1 next-20191002] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' opti

Re: [GIT PULL for v5.5] Venus updates, take 2

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59114/ Build log: https://builder.linuxtv.org/job/patchwork/18656/ Build time: 00:02:36 Link: https://lore.kernel.org/linux-media/20191002112953.16642-1-stanimir.varba...@linaro.org gpg: Signature made Wed 02 Oct 2019 11

Re: [ANN] v4l-utils: remove utils/cec-follower/cec-log.h after a 'git pull'

On 10/2/19 10:52 AM, Hans Verkuil wrote: > Just a heads up: I synced v4l-utils with the latest media_tree master branch, > and that required some reorganization for the CEC utilities. > > If you do a 'git pull' in an existing v4l-utils repo, then it will fail to > build due to an orphaned utils/ce

Re: [RFC,V2,07/11] media: platform: Add Mediatek ISP P1 private control

On Wed, Oct 02, 2019 at 01:55:59PM +0300, Sakari Ailus wrote: > Hi Jungo, Hans, > > On Mon, May 13, 2019 at 10:46:46AM +0200, Hans Verkuil wrote: > > On 5/10/19 3:58 AM, Jungo Lin wrote: > ... > > > +struct v4l2_ctrl_config mtk_cam_controls[] = { > > > + { > > > + .ops = &mtk_cam_dev_ctrl_ops, > >

Re: Build failed in Jenkins: v4l-utils #43

On 10/2/19 12:41 PM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2019 11:49:20 +0200 > Hans Verkuil escreveu: > >> On 10/2/19 11:36 AM, Mauro Carvalho Chehab wrote: >>> Em Wed, 2 Oct 2019 10:25:02 +0200 >>> Hans Verkuil escreveu: >>> Hi Mauro, On 10/2/19 10:16 AM, Jenkins Buil

Re: [RFC,V2,07/11] media: platform: Add Mediatek ISP P1 private control

Hi Jungo, Hans, On Mon, May 13, 2019 at 10:46:46AM +0200, Hans Verkuil wrote: > On 5/10/19 3:58 AM, Jungo Lin wrote: ... > > +struct v4l2_ctrl_config mtk_cam_controls[] = { > > + { > > + .ops = &mtk_cam_dev_ctrl_ops, > > + .id = V4L2_CID_PRIVATE_GET_BIN_INFO, > > Don't use "PRIVATE" in the

Re: Build failed in Jenkins: v4l-utils #43

Em Wed, 2 Oct 2019 11:49:20 +0200 Hans Verkuil escreveu: > On 10/2/19 11:36 AM, Mauro Carvalho Chehab wrote: > > Em Wed, 2 Oct 2019 10:25:02 +0200 > > Hans Verkuil escreveu: > > > >> Hi Mauro, > >> > >> On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: > >>> See > >>>

Re: [GIT PULL for v5.5] Venus updates

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59112/ Build log: https://builder.linuxtv.org/job/patchwork/18645/ Build time: 00:06:36 Link: https://lore.kernel.org/linux-media/20191002094743.28589-1-stanimir.varba...@linaro.org gpg: Signature made Wed 02 Oct 2019 08

Re: Build failed in Jenkins: v4l-utils #43

On 10/2/19 11:36 AM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2019 10:25:02 +0200 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: >>> See >>> >>> >>> Changes: >>> >>>

Re: Build failed in Jenkins: v4l-utils #43

Em Wed, 2 Oct 2019 10:25:02 +0200 Hans Verkuil escreveu: > Hi Mauro, > > On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: > > See > > > > > > Changes: > > > > [hverkuil-cisco] keytable: add new generated keymaps > >

Re: [RFC PATCH V3 1/5] dt-bindings: mt8183: Added DIP dt-bindings

Hi Frederic, On Tue, Sep 10, 2019 at 03:22:40AM +0800, frederic.c...@mediatek.com wrote: > From: Frederic Chen > > This patch adds DT binding documentation for the Digital Image > Processing (DIP) unit of camera ISP system on Mediatek's SoCs. > > It depends on the SCP and MDP 3 patch as followi

Re: [RFC PATCH V3 5/5] media: platform: mtk-mdp3: Add struct tuning_addr and img_sw_buffer

On Tue, Sep 10, 2019 at 03:22:44AM +0800, frederic.c...@mediatek.com wrote: > From: Frederic Chen > > We added a struct tuning_addr which contains a field "present" > so that the driver can tell the firmware if we have user tuning > dataor not. > > The strcut img_sw_buffer is also added. This st

Re: [RFC PATCH V3 3/5] media: platform: Add Mediatek DIP driver KConfig

Hi Frederic, On Tue, Sep 10, 2019 at 03:22:42AM +0800, frederic.c...@mediatek.com wrote: > From: Frederic Chen > > This patch adds KConfig for Mediatek Digital Image Processing > driver(DIP). DIP is embedded in Mediatek SoCs. It provides > image format conversion, resizing, and rotation function

Re: Build failed in Jenkins: v4l-utils #43

Hi Mauro, On 10/2/19 10:16 AM, Jenkins Builder Robot wrote: > See > > > Changes: > > [hverkuil-cisco] keytable: add new generated keymaps > > [hverkuil-cisco] msg2ctl.pl: add newline after log_msg > > [hverkuil-cisco

Re: [PATCH v10 03/14] media: v4l2-fwnode: add initial connector parsing support

Hi Sakari, On 19-10-02 10:03, Sakari Ailus wrote: > Hi Marco, > > On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote: > > The patch adds the initial connector parsing code, so we can move from a > > driver specific parsing code to a generic one. Currently only the > > generic fields and

Re: [PATCH v10 03/14] media: v4l2-fwnode: add initial connector parsing support

Hi Marco, On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote: > The patch adds the initial connector parsing code, so we can move from a > driver specific parsing code to a generic one. Currently only the > generic fields and the analog-connector specific fields are parsed. Parsing > the

Re: [PATCHv3 11/12] media: docs-rst: Document m2m stateless video decoder interface

e OUTPUT queue format is > the padded one. Works for top/left crop, which is likely what we will > be using most of the time. > > For sure, to support all possibilities, we'd need the compose API, the > SPS has top/left/right/bottom offset (in pixels) for cropping the > image.

Re: [GIT PULL FOR v5.5] am437x-vpfe: overdue maintenance

Em Fri, 27 Sep 2019 16:27:00 +0200 Hans Verkuil escreveu: > Various fixes for am437x-vpfe. > > One special note: the last three patches adds new macros to be able to > print a V4L2 fourcc in a standard way, both for kernel and userspace, > and uses them in v4l2-ioctl.c and am437x. > > If you ha

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Tue, Oct 01, 2019 at 11:58:26AM -0700, Tim Harvey wrote: > CONFIDENTIALITY NOTICE: This email constitutes an electronic > communication within the meaning of the Electronic Communications Privacy > Act, 18 U.S.C. 2510, and its disclosure is strictly limited to the named > recipient(s) intende

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Tue, 1 Oct 2019, Tim Harvey wrote: > On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote: > > > > Greetings, > > > > I'm running into an issue with a USB UVC Full speed camera, the > > PureThermal2 [1] on an IMX6 based ARM board. > > > > What I find is that I get two video devices registered (the

Re: PureThermal2 UVC video camera: Failed to submit URB 0 (-28)

On Thu, Sep 26, 2019 at 3:47 PM Tim Harvey wrote: > > Greetings, > > I'm running into an issue with a USB UVC Full speed camera, the > PureThermal2 [1] on an IMX6 based ARM board. > > What I find is that I get two video devices registered (the first one > is the expected device, and I'm not clear

Re: [PATCH] media: vimc: embed the pads of entities in the entities' structs

Hi Dafna, Thanks for your patch, just some comments below. On 10/1/19 2:07 PM, Dafna Hirschfeld wrote: > since the pads array is of known small size, there is no reason to > allocate it separately. Instead, it is embedded in the entity struct. > This also conforms to the media controller doc: > '

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

W dniu 01.10.2019 o 19:35, Helen Koike pisze: I believe just the kcalloc bellow should fix the issue. But if you want to do this cleanup anyway, I would suggest sending a separate patch for it. @@ -199,7 +197,7 @@ static int vimc_register_devices(struct vimc_device *vimc)   }     

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

On 10/1/19 2:25 PM, Andrzej Pietrasiewicz wrote: > Hi Dafna, hi Helen, > > W dniu 01.10.2019 o 19:19, Helen Koike pisze: >> Hi Dafna, >> >> On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: >>> since NULL value for vimc entity pointer indicates >>> that entity creation failed and this is tested, the

Re: [PATCH 3/3] media: vimc: move media_entity_cleanup to release callbacks

Hi Dafna, Thanks for your patch On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: > according to the docs, this function must be called during > the cleanup phase after unregistering the entity. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike I just have one note below. > --- > drivers

Re: [PATCH 1/3] media: vimc: initialize vim entity pointers to NULL

Hi Dafna, hi Helen, W dniu 01.10.2019 o 19:19, Helen Koike pisze: Hi Dafna, On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: since NULL value for vimc entity pointer indicates that entity creation failed and this is tested, the pointers should be initialized to NULL. Nice catch :) Signed-off-b

Re: [PATCH 2/3] media: vimc: sensor: register subdevice only after initialization

On 10/1/19 1:50 PM, Dafna Hirschfeld wrote: > vimc_sen_add function first registers the subdevice and then > calls tpg_alloc. If tpg_alloc fails it unregisters the subdevice > and then frees vsen, this cause double free since the release > callback that follows subdevice unregistration also free

<    1   2   3   4   5   6   7   8   9   10   >