Re: [PATCH v2 1/2] media: ov9650: support device tree probing

2018-01-12 23:14 GMT+09:00 Sylwester Nawrocki : > On 01/07/2018 05:54 PM, Akinobu Mita wrote: >> The ov9650 driver currently only supports legacy platform data probe. >> This change adds device tree probing. > >> Signed-off-by: Akinobu Mita >> --- >

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

On 01/07/2018 05:54 PM, Akinobu Mita wrote: > The ov9650 driver currently only supports legacy platform data probe. > This change adds device tree probing. > Signed-off-by: Akinobu Mita > --- > drivers/media/i2c/ov9650.c | 130 >

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

Hi Sakari, On Mon, Jan 08, 2018 at 11:37:12AM +0200, Sakari Ailus wrote: > Hi Jacopo, > > On Mon, Jan 08, 2018 at 10:18:38AM +0100, jacopo mondi wrote: > > > @@ -1561,9 +1605,19 @@ static const struct i2c_device_id ov965x_id[] = { > > > }; > > > MODULE_DEVICE_TABLE(i2c, ov965x_id); > > > > > >

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

Hi Jacopo, On Mon, Jan 08, 2018 at 10:18:38AM +0100, jacopo mondi wrote: > > @@ -1561,9 +1605,19 @@ static const struct i2c_device_id ov965x_id[] = { > > }; > > MODULE_DEVICE_TABLE(i2c, ov965x_id); > > > > +#if IS_ENABLED(CONFIG_OF) > > +static const struct of_device_id ov965x_of_match[] = { >

Re: [PATCH v2 1/2] media: ov9650: support device tree probing

Hi Akinobu, just one small comments below On Mon, Jan 08, 2018 at 01:54:23AM +0900, Akinobu Mita wrote: > The ov9650 driver currently only supports legacy platform data probe. > This change adds device tree probing. > > There has been an attempt to add device tree support for ov9650 driver >