Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-20 Thread William Towle
On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Mon, 19 Jan 2015, William Towle wrote: in the patchset Ben linked to above we think we have the appropriate loops: a for loop for queue_buf[], and list_for_each_safe() for anything left in priv-capture; this is consistent with

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread William Towle
On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: Well, I thought that too. Will's submission from last week has that change: http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/87009 Anyway, yes, that looks better! But I would

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Guennadi Liakhovetski
Hi, On Mon, 19 Jan 2015, William Towle wrote: On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: Well, I thought that too. Will's submission from last week has that change:

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Hans Verkuil
On 01/19/2015 03:11 PM, William Towle wrote: On Mon, 19 Jan 2015, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: Well, I thought that too. Will's submission from last week has that change:

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Guennadi Liakhovetski
On Mon, 19 Jan 2015, Ben Hutchings wrote: On Sun, 2015-01-18 at 22:23 +0100, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-19 Thread Ben Hutchings
On Sun, 2015-01-18 at 22:23 +0100, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2015-01-18 Thread Guennadi Liakhovetski
On Thu, 18 Dec 2014, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b) tracking of active-state buffers via priv-queue_buf[] is handled as

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

2014-12-18 Thread Sergei Shtylyov
Hello. On 12/18/2014 05:50 PM, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b) tracking of active-state buffers via priv-queue_buf[] is