Re: tda8290 regression fix

2012-12-04 Thread Anders Thomson
On 2012-11-15 21:43, Anders Thomson wrote: On 2012-10-01 18:56, Anders Thomson wrote: > On 2012-09-23 23:06, Anders Thomson wrote: > > Awfully sorry about this. After having had the familty sit in and check > > the differences, > > I must say that the patch does not fix the issue. This

Re: tda8290 regression fix

2012-11-15 Thread Anders Thomson
On 2012-10-01 18:56, Anders Thomson wrote: On 2012-09-23 23:06, Anders Thomson wrote: > Awfully sorry about this. After having had the familty sit in and check > the differences, > I must say that the patch does not fix the issue. This time around I > have x11grabs with > ffmpeg to show if y

Re: tda8290 regression fix

2012-10-01 Thread Anders Thomson
On 2012-09-23 23:06, Anders Thomson wrote: Awfully sorry about this. After having had the familty sit in and check the differences, I must say that the patch does not fix the issue. This time around I have x11grabs with ffmpeg to show if you want. I'll be away from the card until the end of the

Re: tda8290 regression fix

2012-09-23 Thread Anders Thomson
On 2012-09-23 20:39, Anders Thomson wrote: On 2012-09-23 19:54, Anders Thomson wrote: > > diff --git a/drivers/media/pci/saa7134/saa7134-cards.c b/drivers/media/pci/saa7134/saa7134-cards.c > > index bc08f1d..98b482e 100644 > > --- a/drivers/media/pci/saa7134/saa7134-cards.c > > +++ b

Re: tda8290 regression fix

2012-09-23 Thread Anders Thomson
On 2012-09-23 19:54, Anders Thomson wrote: > diff --git a/drivers/media/pci/saa7134/saa7134-cards.c b/drivers/media/pci/saa7134/saa7134-cards.c > index bc08f1d..98b482e 100644 > --- a/drivers/media/pci/saa7134/saa7134-cards.c > +++ b/drivers/media/pci/saa7134/saa7134-cards.c > @@ -3288,13 +

Re: tda8290 regression fix

2012-09-23 Thread Mauro Carvalho Chehab
Em 23-09-2012 14:54, Anders Thomson escreveu: > On 2012-09-23 13:36, Mauro Carvalho Chehab wrote: >> Em 22-09-2012 11:32, Anders Eriksson escreveu: >> I suspect that, in the case of your board, the LNA is at the antenna bundled >> together with the device. If I'm right, by enabling LNA, your board

Re: tda8290 regression fix

2012-09-23 Thread Anders Thomson
On 2012-09-23 13:36, Mauro Carvalho Chehab wrote: Em 22-09-2012 11:32, Anders Eriksson escreveu: > Not to my knowledge. It's a standard antenna cable to my cabletv box. I watch tv over hdmi to get HD. I only use analogue (and this htpc card) to record stuff. (please, don't top-post - it makes

Re: tda8290 regression fix

2012-09-23 Thread Mauro Carvalho Chehab
Em 22-09-2012 11:32, Anders Eriksson escreveu: > Not to my knowledge. It's a standard antenna cable to my cabletv box. I watch > tv over hdmi to get HD. I only use analogue (and this htpc card) to record > stuff. (please, don't top-post - it makes harder to preserve the history of the discussio

Re: tda8290 regression fix

2012-09-21 Thread Mauro Carvalho Chehab
Em 21-09-2012 10:59, Anders Eriksson escreveu: > > > On Wed, Sep 19, 2012 at 9:25 PM, Anders Thomson > wrote: > > diff --git a/drivers/media/common/tuners/tda8290.c > b/drivers/media/common/tuners/tda8290.c > index 064d14c..498cc7b 100644 > --- a/driver

Re: tda8290 regression fix

2012-09-19 Thread Anders Thomson
On 2012-09-19 18:45, Mauro Carvalho Chehab wrote: Em 19-09-2012 10:01, Anders Thomson escreveu: > On 2012-09-18 11:53, Mauro Carvalho Chehab wrote: >> Em 16-09-2012 05:48, Anders Thomson escreveu: >> > It doesn't make any difference though :-( I still have the layer of noise... >> >> That'

Re: tda8290 regression fix

2012-09-19 Thread Mauro Carvalho Chehab
Em 19-09-2012 10:01, Anders Thomson escreveu: > On 2012-09-18 11:53, Mauro Carvalho Chehab wrote: >> Em 16-09-2012 05:48, Anders Thomson escreveu: >> > It doesn't make any difference though :-( I still have the layer of >> > noise... >> >> That's weird. Hmm... perhaps priv->cfg.config is being in

Re: tda8290 regression fix

2012-09-19 Thread Anders Thomson
On 2012-09-18 11:53, Mauro Carvalho Chehab wrote: Em 16-09-2012 05:48, Anders Thomson escreveu: > It doesn't make any difference though :-( I still have the layer of noise... That's weird. Hmm... perhaps priv->cfg.config is being initialized latter. Maybe you can then do, instead:

Re: tda8290 regression fix

2012-09-18 Thread Mauro Carvalho Chehab
Em 16-09-2012 05:48, Anders Thomson escreveu: > On 2012-09-16 00:25, Mauro Carvalho Chehab wrote: >> Em Sat, 15 Sep 2012 20:12:49 +0200 >> Anders Thomson escreveu: >> >> > On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: >> > > Em Sat, 15 Sep 2012 19:39:31 +0200 >> > > Anders Thomson escre

Re: tda8290 regression fix

2012-09-16 Thread Anders Thomson
On 2012-09-16 00:25, Mauro Carvalho Chehab wrote: Em Sat, 15 Sep 2012 20:12:49 +0200 Anders Thomson escreveu: > On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: > > Em Sat, 15 Sep 2012 19:39:31 +0200 > > Anders Thomson escreveu: > > > > > On 2012-09-15 18:34, Mauro Carvalho Chehab

Re: tda8290 regression fix

2012-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2012 20:12:49 +0200 Anders Thomson escreveu: > On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: > > Em Sat, 15 Sep 2012 19:39:31 +0200 > > Anders Thomson escreveu: > > > > > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > > > $ cat /TV_CARD.diff > > > > > diff --

Re: tda8290 regression fix

2012-09-15 Thread Anders Thomson
On 2012-09-15 19:58, Mauro Carvalho Chehab wrote: Em Sat, 15 Sep 2012 19:39:31 +0200 Anders Thomson escreveu: > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > $ cat /TV_CARD.diff > > > diff --git a/drivers/media/common/tuners/tda8290.c > > > b/drivers/media/common/tuners/t

Re: tda8290 regression fix

2012-09-15 Thread Mauro Carvalho Chehab
Em Sat, 15 Sep 2012 19:39:31 +0200 Anders Thomson escreveu: > On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > > $ cat /TV_CARD.diff > > > diff --git a/drivers/media/common/tuners/tda8290.c > > > b/drivers/media/common/tuners/tda8290.c > > > index 064d14c..498cc7b 100644 > > > --- a/dri

Re: tda8290 regression fix

2012-09-15 Thread Anders Thomson
On 2012-09-15 19:39, Anders Thomson wrote: On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > > $ cat /TV_CARD.diff > > diff --git a/drivers/media/common/tuners/tda8290.c > > b/drivers/media/common/tuners/tda8290.c > > index 064d14c..498cc7b 100644 > > --- a/drivers/media/common/t

Re: tda8290 regression fix

2012-09-15 Thread Anders Thomson
On 2012-09-15 18:34, Mauro Carvalho Chehab wrote: > $ cat /TV_CARD.diff > diff --git a/drivers/media/common/tuners/tda8290.c > b/drivers/media/common/tuners/tda8290.c > index 064d14c..498cc7b 100644 > --- a/drivers/media/common/tuners/tda8290.c > +++ b/drivers/media/common/tuners/tda8290.c

Re: tda8290 regression fix

2012-09-15 Thread Mauro Carvalho Chehab
Em Thu, 30 Aug 2012 13:27:21 +0200 Anders Thomson escreveu: > Hi, > > Ever since 2.6.26 or so (where there was a code reorg) I had to carry > this patch. > Without it the received signal is noisy, and the card worked fine prior > to the code > reorg. This patch is a hack, mostly as a result of