RE: [PATCH 0/6] davinci vpbe: V4L2 Display driver for DM644X

2010-11-19 Thread Hadli, Manjunath
Hans, Thank you for the review comments. I will include a section on customizing for additions and changes to different boards. Thanks again, -Manju On Sat, Nov 13, 2010 at 18:22:19, Hans Verkuil wrote: Hi Manju, I've reviewed the other patches as well. The only one for which I had

Re: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent

2010-11-19 Thread David Cohen
Hi Sergio, I've few comments below. On Mon, Nov 15, 2010 at 03:30:00PM +0100, ext Sergio Aguirre wrote: Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/ispccp2.c |3 +-- drivers/media/video/isp/ispreg.h | 14 -- 2 files changed, 9

Re: [omap3isp][PATCH v2 7/9] omap3isp: Cleanup isp_power_settings

2010-11-19 Thread David Cohen
Hi Sergio, Thanks for the patch. On Mon, Nov 15, 2010 at 03:29:59PM +0100, ext Sergio Aguirre wrote: 1. Get rid of CSI2 / CCP2 power settings, as they are controlled in the receivers code anyways. CCP2 is not correctly handling this. It's setting SMART STANDBY mode one when reading from

Re: [omap3isp][PATCH v2 5/9] omap3isp: Remove unused CBUFF register access

2010-11-19 Thread David Cohen
Hi Sergio, I have one comment below. On Mon, Nov 15, 2010 at 03:29:57PM +0100, ext Sergio Aguirre wrote: Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c|2 -- drivers/media/video/isp/isp.h|1 - drivers/media/video/isp/ispreg.h | 25

Re: [omap3isp][PATCH v2 5/9] omap3isp: Remove unused CBUFF register access

2010-11-19 Thread Laurent Pinchart
Hi David, On Friday 19 November 2010 11:19:44 David Cohen wrote: On Mon, Nov 15, 2010 at 03:29:57PM +0100, ext Sergio Aguirre wrote: [snip] @@ -244,26 +239,6 @@ #define ISP_CSIB_SYSCONFIG ISPCCP2_SYSCONFIG #define ISP_CSIA_SYSCONFIG ISPCSI2_SYSCONFIG -/*

[omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet

2010-11-19 Thread David Cohen
OMAP3 ISP driver does not support pipeline with multiple video outputs yet. Driver must return -EBUSY in this case. Signed-off-by: David Cohen david.co...@nokia.com --- drivers/media/video/isp/ispccdc.c| 26 -- drivers/media/video/isp/ispcsi2.c| 19

[PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-subdev.h |4 1 files changed, 4

Re: Translation faults with OMAP ISP

2010-11-19 Thread David Cohen
Hi Lane, On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote: On 11/17/2010 04:09 PM, Laurent Pinchart wrote: Hi Lane, On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote: Laurent, I am getting iommu translation errors when I try to use the CCDC output after using

Re: [omap3isp][PATCH] omap3isp: does not allow pipeline with multiple video outputs yet

2010-11-19 Thread David Cohen
On Fri, Nov 19, 2010 at 02:23:54PM +0100, Cohen David (Nokia-MS/Helsinki) wrote: OMAP3 ISP driver does not support pipeline with multiple video outputs yet. Driver must return -EBUSY in this case. Signed-off-by: David Cohen david.co...@nokia.com --- drivers/media/video/isp/ispccdc.c|

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Hans Verkuil
On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream. Looks OK, but perhaps the two should be combined to one function? I also

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Guennadi Liakhovetski
On Fri, 19 Nov 2010, Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com ---

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Hi Hans, On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream.

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Guennadi Liakhovetski
On Fri, 19 Nov 2010, Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream. Looks OK, but perhaps the

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Hi Guennadi, On Friday 19 November 2010 14:49:44 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of corrupt frames to skip when starting the stream.

Re: Translation faults with OMAP ISP

2010-11-19 Thread Lane Brooks
On 11/19/2010 06:29 AM, David Cohen wrote: On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote: On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote: Laurent, I am getting iommu translation errors when I try to use the CCDC output after using the Resizer output. If I use the

Re: Translation faults with OMAP ISP

2010-11-19 Thread Laurent Pinchart
Hi Lane, On Friday 19 November 2010 15:08:38 Lane Brooks wrote: On 11/19/2010 06:29 AM, David Cohen wrote: On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote: On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote: Laurent, I am getting iommu translation errors when I

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Guennadi Liakhovetski
On Fri, 19 Nov 2010, Laurent Pinchart wrote: Hi Hans, On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when the stream is started. This new operation returns the number of

Re: Translation faults with OMAP ISP

2010-11-19 Thread Lane Brooks
On 11/19/2010 07:13 AM, Laurent Pinchart wrote: On Friday 19 November 2010 15:08:38 Lane Brooks wrote: On 11/19/2010 06:29 AM, David Cohen wrote: On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote: On Wednesday 17 November 2010 00:46:27 Lane Brooks wrote: Laurent, I am getting

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Hans Verkuil
On Friday 19 November 2010 15:15:11 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: Hi Hans, On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames

Re: [PATCH/RFC] v4l: Add subdev sensor g_skip_frames operation

2010-11-19 Thread Laurent Pinchart
Hi Guennadi, On Friday 19 November 2010 15:15:11 Guennadi Liakhovetski wrote: On Fri, 19 Nov 2010, Laurent Pinchart wrote: On Friday 19 November 2010 14:42:31 Hans Verkuil wrote: On Friday 19 November 2010 14:26:42 Laurent Pinchart wrote: Some buggy sensors generate corrupt frames when

[PATCH] v4l: Include linux/videodev2.h in media/v4l2-ctrls.h

2010-11-19 Thread Laurent Pinchart
The later makes extensive use of structures defined in the former. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/media/v4l2-ctrls.h |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h

Re: Translation faults with OMAP ISP

2010-11-19 Thread David Cohen
On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote: On 11/19/2010 07:13 AM, Laurent Pinchart wrote: On Friday 19 November 2010 15:08:38 Lane Brooks wrote: On 11/19/2010 06:29 AM, David Cohen wrote: On Thu, Nov 18, 2010 at 12:17:21AM +0100, ext Lane Brooks wrote: On Wednesday

Re: Translation faults with OMAP ISP

2010-11-19 Thread Laurent Pinchart
Hi David, On Friday 19 November 2010 16:06:21 David Cohen wrote: On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote: On 11/19/2010 07:13 AM, Laurent Pinchart wrote: On Friday 19 November 2010 15:08:38 Lane Brooks wrote: On 11/19/2010 06:29 AM, David Cohen wrote: On Thu,

Re: Translation faults with OMAP ISP

2010-11-19 Thread David Cohen
On Fri, Nov 19, 2010 at 04:07:27PM +0100, ext Laurent Pinchart wrote: Hi David, On Friday 19 November 2010 16:06:21 David Cohen wrote: On Fri, Nov 19, 2010 at 03:16:41PM +0100, ext Lane Brooks wrote: On 11/19/2010 07:13 AM, Laurent Pinchart wrote: On Friday 19 November 2010 15:08:38

RE: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent

2010-11-19 Thread Aguirre, Sergio
-Original Message- From: David Cohen [mailto:david.co...@nokia.com] Sent: Friday, November 19, 2010 4:06 AM To: Aguirre, Sergio Cc: Laurent Pinchart; linux-media@vger.kernel.org Subject: Re: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent Hi Sergio, Hi

RE: [omap3isp][PATCH v2 7/9] omap3isp: Cleanup isp_power_settings

2010-11-19 Thread Aguirre, Sergio
-Original Message- From: David Cohen [mailto:david.co...@nokia.com] Sent: Friday, November 19, 2010 4:18 AM To: Aguirre, Sergio Cc: Laurent Pinchart; linux-media@vger.kernel.org Subject: Re: [omap3isp][PATCH v2 7/9] omap3isp: Cleanup isp_power_settings Hi Sergio, Thanks for

RE: [omap3isp][PATCH v2 5/9] omap3isp: Remove unused CBUFF register access

2010-11-19 Thread Aguirre, Sergio
Hi Laurent and David, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Friday, November 19, 2010 4:33 AM To: David Cohen Cc: Aguirre, Sergio; linux-media@vger.kernel.org Subject: Re: [omap3isp][PATCH v2 5/9] omap3isp: Remove unused CBUFF

[PATCH 2/7] v4l: videobuf2: add generic memory handling routines

2010-11-19 Thread Marek Szyprowski
From: Pawel Osciak p.osc...@samsung.com Add generic memory handling routines for userspace pointer handling, contiguous memory verification and mapping. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park

[PATCH 3/7] v4l: videobuf2: add vmalloc allocator

2010-11-19 Thread Marek Szyprowski
From: Pawel Osciak p.osc...@samsung.com Add an implementation of contiguous virtual memory allocator and handling routines for videobuf2, implemented on top of vmalloc()/vfree() calls. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 1/7] v4l: add videobuf2 Video for Linux 2 driver framework

2010-11-19 Thread Marek Szyprowski
From: Pawel Osciak p.osc...@samsung.com Videobuf2 is a Video for Linux 2 API-compatible driver framework for multimedia devices. It acts as an intermediate layer between userspace applications and device drivers. It also provides low-level, modular memory management functions for drivers.

[PATCH 7/7] v4l: videobuf2: add CMA allocator

2010-11-19 Thread Marek Szyprowski
From: Pawel Osciak p.osc...@samsung.com Add support for the CMA contiguous memory allocator to videobuf2. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com CC: Pawel Osciak

[PATCH 4/7] v4l: videobuf2: add DMA coherent allocator

2010-11-19 Thread Marek Szyprowski
From: Pawel Osciak p.osc...@samsung.com Add an implementation of DMA coherent memory allocator and handling routines for videobuf2, implemented on top of dma_alloc_coherent() call. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 5/7] v4l: videobuf2: add read() and write() emulator

2010-11-19 Thread Marek Szyprowski
Add a generic file io (read and write) emulator for videobuf2. It uses MMAP memory type buffers and generic vb2 calls: req_bufs, qbuf and dqbuf. Video date is being copied from mmap buffers to userspace with standard copy_to_user() function. To add support for file io the driver needs to provide

[PATCH/RFC v5 0/7] Videobuf2 framework

2010-11-19 Thread Marek Szyprowski
Hello, This is a quick update of the patch series posted a few days ago. I've fixed coding style issues pointed by Hans, added the correct version of dma coherent allocator (looks that outdated patch have been included in all previous series) and fixed an ugly bug in __queue_cancel function (the

[PATCH 6/7] v4l: vivi: port to videobuf2

2010-11-19 Thread Marek Szyprowski
Make vivi use videobuf2 in place of videobuf. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Pawel Osciak pa...@osciak.com --- drivers/media/video/Kconfig |2 +-

[RFCv6 01/13] lib: rbtree: rb_root_init() function added

2010-11-19 Thread Michal Nazarewicz
Added a rb_root_init() function which initialises a rb_root structure as a red-black tree with at most one element. The rationale is that using rb_root_init(root, node) is more straightforward and cleaner then first initialising and empty tree followed by an insert operation. Signed-off-by:

[RFCv6 02/13] lib: bitmap: Added alignment offset for bitmap_find_next_zero_area()

2010-11-19 Thread Michal Nazarewicz
This commit adds a bitmap_find_next_zero_area_off() function which works like bitmap_find_next_zero_area() function expect it allows an offset to be specified when alignment is checked. This lets caller request a bit such that its number plus the offset is aligned according to the mask.

[RFCv6 05/13] mm: cma: debugfs support added

2010-11-19 Thread Michal Nazarewicz
The debugfs development interface lets one change the map attribute at run time as well as observe what regions have been reserved. Signed-off-by: Michal Nazarewicz m.nazarew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/contiguous-memory.txt |4 +

[RFCv6 13/13] ARM: cma: Added CMA to Aquila, Goni and c210 universal boards

2010-11-19 Thread Michal Nazarewicz
This commit adds CMA memory reservation code to Aquila, Goni and c210 universal boards. Signed-off-by: Michal Nazarewicz m.nazarew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-s5pv210/mach-aquila.c | 26 ++

[RFCv6 07/13] mm: cma: Test device and application added

2010-11-19 Thread Michal Nazarewicz
This patch adds a cma misc device which lets user space use the CMA API. This device is meant for testing. A testing application is also provided. Signed-off-by: Michal Nazarewicz m.nazarew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/misc/Kconfig |8

[RFCv6 00/13] The Contiguous Memory Allocator framework

2010-11-19 Thread Michal Nazarewicz
Hello everyone, A few people asked about CMA at the LPC, so even though the I have not yet finished working on the new CMA here it is so that all interested parties can take a look and decide if it can be used for their use case. In particular, this version adds not yet completed support for

[RFCv6 10/13] mm: MIGRATE_CMA migration type added

2010-11-19 Thread Michal Nazarewicz
The MIGRATE_CMA migration type has two main characteristics: (i) only movable and reclaimable pages can be allocated from MIGRATE_CMA page blocks and (ii) page allocator will never change migration type of MIGRATE_CMA page blocks. This guarantees that page in a MIGRATE_CMA page block can always

[RFCv6 09/13] mm: alloc_contig_free_pages() added

2010-11-19 Thread Michal Nazarewicz
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com This commit introduces alloc_contig_free_pages() function which allocates (ie. removes from buddy system) free pages in range. Caller has to guarantee that all pages in range are in buddy system. Along with alloc_contig_free_pages(), a

[RFCv6 11/13] mm: MIGRATE_CMA isolation functions added

2010-11-19 Thread Michal Nazarewicz
This commit changes various functions that change pages and pageblocks migrate type between MIGRATE_ISOLATE and MIGRATE_MOVABLE in such a way as to allow to work with MIGRATE_CMA migrate type. Signed-off-by: Michal Nazarewicz m.nazarew...@samsung.com Signed-off-by: Kyungmin Park

[RFCv6 08/13] mm: move some functions to page_isolation.c

2010-11-19 Thread Michal Nazarewicz
From: KAMEZAWA Hiroyuki kamezawa.hir...@jp.fujitsu.com Memory hotplug is a logic for making pages unused in the specified range of pfn. So, some of core logics can be used for other purpose as allocating a very large contigous memory block. This patch moves some functions from

[RFCv6 06/13] mm: cma: Best-fit algorithm added

2010-11-19 Thread Michal Nazarewicz
This commits adds a best-fit algorithm to the set of algorithms supported by the CMA. Signed-off-by: Michal Nazarewicz m.nazarew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- mm/Kconfig| 16 ++- mm/Makefile |1 + mm/cma-best-fit.c | 372

[RFCv6 03/13] lib: genalloc: Generic allocator improvements

2010-11-19 Thread Michal Nazarewicz
This commit adds a gen_pool_alloc_aligned() function to the generic allocator API. It allows specifying alignment for the allocated block. This feature uses the bitmap_find_next_zero_area_off() function. It also fixes possible issue with bitmap's last element being not fully allocated (ie.

[RFCv6 12/13] mm: cma: Migration support added [wip]

2010-11-19 Thread Michal Nazarewicz
This commits adds cma_early_grab_pageblocks() function as well as makes cma_early_region_reserve() function use the former if some conditions are met. Grabbed pageblocks are later given back to page allocator with migration type set to MIGRATE_CMA. This guarantees that only movable and

[omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Aguirre, Sergio
Hi David and Laurent, snip Don't forget that Lane is using an older version of the OMAP3 ISP driver. The bug might have been fixed in the latest code. Hm. We did fix some iommu faults. Maybe it's better to test a newer version instead. If you still see that bug using an up-to-date

Re: [omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Laurent Pinchart
Hi Sergio, On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote: Hi David and Laurent, snip Don't forget that Lane is using an older version of the OMAP3 ISP driver. The bug might have been fixed in the latest code. Hm. We did fix some iommu faults. Maybe it's better to

RE: [omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Aguirre, Sergio
Hi Laurent, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Friday, November 19, 2010 10:16 AM To: Aguirre, Sergio Cc: David Cohen; ext Lane Brooks; linux-media@vger.kernel.org Subject: Re: [omap3isp] Prefered patch base for latest code?

Re: [omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Laurent Pinchart
Hi Sergio, On Friday 19 November 2010 17:23:45 Aguirre, Sergio wrote: On Friday, November 19, 2010 10:16 AM Aguirre, Sergio wrote: On Friday 19 November 2010 17:07:09 Aguirre, Sergio wrote: [snip] How close is this tree from the latest internal version you guys work with?

RE: [omap3isp] Prefered patch base for latest code? (was: RE: Translation faults with OMAP ISP)

2010-11-19 Thread Aguirre, Sergio
Hi Laurent, -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Laurent Pinchart Sent: Friday, November 19, 2010 10:32 AM To: Aguirre, Sergio Cc: David Cohen; ext Lane Brooks; linux-media@vger.kernel.org Subject: Re:

tvp5150 extension to tvp5151

2010-11-19 Thread Raffaele Recalcati
I need to support fully tvp5151. So I'm trying to understand your driver, that is ready for VBI and not for video acquisition. I also take sometimes a look at tvp514x.c, for instance trying to add VIDIOC_ENUM_FMT and other ioctls. I think we can move from tvp5150.c to tvp515x.c, maybe... I don't

[cron job] v4l-dvb daily build: WARNINGS

2010-11-19 Thread Hans Verkuil
This message is generated daily by a cron job that builds v4l-dvb for the kernels and architectures in the list below. Results of the daily build of v4l-dvb: date:Fri Nov 19 19:00:22 CET 2010 git master: 59365d136d205cc20fe666ca7f89b1c5001b0d5a git media-master: gcc version:

[PATCH] media: video: pvrusb2: fix memory leak

2010-11-19 Thread Vasiliy Kulikov
Use put_device() instead of kfree() because of device name leak. Signed-off-by: Vasiliy Kulikov seg...@openwall.com --- Compile tested only. drivers/media/video/pvrusb2/pvrusb2-sysfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] drivers/media: nuvoton: fix chip id probe

2010-11-19 Thread Jarod Wilson
On Wed, Nov 17, 2010 at 11:35:25AM +0100, Nicolas Kaiser wrote: Make sure we have a matching chip id high and one or the other of the chip id low values. Print the values if the probe fails. Signed-off-by: Nicolas Kaiser ni...@nikai.net --- Like this? Supersedes patch drivers/media:

[PATCH] drivers/media: nuvoton: fix chip id probe v2

2010-11-19 Thread Nicolas Kaiser
Make sure we have a matching chip id high and one or the other of the chip id low values. Print the values if the probe fails. Signed-off-by: Nicolas Kaiser ni...@nikai.net --- drivers/media/IR/nuvoton-cir.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git

[GIT PATCHES FOR 2.6.37]

2010-11-19 Thread Hans Verkuil
Hi Mauro, Here is the pull request for the patch series that: 1) Converts 29 drivers to unlocked_ioctl 2) Improves the v4l core by using mutex_lock_interruptible and fixes incorrect return codes for poll, write and read. 3) Improves the BKL-replacement code so that VIDIOC_DQBUF is no longer

Re: [omap3isp][PATCH v2 5/9] omap3isp: Remove unused CBUFF register access

2010-11-19 Thread David Cohen
On Fri, Nov 19, 2010 at 04:54:01PM +0100, ext Aguirre, Sergio wrote: Hi Laurent and David, Hi Sergio, -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Friday, November 19, 2010 4:33 AM To: David Cohen Cc: Aguirre, Sergio;

Re: [PATCH] drivers/media: nuvoton: fix chip id probe v2

2010-11-19 Thread Jarod Wilson
On Fri, Nov 19, 2010 at 09:42:40PM +0100, Nicolas Kaiser wrote: Make sure we have a matching chip id high and one or the other of the chip id low values. Print the values if the probe fails. Signed-off-by: Nicolas Kaiser ni...@nikai.net That works for me, thanks much. Acked-by: Jarod

RE: [omap3isp][PATCH v2 7/9] omap3isp: Cleanup isp_power_settings

2010-11-19 Thread Aguirre, Sergio
-Original Message- From: Aguirre, Sergio Sent: Friday, November 19, 2010 9:46 AM To: 'David Cohen' Cc: Laurent Pinchart; linux-media@vger.kernel.org Subject: RE: [omap3isp][PATCH v2 7/9] omap3isp: Cleanup isp_power_settings -Original Message- From: David Cohen

RE: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent

2010-11-19 Thread Aguirre, Sergio
-Original Message- From: Aguirre, Sergio Sent: Friday, November 19, 2010 9:44 AM To: 'David Cohen' Cc: Laurent Pinchart; linux-media@vger.kernel.org Subject: RE: [omap3isp][PATCH v2 8/9] omap3isp: ccp2: Make SYSCONFIG fields consistent -Original Message- From:

Zooming with V4L2

2010-11-19 Thread Shuzhen Wang
Hello, I am working on a SOC V4L2 video driver, and need to implement zoom functionality. From application, there are 2 ways to do zooming. The 1st way is to use cropping and scaling as described in section 1.11.1. The application calls VIDIOC_S_CROP to achieve zoom. The 2nd way is to use

[omap3isp RFC][PATCH 4/4] omap3isp: csi2: Don't dump ISP main registers

2010-11-19 Thread Sergio Aguirre
This keeps the driver focused only on accessing CSI2 registers only. if the same info is needed, isp_print_status should be called instead. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/ispcsi2.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff

[omap3isp RFC][PATCH 2/4] omap3isp: Move CCDC LSC prefetch wait to main isp code

2010-11-19 Thread Sergio Aguirre
Since this sequence strictly touches ISP global registers, it's not really part of the same register address space than the CCDC. Do this check in main isp code instead. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c | 24

[omap3isp RFC][PATCH 0/4] Improve inter subdev interaction

2010-11-19 Thread Sergio Aguirre
Hi, These are some patches to make these operations more generic: - Clock control is being controlled in a very crude manner by subdevices, it should be centralized in isp.c. - LSC prefetch wait check is reading a main ISP register, so move it to isp.c - Abstract SBL busy check: we don't want

[omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control

2010-11-19 Thread Sergio Aguirre
Submodules shouldn't be aware of global register bit structure, specially if the submodules are shared in the future with other TI architectures (Davinci, future OMAPs, etc) Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c| 54

[omap3isp RFC][PATCH 3/4] omap3isp: sbl: Abstract SBL busy check

2010-11-19 Thread Sergio Aguirre
Make a nicer interface that can be used by anyone accessing the isp. Signed-off-by: Sergio Aguirre saagui...@ti.com --- drivers/media/video/isp/isp.c | 17 + drivers/media/video/isp/isp.h |2 ++ drivers/media/video/isp/ispccdc.c | 10 +- 3 files changed,

RE: [omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control

2010-11-19 Thread Aguirre, Sergio
-Original Message- From: Aguirre, Sergio Sent: Friday, November 19, 2010 5:24 PM To: Laurent Pinchart Cc: linux-media@vger.kernel.org; Aguirre, Sergio Subject: [omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control Submodules shouldn't be aware of global

RE: [omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control

2010-11-19 Thread Aguirre, Sergio
-Original Message- From: Aguirre, Sergio Sent: Friday, November 19, 2010 5:27 PM To: Aguirre, Sergio; Laurent Pinchart Cc: linux-media@vger.kernel.org Subject: RE: [omap3isp RFC][PATCH 1/4] omap3isp: Abstract isp subdevs clock control -Original Message- From:

[PATCH 00/10] rc-core: various cleanups

2010-11-19 Thread David Härdeman
Here's a set of smaller patches which performs various cleanups, mostly to the saa7134 and bttv driver. They are based on the media_tree.git repo (2.6.38 branch) on top of Mauro's recent renaming patches. --- David Härdeman (10): saa7134: remove unused module parameter saa7134: use

[PATCH 01/10] saa7134: remove unused module parameter

2010-11-19 Thread David Härdeman
ir_rc5_remote_gap is a leftover from ir-common, remove it. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-input.c

[PATCH 02/10] saa7134: use full keycode for BeholdTV

2010-11-19 Thread David Härdeman
Using the full keycode for BeholdTV hardware makes another module parameter unnecessary. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/keymaps/rc-behold.c| 70 ++- drivers/media/video/saa7134/saa7134-input.c | 19 +-- 2 files

[PATCH 03/10] saa7134: some minor cleanups

2010-11-19 Thread David Härdeman
Mostly using appropriate data types and constants (e.g. int - bool). Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c | 49 ++- drivers/media/video/saa7134/saa7134.h |4 +- 2 files changed, 21 insertions(+), 32

[PATCH 04/10] saa7134: merge saa7134_card_ir-timer and saa7134_card_ir-timer_end

2010-11-19 Thread David Härdeman
Both timers are used for a similar purpose. Merging them allows for some minor simplifications. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c | 10 -- drivers/media/video/saa7134/saa7134.h |1 - 2 files changed, 4

[PATCH 09/10] mceusb: int to bool conversion

2010-11-19 Thread David Härdeman
Convert boolean variables to use the corresponding data type. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/mceusb.c | 62 +++-- 1 files changed, 26 insertions(+), 36 deletions(-) diff --git a/drivers/media/rc/mceusb.c

[PATCH 05/10] saa7134: protect the ir user count

2010-11-19 Thread David Härdeman
The use of the saa7134_card_ir-users seems racy, so protect the count with a spinlock. Also use proper data types as arguments to __saa7134_ir_start() and __saa7134_ir_stop() to remove some unnecessary casts. Signed-off-by: David Härdeman da...@hardeman.nu ---

[PATCH 10/10] rc-core: fix some leftovers from the renaming patches

2010-11-19 Thread David Härdeman
Fix some minor comments etc which are leftover from the old naming scheme. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/rc/ir-raw.c |2 +- drivers/media/rc/rc-core-priv.h |6 +++--- drivers/media/rc/rc-main.c |2 +- include/media/rc-core.h |

[PATCH 06/10] saa7134: make module parameters boolean

2010-11-19 Thread David Härdeman
int to bool conversion for module parameters which are truely boolean. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-input.c

[PATCH 07/10] bttv: rename struct card_ir to bttv_ir

2010-11-19 Thread David Härdeman
bttv_ir is more consistent with all other structs used in the same driver. Also, clean up the struct to remove commented out members and the work_struct which is unused. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/bt8xx/bttv-input.c | 27 +--

Re: [RFC PATCH 0/2] Apple remote support

2010-11-19 Thread David Härdeman
On Thu, Nov 18, 2010 at 06:59:43PM -0200, Mauro Carvalho Chehab wrote: Em 18-11-2010 18:49, Jarod Wilson escreveu: On Thu, Nov 18, 2010 at 09:43:19PM +0100, David Härdeman wrote: On Thu, Nov 18, 2010 at 11:33:04AM -0500, Jarod Wilson wrote: Mauro's suggestion, iirc, was that max scancode size

Re: [linux-dvb] DVB Driver for DiBcom's DiB7000M does not support the remote control for the kaiserbass TVStick

2010-11-19 Thread David Wilson
This is my first attempt at working on a linux driver and I need some assistance. I have purchased the kaiserbass TVStick product ID 'KBA01007-KB DVD-T USB TUNER WITH 2 GB MEMORY'. The Linux-DVB Driver for DiBcom's DiB7000M driver works very well for video, but the software driver does not

Re: [PATCH 06/10] saa7134: make module parameters boolean

2010-11-19 Thread hermann pitton
Am Samstag, den 20.11.2010, 00:43 +0100 schrieb David Härdeman: int to bool conversion for module parameters which are truely boolean. Signed-off-by: David Härdeman da...@hardeman.nu --- drivers/media/video/saa7134/saa7134-input.c |8 1 files changed, 4 insertions(+), 4