[PATCH] dvb-usb: Add memory free on error path in dw2102_probe()

If dw2102_probe() fails on dvb_usb_device_init(), then memleak occurs. The patch adds deallocation to the error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Anton Vasilyev --- drivers/media/usb/dvb-usb/dw2102.c | 39

Re: [PATCH v2 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

On 09/08/17 13:15, Sakari Ailus wrote: > The v4l2_flash_init() keeps a reference to the ops struct but not to the > config struct (nor anything it contains). Document this. > > Signed-off-by: Sakari Ailus > Acked-by: Pavel Machek Acked-by: Hans

[PATCH] staging:media:atomisp:Fix code indent error

code indent should use tabs where possible change spaces to tabs Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c

Re: [PATCH 2/2] cec: fix remote control passthrough

On Thu, Aug 10, 2017 at 12:45:42PM +0200, Hans Verkuil wrote: > On 09/08/17 23:17, Sean Young wrote: > > On Tue, Aug 08, 2017 at 10:11:13AM +0200, Hans Verkuil wrote: > >> On 07/08/17 22:58, Sean Young wrote: > >>> On Mon, Aug 07, 2017 at 03:31:24PM +0200, Hans Verkuil wrote: > From: Hans

Re: [PATCH 04/12] [media] V4L2: platform: rcar_jpu: constify v4l2_m2m_ops structures

On Sun, Aug 6, 2017 at 11:25 AM, Julia Lawall wrote: > The v4l2_m2m_ops structures are only passed as the only > argument to v4l2_m2m_init, which is declared as const. > Thus the v4l2_m2m_ops structures themselves can be const. > > Done with the help of Coccinelle. > > // >

Re: [PATCH v2 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

On 09/08/17 13:15, Sakari Ailus wrote: > The V4L2 flash interface allows controlling multiple LEDs through a single > sub-devices if, and only if, these LEDs are of different types. This > approach scales badly for flash controllers that drive multiple flash LEDs > or for LED specific

Re: [PATCH v5 6/6] dt-bindings: Document the Rockchip RGA bindings

On Wed, Aug 02, 2017 at 11:19:47AM +0800, Jacob Chen wrote: > Add DT bindings documentation for Rockchip RGA > > Signed-off-by: Jacob Chen > Signed-off-by: Yakir Yang > --- > .../devicetree/bindings/media/rockchip-rga.txt | 33 >

[PATCH v3 0/3] Create sub-device per LED

Hi folks, The original design decision in the V4L2 flash API allows controlling a two LEDs (an indicator and a flash) through a single sub-device. This covered virtually all flash driver chips back then but this no longer holds as there are many LED driver chips with multiple flash LED outputs.

[PATCH v3 1/3] staging: greybus: light: fix memory leak in v4l2 register

From: Rui Miguel Silva We are allocating memory for the v4l2 flash configuration structure and leak it in the normal path. Just use the stack for this as we do not use it outside of this function. Also use IS_ERR() instead of IS_ERR_OR_NULL() to check return value from

[PATCH] staging: media: atomisp: Add blank line after variable declarations.

This patch fixes the checkpatch.pl warning WARNING: Missing a blank line after declarations + int i; + dev_dbg(>dev, "Dump registers for context[%d]:\n", context) WARNING: Missing a blank line after declarations + int ret; + ret = request_firmware(>fw, "ap1302_fw.bin",

[PATCH] staging:media:atomisp:Fix trivial codingstyle issues

change comment style to match codingstyle. Issue found by checkpatch change four comments. Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 38 -- 1 file changed, 25 insertions(+), 13 deletions(-) diff --git

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

Hi, On Thu, Aug 10, 2017 at 04:56:50PM +0300, Sakari Ailus wrote: > Hi Hans, > > On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote: > > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct > > > gb_light *light) > > > { > > > struct gb_connection *connection =

Re: [PATCH v2] media: ov5670: Fix incorrect frame timing reported to user

Hi Chiranjeevi, On Thu, Aug 10, 2017 at 6:59 AM, Chiranjeevi Rapolu wrote: > Previously, pixel-rate/(pixels-per-line * lines-per-frame) was > yielding incorrect frame timing for the user. > > OV sensor is using internal timing and this requires > conversion

Re: [PATCH v2] media: ov5670: Fix incorrect frame timing reported to user

On Thu, Aug 10, 2017 at 04:00:05PM +0900, Tomasz Figa wrote: > Hi Chiranjeevi, > > On Thu, Aug 10, 2017 at 6:59 AM, Chiranjeevi Rapolu > wrote: > > Previously, pixel-rate/(pixels-per-line * lines-per-frame) was > > yielding incorrect frame timing for the user. > > >

[GIT FIXES for 4.13] Revert full OF path comparison in OF matching

Hi Mauro, This reverts the change from pointer comparison to full OF node path comparison. As per commit message: The commit was flawed in that if the device_node pointers are different, then in fact a different device is present and the device node could be different in ways other

Re: [PATCH 1/3] dt-bindings: document the CEC GPIO bindings

On 02/08/17 10:42, Hans Verkuil wrote: > From: Hans Verkuil > > Document the bindings for the cec-gpio module for hardware where the > CEC pin is connected to a GPIO pin. ping? > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCH 1/3] dt-bindings: document the CEC GPIO bindings

On 10/08/17 10:03, Hans Verkuil wrote: > On 02/08/17 10:42, Hans Verkuil wrote: >> From: Hans Verkuil >> >> Document the bindings for the cec-gpio module for hardware where the >> CEC pin is connected to a GPIO pin. > > ping? > >> >> Signed-off-by: Hans Verkuil

[PATCHv3 3/4] tegra-cec: add Tegra HDMI CEC driver

From: Hans Verkuil This driver adds support for the Tegra CEC IP. It is based on the NVIDIA drivers/misc/tegra-cec driver in their 3.10 kernel. This has been converted to the CEC framework and cleaned up. Tested with my Jetson TK1 board. It has also been tested with the

[PATCHv3 4/4] drm/tegra: add cec-notifier support

From: Hans Verkuil In order to support CEC the HDMI driver has to inform the CEC driver whenever the physical address changes. So when the EDID is read the CEC driver has to be informed and whenever the hotplug detect goes away. This is done through the cec-notifier

[PATCHv3 1/4] dt-bindings: document the tegra CEC bindings

From: Hans Verkuil This documents the binding for the Tegra CEC module. Signed-off-by: Hans Verkuil --- .../devicetree/bindings/media/tegra-cec.txt| 27 ++ 1 file changed, 27 insertions(+) create mode 100644

[PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. remove the unnecessary paragraph Signed-off-by: Harold Gomez

[PATCHv3 2/4] ARM: tegra: add CEC support to tegra124.dtsi

From: Hans Verkuil Add support for the Tegra CEC IP to tegra124.dtsi and enable it on the Jetson TK1. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/tegra124-jetson-tk1.dts | 4 arch/arm/boot/dts/tegra124.dtsi | 12

[PATCHv2 2/3] cec-gpio: add HDMI CEC GPIO driver

From: Hans Verkuil Add a simple HDMI CEC GPIO driver that sits on top of the cec-pin framework. While I have heard of SoCs that use the GPIO pin for CEC (apparently an early RockChip SoC used that), the main use-case of this driver is to function as a debugging tool. By

[PATCHv2 3/3] MAINTAINERS: add cec-gpio entry

From: Hans Verkuil Add an entry for the CEC GPIO driver. Signed-off-by: Hans Verkuil --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index aeb84877854b..d85959f82a09 100644 --- a/MAINTAINERS

[PATCHv2 0/3] cec-gpio: add HDMI CEC GPIO-based driver

From: Hans Verkuil This driver adds support for CEC implementations that use a pull-up GPIO pin. While SoCs exist that do this, the primary use-case is to turn a single-board computer into a cheap CEC debugger. Together with 'cec-ctl --monitor-pin' you can do low-level

[PATCH 0/2] media: ov7670: Add entity init and power operation

This patch set is to add the media entity pads initialization and add the s_power operation. Wenyou Yang (2): media: ov7670: Add entity pads initialization media: ov7670: Add the s_power operation drivers/media/i2c/ov7670.c | 43 +++ 1 file changed,

[PATCH 1/2] media: ov7670: Add entity pads initialization

Add the media entity pads initialization. Signed-off-by: Wenyou Yang --- drivers/media/i2c/ov7670.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov7670.c b/drivers/media/i2c/ov7670.c index

[PATCH 2/2] media: ov7670: Add the s_power operation

Add the s_power operation which is responsible for manipulating the power dowm mode through the PWDN pin and the reset operation through the RESET pin. Signed-off-by: Wenyou Yang --- drivers/media/i2c/ov7670.c | 30 +++--- 1 file changed, 27

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

On 10/08/17 11:08, Archit Taneja wrote: > > > On 08/10/2017 02:26 PM, Hans Verkuil wrote: >> On 10/08/17 10:49, Archit Taneja wrote: >>> Hi Hans, >>> >>> On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to

Re: [PATCH 4/4] drm: adv7511/33: add HDMI CEC support

On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil Add support for HDMI CEC to the drm adv7511/adv7533 drivers. The CEC registers that we need to use are identical for both drivers, but they appear at different offsets in the register map. Thanks for

Re: [PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

Hi Harold, On Thu, Aug 10, 2017 at 01:58:24PM +0530, Harold Gomez wrote: > CHECK: Do not include the paragraph about writing to the Free Software > Foundation's mailing address from the sample GPL notice. > The FSF has changed addresses in the past, and may do so again. > Linux already includes a

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

Hi Hans, On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm Dragonboard C410 (adv7533 based) and the Renesas R-Car Koelsch board (adv7511 based).

[PATCH] Subject:drivers:staging:media:atomisp:

Fix Warning from checkpatch.pl Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c

[PATCH] Subject: drivers:staging:media:atomisp:12c:ab1302.c fix CHECK

CHECK: Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. Linux already includes a copy of the GPL. remove the unnecessary paragraph Signed-off-by: Harold Gomez

[PATCHv2 1/3] dt-bindings: document the CEC GPIO bindings

From: Hans Verkuil Document the bindings for the cec-gpio module for hardware where the CEC pin is connected to a GPIO pin. Signed-off-by: Hans Verkuil --- Documentation/devicetree/bindings/media/cec-gpio.txt | 16 1 file

[PATCH] Subject:drivers:staging:media:atomisp:i2c:api1302.c

Fix Warning Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

On 08/10/2017 02:26 PM, Hans Verkuil wrote: On 10/08/17 10:49, Archit Taneja wrote: Hi Hans, On 07/30/2017 06:37 PM, Hans Verkuil wrote: From: Hans Verkuil This patch series adds CEC support to the drm adv7511/adv7533 drivers. I have tested this with the Qualcomm

[PATCHv3 0/4] tegra-cec: add Tegra HDMI CEC support

From: Hans Verkuil This patch series adds support for the Tegra CEC functionality. It has this prerequisite: https://patchwork.linuxtv.org/patch/42521/ That patch has been merged in 4.13-rc4. The first patch documents the CEC bindings, the second adds support for this

Re: [PATCH 0/4] drm/bridge/adv7511: add CEC support

On 10/08/17 10:49, Archit Taneja wrote: > Hi Hans, > > On 07/30/2017 06:37 PM, Hans Verkuil wrote: >> From: Hans Verkuil >> >> This patch series adds CEC support to the drm adv7511/adv7533 drivers. >> >> I have tested this with the Qualcomm Dragonboard C410 (adv7533

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

Hi Hans, On Thu, Aug 10, 2017 at 03:02:46PM +0200, Hans Verkuil wrote: > > @@ -534,25 +534,20 @@ static int gb_lights_light_v4l2_register(struct > > gb_light *light) > > { > > struct gb_connection *connection = get_conn_from_light(light); > > struct device *dev = >bundle->dev; > > -

Re: [PATCH 4/5] media: platform: s5p-jpeg: fix number of components macro

On 08/08/2017 01:27 PM, Andrzej Pietrasiewicz wrote: The value to be processed must be first masked and then shifted, not the other way round. Signed-off-by: Andrzej Pietrasiewicz --- drivers/media/platform/s5p-jpeg/jpeg-regs.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH v3 2/3] v4l2-flash-led-class: Create separate sub-devices for indicators

The V4L2 flash interface allows controlling multiple LEDs through a single sub-devices if, and only if, these LEDs are of different types. This approach scales badly for flash controllers that drive multiple flash LEDs or for LED specific associations. Essentially, the original assumption of a LED

[PATCH v3 3/3] v4l2-flash-led-class: Document v4l2_flash_init() references

The v4l2_flash_init() keeps a reference to the ops struct but not to the config struct (nor anything it contains). Document this. Signed-off-by: Sakari Ailus Acked-by: Pavel Machek Acked-by: Hans Verkuil ---

Re: [PATCH 5/6] [media] rc: rename RC_TYPE_* to RC_PROTO_* and RC_BIT_* to RC_PROTO_BIT_*

On 07/08/17 22:20, Sean Young wrote: > RC_TYPE is confusing and it's just the protocol. So rename it. > > Suggested-by: Hans Verkuil Acked-by: Hans Verkuil Much better! It's a bit of a painful patch, but so be it. The old names were really

Re: [PATCH 2/2] cec: fix remote control passthrough

On Thu, Aug 10, 2017 at 03:00:21PM +0100, Sean Young wrote: > On Thu, Aug 10, 2017 at 12:45:42PM +0200, Hans Verkuil wrote: > > On 09/08/17 23:17, Sean Young wrote: > > > On Tue, Aug 08, 2017 at 10:11:13AM +0200, Hans Verkuil wrote: > > >> On 07/08/17 22:58, Sean Young wrote: > > >>> On Mon, Aug

Re: [PATCH] [media] rc: per-protocol repeat period

On 09/08/17 19:19, Sean Young wrote: > CEC needs a keypress timeout of 550ms, which is too high for the IR > protocols. Also fill in known repeat times, with 50ms error margin. > > Also, combine all protocol data into one structure. > > Signed-off-by: Sean Young > Suggested-by:

Re: [PATCH] imon: constify attribute_group structures

On Fri, Aug 04, 2017 at 09:51:38PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. I'm afraid the exact same patch has already been

[PATCH 3/5] [media] cx25840: fix a possible divide by zero in set_fmt callback

If set_fmt callback is called with format->width or format->height set to zero and HACTIVE_CNT or VACTIVE_CNT bits (respectively) in chip are zero we will divide by zero later in this callback when we try to calculate HSC or VSC values. Fix this by explicitly rejecting these values.

[PATCH 4/5] [media] tuner-simple: allow setting mono radio mode

For some types of tuners (Philips FMD1216ME(X) MK3 currently) we know that letting TDA9887 output port 1 remain high (inactive) will switch FM radio to mono mode. Let's make use of this functionality - nothing changes for the default stereo radio mode. Tested on a Medion 95700 board which has a

[PATCH 1/5] [media] cx25840: add pin to pad mapping and output format configuration

This commit adds pin to pad mapping and output format configuration support in CX2584x-series chips to cx25840 driver. This functionality is then used to allow disabling ivtv-specific hacks (called a "generic mode"), so cx25840 driver can be used for other devices not needing them without risking

[PATCH 2/5] [media] cx25840: describe standard for 0b1100 value in AFD_FMT_STAT bits

A 0b1100 value in 4 LSBs of "General Status 1" register (AFD_FMT_STAT) has known meaning for CX2584x-series chips - it means that a SECAM signal is currently detected by the chip. Use this opportunity to also fix wrong binary values that were present as comments attached to some entries in an

[PATCH 0/5] [media] Add analog mode support for Medion MD95700

This series adds support for analog part of Medion 95700 in the cxusb driver. What works: * Video capture at various sizes with sequential fields, * Input switching (TV Tuner, Composite, S-Video), * TV and radio tuning, * Video standard switching and auto detection, * Radio mode switching (stereo

[PATCH 5/5] [media] cxusb: add analog mode support for Medion MD95700

This patch adds support for analog part of Medion 95700 in the cxusb driver. What works: * Video capture at various sizes with sequential fields, * Input switching (TV Tuner, Composite, S-Video), * TV and radio tuning, * Video standard switching and auto detection, * Radio mode switching (stereo

[PATCH] staging:media:atomisp:Fix block comments use * on subsequent lines ap1302.c

This patch fixes the warning WARNING: Block comments use * on subsequent lines +/* When loading firmware, host writes firmware data from address 0x8000. + When the address reaches 0x9FFF, the next address should return to 0x8000. WARNING: Block comments use a trailing */ on a separate line +

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Aug 11 05:00:17 CEST 2017 media-tree git hash:ec0c3ec497cabbf3bfa03a9eb5edcc252190a4e0 media_build

Re: [PATCH 1/3] drm: add support for DisplayPort CEC-Tunneling-over-AUX

On Tue, Jul 11, 2017 at 03:30:09PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > This adds support for the DisplayPort CEC-Tunneling-over-AUX > feature that is part of the DisplayPort 1.3 standard. Hi Hans, Thank you for the patch, it looks great, I just have a few

[PATCH RESEND 0/3] v4l2-compat-ioctl32.c: better detect pointer controls

In the past, only string controls were pointers. That changed when compounded types got added, but the compat32 code was not updated. We could just add those controls there, but maintaining it is flaw, as we often forget about the compat code. So, instead, rely on the control type, as this is

[PATCH 1/3] media: v4l2-ctrls.h: better document the arguments for v4l2_ctrl_fill

The arguments for this function are pointers. Make it clear at its documentation. Signed-off-by: Mauro Carvalho Chehab --- include/media/v4l2-ctrls.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/include/media/v4l2-ctrls.h

[PATCH 3/3] media: compat32: reimplement ctrl_is_pointer()

The current way that this function works is subject to problems as new controls gets added. Move it to v4l2-ctrls and use the knowledge that v4l2_ctrl_fill() has about controls, in order to detect if a given control is a pointer. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 2/3] media: v4l2-ctrls: prepare the function to be used by compat32 code

Right now, both v4l2_ctrl_fill() and compat32 code need to know the type of the control. As new controls are added, this cause troubles at compat32, as it won't be able to discover what functions are pointers or not. Change v4l2_ctrl_fill() function for it to be called with just one argument: the

Re: [PATCH] v4l2-compat-ioctl32.c: add capabilities field to, v4l2_input32

Em Fri, 4 Aug 2017 13:25:06 +0200 Hans Verkuil escreveu: > The v4l2_input32 struct wasn't updated when this field was added. > It didn't cause a failure in the compat code, but it is better to > keep it in sync with v4l2_input to avoid confusion. > > Signed-off-by: Hans

Re: [GIT PULL for 4.14] Stream control documentation

Hi Sakari, My apologies, I should have reviewed this weeks ago. Please ping me next time, this got buried under all the other patches, even though it was delegated to me. Anyway, better late than never: On 09/08/17 17:57, Mauro Carvalho Chehab wrote: > Em Wed, 9 Aug 2017 12:29:17 -0300 > Mauro

Re: [PATCH 2/2] cec: fix remote control passthrough

On 09/08/17 23:17, Sean Young wrote: > On Tue, Aug 08, 2017 at 10:11:13AM +0200, Hans Verkuil wrote: >> On 07/08/17 22:58, Sean Young wrote: >>> On Mon, Aug 07, 2017 at 03:31:24PM +0200, Hans Verkuil wrote: From: Hans Verkuil The 'Press and Hold' operation

Re: [PATCH] Subject:drivers:staging:media:atomisp:

Hi Harold, Please use a better subject line. On Thu, Aug 10, 2017 at 03:08:26PM +0530, Harold Gomez wrote: > Fix Warning from checkpatch.pl > Block comments use * on subsequent lines > > Signed-off-by: Harold Gomez > --- > drivers/staging/media/atomisp/i2c/ap1302.c | 5

[PATCH] [media] staging: atomisp: fix bounds checking in mt9m114_s_exposure_selection()

These clamp_t() calls are no-ops because we don't save the results. It leads to an array out of bounds bug. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Dan Carpenter diff --git a/drivers/staging/media/atomisp/i2c/mt9m114.c

[PATCH] Subject:staging:media:atomisp:ap1302: fix comments style

fix comment style Warning in ap1302.c fix WARNING on Block comments use * on subsequent lines Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] drm/bridge/sii8620: add remote control support

Hi Hans, Thank you for your reply. All dongles that we used to work with in Samsung convert CEC protocol to RCP which we get through MHL Sideband Channel. All we can do in the driver is to report RCP messages to user-space. On the RC subsystem: your point is right, which was confirmed by Sean

[PATCH] staging:media:atomisp: Add blank line after declarations

Add blank line after declarations to avoid warning from checkpatch.pl script Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c

[PATCH] media:staging:atomisp:ap1302: Fix comment style

fix comment style to avoid warning from checkpatch.pl script Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

On 09/08/17 13:15, Sakari Ailus wrote: > From: Rui Miguel Silva > > We are allocating memory for the v4l2 flash configuration structure and > leak it in the normal path. Just use the stack for this as we do not > use it outside of this function. I'm not sure why this is part

Re: [PATCH] Subject:staging:media:atomisp:ap1302: fix comments style

On Thu, Aug 10, 2017 at 05:57:35PM +0530, Harold Gomez wrote: > fix comment style Warning in ap1302.c > fix WARNING on Block comments use * on subsequent lines > > Signed-off-by: Harold Gomez If you're making a number of trivial cleanups to a single driver, please submit

[PATCH] media:atomisp:ap1302 Fix style warning

Add a blank line after declarations to avoid checkpatch.pl script warning Signed-off-by: Harold Gomez --- drivers/staging/media/atomisp/i2c/ap1302.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/media/atomisp/i2c/ap1302.c

Re: [PATCH v2 1/3] staging: greybus: light: fix memory leak in v4l2 register

On 10/08/17 15:02, Hans Verkuil wrote: > On 09/08/17 13:15, Sakari Ailus wrote: >> From: Rui Miguel Silva >> >> We are allocating memory for the v4l2 flash configuration structure and >> leak it in the normal path. Just use the stack for this as we do not >> use it outside of