Re: [PATCH v2 1/4] media: ov5695: add support for OV5695 sensor

2018-01-03 Thread Sakari Ailus
On Fri, Dec 29, 2017 at 04:08:22PM +0800, Shunqian Zheng wrote: > This patch adds driver for Omnivision's ov5695 sensor, > the driver supports following features: > - supported resolutions >+ 2592x1944 at 30fps >+ 1920x1080 at 30fps >+ 1296x972 at 60fps >+ 1280x720 at 30fps >+

Re: [PATCH v2 4/4] [media] dt/bindings: Add bindings for OV2685

2018-01-03 Thread Sakari Ailus
Hi Shunqian, On Fri, Dec 29, 2017 at 04:08:25PM +0800, Shunqian Zheng wrote: > Add device tree binding documentation for the OV2685 sensor. DT bindings should precede the driver. Speaking of which --- you should add an entry in the MAINTAINERS file for both. > > Signed-off-by: Shunqian Zheng

Re: [PATCH v2 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 01:45:30PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:13 EET Jacopo Mondi wrote: > > Add bindings documentation for Renesas Capture Engine Unit (CEU). > > > > Signed-off-by: Jacopo Mondi

Re: [PATCH v4 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Hugues FRUCHET
Hi Sakari, this is fine for me to drop those two lines so sync signals become mandatory. Must I repost a v5 serie ? Best regards, Hugues. On 01/02/2018 01:24 PM, Sakari Ailus wrote: > On Tue, Jan 02, 2018 at 02:20:46PM +0200, Sakari Ailus wrote: >> Hi Hugues, >> >> One more thing, please see

Re: [PATCH v2 2/9] include: media: Add Renesas CEU driver interface

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 01:50:07PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:14 EET Jacopo Mondi wrote: > > Add renesas-ceu header file. > > > > Do not remove the existing sh_mobile_ceu.h one as long as the

Re: [PATCH v4 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Sakari Ailus
On Wed, Jan 03, 2018 at 08:47:09AM +, Hugues FRUCHET wrote: > Hi Sakari, > this is fine for me to drop those two lines so sync signals become > mandatory. > Must I repost a v5 serie ? I'll do that while applying the patches. Thanks. -- Sakari Ailus e-mail: sakari.ai...@iki.fi

Re: [PATCH v4 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Sakari Ailus
On Wed, Jan 03, 2018 at 08:47:09AM +, Hugues FRUCHET wrote: > Hi Sakari, > this is fine for me to drop those two lines so sync signals become > mandatory. > Must I repost a v5 serie ? Here's the diff: diff --git a/Documentation/devicetree/bindings/media/i2c/ov5640.txt

Re: [PATCH v4 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Hugues FRUCHET
OK, thanks for all Sakari ! On 01/03/2018 10:10 AM, Sakari Ailus wrote: > On Wed, Jan 03, 2018 at 08:47:09AM +, Hugues FRUCHET wrote: >> Hi Sakari, >> this is fine for me to drop those two lines so sync signals become >> mandatory. >> Must I repost a v5 serie ? > > Here's the diff: > > diff

Re: [PATCH v4 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Sakari Ailus
Hi Hugues, On Wed, Jan 03, 2018 at 09:12:43AM +, Hugues FRUCHET wrote: > OK, thanks for all Sakari ! One thing I've missed so far --- the DT binding changes should be always cc'd to the devicetree list which I see is missing now. Could you send v5, cc'ing at least the bindings to the

[PATCH] media: intel-ipu3: cio2: mark PM functions as __maybe_unused

2018-01-03 Thread Arnd Bergmann
When CONFIG_PM is disabled, we get harmless warnings about the suspend/resume callbacks being unused: drivers/media/pci/intel/ipu3/ipu3-cio2.c:1993:12: error: 'cio2_resume' defined but not used [-Werror=unused-function] drivers/media/pci/intel/ipu3/ipu3-cio2.c:1967:12: error: 'cio2_suspend'

[PATCH v5 2/5] media: ov5640: check chip id

2018-01-03 Thread Hugues Fruchet
Verify that chip identifier is correct when probing. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 95 ++ 1 file changed, 79 insertions(+), 16 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v5 5/5] media: ov5640: add support of RGB565 and YUYV formats

2018-01-03 Thread Hugues Fruchet
Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing YUV422 UYVY format. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 74 +- 1 file changed, 67 insertions(+), 7 deletions(-) diff --git

[PATCH v5 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Hugues Fruchet
Refine CSI-2 endpoint documentation and add bindings for DVP parallel interface support. Signed-off-by: Hugues Fruchet --- .../devicetree/bindings/media/i2c/ov5640.txt | 46 +- 1 file changed, 44 insertions(+), 2 deletions(-) diff --git

[PATCH v5 0/5] Add OV5640 parallel interface and RGB565/YUYV support

2018-01-03 Thread Hugues Fruchet
Enhance OV5640 CSI driver to support also DVP parallel interface. Add RGB565 (LE & BE) and YUV422 YUYV format in addition to existing YUV422 UYVY format. Some other improvements on chip identifier check and removal of warnings in powering phase around gpio handling. === = history =

[PATCH v5 1/5] media: ov5640: switch to gpiod_set_value_cansleep()

2018-01-03 Thread Hugues Fruchet
Switch gpiod_set_value to gpiod_set_value_cansleep to avoid warnings when powering sensor. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v5 4/5] media: ov5640: add support of DVP parallel interface

2018-01-03 Thread Hugues Fruchet
Add support of DVP parallel mode in addition of existing MIPI CSI mode. The choice between two modes and configuration is made through device tree. Signed-off-by: Hugues Fruchet --- drivers/media/i2c/ov5640.c | 148 +++-- 1 file

Re: [PATCH v4 3/5] media: dt-bindings: ov5640: refine CSI-2 and add parallel interface

2018-01-03 Thread Hugues FRUCHET
v5 sent ! On 01/03/2018 10:23 AM, Sakari Ailus wrote: > Hi Hugues, > > On Wed, Jan 03, 2018 at 09:12:43AM +, Hugues FRUCHET wrote: >> OK, thanks for all Sakari ! > > One thing I've missed so far --- the DT binding changes should be always > cc'd to the devicetree list which I see is missing

Re: [PATCH v3 01/34] clk_ops: change round_rate() to return unsigned long

2018-01-03 Thread Mauro Carvalho Chehab
Em Mon, 1 Jan 2018 19:42:40 + Bryan O'Donoghue escreveu: > Right now it is not possible to return a value larger than LONG_MAX on 32 > bit systems. You can pass a rate of ULONG_MAX but can't return anything > past LONG_MAX due to the fact both the rounded_rate

Re: [PATCH] v4l2: i2c: ov7670: Implement OF mbus configuration

2018-01-03 Thread Sakari Ailus
Hi Jacopo, Please see my comments below. On Tue, Jan 02, 2018 at 04:03:53PM +0100, Jacopo Mondi wrote: > ov7670 driver supports two optional properties supplied through platform > data, but currently does not support any standard video interface > property. > > Add support through OF parsing

Re: [PATCH] media: don't drop front-end reference count for ->detach

2018-01-03 Thread Mauro Carvalho Chehab
Em Tue, 2 Jan 2018 10:48:54 +0100 Arnd Bergmann escreveu: > A bugfix introduce a link failure in configurations without CONFIG_MODULES: > > In file included from drivers/media/usb/dvb-usb/pctv452e.c:20:0: > drivers/media/usb/dvb-usb/pctv452e.c: In function

Re: [PATCH v2 3/9] v4l: platform: Add Renesas CEU driver

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 03:46:27PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > > +/* > > + * ceu_device - CEU device instance > > + */ > > +struct ceu_device { > > + struct device *dev; > > + struct video_device vdev; > > + struct

Re: [PATCH] uvcvideo: Apply flags from device to actual properties

2018-01-03 Thread Laurent Pinchart
Hi Edgar, On Wednesday, 3 January 2018 08:07:44 EET Edgar Thier wrote: > Hi Emmanuel, If we pick names randomly I'll call you David :-) > >>> + int flags = 0; > >>> + > >>> + data = kmalloc(2, GFP_KERNEL); > > > > Isn't 1 byte enough ? > > To quote from Kieran further up this thread: > > >>

[PATCH] uvcvideo: Apply flags from device to actual properties

2018-01-03 Thread Laurent Pinchart
From: Edgar Thier Use flags the device exposes for UVC controls. This allows the device to define which property flags are set. Since some cameras offer auto-adjustments for properties (e.g. auto-gain), the values of other properties (e.g. gain) can change in the camera.

Re: [PATCH v2 3/9] v4l: platform: Add Renesas CEU driver

2018-01-03 Thread Laurent Pinchart
Hi Jacopo, On Wednesday, 3 January 2018 12:47:48 EET jacopo mondi wrote: > On Tue, Jan 02, 2018 at 03:46:27PM +0200, Laurent Pinchart wrote: > >> +/* > >> + * ceu_device - CEU device instance > >> + */ > >> +struct ceu_device { > >> + struct device *dev; > >> + struct video_device

Re: [PATCH v2 1/9] dt-bindings: media: Add Renesas CEU bindings

2018-01-03 Thread Laurent Pinchart
Hi Jacopo, On Wednesday, 3 January 2018 10:49:52 EET jacopo mondi wrote: > On Tue, Jan 02, 2018 at 01:45:30PM +0200, Laurent Pinchart wrote: > > On Thursday, 28 December 2017 16:01:13 EET Jacopo Mondi wrote: > >> Add bindings documentation for Renesas Capture Engine Unit (CEU). > >> > >>

Re: [PATCH] media: don't drop front-end reference count for ->detach

2018-01-03 Thread Arnd Bergmann
On Wed, Jan 3, 2018 at 11:23 AM, Mauro Carvalho Chehab wrote: > Em Tue, 2 Jan 2018 10:48:54 +0100 > Arnd Bergmann escreveu: >> @@ -2965,7 +2968,6 @@ void dvb_frontend_detach(struct dvb_frontend* fe) >> dvb_frontend_invoke_release(fe,

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread Laurent Pinchart
Hi Jacopo, On Wednesday, 3 January 2018 17:44:58 EET jacopo mondi wrote: > On Tue, Jan 02, 2018 at 05:44:03PM +0200, Laurent Pinchart wrote: > > On Thursday, 28 December 2017 16:01:19 EET Jacopo Mondi wrote: > >> Remove soc_camera framework dependencies from ov772x sensor driver. > >> - Handle

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Wed, Jan 03, 2018 at 05:49:55PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > > > > DT based platforms won't have any info->xlkc_rate, so they should be > > fine. I wonder how could I set rate in board code, as I'm just > > registering an alias for the clock there... > > Exactly

[PATCH] media: ov5640: Check the return value from clk_prepare_enable()

2018-01-03 Thread Fabio Estevam
clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam --- drivers/media/i2c/ov5640.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c

Re: [PATCH v2 2/2] media: coda: Add i.MX51 (CodaHx4) support

2018-01-03 Thread Philipp Zabel
On Thu, 2017-12-21 at 05:52 +0800, kbuild test robot wrote: > Hi Philipp, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on linuxtv-media/master] > [also build test WARNING on v4.15-rc4 next-20171220] > [if your patch is applied to the wrong git tree, please

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 05:50:38PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:21 EET Jacopo Mondi wrote: > > - priv->clk = v4l2_clk_get(>dev, "mclk"); > > - if (IS_ERR(priv->clk)) > > + priv->clk =

Re: [PATCH v2 7/9] media: i2c: ov772x: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Laurent, On Tue, Jan 02, 2018 at 05:44:03PM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Thursday, 28 December 2017 16:01:19 EET Jacopo Mondi wrote: > > Remove soc_camera framework dependencies from ov772x sensor driver. > > - Handle clock and gpios > > -

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread Fabio Estevam
Hi Jacopo, On Thu, Dec 28, 2017 at 12:01 PM, Jacopo Mondi wrote: > + if (priv->rstb_gpio) { > + gpiod_set_value(priv->rstb_gpio, 0); > + usleep_range(500, 1000); > + gpiod_set_value(priv->rstb_gpio, 1); > +

Re: [PATCH] v4l2: i2c: ov7670: Implement OF mbus configuration

2018-01-03 Thread jacopo mondi
Hi Sakari, thanks for review.. On Wed, Jan 03, 2018 at 12:11:32PM +0200, Sakari Ailus wrote: > Hi Jacopo, > > Please see my comments below. > > On Tue, Jan 02, 2018 at 04:03:53PM +0100, Jacopo Mondi wrote: > > ov7670 driver supports two optional properties supplied through platform > > data,

[PATCH] media: intel-ipu3: cio2: fix building with large PAGE_SIZE

2018-01-03 Thread Arnd Bergmann
The driver apparently assumes that the device uses the same page size as the CPU, but also assumes that this is 4096 bytes. On architectures with a larger page size like 65536 bytes, we get a warning about an integer overflow: drivers/media/pci/intel/ipu3/ipu3-cio2.c: In function

[PATCH 1/2] media: intel-ipu3: cio2: fix a crash with out-of-bounds access

2018-01-03 Thread Yong Zhi
When dmabuf is used for BLOB type frame, the frame buffers allocated by gralloc will hold more pages than the valid frame data due to height alignment. In this case, the page numbers in sg list could exceed the FBPT upper limit value - max_lops(8)*1024 to cause crash. Limit the LOP access to the

[PATCH 2/2] media: intel-ipu3: cio2: fix for wrong vb2buf state warnings

2018-01-03 Thread Yong Zhi
cio2 driver should release buffer with QUEUED state when start_stream op failed, wrong buffer state will cause vb2 core throw a warning. Signed-off-by: Yong Zhi Signed-off-by: Cao Bing Bu --- drivers/media/pci/intel/ipu3/ipu3-cio2.c | 9 + 1

[MAIN PATCH v1 1/2] Update headers from upstream kernel

2018-01-03 Thread tian . shu . qiu
From: Tianshu Qiu Upstream commit 6f0e5fd39143a59c22d60e7befc4f33f22aeed2f Signed-off-by: Tianshu Qiu --- include/linux/videodev2.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/linux/videodev2.h

[Yavta Patches v1 0/2] Add support for intel ipu3 specific formats

2018-01-03 Thread tian . shu . qiu
From: Tianshu Qiu This patch set adds new pixel formats specific for intel 3rd generation ipu driver. Tianshu Qiu (2): Update headers from upstream kernel Add support for intel ipu3 specific raw formats include/linux/videodev2.h | 15 +++ yavta.c

[MAIN PATCH v1 2/2] Add support for intel ipu3 specific raw formats

2018-01-03 Thread tian . shu . qiu
From: Tianshu Qiu Add support for these pixel formats: V4L2_PIX_FMT_IPU3_SBGGR10 V4L2_PIX_FMT_IPU3_SGBRG10 V4L2_PIX_FMT_IPU3_SGRBG10 V4L2_PIX_FMT_IPU3_SRGGB10 Signed-off-by: Tianshu Qiu --- yavta.c | 4 1 file changed, 4 insertions(+)

[Yavta Patches v1 0/2] Add support for intel ipu3 specific formats

2018-01-03 Thread tian . shu . qiu
From: Tianshu Qiu This patch set adds new pixel formats specific for intel 3rd generation ipu driver. Tianshu Qiu (2): Update headers from upstream kernel Add support for intel ipu3 specific raw formats include/linux/videodev2.h | 15 +++ yavta.c

[MAIN PATCH v1 1/2] Update headers from upstream kernel

2018-01-03 Thread tian . shu . qiu
From: Tianshu Qiu Upstream commit 6f0e5fd39143a59c22d60e7befc4f33f22aeed2f Signed-off-by: Tianshu Qiu --- include/linux/videodev2.h | 15 +++ 1 file changed, 15 insertions(+) diff --git a/include/linux/videodev2.h

[MAIN PATCH v1 2/2] Add support for intel ipu3 specific raw formats

2018-01-03 Thread tian . shu . qiu
From: Tianshu Qiu Add support for these pixel formats: V4L2_PIX_FMT_IPU3_SBGGR10 V4L2_PIX_FMT_IPU3_SGBRG10 V4L2_PIX_FMT_IPU3_SGRBG10 V4L2_PIX_FMT_IPU3_SRGGB10 Signed-off-by: Tianshu Qiu --- yavta.c | 4 1 file changed, 4 insertions(+)

cron job: media_tree daily build: ERRORS

2018-01-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Jan 4 05:00:17 CET 2018 media-tree git hash:6f0e5fd39143a59c22d60e7befc4f33f22aeed2f media_build

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 02:41:20PM -0200, Fabio Estevam wrote: > Hi Jacopo, > > On Thu, Dec 28, 2017 at 12:01 PM, Jacopo Mondi > wrote: > > > + if (priv->rstb_gpio) { > > + gpiod_set_value(priv->rstb_gpio, 0); > > +

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread Fabio Estevam
Hi Jacopo, On Wed, Jan 3, 2018 at 3:13 PM, jacopo mondi wrote: > That would be true if I would have declared the GPIO to be ACTIVE_LOW. > See patch [5/9] in this series and search for "rstb". The GPIO (which > is shared between two devices) is said to be active high... Just

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 03:27:53PM -0200, Fabio Estevam wrote: > Hi Jacopo, > > On Wed, Jan 3, 2018 at 3:13 PM, jacopo mondi wrote: > > > That would be true if I would have declared the GPIO to be ACTIVE_LOW. > > See patch [5/9] in this series and search for "rstb".

Re: [PATCH v2 3/4] media: ov2685: add support for OV2685 sensor

2018-01-03 Thread Sakari Ailus
Hi Shunqian, Please see my comments below. On Fri, Dec 29, 2017 at 04:08:24PM +0800, Shunqian Zheng wrote: > This patch adds driver for Omnivision's ov2685 sensor. > Though the ov2685 can output yuv data, this driver only > supports the raw bayer format, including the following features: > -

[GIT PULL FOR v4.16] uvcvideo changes

2018-01-03 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 9eb124fe796cbadd454c8f946d7051f4c3f4a251: Merge branch 'docs-next' of git://git.lwn.net/linux into patchwork (2017-12-22 14:38:28 -0500) are available in the git repository at: git://linuxtv.org/pinchartl/media.git uvc/next for you to fetch

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread jacopo mondi
Hi Fabio, On Wed, Jan 03, 2018 at 04:14:35PM -0200, Fabio Estevam wrote: > On Wed, Jan 3, 2018 at 3:37 PM, jacopo mondi wrote: > > >> Initially the rest GPIO was doing: > >> > >> - gpio_set_value(GPIO_PTT3, 0); > >> - mdelay(10); > >> -

Re: [PATCH v2 9/9] media: i2c: tw9910: Remove soc_camera dependencies

2018-01-03 Thread Fabio Estevam
On Wed, Jan 3, 2018 at 3:37 PM, jacopo mondi wrote: >> Initially the rest GPIO was doing: >> >> - gpio_set_value(GPIO_PTT3, 0); >> - mdelay(10); >> - gpio_set_value(GPIO_PTT3, 1); >> - mdelay(10); /* wait to let chip come out of reset */ > > And that's

[PATCH v2 4/4] media: mt9m111: add V4L2_CID_TEST_PATTERN control

2018-01-03 Thread Akinobu Mita
The mt9m111 has the test pattern generator features. This makes use of it through V4L2_CID_TEST_PATTERN control. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * Changelog v2 - Fix typo

[PATCH v2 2/4] media: mt9m111: add media controller support

2018-01-03 Thread Akinobu Mita
Create a source pad and set the media controller type to the sensor. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * Changelog v2 - Fix typo s/meida/media/ in the patch title, noticed

[PATCH v2 3/4] media: mt9m111: document missing required clocks property

2018-01-03 Thread Akinobu Mita
The mt9m111 driver requires clocks property for the master clock to the sensor, but there is no description for that. This adds it. Cc: Rob Herring Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita

[PATCH v2 0/4] media: mt9m111: media controller support and misc changes

2018-01-03 Thread Akinobu Mita
This series adds media controller support and other miscellaneous changes to the mt9m111 driver. The MT9M111 camera modules are easily available for the hobbyists. * Changelog v2 - Fix typo s/meida/media/ in the patch title, noticed by Sakari Ailus - Improve the wording for "clock-names"

[PATCH v2 1/4] media: mt9m111: create subdevice device node

2018-01-03 Thread Akinobu Mita
Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the subdevice device node is created. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- * Changelog v2 - Fix typo

[RFC/RFT PATCH 0/6] Asynchronous UVC

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham The Linux UVC driver has long provided adequate performance capabilities for web-cams and low data rate video devices in Linux while resolutions were low. Modern USB cameras are now capable of high data rates thanks to USB3 with 1080p, and

[RFC/RFT PATCH 5/6] uvcvideo: queue: Support asynchronous buffer handling

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham The buffer queue interface currently operates sequentially, processing buffers after they have fully completed. In preparation for supporting parallel tasks operating on the buffers, we will need to support buffers being processed on

[RFC/RFT PATCH 6/6] uvcvideo: Move decode processing to process context

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham Newer high definition cameras, and cameras with multiple lenses such as the range of stereovision cameras now available have ever increasing data rates. The inclusion of a variable length packet header in URB packets mean that we must memcpy

[RFC/RFT PATCH 4/6] uvcvideo: queue: Simplify spin-lock usage

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham Both uvc_start_streaming(), and uvc_stop_streaming() are called from userspace context. As such, they do not need to save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq() respectively. Signed-off-by: Kieran Bingham

[RFC/RFT PATCH 2/6] uvcvideo: Convert decode functions to use new context structure

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham The URB completion handlers currently reference the stream context. Now that each URB has its own context structure, convert the decode (and one encode) functions to utilise this context for URB management. Signed-off-by: Kieran Bingham

[RFC/RFT PATCH 3/6] uvcvideo: Protect queue internals with helper

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham The URB completion operation obtains the current buffer by reading directly into the queue internal interface. Protect this queue abstraction by providing a helper uvc_queue_get_current_buffer() which can be used by both the decode task, and

[RFC/RFT PATCH 1/6] uvcvideo: Refactor URB descriptors

2018-01-03 Thread Kieran Bingham
From: Kieran Bingham We currently store three separate arrays for each URB reference we hold. Objectify the data needed to track URBs into a single uvc_urb structure, allowing better object management and tracking of the URB. All accesses to the data pointers

Re: [PATCH] media: ov5640: Check the return value from clk_prepare_enable()

2018-01-03 Thread Sakari Ailus
Hi Fabio, On Wed, Jan 03, 2018 at 02:57:07PM -0200, Fabio Estevam wrote: > clk_prepare_enable() may fail, so we should better check its return value > and propagate it in the case of error. > > Signed-off-by: Fabio Estevam Thanks for the patch. This particular issue

Re: [RFC/RFT PATCH 0/6] Asynchronous UVC

2018-01-03 Thread Troy Kisky
On 1/3/2018 12:32 PM, Kieran Bingham wrote: > From: Kieran Bingham > > The Linux UVC driver has long provided adequate performance capabilities for > web-cams and low data rate video devices in Linux while resolutions were low. > > Modern USB cameras are now