[PATCH 6/9] media: atomisp: ov2680: don't declare unused vars

2018-04-16 Thread Mauro Carvalho Chehab
drivers/staging/media/atomisp/i2c/atomisp-ov2680.c: In function ‘__ov2680_set_exposure’: drivers/staging/media/atomisp/i2c/atomisp-ov2680.c:400:10: warning: variable ‘hts’ set but not used [-Wunused-but-set-variable] u16 vts,hts; ^~~

[PATCH 1/9] media: staging: atomisp: get rid of __KERNEL macros

2018-04-16 Thread Mauro Carvalho Chehab
There's no sense for a Kernel driver to have __KERNEL macros on it. Signed-off-by: Mauro Carvalho Chehab --- .../css2400/css_2401_csi2p_system/host/system_local.h | 15 --- .../css2400/hive_isp_css_common/host/system_local.h | 15 ---

[PATCH 2/9] media: staging: atomisp: reenable warnings for I2C

2018-04-16 Thread Mauro Carvalho Chehab
When atomisp got merged, there were so many warnings with W=1 that we simply disabled the ones that were causing troubles. Since then, several changes got applied to atomisp, and the number of warnings are a way smaller than it used to be. So, let's reenable warnings there and fix the issues.

[PATCH] [media] ddbridge: don't uselessly check for dma in start/stop functions

2018-04-16 Thread Daniel Scheller
From: Daniel Scheller The check for a valid ptr in ddb_io->dma isn't really necessary since only devices that do data transport using DMA are supported by the driver, and all previous initialisation code (through input_init(), output_init() and dma_init(), has_dma is always

Re: [PATCHv2 4/9] media: add function field to struct media_entity_desc

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:16 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > This adds support for 'proper' functions to the existing API. > This information was before only available through the new v2 > API, with this change it's available to

Re: [PATCHv2 7/9] media-ioc-g-topology.rst: document new 'index' field

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:19 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Document the new struct media_v2_pad 'index' field. > > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv2 6/9] media: add 'index' to struct media_v2_pad

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:18 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The v2 pad structure never exposed the pad index, which made it impossible > to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information. > > It is really

Re: [PATCHv2 6/9] media: add 'index' to struct media_v2_pad

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:03:35 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 16 Apr 2018 15:21:18 +0200 > Hans Verkuil escreveu: > > > From: Hans Verkuil > > > > The v2 pad structure never exposed the pad index, which made it

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-16 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 2:39 PM, Christoph Hellwig wrote: > On Tue, Apr 03, 2018 at 08:08:32PM +0200, Daniel Vetter wrote: >> I did not mean you should dma_map_sg/page. I just meant that using >> dma_map_resource to fill only the dma address part of the sg table seems >>

Re: [PATCH v3 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

2018-04-16 Thread Fabio Estevam
On Mon, Apr 16, 2018 at 10:16 AM, Philipp Zabel wrote: > The second patch is applied now, but this part is still missing in > v4.17-rc1, causing the CSI subdev probe to fail: > > imx-ipuv3-csi: probe of imx-ipuv3-csi.0 failed with error -1369528304 > imx-ipuv3-csi:

[PATCH 9/9] media: atomisp-mt9m114: comment out unused stuff

2018-04-16 Thread Mauro Carvalho Chehab
There are lots of data structs defined there but aren't used anywhere. Comment them out. Gets rid of those warnings: drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c:1808:45: warning: 'mt9m114_entity_ops' defined but not used [-Wunused-const-variable=] static const struct

[PATCH 4/9] media: staging: atomisp-gc2235: don't fill an unused var

2018-04-16 Thread Mauro Carvalho Chehab
The code with uses the dummy var is commented out. So, coment out its definition/initialization. Fix this warning: drivers/staging/media/atomisp/i2c/atomisp-gc2235.c: In function 'gc2235_get_intg_factor': drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:249:26: warning: variable 'dummy'

[PATCH 3/9] media: atomisp: ov2680.h: fix identation

2018-04-16 Thread Mauro Carvalho Chehab
The identation for several tables there are broken. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/atomisp/i2c/ov2680.h | 895 ++--- 1 file changed, 447 insertions(+), 448 deletions(-) diff --git

[PATCH 7/9] media: atomisp-gc0310: return errors at gc0310_init()

2018-04-16 Thread Mauro Carvalho Chehab
If something wrong gets there, return the error. Get rid of this warning: drivers/staging/media/atomisp/i2c/atomisp-gc0310.c: In function 'gc0310_init': drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:713:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] int

[PATCH 5/9] media: staging: atomisp: Comment out several unused sensor resolutions

2018-04-16 Thread Mauro Carvalho Chehab
The register settings for several resolutions aren't used currently. So, comment them out. Fix those warnings: In file included from drivers/staging/media/atomisp/i2c/atomisp-gc2235.c:35:0: drivers/staging/media/atomisp/i2c/gc2235.h:340:32: warning: 'gc2235_960_640_30fps' defined but not used

Re: [PATCHv2 17/17] media: v4l2-compat-ioctl32: fix several __user annotations

2018-04-16 Thread Mauro Carvalho Chehab
> >>> @@ -898,7 +899,8 @@ static int put_v4l2_ext_controls32(struct file *file, > >>> if (ctrl_is_pointer(file, id)) > >>> size -= sizeof(ucontrols->value64); > >>> > >>> - if (copy_in_user(ucontrols, kcontrols, size)) > >>> + if

Re: [PATCHv2 1/9] v4l2-mediabus.h: add hsv_enc

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:13 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Just like struct v4l2_pix_format add a hsv_enc field to describe > the HSV encoding. It is in a union with the ycbcr_enc, since it > is one or the other. > >

[PATCH v2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

2018-04-16 Thread Fabio Estevam
From: From: Gustavo A. R. Silva Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. The proper pointer to be passed as argument is pinctrl instead of priv->vdev. This issue was detected with the help of Coccinelle. Fixes: 52e17089d185 ("media: imx: Don't initialize

[PATCH 0/9] Do some atomisp cleanups

2018-04-16 Thread Mauro Carvalho Chehab
When I started building media subsystem with the atomisp driver, I ended by adding several hacks on their Makefiles, in order to get rid of thousands of warnings. I felt a little guty of hiding how broken is this driver, so I decided t remove two Makefile hacks that affect sensors and fix the

[PATCH 8/9] media: atomisp-mt9m114: remove dead data

2018-04-16 Thread Mauro Carvalho Chehab
It seems that, originally, the logic would allow selecting between fine and coarse integration. However, only coarse seems to be implemented. Get rid of this warning: drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c: In function 'mt9m114_s_exposure':

Re: [PATCHv2 3/9] media.h: remove __NEED_MEDIA_LEGACY_API

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:15 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > The __NEED_MEDIA_LEGACY_API define is 1) ugly and 2) dangerous > since it is all too easy for drivers to define it to get hold of > legacy defines. Instead just define

Re: [PATCHv2 5/9] media-ioc-enum-entities.rst: document new 'function' field

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:17 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Document the new struct media_entity_desc 'function' field. See my comments to patch 4/9. > Signed-off-by: Hans Verkuil > --- >

Re: [PATCHv2 9/9] media-ioc-g-topology.rst: document new 'flags' field

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 15:21:21 +0200 Hans Verkuil escreveu: > From: Hans Verkuil > > Document the new struct media_v2_entity 'flags' field. > > Signed-off-by: Hans Verkuil > --- >

[PATCH v10] media: imx258: Add imx258 camera sensor driver

2018-04-16 Thread Andy Yeh
From: Jason Chen Add a V4L2 sub-device driver for the Sony IMX258 image sensor. This is a camera sensor using the I2C bus for control and the CSI-2 bus for data. Signed-off-by: Andy Yeh Signed-off-by: Alan Chiang --- ince

[PATCH] media: v4l2-compat-ioctl32: better name userspace pointers

2018-04-16 Thread Mauro Carvalho Chehab
In the past, "up" were an acronym for "user pointer" and "kp" for "kernel pointer". However, since a1dfb4c48cc1 ("media: v4l2-compat-ioctl32.c: refactor compat ioctl32 logic"), both are now __user pointers. So, the usage of "kp" is really misleading there. So, rename both to just "p32" and "p64"

[GIT PULL FOR v4.18] rc changes

2018-04-16 Thread Sean Young
Hi Mauro, These patches include the low latency changes, which do make IR more responsive. These patches could breaks things in subtle ways, so it would be great to have these changes in early in the cycle. Thanks, Sean The following changes since commit

Re: [PATCH v2 10/10] media: ov772x: avoid accessing registers under power saving mode

2018-04-16 Thread Sakari Ailus
Hi Akinobu, As the driver now offers a V4L2 sub-device uAPI, it needs to serialise access to its internal data structures. This appears to be fine, but there are additional requirements; for instance ov772x_select_params() should likely fail if you're streaming. On Mon, Apr 16, 2018 at

[PATCHv2 4/9] media: add function field to struct media_entity_desc

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil This adds support for 'proper' functions to the existing API. This information was before only available through the new v2 API, with this change it's available to both. Yes, the plan is to allow entities to expose multiple functions for multi-function

[PATCHv2 5/9] media-ioc-enum-entities.rst: document new 'function' field

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil Document the new struct media_entity_desc 'function' field. Signed-off-by: Hans Verkuil --- .../uapi/mediactl/media-ioc-enum-entities.rst | 31 +- 1 file changed, 25 insertions(+), 6 deletions(-) diff

Re: [PATCH v7] media: platform: Renesas IMR driver

2018-04-16 Thread Sergei Shtylyov
On 04/16/2018 04:27 PM, Geert Uytterhoeven wrote: >> The image renderer, or the distortion correction engine, is a drawing >> processor with a simple instruction system capable of referencing video >> capture data or data in an external memory as the 2D texture data and >> performing texture

Re: [PATCHv2 17/17] media: v4l2-compat-ioctl32: fix several __user annotations

2018-04-16 Thread Hans Verkuil
On 04/16/2018 04:50 PM, Mauro Carvalho Chehab wrote: > Em Mon, 16 Apr 2018 14:03:45 +0200 > Hans Verkuil escreveu: > >> On 04/13/2018 08:07 PM, Mauro Carvalho Chehab wrote: >>> Smatch report several issues with bad __user annotations: >>> >>>

Re: [PATCHv2 17/17] media: v4l2-compat-ioctl32: fix several __user annotations

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 14:03:45 +0200 Hans Verkuil escreveu: > On 04/13/2018 08:07 PM, Mauro Carvalho Chehab wrote: > > Smatch report several issues with bad __user annotations: > > > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect > > type in

Re: [PATCH] media: v4l2-compat-ioctl32: better name userspace pointers

2018-04-16 Thread Hans Verkuil
On 04/16/2018 05:11 PM, Mauro Carvalho Chehab wrote: > In the past, "up" were an acronym for "user pointer" and "kp" for > "kernel pointer". However, since a1dfb4c48cc1 ("media: > v4l2-compat-ioctl32.c: refactor compat ioctl32 logic"), both > are now __user pointers. > > So, the usage of "kp" is

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-16 Thread jacopo mondi
Hi Niklas, On Mon, Apr 16, 2018 at 01:16:35AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your feedback. > > Comments I have snipped out from this reply are addressed, thanks for > bringing them to my attention! > > On 2018-04-05 11:10:01 +0200, Jacopo Mondi wrote: > > [snip] > > >

Re: OV5640 with 12MHz xclk

2018-04-16 Thread Philipp Zabel
On Sun, 2018-04-15 at 18:39 -0700, Samuel Bobrowicz wrote: > Can anyone verify if the OV5640 driver works with input clocks other > than the typical 24MHz? The driver suggests anything from 6MHz-24MHz > is acceptable, but I am running into issues while bringing up a module > that uses a 12MHz

Re: [PATCH v3 1/2] media: imx-media-csi: Fix inconsistent IS_ERR and PTR_ERR

2018-04-16 Thread Philipp Zabel
Hi, On Sat, 2018-03-03 at 09:56 -0300, Fabio Estevam wrote: > From: Gustavo A. R. Silva > > Fix inconsistent IS_ERR and PTR_ERR in imx_csi_probe. > The proper pointer to be passed as argument is pinctrl > instead of priv->vdev. > > This issue was detected with the help

Re: [PATCH v7] media: platform: Renesas IMR driver

2018-04-16 Thread Geert Uytterhoeven
Hi Sergei, On Fri, Aug 4, 2017 at 8:03 PM, Sergei Shtylyov wrote: > The image renderer, or the distortion correction engine, is a drawing > processor with a simple instruction system capable of referencing video > capture data or data in an external memory as

Re: [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Daniel Vetter
Ok, confusion around backend is I think cleared up. The other confusion seems to be around dma-buf: dma-buf is the cross subsystem zerocopy abstraction. PRIME is the drm-specific support for it, 100% based on top of the generic struct dma_buf. You need a dma_buf exporter to convert a xen grant

Re: [PATCH v2 03/10] media: ov772x: create subdevice device node

2018-04-16 Thread Sakari Ailus
Hi Akinobu, On Mon, Apr 16, 2018 at 11:51:44AM +0900, Akinobu Mita wrote: > Set the V4L2_SUBDEV_FL_HAS_DEVNODE flag for the subdevice so that the > subdevice device node is created. > > Cc: Jacopo Mondi > Cc: Laurent Pinchart > Cc:

Re: [PATCHv2 17/17] media: v4l2-compat-ioctl32: fix several __user annotations

2018-04-16 Thread Hans Verkuil
On 04/13/2018 08:07 PM, Mauro Carvalho Chehab wrote: > Smatch report several issues with bad __user annotations: > > drivers/media/v4l2-core/v4l2-compat-ioctl32.c:447:21: warning: incorrect > type in argument 1 (different address spaces) >

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-04-16 Thread Christoph Hellwig
On Tue, Apr 03, 2018 at 08:08:32PM +0200, Daniel Vetter wrote: > I did not mean you should dma_map_sg/page. I just meant that using > dma_map_resource to fill only the dma address part of the sg table seems > perfectly sufficient. But that is not how the interface work, especially facing

Re: Smatch and sparse errors

2018-04-16 Thread Hans Verkuil
On 04/14/2018 03:18 AM, Jasmin J. wrote: > Hello Mauro/Hans! > >> There is already an upstream patch for hidding it: > The patch from https://patchwork.kernel.org/patch/10334353 will not > apply at the smatch tree. > > Attached is an updated version for smatch. > > Even with the patched tools,

Re: OV5640 with 12MHz xclk

2018-04-16 Thread Hans Verkuil
On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote: > Can anyone verify if the OV5640 driver works with input clocks other > than the typical 24MHz? The driver suggests anything from 6MHz-24MHz > is acceptable, but I am running into issues while bringing up a module > that uses a 12MHz oscillator. I'd

[PATCH v2 07/12] media: ov5640: Program the visible resolution

2018-04-16 Thread Maxime Ripard
The active frame size is set in the initialization arrays, but the value itself is also available in the struct ov5640_mode_info. Let's move these values out of the big bytes arrays, and program it with the value of the mode that we are given. Signed-off-by: Maxime Ripard

[PATCH v2 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-04-16 Thread Maxime Ripard
The clock structure for the PCLK is quite obscure in the documentation, and was hardcoded through the bytes array of each and every mode. This is troublesome, since we cannot adjust it at runtime based on other parameters (such as the number of bytes per pixel), and we can't support either

[PATCH v2 10/12] media: ov5640: Enhance FPS handling

2018-04-16 Thread Maxime Ripard
Now that we have moved the clock generation logic out of the bytes array, these arrays are identical between the 15fps and 30fps variants. Remove the duplicate entries, and convert the code accordingly. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c |

[PATCH v2 03/12] media: ov5640: Don't force the auto exposure state at start time

2018-04-16 Thread Maxime Ripard
The sensor needs to have the auto exposure stopped while changing mode. However, when the new mode is set, the driver will force the auto exposure on, disregarding whether the control has been changed or not. Bypass the controls code entirely to do that, and only use the control value cached when

[PATCH v2 06/12] media: ov5640: Add horizontal and vertical totals

2018-04-16 Thread Maxime Ripard
All the initialization arrays are changing the horizontal and vertical totals for some value. In order to clean up the driver, and since we're going to need that value later on, let's introduce in the ov5640_mode_info structure the horizontal and vertical total sizes, and move these out of the

[PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-04-16 Thread Maxime Ripard
Hi, Here is a "small" series that mostly cleans up the ov5640 driver code, slowly getting rid of the big data array for more understandable code (hopefully). The biggest addition would be the clock rate computation at runtime, instead of relying on those arrays to setup the clock tree properly.

[PATCH v2 05/12] media: ov5640: Change horizontal and vertical resolutions name

2018-04-16 Thread Maxime Ripard
The current width and height parameters in the struct ov5640_mode_info are actually the active horizontal and vertical resolutions. Since we're going to add a few other parameters, let's pick a better, more precise name for these values. Signed-off-by: Maxime Ripard

[PATCH v2 02/12] media: ov5640: Add light frequency control

2018-04-16 Thread Maxime Ripard
From: Mylène Josserand Add the light frequency control to be able to set the frequency to manual (50Hz or 60Hz) or auto. Signed-off-by: Mylène Josserand Signed-off-by: Maxime Ripard ---

[PATCH v2 01/12] media: ov5640: Add auto-focus feature

2018-04-16 Thread Maxime Ripard
From: Mylène Josserand Add the auto-focus ENABLE/DISABLE feature as V4L2 control. Disabled by default. Signed-off-by: Mylène Josserand Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 16

[PATCH v2 09/12] media: ov5640: Compute the clock rate at runtime

2018-04-16 Thread Maxime Ripard
The clock rate, while hardcoded until now, is actually a function of the resolution, framerate and bytes per pixel. Now that we have an algorithm to adjust our clock rate, we can select it dynamically when we change the mode. This changes a bit the clock rate being used, with the following

[PATCH v2 11/12] media: ov5640: Add 60 fps support

2018-04-16 Thread Maxime Ripard
Now that we have everything in place to compute the clock rate at runtime, we can enable the 60fps framerate for the mode we tested it with. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 33 + 1 file changed, 25

[PATCH v2 04/12] media: ov5640: Init properly the SCLK dividers

2018-04-16 Thread Maxime Ripard
The SCLK and SCLK2X dividers are fixed in stone in the initialization array. Let's make explicit what we're doing and move that away from the huge array to the initialization code. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 11 ++- 1 file

[PATCH v2 12/12] media: ov5640: Remove duplicate auto-exposure setup

2018-04-16 Thread Maxime Ripard
The autoexposure setup in the 1080p init array is redundant with the default value of the sensor. Remove it. Signed-off-by: Maxime Ripard --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c

Re: [PATCHv2 4/9] media: add function field to struct media_entity_desc

2018-04-16 Thread Hans Verkuil
On 04/16/2018 08:01 PM, Mauro Carvalho Chehab wrote: > Em Mon, 16 Apr 2018 15:21:16 +0200 > Hans Verkuil escreveu: > >> From: Hans Verkuil >> >> This adds support for 'proper' functions to the existing API. >> This information was before only available

Re: [PATCH] media: v4l2-compat-ioctl32: better name userspace pointers

2018-04-16 Thread Sakari Ailus
On Mon, Apr 16, 2018 at 06:00:12PM +0200, Hans Verkuil wrote: > On 04/16/2018 05:11 PM, Mauro Carvalho Chehab wrote: > > In the past, "up" were an acronym for "user pointer" and "kp" for > > "kernel pointer". However, since a1dfb4c48cc1 ("media: > > v4l2-compat-ioctl32.c: refactor compat ioctl32

Re: [PATCHv2 6/9] media: add 'index' to struct media_v2_pad

2018-04-16 Thread Hans Verkuil
On 04/16/2018 08:09 PM, Mauro Carvalho Chehab wrote: > Em Mon, 16 Apr 2018 15:03:35 -0300 > Mauro Carvalho Chehab escreveu: > >> Em Mon, 16 Apr 2018 15:21:18 +0200 >> Hans Verkuil escreveu: >> >>> From: Hans Verkuil >>> >>> The

Re: OV5640 with 12MHz xclk

2018-04-16 Thread Steve Longerbeam
Hi Sam, On 04/16/2018 05:26 AM, Hans Verkuil wrote: On 04/16/2018 03:39 AM, Samuel Bobrowicz wrote: Can anyone verify if the OV5640 driver works with input clocks other than the typical 24MHz? The driver suggests anything from 6MHz-24MHz is acceptable, but I am running into issues while

Re: [PATCHv2 4/9] media: add function field to struct media_entity_desc

2018-04-16 Thread Mauro Carvalho Chehab
Em Mon, 16 Apr 2018 21:27:01 +0200 Hans Verkuil escreveu: > On 04/16/2018 08:01 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 16 Apr 2018 15:21:16 +0200 > > Hans Verkuil escreveu: > > > >> From: Hans Verkuil > >> > >> This adds

Re: Donation

2018-04-16 Thread M. M. Fridman
-- I Mikhail Fridman. has selected you specially as one of my beneficiaries for my Charitable Donation, Just as I have declared on May 23, 2016 to give my fortune as charity. Check the link below for confirmation:

Re: [PATCHv2 4/9] media: add function field to struct media_entity_desc

2018-04-16 Thread Hans Verkuil
On 04/16/2018 09:40 PM, Mauro Carvalho Chehab wrote: > Em Mon, 16 Apr 2018 21:27:01 +0200 > Hans Verkuil escreveu: > >> On 04/16/2018 08:01 PM, Mauro Carvalho Chehab wrote: >>> Em Mon, 16 Apr 2018 15:21:16 +0200 >>> Hans Verkuil escreveu: >>>

Proposal

2018-04-16 Thread MS Zeliha Omer Faruk
Hello Greeetings to you please did you get my previous email regarding my investment proposal last week friday ? MS.Zeliha ömer faruk zeliha.omer.fa...@gmail.com

Re: [PATCH v2 06/10] media: dt-bindings: ov772x: add device tree binding

2018-04-16 Thread Rob Herring
On Mon, Apr 16, 2018 at 11:51:47AM +0900, Akinobu Mita wrote: > This adds a device tree binding documentation for OV7720/OV7725 sensor. > > Cc: Jacopo Mondi > Cc: Laurent Pinchart > Cc: Hans Verkuil > Cc:

Re: OV5640 with 12MHz xclk

2018-04-16 Thread Samuel Bobrowicz
Thanks all, that's what I was expecting. It clears some things up. I'm going to check out Maxime's recent patches and see if those do the trick, otherwise I'll get cracking on some patches myself. Sam --- Sam Bobrowicz Elite Embedded Consulting LLC elite-embedded.com On

Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

2018-04-16 Thread Greg KH
On Sun, Apr 15, 2018 at 10:54:20AM +0100, Sean Young wrote: > commit 615cd3fe6ccc ("[media] media: lirc_dev: make better use of > file->private_data") removed the reference get from open, so on the first > close the reference count hits zero and the lirc device is freed. > > BUG: unable to handle

Re: [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: > On 04/13/2018 06:37 PM, Daniel Vetter wrote: > > On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: > > > On 04/10/2018 08:26 PM, Dongwon Kim wrote: > > > > On Tue, Apr 10, 2018 at 09:37:53AM +0300,

Re: [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Oleksandr Andrushchenko
On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: On 04/10/2018 08:26 PM, Dongwon Kim wrote: On Tue, Apr 10, 2018 at 09:37:53AM +0300, Oleksandr Andrushchenko wrote: On 04/06/2018 09:57 PM, Dongwon Kim wrote: On Fri, Apr 06,

Re: imx-media: MT9P031 Capture issues on IMX6

2018-04-16 Thread Ibtsam Ul-Haq
Hi Philipp, Thanks a lot for your response. On Fri, Apr 13, 2018 at 4:18 PM, Philipp Zabel wrote: > Hi Ibtsam, > > On Thu, 2018-04-12 at 16:00 +0200, Ibtsam Ul-Haq wrote: >> Greetings everyone, >> I am using Linux 4.14.31 on an IMX6 platform, with an MT9P031 sensor >>

Re: [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Oleksandr Andrushchenko
On 04/16/2018 10:43 AM, Daniel Vetter wrote: On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at 08:59:32AM +0300, Oleksandr Andrushchenko wrote: On 04/10/2018 08:26 PM, Dongwon Kim wrote: On Tue, Apr

cron job: media_tree daily build: OK

2018-04-16 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Apr 17 05:00:16 CEST 2018 media-tree git hash:60cc43fc888428bb2f18f08997432d426a243338 media_build

Re: [PATCH] media: rc: mtk-cir: use of_device_get_match_data()

2018-04-16 Thread Sean Wang
On Mon, 2018-04-16 at 10:34 +0800, Ryder Lee wrote: > The usage of of_device_get_match_data() reduce the code size a bit. > > Signed-off-by: Ryder Lee > --- > drivers/media/rc/mtk-cir.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git

Re: [RFCv11 PATCH 00/29] Request API

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > From: Hans Verkuil > Hi all, > This is a cleaned up version of the v10 series (never posted to > the list since it was messy). Hi Hans, It took me a while to test and review this, but finally

Re: [RFCv11 PATCH 03/29] media-request: allocate media requests

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > From: Hans Verkuil > Add support for allocating a new request. This is only supported > if mdev->ops->req_queue is set, i.e. the driver indicates that it > supports queueing requests. >

Re: [RFCv11 PATCH 01/29] v4l2-device.h: always expose mdev

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > From: Hans Verkuil > The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. > But since we will need to pass the media_device to vb2 snd the Typo: s/snd/and > control framework it is

Re: [RFCv11 PATCH 02/29] uapi/linux/media.h: add request API

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > From: Hans Verkuil > Define the public request API. > This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request > and two ioctls that operate on a request in order to queue the >

RE: [PATCH v10] media: imx258: Add imx258 camera sensor driver

2018-04-16 Thread Yeh, Andy
We are re-implementing this patch. So obsolete this patch from list first. https://patchwork.linuxtv.org/patch/48722/ Permalink /patch/48722/ State Obsoleted Regards, Andy -Original Message- From: Yeh, Andy Sent: Monday, April 16, 2018 11:04 PM To: linux-media@vger.kernel.org

Re: [RFCv11 PATCH 25/29] media: vim2m: add media device

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > From: Alexandre Courbot > Request API requires a media node. Add one to the vim2m driver so we can > use requests with it. > This probably needs a bit more work to correctly represent m2m >

Re: [RFCv11 PATCH 27/29] vim2m: support requests

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:20 PM Hans Verkuil wrote: > From: Hans Verkuil > Add support for requests to vim2m. > Signed-off-by: Hans Verkuil > --- > drivers/media/platform/vim2m.c | 25 + > 1 file

Re: [RFCv11 PATCH 20/29] videobuf2-v4l2: integrate with media requests

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > From: Hans Verkuil > This implements the V4L2 part of the request support. The main > change is that vb2_qbuf and vb2_prepare_buf now have a new > media_device pointer. This required changes to

Re: [RFCv11 PATCH 04/29] media-request: core request support

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > From: Hans Verkuil > Implement the core of the media request processing. > Drivers can bind request objects to a request. These objects > can then be marked completed if the driver finished using

Re: [RFCv11 PATCH 07/29] media-request: add media_request_object_find

2018-04-16 Thread Alexandre Courbot
On Mon, Apr 9, 2018 at 11:21 PM Hans Verkuil wrote: > From: Hans Verkuil > Add media_request_object_find to find a request object inside a > request based on ops and/or priv values. > Objects of the same type (vb2 buffer, control handler) will have

Re: cx88 invalid video opcodes when VBI enabled

2018-04-16 Thread Daniel Glöckner
Hi, On Sun, Apr 15, 2018 at 01:37:50PM -0400, Devin Heitmueller wrote: > Any suggestions on the best way to debug this without having to learn > the intimate details of the RISC engine on the cx88? From the state > of the RISC engine it looks like there is some issue with queuing the >

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-04-16 Thread Samuel Bobrowicz
I've been digging around the ov5640.c code for a few weeks now, these look like some solid improvements. I'll give them a shot and let you know how they work. On that note, I'm bringing up a module that uses dual lane MIPI with a 12MHz fixed oscillator for xclk (Digilent's Pcam 5c). The mainline

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-16 Thread Niklas Söderlund
Hi Jacopo, On 2018-04-16 01:16:35 +0200, Niklas Söderlund wrote: [snip] > > > + > > > + /* Set frequency range if we have it */ > > > + if (priv->info->csi0clkfreqrange) > > > + rcar_csi2_write(priv, CSI0CLKFCPR_REG, > > > +

[PATCHv2 7/9] media-ioc-g-topology.rst: document new 'index' field

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil Document the new struct media_v2_pad 'index' field. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git

[PATCHv2 2/9] subdev-formats.rst: fix incorrect types

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil The ycbcr_enc, quantization and xfer_func fields are __u16 and not enums. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/subdev-formats.rst | 27 +++-- 1 file changed, 21 insertions(+), 6

[PATCHv2 0/9] media/mc: fix inconsistencies

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil This patch series is a follow-up to these two v1 series: https://www.mail-archive.com/linux-media@vger.kernel.org/msg127943.html https://www.mail-archive.com/linux-media@vger.kernel.org/msg127963.html Some of those patches have been merged for 4.17,

[PATCHv2 1/9] v4l2-mediabus.h: add hsv_enc

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil Just like struct v4l2_pix_format add a hsv_enc field to describe the HSV encoding. It is in a union with the ycbcr_enc, since it is one or the other. Signed-off-by: Hans Verkuil --- include/uapi/linux/v4l2-mediabus.h | 8

[PATCHv2 9/9] media-ioc-g-topology.rst: document new 'flags' field

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil Document the new struct media_v2_entity 'flags' field. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/mediactl/media-ioc-g-topology.rst | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[PATCHv2 3/9] media.h: remove __NEED_MEDIA_LEGACY_API

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil The __NEED_MEDIA_LEGACY_API define is 1) ugly and 2) dangerous since it is all too easy for drivers to define it to get hold of legacy defines. Instead just define what we need in media-device.c which is the only place where we need the legacy define

[PATCHv2 6/9] media: add 'index' to struct media_v2_pad

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil The v2 pad structure never exposed the pad index, which made it impossible to call the MEDIA_IOC_SETUP_LINK ioctl, which needs that information. It is really trivial to just expose this information, so implement this. Signed-off-by: Hans Verkuil

[PATCHv2 8/9] media: add flags field to struct media_v2_entity

2018-04-16 Thread Hans Verkuil
From: Hans Verkuil The v2 entity structure never exposed the entity flags, which made it impossible to detect connector or default entities. It is really trivial to just expose this information, so implement this. Signed-off-by: Hans Verkuil ---

Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

2018-04-16 Thread Sean Young
On Mon, Apr 16, 2018 at 09:52:28AM +0200, Greg KH wrote: > On Sun, Apr 15, 2018 at 10:54:20AM +0100, Sean Young wrote: > > commit 615cd3fe6ccc ("[media] media: lirc_dev: make better use of > > file->private_data") removed the reference get from open, so on the first > > close the reference count

Re: [PATCH stable v4.15 1/3] media: staging: lirc_zilog: broken reference counting

2018-04-16 Thread Sean Young
On Mon, Apr 16, 2018 at 10:50:15AM +0200, Greg KH wrote: > On Mon, Apr 16, 2018 at 09:43:45AM +0100, Sean Young wrote: > > On Mon, Apr 16, 2018 at 09:52:28AM +0200, Greg KH wrote: > > > What is the git commit id of this patch, and the other patches in this > > > series and the 4.14 patch series

Re: imx-media: MT9P031 Capture issues on IMX6

2018-04-16 Thread Philipp Zabel
On Mon, 2018-04-16 at 09:54 +0200, Ibtsam Ul-Haq wrote: [...] > This indeed looks the case. But then, is 'GR16' the FourCC for 'SGRBG16'? Yes, see Documentation/media/uapi/v4l/pixfmt-srggb16.rst: https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/pixfmt-srggb16.html > To be honest, I had

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-04-16 Thread Sakari Ailus
Hi Niklas, On Sun, Apr 15, 2018 at 10:47:37PM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your feedback. > > On 2018-04-04 23:13:57 +0300, Sakari Ailus wrote: > > [snip] > > > > > + pm_runtime_enable(>dev); > > > > > > Is CONFIG_PM mandatory on Renesas SoCs? If not, you

Re: [RfC PATCH] Add udmabuf misc device

2018-04-16 Thread Daniel Vetter
On Mon, Apr 16, 2018 at 10:22 AM, Oleksandr Andrushchenko wrote: > On 04/16/2018 10:43 AM, Daniel Vetter wrote: >> >> On Mon, Apr 16, 2018 at 10:16:31AM +0300, Oleksandr Andrushchenko wrote: >>> >>> On 04/13/2018 06:37 PM, Daniel Vetter wrote: On Wed, Apr 11, 2018 at

Re: [PATCH] media: Revert cleanup ktime_set() usage

2018-04-16 Thread Mauro Carvalho Chehab
Em Sat, 14 Apr 2018 01:31:34 +0200 "Jasmin J." escreveu: > From: Jasmin Jessich > > This reverts 8b0e195314fa, because this will not compile for Kernels > older than 4.10. This patch looks fine, but not for the above-mentioned. The thing is that it is not

  1   2   >